Skip to content
  • mario@webkit.org's avatar
    [ATK] Do not expose aria-help in ATK based platforms · 74ae3467
    mario@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=121675
    
    Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-09-20
    Reviewed by Chris Fleizach.
    
    Source/WebCore:
    
    Stop exposing the value for the 'aria-help' attribute as an
    AtkObject attribute, based in AccessibilityObject::helpText().
    
    * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
    (webkitAccessibleGetAttributes): Remove the mapping.
    
    Source/WebKit/efl:
    
    Removed accessibilityHelpText() helper method from
    DumpRenderSupportEfl's API, since it's not longer needed.
    
    * WebCoreSupport/DumpRenderTreeSupportEfl.cpp: Removed method.
    * WebCoreSupport/DumpRenderTreeSupportEfl.h: Ditto.
    
    Source/WebKit/gtk:
    
    Removed accessibilityHelpText() helper method from
    DumpRenderSupportGtk's API, since it's not longer needed.
    
    * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Removed method.
    * WebCoreSupport/DumpRenderTreeSupportGtk.h: Ditto.
    
    Tools:
    
    Remove the implementations for AccessibilityUIElement::helpText()
    from DRT and WKTR for GTK and EFL, since they are based on the
    AccessibilityObject::helpText() method and the 'aria-help'
    attributes, which is wrong since they should not depend on that
    but in ATK specific API (see also http://webkit.org/b/121684).
    
    * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
    (AccessibilityUIElement::helpText): Added a new and empty
    implementation, now that we are no longer using this in ATK.
    * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
    as the only function provided here was helpText().
    * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
    * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
    removed from the list of sources to compile.
    * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
    * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
    (WTR::AccessibilityUIElement::helpText): Replaced old implementation
    based in DumpRenderTreeSupportGtk with an empty one.
    
    LayoutTests:
    
    Moved test based in helpText() into the Mac directory, and update
    expectations for platforms as needed.
    
    * platform/mac/accessibility/aria-help-expected.txt: Renamed from LayoutTests/accessibility/aria-help-expected.txt.
    * platform/mac/accessibility/aria-help.html: Renamed from LayoutTests/accessibility/aria-help.html.
    * platform/gtk-wk2/TestExpectations: Removed failure expectation
    for aria-help, now moved to Mac, and for aria-describedby-on-input,
    which is now moved to the generic TestExpectations file for GTK.
    * platform/gtk/TestExpectations: Added aria-describedby-on-input,
    linking it to the newly filed bug 121684.
    * platform/gtk-wk2/TestExpectations: Removed failure expectation.
    * platform/win/TestExpectations: Removed failure expectation.
    * platform/wincairo/TestExpectations: Ditto.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    74ae3467