Skip to content
  • tonikitoo@webkit.org's avatar
    2011-10-17 Antonio Gomes <agomes@rim.com> · 73c1c052
    tonikitoo@webkit.org authored
            Pass a Frame* parameter in EditorClient::respondToChangedSelection
            https://bugs.webkit.org/show_bug.cgi?id=70248
    
            Reviewed by Ryosuke Niwa.
    
            Most of the port specific implementations of EditorClient::respondToChangedSelection
            (like EditorClient{Qt,Gtk,etc}) are wrongly relying on FocusController::focusedOrMainFrame
            method to get the Frame where the selection is happening on.
    
            It is not right, since a selection can be easily triggered in an inner
            frame that is not focused.
    
            No new tests since it is a hard thing to test without
            to hook into editor client in layout tests. We could
            change the "Dumped Delegate" messages, but it would
            require a rebasile of +1200 for a minor change.
    
            No new tests since it is a hard thing to test without
            to hook into editor client in layout tests. We could
            change the "Dumped Delegate" messages, but it would
            require a rebasile of +1200 for a minor change.
    
            Source/WebCore:
            * editing/Editor.cpp: Pass the Frame on where the selection is changing to the client.
            (WebCore::Editor::respondToChangedSelection): Ditto.
            (WebCore::Editor::changeSelectionAfterCommand): Ditto.
            (WebCore::EmptyEditorClient::respondToChangedSelection):
            * page/EditorClient.h:  Pass Frame* to indicate where the selection is happening.
            * loader/EmptyClients.h: Changed signature as per base class change.
    
            Source/WebKit/chromium:
            * src/EditorClientImpl.cpp: Make use of the newly added Frame* parameter.
            (WebKit::EditorClientImpl::respondToChangedSelection):
            * src/EditorClientImpl.h:
    
            Source/WebKit/efl:
            * WebCoreSupport/EditorClientEfl.cpp: Make use of the newly added Frame* parameter.
            (WebCore::EditorClientEfl::respondToChangedSelection):
            * WebCoreSupport/EditorClientEfl.h:
    
            Source/WebKit/gtk:
            * WebCoreSupport/EditorClientGtk.cpp: Make use of the newly added Frame* parameter.
            (WebKit::EditorClient::respondToChangedSelection):
            * WebCoreSupport/EditorClientGtk.h:
    
            Source/WebKit/mac:
            * WebCoreSupport/WebEditorClient.h: Make use of the newly added Frame* parameter.
            * WebCoreSupport/WebEditorClient.mm:
            (WebEditorClient::respondToChangedSelection):
    
            Source/WebKit/qt:
            * WebCoreSupport/EditorClientQt.cpp: Make use of the newly added Frame* parameter.
            (WebCore::EditorClientQt::respondToChangedSelection):
            * WebCoreSupport/EditorClientQt.h:
    
            Source/WebKit/win:
            * WebCoreSupport/WebEditorClient.cpp: Make use of the newly added Frame* parameter.
            (WebEditorClient::respondToChangedSelection):
            * WebCoreSupport/WebEditorClient.h:
    
            Source/WebKit/wx:
            * WebKitSupport/EditorClientWx.cpp: Make use of the newly added Frame* parameter.
            (WebCore::EditorClientWx::respondToChangedSelection):
            * WebKitSupport/EditorClientWx.h:
    
            Source/WebKit2:
            * WebProcess/WebCoreSupport/WebEditorClient.cpp: Make use of the newly added Frame* parameter.
            (WebKit::WebEditorClient::respondToChangedSelection):
            * WebProcess/WebCoreSupport/WebEditorClient.h:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    73c1c052