Skip to content
  • darin's avatar
    WebCore: · 6f5b5073
    darin authored
            Reviewed by Trey and Maciej.
    
    	- fixed 3117558 -- Assertion failure in KWQKHTMLPart::slotData after typing "amazon.com" twice
    	- got rid of the per-part NSEvent in preparation for NSView mouse event handling going through WebCore
    
            * khtml/khtml_part.h: Added declaration for didOpenURL.
            * khtml/khtml_part.cpp: (KHTMLPart::openURL): Changed name to didOpenURL in the APPLE_CHANGES
    	version because calls to openURL from within KHTML need to make the round trip to WebKit.
    	Also disabled the "scroll to anchor" part.
    
            * kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::isFrameSet): Fix to return false when document is 0.
    
            * kwq/KWQKHTMLPart.h: Add scrollToAnchor, remove setCurrentEvent and _currentEvent
            * kwq/KWQKHTMLPart.mm:
            (KHTMLPart::openURL): Pass the openURL call to the KWQKHTMLPart.
            (KWQKHTMLPart::KWQKHTMLPart): Don't initialize _currentEvent.
            (KWQKHTMLPart::~KWQKHTMLPart): Don't release _currentEvent.
            (KWQKHTMLPart::submitForm): Pass [NSApp currentEvent] instead of _currentEvent.
            (KWQKHTMLPart::urlSelected): Pass [NSApp currentEvent] instead of _currentEvent.
            (KWQKHTMLPart::scrollToAnchor): Added. Contains the code from the anchor case inside
    	KHTMLPart::openURL.
    
            * kwq/WebCoreBridge.h: Added scrollToAnchorWithURL:.
            * kwq/WebCoreBridge.mm:
            (-[WebCoreBridge openURL:reload:headers:lastModified:pageCache:]): Change around so that we
    	don't do a bunch of irrelevant stuff in the page cache case. I think we might just want to
    	make a separate method for the page cache case.
            (-[WebCoreBridge scrollToAnchorWithURL:]): Added.
            (-[WebCoreBridge mouseUp:]): Simplify check for nil view. Remove calls to setCurrentEvent.
            (-[WebCoreBridge mouseDown:]): Simplify check for nil view. Fix event type constants for
    	right mouse button and other mouse button.
            (-[WebCoreBridge mouseMoved:]): Simplify check for nil view.
            (-[WebCoreBridge mouseDragged:]): Simplify check for nil view.
    
    WebKit:
    
            Reviewed by Trey and Maciej.
    
    	- fixed 3117558 -- Assertion failure in KWQKHTMLPart::slotData after typing "amazon.com" twice
    	- update NSEvent handling in preparation for NSView mouse event handling going through WebCore
    
            * WebView.subproj/WebFramePrivate.m:
            (-[WebFrame _loadItem:fromItem:withLoadType:]): Added FIXME comments about matching the _loadURL
    	case more closely.
            (-[WebFrame _actionInformationForNavigationType:event:originalURL:]): Only use the event if it's
    	a mouse down event. This prevents trouble when we have other kinds of events coming through.
            (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]): Call the new scrollToAnchorWithURL:
    	instead of openURL:. This fixes the assertion failure in the bug above.
            (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Update checks here to more closely
    	match the ones in KHTMLPart::openURL that we are replacing. Add more comments.
    
            * WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): Function to intercept all clicks at the
    	WebHTMLView level, disabled for now because we are not yet ready.
    
    	- started a gzip download decoder, not yet hooked up
    
            * Downloads.subproj/WebGZipDecoder.h: Added.
            * Downloads.subproj/WebGZipDecoder.m: Added.
            * WebKit.pbproj/project.pbxproj: Add WebGZipDecoder and zlib.
    
    	- other changes
    
            * Panels.subproj/WebAuthenticationPanel.m: Fixed screwed-up indentation.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    6f5b5073