Skip to content
  • tkent@chromium.org's avatar
    2011-03-29 Kent Tamura <tkent@chromium.org> · 6f499f0f
    tkent@chromium.org authored
            Reviewed by Dimitri Glazkov.
    
            Make validation message bubble testable
            https://bugs.webkit.org/show_bug.cgi?id=57290
    
            Add a new test for validation message bubble, and skip it on non-Mac platforms.
    
            * fast/forms/validation-message-appearance.html: Added.
            * platform/chromium/test_expectations.txt:
            * platform/gtk/Skipped:
            * platform/mac/fast/forms/validation-message-appearance-expected.checksum: Added.
            * platform/mac/fast/forms/validation-message-appearance-expected.png: Added.
            * platform/mac/fast/forms/validation-message-appearance-expected.txt: Added.
            * platform/qt/Skipped:
            * platform/win/Skipped:
    2011-03-29  Kent Tamura  <tkent@chromium.org>
    
            Reviewed by Dimitri Glazkov.
    
            Make validation message bubble testable
            https://bugs.webkit.org/show_bug.cgi?id=57290
    
            Introduce a setting for validation message timer so that we can configure
            how long we show a validation message bubble.
    
            Test: fast/forms/validation-message-appearance.html
    
            * html/ValidationMessage.cpp:
            (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
              Don't set a timer if the timer magnification value is 0 or negative.
              Otherwise, hides the bubble length * magnification / 1000 seconds.
            * page/Settings.cpp:
            (WebCore::Settings::Settings): Initialize the timer magnification value.
            * page/Settings.h:
            (WebCore::Settings::setValidationMessageTimerMagnification): Added.
            (WebCore::Settings::validationMessageTimerMaginification): Added.
    2011-03-29  Kent Tamura  <tkent@chromium.org>
    
            Reviewed by Dimitri Glazkov.
    
            Make validation message bubble testable
            https://bugs.webkit.org/show_bug.cgi?id=57290
    
            * WebView/WebView.mm:
            (-[WebView _preferencesChangedNotification:]): Copy the private value of
              the timer magnification to WebCore::Settings.
            (-[WebView validationMessageTimerMagnification]): Added.
            (-[WebView setValidationMessageTimerMagnification:]): Added.
            * WebView/WebViewData.h: Declare a member for the timer magnification.
            * WebView/WebViewData.mm:
            (-[WebViewPrivate init]): Initialize the timer magnification.
            * WebView/WebViewPrivate.h:
              Declare a setter and a getter for the timer magnification.
    2011-03-29  Kent Tamura  <tkent@chromium.org>
    
            Reviewed by Dimitri Glazkov.
    
            Make validation message bubble testable
            https://bugs.webkit.org/show_bug.cgi?id=57290
    
            * DumpRenderTree/mac/DumpRenderTree.mm:
            (createWebViewAndOffscreenWindow): Change a setting so that validation
              bubbles isn't hidden automatically.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    6f499f0f