Skip to content
  • commit-queue@webkit.org's avatar
    [css3-text] Add suport for -webkit-text-decoration-line · 68a556b0
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=90959
    
    Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-08-09
    Reviewed by Kenneth Rohde Christiansen.
    
    This patch implements the "text-decoration-line" property specified in CSS3
    working draft, with "-webkit-" prefix. The specification can be found below:
    http://dev.w3.org/csswg/css3-text/#text-decoration-line
    
    Additionally, Mozilla implementation details can be found here:
    https://developer-dev.allizom.org/en-US/docs/CSS/text-decoration-line
    
    It is important to notice that "-webkit-text-decoration-line" and
    "text-decoration" properties shares the same property handlers, however, the
    former resets the latter if value from latter doesn't have "important" value
    set (same behavior as Firefox). In a rare case where both properties have
    "important" value set, the text decoration gets value from the last parsed
    property.
    
    Source/WebCore:
    
    Test: fast/css/text-decoration-line.html
    
    * css/CSSComputedStyleDeclaration.cpp:
    (WebCore::renderTextDecorationFlagsToCSSValue):
    (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
    * css/CSSParser.cpp:
    (WebCore::CSSParser::parseValue):
    (WebCore::CSSParser::addTextDecorationProperty):
    (WebCore::CSSParser::parseTextDecoration):
    * css/CSSParser.h:
    * css/CSSProperty.cpp:
    (WebCore::CSSProperty::isInheritedProperty):
    * css/CSSPropertyNames.in:
    * css/StyleBuilder.cpp:
    (WebCore::StyleBuilder::StyleBuilder):
    * css/StyleResolver.cpp:
    (WebCore::StyleResolver::collectMatchingRulesForList):
    
    LayoutTests:
    
    * fast/css/getComputedStyle/computed-style-expected.txt:
    * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
    * fast/css/getComputedStyle/resources/property-names.js:
    * fast/css/text-decoration-line-expected.html: Added.
    * fast/css/text-decoration-line.html: Added.
    * svg/css/getComputedStyle-basic-expected.txt:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    68a556b0