Skip to content
  • ggaren's avatar
    WebCore: · 64f3f21d
    ggaren authored
            Reviewed by Oliver Hunt.
    
            Removed WebCoreSettings, cleaned up WebCore::Settings.
    
            * WebCore.exp: Exported Settings for use by WebKit, removed WebCoreSettings class.
            
            * WebCore.xcodeproj/project.pbxproj: Removed WebCoreSetttings.h/.mm.
            Added Settings.cpp.
    
            * page/Frame.cpp: Removed cruft that duplicated Settings data. Callers now call
            through to Settings to get Settings data.
    
            * page/Page.cpp: Added Settings data member, to replace the one that WebView
            used to hold.
    
            * page/Settings.cpp: Added.
            * page/Settings.h:
                - Renamed all functions to match WebKit API. Renamed all variables to
                match functions. Favorite old name: "isPluginsEnabled."
                - Moved EditableLinkBehavior outside of the class. Having it inside
                just made it harder to type.
                - Merged in old WebCoreSettings functionality, like guarding against re-setting
                to the same value, and making sure to update page layout.
                - Paired setters and getters, putting setters first.            
    
    WebKit:
    
            Reviewed by Oliver Hunt.
            
            Removed WebCoreSettings, cleaned up WebCore::Settings.
    
            * WebView/WebFrame.mm: Added helper functions for converting between
            WebKitEditableLinkBehavior and WebCore::EditableLinkBehavior. I'm not sure
            that this is the best place for these functions, but it's where all the
            other functions like them reside.
            (core):
            (kit):
            * WebView/WebFrameInternal.h:
    
            * WebView/WebView.mm: Removed uses of WebCoreSettings. Replaced with direct
            use of underlying page's settings.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    64f3f21d