Skip to content
  • hausmann@webkit.org's avatar
    2008-06-26 Holger Hans Peter Freyther <zecke@selfish.org> · 647f4529
    hausmann@webkit.org authored
            Reviewed by Simon.
    
            [svg] Disable plugins for SVG images
            The Qt platform allows to have a plugin factory per Page. Now SVG Images
            are using a Page and dummy/empty clients for Chrome. The only way to get
            the kit from the WebCore::Page is to go through the ChromeClient but this
            is not possible when the ChromeClient is an empty client. This leads to a
            crash in PluginDataQt.cpp. One way to avoid this would have been the
            addition of a rtti like field to ChromeClient to see if it is an empty
            client. The other possibility is to not enable plugins for images.
    
            The SVGImage relies on the fact that the document is a SVGDocument and
            that the rootElement is a SVGSVGElement. If plugins are used we could
            end up with a PluginDocument and crash badly. Do not try to use plugins
            if plugins are disabled for the WebCore::Page.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    647f4529