• commit-queue@webkit.org's avatar
    [Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex · 61d00bd3
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=95618
    
    Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-09-04
    Reviewed by Martin Robinson.
    
    Source/WebCore:
    
    Make sure we only emit the the signal for menu lists and list
    boxes rendered from actual HTML select elements.
    
    * accessibility/gtk/AXObjectCacheAtk.cpp:
    (WebCore::notifyChildrenSelectionChange): We support accessibility
    ListBoxes and MenuLists only here, assuming they represent HTML
    select elements, which might be not always true (e.g. ARIA). Thus,
    check if that condition is true, early returning in other case.
    
    LayoutTests:
    
    New layout test to ensure we don't crash with ATK notifications
    anymore when changing the selection in an ARIA listbox.
    
    * platform/gtk/accessibility/aria-listbox-crash-expected.txt: Added.
    * platform/gtk/accessibility/aria-listbox-crash.html: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    61d00bd3
ChangeLog 3.61 MB