-
mrobinson@webkit.org authored
Reviewed by Eric Seidel. [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange) https://bugs.webkit.org/show_bug.cgi?id=55603 * platform/gtk/Skipped: Unskip a test that is now passing. Better describe remaining failures. 2011-06-09 Martin Robinson <mrobinson@igalia.com> Reviewed by Eric Seidel. [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange) https://bugs.webkit.org/show_bug.cgi?id=55603 Added DumpRenderTreeSupport methods to support hasMarkedText and markedRange. * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setComposition): Use start and length rather than start and end. This matches other ports. Only use GLib style early returns when checking the validity of GObjects. (DumpRenderTreeSupportGtk::hasComposition): Added. (DumpRenderTreeSupportGtk::compositionRange): Added. (DumpRenderTreeSupportGtk::confirmComposition): Cleanup as described above. (DumpRenderTreeSupportGtk::firstRectForCharacterRange): Cleanup as described above. (DumpRenderTreeSupportGtk::selectedRange): Cleanup as described above. * WebCoreSupport/DumpRenderTreeSupportGtk.h: Added new declarations. 2011-06-09 Martin Robinson <mrobinson@igalia.com> Reviewed by Eric Seidel. [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange) https://bugs.webkit.org/show_bug.cgi?id=55603 Add callbacks to support hasMarkedText and markedRange and also clean up existing TextInputController support. * DumpRenderTree/gtk/TextInputController.cpp: (setMarkedTextCallback): Accept parameters in terms of start and length, instead of start and end. This matches the other ports. Do not use GLib style early returns. (hasMarkedTextCallback): Added. (markedRangeCallback): Added. (insertTextCallback): Cleanup as described above. (unmarkTextCallback): Cleanup as described above. (firstRectForCharacterRangeCallback): Cleanup as described above. (selectedRangeCallback): Cleanup as described above. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
5d92606e