Skip to content
  • joepeck@webkit.org's avatar
    Web Inspector: Move Inspector and Debugger protocol domains into JavaScriptCore · 4591f9bc
    joepeck@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=125707
    
    Reviewed by Timothy Hatcher.
    
    Source/JavaScriptCore:
    
    * CMakeLists.txt:
    * DerivedSources.make:
    * GNUmakefile.am:
    * inspector/protocol/Debugger.json: Renamed from Source/WebCore/inspector/protocol/Debugger.json.
    * inspector/protocol/GenericTypes.json: Added.
    * inspector/protocol/InspectorDomain.json: Renamed from Source/WebCore/inspector/protocol/InspectorDomain.json.
    Add new files to inspector generation.
    
    * inspector/scripts/CodeGeneratorInspector.py:
    (Generator.go):
    Only build TypeBuilder output if the domain only has types. Avoid
    backend/frontend dispatchers and backend commands.
    
    (TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
    (format_setter_value_expression):
    (Generator.process_command):
    (Generator.generate_send_method):
    * inspector/scripts/CodeGeneratorInspectorStrings.py:
    Export and name the get{JS,Web}EnumConstant function.
    
    Source/WebCore:
    
      - Switch TypeBuilder::Page::SearchMatch to TypeBuilder::GenericTypes::SearchMatch
        which comes from InspectorJSTypeBuilders.
      - Remove domains that moved to JavaScriptCore.
    
    No new tests, this only moves code around. There are no functional changes.
    
    * CMakeLists.txt:
    * DerivedSources.make:
    * GNUmakefile.am:
    Add new files.
    
    * inspector/ContentSearchUtils.cpp:
    (WebCore::ContentSearchUtils::buildObjectForSearchMatch):
    (WebCore::ContentSearchUtils::searchInTextByLines):
    * inspector/ContentSearchUtils.h:
    * inspector/InspectorAgent.cpp:
    * inspector/InspectorAgent.h:
    * inspector/InspectorDebuggerAgent.h:
    * inspector/InspectorPageAgent.cpp:
    (WebCore::InspectorPageAgent::searchInResource):
    * inspector/InspectorPageAgent.h:
    * inspector/protocol/Page.json:
    Update includes and type builder type names.
    
    * inspector/InspectorDebuggerAgent.cpp:
    (WebCore::breakpointActionTypeForString):
    (WebCore::InspectorDebuggerAgent::searchInContent):
    * inspector/InspectorTimelineAgent.cpp:
    (WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
    Use the new getEnum function names.
    
    Source/WebInspectorUI:
    
    * UserInterface/InspectorJSBackendCommands.js:
    * UserInterface/InspectorWebBackendCommands.js:
    Regenerate now that domains have moved around.
    
    LayoutTests:
    
    * http/tests/inspector-protocol/resources/InspectorTest.js:
    (InspectorTest.checkForError):
    Since having a protocol error is likely wrong, make the output
    for it as detailed as possible.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    4591f9bc