• zandobersek@gmail.com's avatar
    Move MemoryInfo under window.internals · 43a80137
    zandobersek@gmail.com authored
    https://bugs.webkit.org/show_bug.cgi?id=117197
    
    Reviewed by Ryosuke Niwa.
    
    .: 
    
    * Source/autotools/symbols.filter: Export the required symbol.
    
    PerformanceTests: 
    
    * resources/runner.js: Remove the setMemoryEnabled call, it's not required anymore as the memory
    info is now accessed through window.internals and doesn't need the setting to be enabled to work.
    
    Source/WebCore: 
    
    The MemoryInfo interface is not a subject of any specification and should not be exposed
    to the Web. It's still used by the performance tests so it is moved under the testing
    internals, accessible through window.internals.memoryInfo.
    
    The jsHeapSizeLimit attribute is removed from the MemoryInfo interface as that value was
    only usable when using the V8 bindings which are not supported anymore. A small fast/harness
    test is also provided to check that the MemoryInfo object is accessible through window.internals.
    
    Test: fast/harness/memoryinfo-object.html
    
    * CMakeLists.txt:
    * DerivedSources.cpp:
    * DerivedSources.make:
    * DerivedSources.pri:
    * GNUmakefile.list.am:
    * Target.pri:
    * UseJSC.cmake:
    * WebCore.exp.in:
    * WebCore.order:
    * WebCore.vcxproj/WebCore.vcxproj:
    * WebCore.vcxproj/WebCore.vcxproj.filters:
    * WebCore.vcxproj/WebCoreTestSupport.vcxproj:
    * WebCore.vcxproj/WebCoreTestSupport.vcxproj.filters:
    * WebCore.xcodeproj/project.pbxproj:
    * bindings/gobject/GNUmakefile.am: Remove the GObject bindings targets for MemoryInfo.
    * bindings/js/JSBindingsAllInOne.cpp: Remove the JSMemoryInfo.h and MemoryInfo.h inclusion.
    * bindings/js/JSMemoryInfoCustom.cpp: Removed.
    * bindings/js/ScriptGCEvent.cpp: Remove the ENABLE(INSPECTOR) guards.
    (WebCore::ScriptGCEvent::getHeapSize): Remove the jsHeapSizeLimit assignment.
    * bindings/js/ScriptGCEvent.h: Remove the ENABLE(INSPECTOR) guards.
    (WebCore::HeapInfo::HeapInfo): Remove the jsHeapSizeLimit member.
    * page/Console.cpp: Remove the Console::memory method.
    * page/Console.h: Ditto.
    * page/Console.idl: Remove the window.console.memory attribute.
    * page/MemoryInfo.cpp: Removed.
    * page/Performance.cpp: Remove the Performance::memory method.
    * page/Performance.h: Ditto.
    * page/Performance.idl: Remove the window.performance.memory attribute.
    * testing/Internals.cpp:
    (WebCore::Internals::memoryInfo): Return a MemoryInfo object upon invoking.
    * testing/Internals.h: Declare the Internals::memoryInfo method.
    * testing/Internals.idl: Expose the window.internals.memoryInfo operation.
    * testing/MemoryInfo.h: Renamed from Source/WebCore/page/MemoryInfo.h.
    (WebCore::MemoryInfo::create): Return a new RefPtr-wrapped MemoryInfo object.
    (WebCore::MemoryInfo::usedJSHeapSize): Return the value of the equally-named HeapInfo member.
    (WebCore::MemoryInfo::totalJSHeapSize): Ditto.
    (WebCore::MemoryInfo::MemoryInfo): Acquire the current heap info upon construction.
    * testing/MemoryInfo.idl: Renamed from Source/WebCore/page/MemoryInfo.idl.
    The jsHeapSizeLimit attribute is removed.
    
    Tools: 
    
    * GNUmakefile.am: Add the testing/MemoryInfo.(h|idl) files and the generated targets to
    the Automake build
    * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: List the
    testing/MemoryInfo.idl file instead of page/MemoryInfo.idl.
    
    LayoutTests: 
    
    Remove window.performance.memory property listings from the baselines, the object was moved
    under window.internals. The latter is tested throug the new fast/harness test.
    
    * fast/dom/Window/window-properties-performance-expected.txt:
    * fast/harness/memoryinfo-object-expected.txt: Added.
    * fast/harness/memoryinfo-object.html: Added.
    * platform/efl/fast/dom/Window/window-properties-performance-expected.txt:
    * platform/gtk/fast/dom/Window/window-properties-performance-expected.txt:
    * platform/qt/fast/dom/Window/window-properties-performance-expected.txt:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    43a80137
window-properties-performance-expected.txt 1.81 KB