Skip to content
  • jchaffraix@webkit.org's avatar
    2011-05-11 Julien Chaffraix <jchaffraix@webkit.org> · 3e8c7d14
    jchaffraix@webkit.org authored
            Reviewed by Geoffrey Garen.
    
            Tests for: XPathResult should keep its node set's JS wrappers alive
            https://bugs.webkit.org/show_bug.cgi?id=34231
    
            * fast/xpath/xpath-result-eventlistener-crash-expected.txt: Added.
            * fast/xpath/xpath-result-eventlistener-crash.html: Added.
            Test that an event listener registered on an XPATH result snapshots' node does
            not crash. This case was already fixed prior to this change. However it is better
            to keep it as a regression test.
    
            * fast/xpath/xpath-snapshot-result-should-mark-its-nodeset-expected.txt: Added.
            * fast/xpath/xpath-snapshot-result-should-mark-its-nodeset.html: Added.
            Test that an XPath snapshot result keeps its node wrapper alive.
    
            * fast/xpath/xpath-iterator-result-should-mark-its-nodeset-expected.txt: Added.
            * fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html: Added.
            Test that an XPath iterator result keeps its node wrapper alive.
    
            * fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset-expected.txt: Added.
            * fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset.html: Added.
            Test that other XPath result that holds nodes keeps their wrapper alive.
    2011-05-11  Julien Chaffraix  <jchaffraix@webkit.org>
    
            Reviewed by Geoffrey Garen.
    
            XPathResult should keep its node set's JS wrappers alive
            https://bugs.webkit.org/show_bug.cgi?id=34231
    
            The change added a custom mark function for JSC. V8 was already properly
            marking the nodes so no change were done on the V8 side.
    
            Tests: fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html
                   fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset.html
                   fast/xpath/xpath-result-eventlistener-crash.html
                   fast/xpath/xpath-snapshot-result-should-mark-its-nodeset.html
    
            * Android.jscbindings.mk:
            * GNUmakefile.list.am:
            * UseJSC.cmake:
            * WebCore.gypi:
            * WebCore.pro:
            * WebCore.vcproj/WebCore.vcproj:
            * WebCore.xcodeproj/project.pbxproj:
            * bindings/js/JSBindingsAllInOne.cpp:
            Added the new file to our build systems.
    
            * bindings/js/JSXPathResultCustom.cpp: Added.
            (WebCore::JSXPathResult::markChildren): Added code to mark the
            XPathResult snapshot's nodes.
            * xml/XPathResult.h:
            (WebCore::XPathResult::value): Exposed this getter so that we can
            mark our XPathValue.
            * xml/XPathResult.idl: Told the IDL parser that we now need
            a custom mark function.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    3e8c7d14