Skip to content
  • darin's avatar
    WebCore: · 3d938e6d
    darin authored
            Reviewed by Maciej.
    
            - cut out a little unneeded bridge code
    
            * bridge/mac/WebCoreFrameBridge.h: Removed frame name from createWindowWithURL: method
            and changed it to return a page bridge. Also made createModalDialogWithURL: method
            return a page bridge. Removed the mainFrame and webView methods.
            * bridge/mac/WebCoreFrameBridge.mm:
            (-[WebCoreFrameBridge nextFrameWithWrap:]): Use page to get to main frame.
            (-[WebCoreFrameBridge setFrameNamespace:]): Ditto.
            (-[WebCoreFrameBridge frameNamespace]): Ditto.
            (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Ditto.
            (-[WebCoreFrameBridge _frameInAnyWindowNamed:sourceFrame:]): Ditto.
            (-[WebCoreFrameBridge findFrameNamed:]): Ditto.
            (-[WebCoreFrameBridge installInFrame:]): Ditto.
    
            * bridge/mac/WebCorePageBridge.h: Added outerView method to replace webView method
            on the frame bridge.
    
            * bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
            Update to use a page bridge instead of frame bridge.
    
    WebKit:
    
            Reviewed by Maciej.
    
            - cut out a little unneeded bridge code
    
            * WebCoreSupport/WebFrameBridge.m:
            (-[WebFrameBridge webView]): Added. Helper, since the WebCore side of the bridge no longer
            has this method.
            (-[WebFrameBridge createWindowWithURL:]): Removed the frameName parameter -- this is now
            handled on the WebCore side. Also return a page bridge instead of a frame bridge.
            (-[WebFrameBridge createModalDialogWithURL:]): Changed to return a page bridge instead of
            a frame bridge.
    
            * WebView/WebFrame.m: (-[WebFrame webView]): Change to get the webView from the page bridge
            instead of the frame bridge, since it's a per-page thing.
    
            * WebView/WebView.m: Removed init method since it just does what the default does (calls
            initWithFrame: with a zero rect).
            (-[WebView initWithCoder:]): Added checking so that if the obejcts have the wrong type
            we will fail gracefully instead of hitting "method not found" and the like.
            (-[WebView setPreferencesIdentifier:]): Fix storage leak. The WebPreferences object was
            not released.
            (-[WebView mainFrame]): Removed excess "return nil".
            (-[WebView _pageBridge]): Added. Helper to let you go from the WebView to the bridge
            from outside the WebView class.
            * WebView/WebViewInternal.h: Put _pageBridge into an internal header.
    
            * WebCoreSupport/WebPageBridge.m: (-[WebPageBridge outerView]): Added. Replaces "webView"
            as public method to tell the WebCore side about the view everything's embedded in.
    
            - other cleanup
    
            * WebCoreSupport/WebPageBridge.h: Removed some unneeded declarations.
    
            * Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadPluginRequest:]):
            Rearrange code so it doesn't have to get the main frame twice.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    3d938e6d