Skip to content
  • rniwa@webkit.org's avatar
    There are too many poorly named functions to create a fragment from markup · 3976f1be
    rniwa@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=87339
    
    Reviewed by Eric Seidel.
    
    Source/WebCore:
    
    Moved all functions that create a fragment from markup to markup.h/cpp.
    There should be no behavioral change.
    
    * dom/Range.cpp:
    (WebCore::Range::createContextualFragment):
    * dom/Range.h: Removed createDocumentFragmentForElement.
    * dom/ShadowRoot.cpp:
    (WebCore::ShadowRoot::setInnerHTML):
    * editing/markup.cpp:
    (WebCore::createFragmentFromMarkup):
    (WebCore::createFragmentForInnerOuterHTML): Renamed from createFragmentFromSource.
    (WebCore::createFragmentForTransformToFragment): Moved from XSLTProcessor.
    (WebCore::removeElementPreservingChildren): Moved from Range.
    (WebCore::createContextualFragment): Ditto.
    * editing/markup.h:
    * html/HTMLElement.cpp:
    (WebCore::HTMLElement::setInnerHTML):
    (WebCore::HTMLElement::setOuterHTML):
    (WebCore::HTMLElement::insertAdjacentHTML):
    * inspector/DOMPatchSupport.cpp:
    (WebCore::DOMPatchSupport::patchNode): Added a FIXME since this code should be using
    one of the functions listed in markup.h
    * xml/XSLTProcessor.cpp:
    (WebCore::XSLTProcessor::transformToFragment):
    
    Source/WebKit/qt:
    
    Replace calls to Range::createDocumentFragmentForElement by calls to
    createContextualDocumentFragment.
    
    * Api/qwebelement.cpp:
    (QWebElement::appendInside):
    (QWebElement::prependInside):
    (QWebElement::prependOutside):
    (QWebElement::appendOutside):
    (QWebElement::encloseContentsWith):
    (QWebElement::encloseWith):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    3976f1be