Skip to content
  • kihong.kwon@samsung.com's avatar
    Vibration API: IDL type doesn't match implementation type · 2f437bd7
    kihong.kwon@samsung.com authored
    https://bugs.webkit.org/show_bug.cgi?id=103899
    
    Reviewed by Kentaro Hara.
    
    Source/WebCore:
    
    According to WebIDL, "unsigned long" corresponds to "unsigned" in the platform.
    Therefore unsigned long need to be changed to unsigned for the Vibration API.
    - Change a parameter type of vibrate function from unsigned long to unsigned.
    
    No new tests, it is covered by exist test.
    
    * Modules/vibration/NavigatorVibration.cpp:
    (WebCore::NavigatorVibration::vibrate):
    * Modules/vibration/NavigatorVibration.h:
    (NavigatorVibration):
    * Modules/vibration/Vibration.cpp:
    (WebCore::Vibration::vibrate):
    * Modules/vibration/Vibration.h:
    (Vibration):
    * Modules/vibration/VibrationClient.h:
    (VibrationClient):
    * bindings/js/JSDOMBinding.h:
    * bindings/scripts/CodeGeneratorJS.pm:
    Remove workaround codes for the Vibration API which is mapped from unsigned long to unsigned long.
    It should be mapped from unsigned long to unsigned by WebIDL spec.
    (GetNativeVectorInnerType):
    * bindings/scripts/test/JS/JSTestObj.cpp:
    (WebCore::jsTestObjPrototypeFunctionOverloadedMethod10):
    (WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongSequence):
    
    Source/WebKit/blackberry:
    
    According to WebIDL, "unsigned long" corresponds to "unsigned" in the platform.
    Therefore unsigned long need to be changed to unsigned for the Vibration API.
    - Change a parameter type of vibrate function from unsigned long to unsigned.
    
    * WebCoreSupport/VibrationClientBlackBerry.cpp:
    (WebCore::VibrationClientBlackBerry::vibrate):
    * WebCoreSupport/VibrationClientBlackBerry.h:
    (VibrationClientBlackBerry):
    
    Source/WebKit/efl:
    
    According to WebIDL, "unsigned long" corresponds to "unsigned" in the platform.
    Therefore unsigned long need to be changed to unsigned for the Vibration API.
    - Change a parameter type of vibrate function from unsigned long to unsigned.
    
    * WebCoreSupport/VibrationClientEfl.cpp:
    (WebCore::VibrationClientEfl::vibrate):
    * WebCoreSupport/VibrationClientEfl.h:
    (VibrationClientEfl):
    
    Source/WebKit2:
    
    According to WebIDL, "unsigned long" corresponds to "unsigned" in the platform.
    Therefore unsigned long need to be changed to unsigned for the Vibration API.
    - Change a parameter type of vibrate function from uint64_t to uint_32_t.
    
    * UIProcess/API/C/WKVibration.h:
    * UIProcess/API/efl/EwkViewCallbacks.h:
    * UIProcess/WebVibrationProvider.cpp:
    (WebKit::WebVibrationProvider::vibrate):
    * UIProcess/WebVibrationProvider.h:
    (WebVibrationProvider):
    * UIProcess/WebVibrationProxy.cpp:
    (WebKit::WebVibrationProxy::vibrate):
    * UIProcess/WebVibrationProxy.h:
    (WebVibrationProxy):
    * UIProcess/WebVibrationProxy.messages.in:
    * UIProcess/efl/VibrationClientEfl.cpp:
    (VibrationClientEfl::vibrateCallback):
    * UIProcess/efl/VibrationClientEfl.h:
    (VibrationClientEfl):
    * WebProcess/WebCoreSupport/WebVibrationClient.cpp:
    (WebKit::WebVibrationClient::vibrate):
    * WebProcess/WebCoreSupport/WebVibrationClient.h:
    (WebVibrationClient):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    2f437bd7