-
darin@apple.com authored
2008-10-12 Darin Adler <darin@apple.com> Reviewed by Sam Weinig. - https://bugs.webkit.org/show_bug.cgi?id=21556 Bug 21556: non-ASCII digits are allowed in places where only ASCII should be * wtf/unicode/icu/UnicodeIcu.h: Removed isDigit, digitValue, and isFormatChar. * wtf/unicode/qt4/UnicodeQt4.h: Ditto. WebCore: 2008-10-12 Darin Adler <darin@apple.com> Reviewed by Sam Weinig. - https://bugs.webkit.org/show_bug.cgi?id=21556 Bug 21556: non-ASCII digits are allowed in places where only ASCII should be Tests: fast/dom/HTMLFontElement/size-attribute.html fast/dom/HTMLInputElement/size-attribute.html fast/dom/HTMLTableElement/cellpadding-attribute.html * html/HTMLFontElement.cpp: (WebCore::parseFontSizeNumber): Use isASCIIDigit instead of Unicode::isDigit, since non-ASCII digits are not valid here. * html/HTMLFontElement.h: Tweaked formatting a bit and removed the unneeded destructor declaration. * platform/text/String.cpp: (WebCore::lengthOfCharactersAsInteger): Use isASCIIDigit instead of Unicode::isDigit, since non-ASCII digits are not valid. LayoutTests: 2008-10-12 Darin Adler <darin@apple.com> Reviewed by Sam Weinig. - tests for https://bugs.webkit.org/show_bug.cgi?id=21556 Bug 21556: non-ASCII digits are allowed in places where only ASCII should be The fix was in a function used all over the place. I set a breakpoint in the function and made some regression tests for the first few places it was used. * fast/dom/HTMLFontElement: Added. * fast/dom/HTMLFontElement/resources: Added. * fast/dom/HTMLFontElement/resources/TEMPLATE.html: Added. * fast/dom/HTMLFontElement/resources/size-attribute.js: Added. * fast/dom/HTMLFontElement/size-attribute-expected.txt: Added. * fast/dom/HTMLFontElement/size-attribute.html: Added. * fast/dom/HTMLInputElement/resources/size-attribute.js: Added. * fast/dom/HTMLInputElement/size-attribute-expected.txt: Added. * fast/dom/HTMLInputElement/size-attribute.html: Added. * fast/dom/HTMLTableElement/cellpadding-attribute-expected.txt: Added. * fast/dom/HTMLTableElement/cellpadding-attribute.html: Added. * fast/dom/HTMLTableElement/resources/cellpadding-attribute.js: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2ce65d5d