-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=31312 Decouple authentication panel callbacks from ResourceHandle No change in functionality. SocketStreamHandle also needs to request credentials, so it's not appropriate to store ResourceHandle as delegate. WebCore: * WebCore.vcproj/WebCore.vcproj: * platform/network/AuthenticationClient.h: Added. Added a new interface for listening to authentication panel notifications. * WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what it wants with the project file. (WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an interface class. (WebCore::AuthenticationClient::deref): Ditto. * platform/network/ResourceHandle.h: (WebCore::ResourceHandle::refAuthenticationClient): Ditto. (WebCore::ResourceHandle::derefAuthenticationClient): Ditto. * platform/network/cf/AuthenticationCF.cpp: (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::platformCompare): * platform/network/cf/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::authenticationClient): * platform/network/chromium/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::authenticationClient): * platform/network/curl/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::authenticationClient): Keeping a reference to AuthenticationClient, not to ResourceHandle. WebKit: * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): * WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::initWithAuthenticationChallenge): (WebURLAuthenticationChallenge::sender): * WebURLAuthenticationChallengeSender.cpp: (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender): (WebURLAuthenticationChallengeSender::createInstance): (WebURLAuthenticationChallengeSender::authenticationClient): * WebURLAuthenticationChallengeSender.h: * WebURLAuthenticationChallengeSenderCFNet.cpp: (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge): (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge): (WebURLAuthenticationChallengeSender::useCredential): Adjusted for WebCore changes. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2ab1e6a4