Skip to content
  • timothy_horton@apple.com's avatar
    Tiled drawing GraphicsLayer tree dumps should match non-tiled more closely · 203cdfa0
    timothy_horton@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=122172
    
    Reviewed by Anders Carlsson.
    
    No new tests, but will be tested by all of the compositing tests after bug 121859 lands.
    
    * platform/graphics/GraphicsLayer.cpp:
    (WebCore::GraphicsLayer::dumpProperties):
    Only dump drawsContent and backgroundColor if the client says we should.
    Provide the ability to skip over a layer in the dump, making it appear as if that layer's
    children are direct decendents of that layer's parent.
    
    * platform/graphics/GraphicsLayerClient.h:
    (WebCore::GraphicsLayerClient::shouldSkipLayerInDump): Added.
    (WebCore::GraphicsLayerClient::shouldDumpPropertyForLayer): Added.
    
    * rendering/RenderLayerBacking.cpp:
    (WebCore::RenderLayerBacking::shouldSkipLayerInDump):
    Added. Always skip the root tile cache's flattening layer, as it is
    uninteresting and does not exist in the non-tiled-drawing compositing case.
    
    (WebCore::RenderLayerBacking::shouldDumpPropertyForLayer):
    Don't dump drawsContent on the root tile cache.
    Don't dump backgroundcolor on the root tile cache, unless it is non-white.
    This may require some WebKit2-specific rebaselines, but they will occur later.
    
    * rendering/RenderLayerBacking.h:
    * rendering/RenderLayerCompositor.cpp:
    (WebCore::RenderLayerCompositor::updateBacking):
    (WebCore::RenderLayerCompositor::layerTreeAsText):
    If the root tile cache has no composited children, don't dump anything,
    to match the traditional case where we drop out of compositing when
    we have no reason to be compositing. Except, do dump the root tile cache's
    layers if we're specifically being asked to dump tile caches.
    
    * platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt:
    * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
    * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
    * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
    * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
    * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
    * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
    * platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
    * platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt:
    * platform/mac-wk2/tiled-drawing/sticky/sticky-layers-expected.txt:
    * platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
    * platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative-expected.txt:
    * platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
    * platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
    * platform/mac-wk2/tiled-drawing/tile-coverage-speculative-expected.txt:
    * platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:
    * platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration-expected.txt:
    * platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
    * platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
    * platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:
    Rebaseline some tests given these changes.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    203cdfa0