• mitz@apple.com's avatar
    REGRESSION (r76743): Uneven spacing in right-to-left justified text · 1b0578db
    mitz@apple.com authored
    Reviewed by Sam Weinig.
    Fixes failure in fast/text/atsui-spacing-features.html
    There was an inconsistency between rendering code and font code in the interpretation of
    'after expansion' and 'trailing expansion'. Changed all code to interpret these in terms of
    visual order rather than logical.
    * platform/graphics/Font.cpp:
    (WebCore::Font::expansionOpportunityCount): Added a text direction parameter and changed to
    iterate in visual order accordingly.
    * platform/graphics/Font.h:
    * platform/graphics/WidthIterator.cpp:
    (WebCore::WidthIterator::WidthIterator): Pass the run direction to expansionOpportunityCount().
    (WebCore::WidthIterator::advance): For right-to-left runs, evaluate the trailing expansion
    condition with respect to the first character, which is the trailing character in visual order.
    * platform/graphics/mac/ComplexTextController.cpp:
    (WebCore::ComplexTextController::ComplexTextController): Pass the run direction to
    * rendering/RenderBlockLineLayout.cpp:
    (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Ditto.
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Font.cpp 16.6 KB