Skip to content
  • fpizlo@apple.com's avatar
    DFG disassembly should be easier to read · 12c18391
    fpizlo@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=90106
    
    Reviewed by Mark Hahnenberg.
            
    Did a few things:
            
    - Options::showDFGDisassembly now shows OSR exit disassembly as well.
            
    - Phi node dumping doesn't attempt to do line wrapping since it just made the dump harder
      to read.
            
    - DFG graph disassembly view shows a few additional node types that turn out to be
      essential for understanding OSR exits.
            
    Put together, these changes reinforce the philosophy that anything needed for computing
    OSR exit is just as important as the machine code itself. Of course, we still don't take
    that philosophy to its full extreme - for example Phantom nodes are not dumped. We may
    revisit that in the future.
    
    * assembler/LinkBuffer.cpp:
    (JSC::LinkBuffer::finalizeCodeWithDisassembly):
    * assembler/LinkBuffer.h:
    (JSC):
    * dfg/DFGDisassembler.cpp:
    (JSC::DFG::Disassembler::dump):
    * dfg/DFGGraph.cpp:
    (JSC::DFG::Graph::dumpBlockHeader):
    * dfg/DFGNode.h:
    (JSC::DFG::Node::willHaveCodeGenOrOSR):
    * dfg/DFGOSRExitCompiler.cpp:
    * jit/JIT.cpp:
    (JSC::JIT::privateCompile):
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    12c18391