Skip to content
  • adele@apple.com's avatar
    WebCore: · 0677d680
    adele@apple.com authored
    2009-03-17  Adele Peterson  <adele@apple.com>
    
            Reviewed by Darin Adler.
    
            Fix for https://bugs.webkit.org/show_bug.cgi?id=24655
            <rdar://problem/6633727> Hitting return at the end of a line with an anchor jumps me to the bottom of the message
    
            Test: editing/inserting/6633727.html
    
            This changes does a few things:
            1) Renames pos to insertionPosition.
            2) Eliminates "startNode".  It doesn't work well to consider the node separately from the insertionPosition.  
               The insertionPosition gets updated at various times, and it seems likely that startNode can get out of sync.
            3) Before building up a list of ancestors to move around when we insert the new block, make sure to use the deepest
               representation of the insertionPosition, so all ancestor nodes are correctly included.
    
            * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
    
    LayoutTests:
    
    2009-03-17  Adele Peterson  <adele@apple.com>
    
            Reviewed by Darin Adler.
    
            Test for https://bugs.webkit.org/show_bug.cgi?id=24655
            <rdar://problem/6633727> Hitting return at the end of a line with an anchor jumps me to the bottom of the message
    
            * editing/inserting/6633727.html: Added.
            * platform/mac/editing/inserting/6633727-expected.checksum: Added.
            * platform/mac/editing/inserting/6633727-expected.png: Added.
            * platform/mac/editing/inserting/6633727-expected.txt: Added.
    
            Updated results.  The behavior for these tests doesn't change, but the render tree is slightly different.
    
            * platform/mac/editing/inserting/insert-div-021-expected.txt:
            * platform/mac/editing/style/block-styles-007-expected.txt:
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    0677d680