Skip to content
  • atwilson@chromium.org's avatar
    WebCore: isEnabled switch for notifications (experimental) in Page Settings · 046e502c
    atwilson@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=28930
    
    Patch by John Gregg <johnnyg@google.com> on 2009-09-14
    Reviewed by Eric Seidel.
    
    Adds a run-time flag in Settings object that controls whether
    to expose desktop notifications.
    
    No new test, but test code also modified to set this preference.
    
    * page/DOMWindow.cpp:
    (WebCore::DOMWindow::webkitNotifications): check preference before returning notifications object
    * page/Settings.cpp:
    (WebCore::Settings::Settings):
    (WebCore::Settings::setExperimentalNotificationsEnabled):
    * page/Settings.h:
    (WebCore::Settings::experimentalNotificationsEnabled):
    
    WebKit/mac: isEnabled switch for notifications (experimental) in Page Settings
    https://bugs.webkit.org/show_bug.cgi?id=28930
    
    Patch by John Gregg <johnnyg@google.com> on 2009-09-14
    Reviewed by Eric Seidel.
    
    Adds support for the experimentalNotificationsEnabled flag in Settings
    through WebPreferencesPrivate.
    
    * WebView/WebPreferenceKeysPrivate.h:
    * WebView/WebPreferences.mm:
    (+[WebPreferences initialize]):
    (-[WebPreferences experimentalNotificationsEnabled]):
    (-[WebPreferences setExperimentalNotificationsEnabled:]):
    * WebView/WebPreferencesPrivate.h:
    * WebView/WebView.mm:
    (-[WebView _preferencesChangedNotification:]):
    
    WebKit/win: Enable switch for notifications (experimental) in Page Settings
    https://bugs.webkit.org/show_bug.cgi?id=28930
    
    Patch by John Gregg <johnnyg@google.com> on 2009-09-14
    Reviewed by Eric Seidel.
    
    Adds support for the experimentalNotificationsEnabled flag in Settings through
    WebPreferencesPrivate interface.  Also cleans up some issues accessing the
    notification delegate through DumpRenderTree.
    
    * Interfaces/IWebPreferencesPrivate.idl:
    * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
    (WebDesktopNotificationsDelegate::hasNotificationDelegate):
    (WebDesktopNotificationsDelegate::notificationDelegate):
    * WebPreferenceKeysPrivate.h:
    * WebPreferences.cpp:
    (WebPreferences::initializeDefaultSettings):
    (WebPreferences::setExperimentalNotificationsEnabled):
    (WebPreferences::experimentalNotificationsEnabled):
    * WebPreferences.h:
    * WebView.cpp:
    (WebView::notifyPreferencesChanged):
    
    WebKitTools: Enable switch for notifications (experimental) in Page Settings
    https://bugs.webkit.org/show_bug.cgi?id=28930
    
    Patch by John Gregg <johnnyg@google.com> on 2009-09-14
    Reviewed by Eric Seidel.
    
    Now that desktop notifications are controlled by run-time switch,
    set that switch to true for DumpRenderTree.
    
    * DumpRenderTree/mac/DumpRenderTree.mm:
    (resetDefaultsToConsistentValues):
    * DumpRenderTree/win/DumpRenderTree.cpp:
    (resetDefaultsToConsistentValues):
    * DumpRenderTree/win/UIDelegate.cpp:
    (UIDelegate::QueryInterface):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    046e502c