Skip to content
  • bdakin@apple.com's avatar
    https://bugs.webkit.org/show_bug.cgi?id=91299 · 03247b23
    bdakin@apple.com authored
    Paginated views should restrict available height to column height
    -and corresponding-
    <rdar://problem/11152108>
    
    Reviewed by Dan Bernstein.
    
    Source/WebCore: 
    
    Now that RenderViews can have columns, availableLogicalHeight needs to consider 
    that column height, much like how availableLogicalWidth already considers column 
    width.
    
    availableLogicalHeight is newly virtual, like the already-virtual 
    availableLogicalWidth.
    * rendering/RenderBox.h:
    (RenderBox):
    
    Check with the columnHeight.
    * rendering/RenderView.cpp:
    (WebCore):
    (WebCore::RenderView::availableLogicalHeight):
    * rendering/RenderView.h:
    
    setPagination now takes pageLength as an optional parameter. 
    * testing/InternalSettings.cpp:
    (WebCore::InternalSettings::setPagination):
    * testing/InternalSettings.h:
    (WebCore::InternalSettings::setPagination):
    (InternalSettings):
    * testing/InternalSettings.idl:
    * testing/Internals.cpp:
    (WebCore::Internals::setPagination):
    * testing/Internals.h:
    (WebCore::Internals::setPagination):
    (Internals):
    * testing/Internals.idl:
    
    LayoutTests: 
    
    New test.
    * fast/multicol/resources/big-green.png: Added.
    * fast/multicol/shrink-to-column-height-for-pagination.html: Added.
    * platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Added.
    * platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Added.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    03247b23