-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=74864 Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-08-15 Reviewed by Julien Chaffraix. Source/WebCore: Hittest for a point on the edge, i.e. between two table columns, currently does not return any matching underlying element. A hittest on such a point (on the edge of two table columns) should return the column that lies either on the logical right/bottom of the said point. Tests: fast/table/hittest-tablecell-bottom-edge.html fast/table/hittest-tablecell-right-edge.html fast/table/hittest-tablecell-with-borders-bottom-edge.html fast/table/hittest-tablecell-with-borders-right-edge.html * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::spannedRows): Removed the FIXME regarding the correctness of the usage of the upper_bound algorithm since that is now verified by the testcases in this patch. Also, the comment regarding the inconsistency between the algorithms used in spannedRows and spannedColumns is no longer valid. (WebCore::RenderTableSection::spannedColumns): Changed lower_bound() algorithm to upper_bound() for obtaining the next column. This is now similar to what is used for obtaining the next row in spannedRows(). LayoutTests: * fast/table/hittest-tablecell-bottom-edge-expected.txt: Added. * fast/table/hittest-tablecell-bottom-edge.html: Added. * fast/table/hittest-tablecell-right-edge-expected.txt: Added. * fast/table/hittest-tablecell-right-edge.html: Added. Testcases added for verifying that the proper node is returned upon hit test carried out at a point lying on the edge of two table cells. * fast/table/hittest-tablecell-with-borders-bottom-edge-expected.txt: Added. * fast/table/hittest-tablecell-with-borders-bottom-edge.html: Added. * fast/table/hittest-tablecell-with-borders-right-edge-expected.txt: Added. * fast/table/hittest-tablecell-with-borders-right-edge.html: Added. These testcases verify the aforementioned behavior when the table cells also have border specified for them. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
01f61419