Skip to content
  • darin's avatar
    WebFoundation: · 01481afe
    darin authored
            * English.lproj/StringsNotToBeLocalized.txt:
    
    WebCore:
    
    	- finished up the job of moving the file button to WebKit
    
    	I did this mainly for localization reasons.
    
            * kwq/KWQFileButton.h: Remove filename(), add filenameChanged(),
    	make KWQFileButton be a QWidget subclass, not a QPushButton one.
    	Remove clicked() and paint() virtual functions, _filename, _icon,
    	and _label data members.
            * kwq/KWQFileButton.mm:
            (KWQFileButton::KWQFileButton): Just make a WebCoreFileButton.
            (KWQFileButton::~KWQFileButton): Less to do here now.
            (KWQFileButton::setFilename): Call the button to do the work.
            (KWQFileButton::sizeHint): Ditto.
            (KWQFileButton::frameGeometry): Ditto.
            (KWQFileButton::setFrameGeometry): Ditto.
            (KWQFileButton::baselinePosition): Ditto.
            (KWQFileButton::filenameChanged): Added. Sends message.
            (-[KWQFileButtonAdapter initWithKWQFileButton:]): Observe the "filename
    	changed notification".
            (-[KWQFileButtonAdapter dealloc]): Stop observing.
            (-[KWQFileButtonAdapter filenameChanged:]): Send a signal when the notification
    	comes in, so KHTML finds out.
    
            * kwq/KWQSlot.mm:
            (KWQSlot::KWQSlot): Remove handling for RenderFileButton slotReturnPressed.
            (KWQSlot::call): Ditto.
    
            * kwq/WebCoreViewFactory.h: Remove bestSize. Add setVisualFrame, visualFrame, and
    	bestVisualFrameSize.
    
            * kwq/KWQInputDialog.mm: Tweaked includes. Long-term we want to use "", not <>.
            * kwq/KWQKConfigBase.mm: Ditto.
            * kwq/KWQKHTMLPartImpl.mm: Ditto.
    
    WebKit:
    
    	- finished up the job of moving the file button here from WebCore.
    
    	I did this mainly for localization reasons.
    
            * WebCoreSupport.subproj/WebFileButton.m:
            (-[WebFileButton initWithFrame:]): Set up button control size, font, bezel style,
    	target, and action. Also add it as a subview.
            (-[WebFileButton drawRect:]): Center icon in the "visual frame" part of the view,
    	not the entire bounds.
            (-[WebFileButton setFilename:]): Don't show any icon when the filename is empty.
            (-[WebFileButton bestVisualFrameSize]): Implemented this.
            (-[WebFileButton visualFrame]): Ditto.
            (-[WebFileButton setVisualFrame:]): Ditto.
            (-[WebFileButton baseline]): Ditto.
            (-[WebFileButton beginSheet]): Added. Shared between button presses and other clicks.
            (-[WebFileButton chooseButtonPressed:]): Call beginSheet.
            (-[WebFileButton mouseDown:]): Ditto.
            (-[WebFileButton openPanelDidEnd:returnCode:contextInfo:]): Send the notification,
    	WebCoreFileButtonFilenameChanged, when the filename is changed.
    
            * WebView.subproj/WebController.m: (-[WebController policyDelegate]):
    	Add a FIXME about the leak I found here.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    01481afe