GitLab

This is not mandated by HTTP RFC's but the UPnP CTT requires this.

See Table 4-4 in UPnP DeviceArchitecture v1.1

The SoupMessage that is cancelled in the dispose handler doesn't
belong us, it has already been queued. This fixes a crash that
occured when a GUPnPService object is disposed before the initial
introspection call has finished.

GUPnPService used to hold a reference on itself for the run-time of
the initial asynchronous introspection. Due to this reference the
object can't be disposed until this call has finished. Now if you
create a device with services and immidiately destroy it, the
service will still be alive holding a pointer to the XML device
description that is not any longer valid. This leads to a crash
when the asynchronous introspection finishes.

Fix this crash by not keeping a reference on ourselves. The pending
introspection is then cancelled from the dispose handler.

This patch does not break compatibility against NM 0.8.x.

The UPnP spec requires quotes around the charset value in the
Content-Type HTTP header for action responses.

The UPnP spec requires quotes around the charset value in the
Content-Type HTTP header for NOTIFY messages.

We were using a very short timeout (3 ms) on one of the dbus calls.

Most of them are just accidently inverted and one of them isn't checking
for the (exactly) right type.

This fixes a regression in commit c7238cb7.

Check that variant is not NULL and it's of assumed type before accessing
it.

This reverts commit 1ff7bd81.

The action response document was missing an opening quote
sign in the namespace declaration of the <actionResponse>
element.

Fix it by adding the missing quote and also tweak the code
a bit to output well-formed XML in case that the service-type
is not set.

There's no point in setting "l" to the next list member here as we
are done with it anyway. Remove redundant code and use local variables
to make it clear that the variable is not used afterwards.

The same check has already been done a few lines above.

The ChangeLog was obsolete and since it's use has been replaced
by git log, an empty ChangeLog file is kept to satisfy autools.

Refactor device_proxy_new_cb()

Otherwise unhost_path will lazy-create a new SoupServer

This fixes the issue of wrongly ignoring new services.

Each service keeps a pointer to its node in the device description doc so
we could easily end-up service accessing an invalid node pointer in
situations where the service in question is not unrefed BEFORE the dispose
of the associated device is run.

This was the cause of rygel crashing if you hit CTRL^C at its initialization.

Check that a GUPnPServiceProxyAction is used with the
GUPnPServiceProxy object that it was created for.

The code that sorts the Accept-Language header by quality leaked
languages under certain circumstances and was overly complex.
Replace it by a simpler implementation that sorts the returned
list instead of trying to sort the string array in place.

This reverts commit 9da38618.

This is no longer needed as the bug in DLNA CTT has been fixed and
hopefully be available in the next release. The issue turned out to that
CTT *was* replying to all the HTTP requests but in one of them, it didn't
set any headers at all and libsoup was still expecting more data on the
socket and hence didn't close the socket since from its POV the socket was
still active.