Commit 423e5e89 authored by Jens Georg's avatar Jens Georg
Browse files

Deprecate {begin,send}_action_hash

They cannot guarantee the order of arguments which breaks interaction with
DLNA-complient devices.

The use of end_action_hash is fine, though. It can be paired with all of the
begin_action_* functions.

https://bugzilla.gnome.org/show_bug.cgi?id=710491
parent 98dedfec
......@@ -631,7 +631,13 @@ out:
* See gupnp_service_proxy_send_action(); this version takes a pair of
* #GHashTable<!-- -->s for runtime determined parameter lists.
*
* Do not use this function in newly written code; it cannot guarantee the
* order of arguments and thus breaks interaction with many devices.
*
* Return value: %TRUE if sending the action was succesful.
*
* Deprecated: 0.20.9: Use gupnp_service_proxy_send_action() or
* gupnp_service_proxy_send_action_list()
**/
gboolean
gupnp_service_proxy_send_action_hash (GUPnPServiceProxy *proxy,
......@@ -1103,9 +1109,16 @@ gupnp_service_proxy_begin_action_list
* See gupnp_service_proxy_begin_action(); this version takes a #GHashTable
* for runtime generated parameter lists.
*
* Do not use this function in newly written code; it cannot guarantee the
* order of arguments and thus breaks interaction with many devices.
*
* Return value: (transfer none): A #GUPnPServiceProxyAction handle. This will
* be freed when calling gupnp_service_proxy_cancel_action() or
* gupnp_service_proxy_end_action_hash().
*
* Deprecated: 0.20.9: Use gupnp_service_proxy_send_action() or
* gupnp_service_proxy_send_action_list()
*
**/
GUPnPServiceProxyAction *
gupnp_service_proxy_begin_action_hash
......
......@@ -136,7 +136,7 @@ gupnp_service_proxy_send_action_hash
const char *action,
GError **error,
GHashTable *in_hash,
GHashTable *out_hash);
GHashTable *out_hash) G_GNUC_DEPRECATED;
gboolean
......@@ -180,7 +180,7 @@ gupnp_service_proxy_begin_action_hash
const char *action,
GUPnPServiceProxyActionCallback callback,
gpointer user_data,
GHashTable *hash);
GHashTable *hash) G_GNUC_DEPRECATED;
gboolean
gupnp_service_proxy_end_action (GUPnPServiceProxy *proxy,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment