• commit-queue@webkit.org's avatar
    [CSS Regions] Fix positioning composited layers when the region has overflow:hidden · 4affaa08
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=124042
    
    Patch by Mihai Maerean <mmaerean@adobe.com> on 2014-01-23
    Reviewed by Mihnea Ovidenie.
    
    Source/WebCore:
    
    If there's a clipping GraphicsLayer on the hierarchy, substract its offset, since it's its
    parent that positions us.
    
    Tests: compositing/regions/position-layer-inside-region-overflow-hidden.html
           compositing/regions/position-layer-inside-overflow-hidden.html
           compositing/regions/position-layers-inside-region-overflow-hidden.html
           compositing/regions/position-layers-inside-regions-overflow-hidden.html
    
    * rendering/RenderLayerBacking.cpp:
    (WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread): The position
    must also be correct when the region has box-shadow that inflates the region's layer. The
    composited layers from the flow thread should be rendered in the same position whether the
    associated region has clipping or not.
    Using the position of the clipping layer instead of the location of the clipbox makes it
    also work with box-shadow that inflates the region's graphics layer.
    
    LayoutTests:
    
    * compositing/regions/position-layer-inside-region-overflow-hidden.html: Added.
    * compositing/regions/position-layer-inside-region-overflow-hidden-expected.html: Added.
    * compositing/regions/position-layer-inside-overflow-hidden.html: Added.
    * compositing/regions/position-layer-inside-overflow-hidden-expected.html: Added.
    * compositing/regions/position-layers-inside-region-overflow-hidden.html: Added.
    * compositing/regions/position-layers-inside-region-overflow-hidden-expected.html: Added.
    * compositing/regions/position-layers-inside-regions-overflow-hidden.html: Added.
    * compositing/regions/position-layers-inside-regions-overflow-hidden-expected.html: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    4affaa08
Name
Last commit
Last update
..
animation Loading commit data...
backface-visibility Loading commit data...
background-color Loading commit data...
backgrounds Loading commit data...
backing Loading commit data...
color-matching Loading commit data...
columns Loading commit data...
contents-opaque Loading commit data...
contents-scale Loading commit data...
culling Loading commit data...
filters Loading commit data...
framesets Loading commit data...
geometry Loading commit data...
iframes Loading commit data...
images Loading commit data...
layer-creation Loading commit data...
masks Loading commit data...
objects Loading commit data...
overflow Loading commit data...
overlap-blending Loading commit data...
patterns Loading commit data...
plugins Loading commit data...
reflections Loading commit data...
regions Loading commit data...
repaint Loading commit data...
resources Loading commit data...
rtl Loading commit data...
scaling Loading commit data...
shadows Loading commit data...
tiling Loading commit data...
transitions Loading commit data...
video Loading commit data...
visibility Loading commit data...
visible-rect Loading commit data...
webgl Loading commit data...
z-order Loading commit data...
absolute-inside-out-of-view-fixed-expected.txt Loading commit data...
absolute-inside-out-of-view-fixed.html Loading commit data...
absolute-position-changed-in-composited-layer-expected.png Loading commit data...
absolute-position-changed-in-composited-layer-expected.txt Loading commit data...
absolute-position-changed-in-composited-layer.html Loading commit data...
absolute-position-changed-with-composited-parent-layer-expected.png Loading commit data...
absolute-position-changed-with-composited-parent-layer-expected.txt Loading commit data...
absolute-position-changed-with-composited-parent-layer.html Loading commit data...
bounds-in-flipped-writing-mode-expected.txt Loading commit data...
bounds-in-flipped-writing-mode.html Loading commit data...
checkerboard-expected.png Loading commit data...
checkerboard-expected.txt Loading commit data...
checkerboard.html Loading commit data...
clip-change-expected.png Loading commit data...
clip-change-expected.txt Loading commit data...
clip-change.html Loading commit data...
clip-child-by-non-stacking-ancestor-expected.txt Loading commit data...
clip-child-by-non-stacking-ancestor.html Loading commit data...
composited-negative-zindex-child-expected.txt Loading commit data...
composited-negative-zindex-child.html Loading commit data...
compositing-visible-descendant.html Loading commit data...
direct-image-compositing.html Loading commit data...
document-background-color-expected.html Loading commit data...
document-background-color.html Loading commit data...
fixed-position-changed-in-composited-layer-expected.png Loading commit data...
fixed-position-changed-in-composited-layer-expected.txt Loading commit data...
fixed-position-changed-in-composited-layer.html Loading commit data...
fixed-position-changed-within-composited-parent-layer-expected.png Loading commit data...
fixed-position-changed-within-composited-parent-layer-expected.txt Loading commit data...
fixed-position-changed-within-composited-parent-layer.html Loading commit data...
fixed-position-scroll-offset-history-restore-expected.txt Loading commit data...
fixed-position-scroll-offset-history-restore.html Loading commit data...
flat-with-transformed-child-expected.txt Loading commit data...
flat-with-transformed-child.html Loading commit data...
generated-content.html Loading commit data...
layers-inside-overflow-scroll.html Loading commit data...
nested-direct-image-compositing-expected.png Loading commit data...
nested-direct-image-compositing-expected.txt Loading commit data...
nested-direct-image-compositing.html Loading commit data...
overflow-trumps-transform-style-expected.txt Loading commit data...
overflow-trumps-transform-style.html Loading commit data...
preserve-3d-toggle-expected.png Loading commit data...
preserve-3d-toggle-expected.txt Loading commit data...
preserve-3d-toggle.html Loading commit data...
scroll-painted-composited-content-expected.txt Loading commit data...
scroll-painted-composited-content.html Loading commit data...
scrollbar-painting-expected.png Loading commit data...
scrollbar-painting-expected.txt Loading commit data...
scrollbar-painting.html Loading commit data...
self-painting-layers.html Loading commit data...
self-painting-layers2-expected.txt Loading commit data...
self-painting-layers2.html Loading commit data...
sibling-positioning.html Loading commit data...
sub-layer-focus-ring-expected.html Loading commit data...
sub-layer-focus-ring.html Loading commit data...
text-on-large-layer.html Loading commit data...
text-on-scaled-layer-expected.html Loading commit data...
text-on-scaled-layer.html Loading commit data...
text-on-scaled-surface-expected.html Loading commit data...
text-on-scaled-surface.html Loading commit data...
tile-cache-must-flatten-expected.html Loading commit data...
tile-cache-must-flatten.html Loading commit data...
tiled-layers-hidpi-expected.txt Loading commit data...
tiled-layers-hidpi.html Loading commit data...
toggle-compositing-expected.txt Loading commit data...
toggle-compositing.html Loading commit data...
video-page-visibility-expected.png Loading commit data...
video-page-visibility-expected.txt Loading commit data...
video-page-visibility.html Loading commit data...