1. 13 Jan, 2014 1 commit
  2. 05 Dec, 2012 1 commit
    • commit-queue@webkit.org's avatar
      [CMake] Unify coding style for CMake files · d6fb2c5a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103605
      
      Patch by Halton Huo <halton.huo@intel.com> on 2012-12-05
      Reviewed by Laszlo Gombos.
      
      Update cmake files(.cmake, CMakeLists.txt) with following style rules:
      1. Indentation
      1.1 Use spaces, not tabs.
      1.2 Four spaces as indent.
      2. Spacing
      2.1 Place one space between control statements and their parentheses.
          For eg, if (), else (), elseif (), endif (), foreach (),
          endforeach (), while (), endwhile (), break ().
      2.2 Do not place spaces between function and macro statements and
          their parentheses. For eg, macro(), endmacro(), function(),
          endfunction().
      2.3 Do not place spaces between a command or function or macro and its
          parentheses, or between a parenthesis and its content. For eg,
          message("testing") not message( "testing") or message ("testing" )
      2.4 No space at line ending.
      3. Lowercase when call commands macros and functions. For eg,
         add_executable() not ADD_EXECUTABLE(), set() not SET().
      
      .:
      
      * CMakeLists.txt:
      * Source/CMakeLists.txt:
      * Source/PlatformEfl.cmake:
      * Source/cmake/EFLHelpers.cmake:
      * Source/cmake/FindATK.cmake:
      * Source/cmake/FindCFLite.cmake:
      * Source/cmake/FindCairo.cmake:
      * Source/cmake/FindDBus.cmake:
      * Source/cmake/FindDirectX.cmake:
      * Source/cmake/FindE_DBus.cmake:
      * Source/cmake/FindEcore.cmake:
      * Source/cmake/FindEdje.cmake:
      * Source/cmake/FindEet.cmake:
      * Source/cmake/FindEeze.cmake:
      * Source/cmake/FindEfreet.cmake:
      * Source/cmake/FindEina.cmake:
      * Source/cmake/FindElementary.cmake:
      * Source/cmake/FindEnchant.cmake:
      * Source/cmake/FindEvas.cmake:
      * Source/cmake/FindFontconfig.cmake:
      * Source/cmake/FindGLIB.cmake:
      * Source/cmake/FindGStreamer.cmake:
      * Source/cmake/FindGperf.cmake:
      * Source/cmake/FindHarfBuzz.cmake:
      * Source/cmake/FindICU.cmake:
      * Source/cmake/FindLibSoup.cmake:
      * Source/cmake/FindQuickTimeSDK.cmake:
      * Source/cmake/FindSqlite.cmake:
      * Source/cmake/OptionsBlackBerry.cmake:
      * Source/cmake/OptionsCommon.cmake:
      * Source/cmake/OptionsEfl.cmake:
      * Source/cmake/OptionsWinCE.cmake:
      * Source/cmake/OptionsWindows.cmake:
      * Source/cmake/WebKitFS.cmake:
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmake/WebKitHelpers.cmake:
      * Source/cmake/WebKitMacros.cmake:
      * Source/cmake/WebKitPackaging.cmake:
      * Source/cmake/gtest/CMakeLists.txt:
      
      Source/JavaScriptCore:
      
      * CMakeLists.txt:
      * PlatformBlackBerry.cmake:
      * PlatformEfl.cmake:
      * PlatformWinCE.cmake:
      * shell/CMakeLists.txt:
      * shell/PlatformBlackBerry.cmake:
      * shell/PlatformEfl.cmake:
      * shell/PlatformWinCE.cmake:
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * PlatformBlackBerry.cmake:
      * PlatformEfl.cmake:
      * PlatformWinCE.cmake:
      * UseJSC.cmake:
      * UseV8.cmake:
      
      Source/WebKit:
      
      * CMakeLists.txt:
      * PlatformBlackBerry.cmake:
      * PlatformEfl.cmake:
      * PlatformWinCE.cmake:
      
      Source/WebKit/efl:
      
      * DefaultTheme/CMakeLists.txt:
      
      Source/WebKit2:
      
      * CMakeLists.txt:
      * PlatformEfl.cmake:
      * win/WebKit2ExportGenerator.vcproj:
      * win/WebKit2ExportGeneratorCommon.vsprops:
      
      Source/WTF:
      
      * CMakeLists.txt:
      * wtf/CMakeLists.txt:
      * wtf/PlatformBlackBerry.cmake:
      * wtf/PlatformEfl.cmake:
      * wtf/PlatformWinCE.cmake:
      
      Tools:
      
      * CMakeLists.txt:
      * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
      * DumpRenderTree/efl/CMakeLists.txt:
      * EWebLauncher/CMakeLists.txt:
      * EWebLauncher/ControlTheme/CMakeLists.txt:
      * MiniBrowser/efl/CMakeLists.txt:
      * TestWebKitAPI/CMakeLists.txt:
      * TestWebKitAPI/PlatformEfl.cmake:
      * WebKitTestRunner/CMakeLists.txt:
      * WebKitTestRunner/PlatformEfl.cmake:
      * WinCELauncher/CMakeLists.txt:
      * clang/ReportMemoryUsagePlugin/CMakeLists.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6fb2c5a
  3. 17 Oct, 2012 1 commit
    • commit-queue@webkit.org's avatar
      .: [WK2][EFL] Implementation of spellchecking feature. · 22975d0d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=91854
      
      Patch by Grzegorz Czajkowski  <g.czajkowski@samsung.com>, Michal Roj <m.roj@sasmung.com> on 2012-10-17
      Reviewed by Gyuyoung Kim.
      
      Define SPELLCHECK macro and enable it for WK2-Efl.
      The spellchecking implementation is based on the Enchant library.
      It can be used by other WebKit ports.
      
      * Source/cmake/FindEnchant.cmake: Added.
      * Source/cmake/OptionsEfl.cmake: Enable spellchecking feature for WebKit2-EFL.
      * Source/cmake/WebKitFeatures.cmake: Define the SPELLCHECK macro.
      * Source/cmakeconfig.h.cmake: Add the feature.
      
      Source/WebCore: [WK2][EFL] Implementation of spellchecking feature.
      https://bugs.webkit.org/show_bug.cgi?id=91854
      
      Patch by Grzegorz Czajkowski  <g.czajkowski@samsung.com>, Michal Roj <m.roj@samsung.com> on 2012-10-17
      Reviewed by Gyuyoung Kim.
      
      * PlatformEfl.cmake:
      Add enchant-related compiler flags: header paths and the library flag.
      
      Source/WebKit2: Implementation of spellchecking feature.
      https://bugs.webkit.org/show_bug.cgi?id=91854
      
      Patch by Grzegorz Czajkowski  <g.czajkowski@samsung.com>, Michal Roj <m.roj@samsung.com> on 2012-10-17
      Reviewed by Gyuyoung Kim.
      
      Add spelling implementation for WebKit2-EFL that is based on Enchant library.
      
      Additionally the patch provides API to overwrite the default WebKit
      spellchecker implementation as Enchant library doesn't ensure grammar checking.
      Application is able to overwrite it by defining its own implementation and
      setting appropriate callback functions.
      
      * PlatformEfl.cmake:
      Add enchant-related compiler flags: header paths and the library flag.
      
      * UIProcess/API/efl/EWebKit2.h:
      Add ewk_text_checker.h to the main WebKit2-EFL's header to be available for applications.
      
      * UIProcess/API/efl/WebKitTextChecker.cpp: Added.
      Implement the callbacks functions of WKTextChecker.
      
      (WebKit):
      (WebKit::isContinuousSpellCheckingEnabled):
      (WebKit::setContinuousSpellCheckingEnabled):
      (WebKit::uniqueSpellDocumentTag):
      (WebKit::closeSpellDocumentWithTag):
      (WebKit::checkSpellingOfString):
      (WebKit::guessesForWord):
      (WebKit::learnWord):
      (WebKit::ignoreWord):
      Those functions are directly given as callback functions for WKTextChecker's client.
      They choose between WebKit's spelling implementation and client's ones.
      
      (WebKit::availableSpellCheckingLanguages):
      (WebKit::updateSpellCheckingLanguages):
      (WebKit::loadedSpellCheckingLanguages):
      They are used by ewk_settings.cpp file and allow to do not
      expose 'textCheckerEnchant'.
      
      * UIProcess/API/efl/WebKitTextChecker.h: Added.
      Define the functions which choose between WebKit's spelling implementation and
      the client's ones.
      
      (WebKit):
      * UIProcess/API/efl/ewk_context.cpp:
      (_Ewk_Context::_Ewk_Context):
      Attach the spellchecker feature for the context.
      
      * UIProcess/API/efl/ewk_text_checker.cpp: Added.
      (ewk_text_checker_callbacks_get):
      An internal function to get the client's callback functions.
      
      * UIProcess/API/efl/ewk_text_checker.h: Added.
      Define API to set the client's own spelling implementation.
      
      * UIProcess/API/efl/ewk_text_checker_private.h: Added.
      (_Ewk_Text_Checker):
      Define the struct with the client's callbacks responisble for spelling.
      
      * UIProcess/API/efl/ewk_settings.cpp:
      (onContinuousSpellCheckingIdler):
      The application is notified about the spelling setting change on idler
      to do not block WebKit.
      The the continuous spell checking may be changed through the context menu option.
      
      (spellCheckingLanguagesSetUpdate):
      The dictionaries are requested on 'idler' to do not block WebKit.
      
      (spellCheckingLanguagesSet):
      Set the languages.
      
      (ewk_settings_continuous_spell_checking_change_cb_set):
      Set the callback function used to notify the client when the spelling
      setting was changed by WebKit.
      
      (ewk_settings_continuous_spell_checking_enabled_get):
      (ewk_settings_continuous_spell_checking_enabled_set):
      API to set/get the continuous spell checking.
      
      (ewk_settings_spell_checking_available_languages_get):
      (ewk_settings_spell_checking_languages_set):
      (ewk_settings_spell_checking_languages_get):
      API to get/set languages to use by WebKit implementation based on Enchant library.
      
      * UIProcess/efl/TextCheckerEfl.cpp:
      (WebKit::TextChecker::state):
      (WebKit::TextChecker::isContinuousSpellCheckingAllowed):
      (WebKit::TextChecker::setContinuousSpellCheckingEnabled):
      (WebKit::TextChecker::setGrammarCheckingEnabled):
      (WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
      (WebKit::TextChecker::grammarCheckingEnabledStateChanged):
      (WebKit::TextChecker::uniqueSpellDocumentTag):
      (WebKit::TextChecker::closeSpellDocumentWithTag):
      (WebKit::TextChecker::checkSpellingOfString):
      (WebKit::TextChecker::checkGrammarOfString): Remove WebCore namaspace as it's already defined for the whole file.
      (WebKit::TextChecker::spellingUIIsShowing):
      (WebKit::TextChecker::toggleSpellingUIIsShowing):
      (WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
      (WebKit::TextChecker::updateSpellingUIWithGrammarString):
      (WebKit::TextChecker::getGuessesForWord):
      (WebKit::TextChecker::learnWord):
      (WebKit::TextChecker::ignoreWord):
      Those call WKTextChecker client's methods.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@131579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22975d0d