1. 20 Jan, 2014 2 commits
    • timothy@apple.com's avatar
      Add the recording button back to the Timelines sidebar. · 8bc799e8
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127314
      
      Reviewed by Joseph Pecoraro.
      
      * Localizations/en.lproj/localizedStrings.js: Updated.
      
      * UserInterface/TimelineContentView.js:
      (WebInspector.TimelineContentView.prototype.get navigationItems):
      (WebInspector.TimelineContentView.prototype._update):
      (WebInspector.TimelineContentView.prototype._updateTimes):
      (WebInspector.TimelineContentView.prototype._startUpdatingCurrentTime):
      (WebInspector.TimelineContentView.prototype._recordingTimesUpdated):
      (WebInspector.TimelineContentView.prototype._clearTimeline):
      (WebInspector.TimelineContentView.prototype._recordingReset):
      Add a clear button and reset the time ruler and views when the recording resets.
      
      * UserInterface/TimelineSidebarPanel.css:
      (.sidebar > .panel.timeline > .status-bar):
      (.sidebar > .panel.timeline > .status-bar > .record-glyph):
      (.sidebar > .panel.timeline > .status-bar > .record-glyph.recording):
      (.sidebar > .panel.timeline > .status-bar > .record-glyph:hover):
      (.sidebar > .panel.timeline > .status-bar > .record-glyph.recording:hover):
      (.sidebar > .panel.timeline > .status-bar > .record-glyph.forced):
      (.sidebar > .panel.timeline > .status-bar > .record-glyph.recording.forced):
      (.sidebar > .panel.timeline > .status-bar > .record-status):
      Add styles for the recording button and status message.
      
      * UserInterface/TimelineSidebarPanel.js:
      (WebInspector.TimelineSidebarPanel.prototype._contentBrowserCurrentContentViewDidChange):
      (WebInspector.TimelineSidebarPanel.prototype._recordingStarted):
      (WebInspector.TimelineSidebarPanel.prototype._recordingStopped):
      (WebInspector.TimelineSidebarPanel.prototype._recordGlyphMousedOver):
      (WebInspector.TimelineSidebarPanel.prototype._recordGlyphMousedOut):
      (WebInspector.TimelineSidebarPanel.prototype._recordGlyphClicked):
      Add support for the recording button and status message.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8bc799e8
    • timothy@apple.com's avatar
      Make the TimelineRecordTreeElement location subtitle live. · 2733f18a
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127270
      
      Reviewed by Joseph Pecoraro.
      
      * Localizations/en.lproj/localizedStrings.js: Updated.
      
      * UserInterface/SourceCodeLocation.js:
      (WebInspector.SourceCodeLocation.prototype.originalLocationString):
      (WebInspector.SourceCodeLocation.prototype.formattedLocationString):
      (WebInspector.SourceCodeLocation.prototype.displayLocationString):
      (WebInspector.SourceCodeLocation.prototype.updateDisplayString):
      (WebInspector.SourceCodeLocation.prototype._locationString):
      Support for a new nameStyle enum and a prefix for the location string.
      Passing the prefix here lets it be italicized with the line number.
      Support column number for SourceCode's without a URL too.
      
      * UserInterface/TimelineRecordTreeElement.js:
      (WebInspector.TimelineRecordTreeElement):
      (WebInspector.TimelineRecordTreeElement.prototype.onattach):
      Create a subtitle span to update the location inside. Update the tooltip on attach.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2733f18a
  2. 16 Jan, 2014 1 commit
  3. 15 Jan, 2014 1 commit
    • akling@apple.com's avatar
      Remove the CSS selector profiler. · 6f601c10
      akling@apple.com authored
      <https://webkit.org/b/127039>
      
      Source/WebCore:
      
      The selector profiler was painting a mostly fictional picture of what
      selectors we were spending time on. It never really grokked the fast
      path selectors, nor did it understand recent additions like the extra
      cascading pass or the selector JIT.
      
      Somewhat ironically, this may end up making some selectors run faster
      since it removes a number of brances in hot code.
      
      Reviewed by Sam Weinig.
      
      * css/ElementRuleCollector.cpp:
      (WebCore::ElementRuleCollector::collectMatchingRulesForList):
      * css/ElementRuleCollector.h:
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorCSSAgent.h:
      * inspector/InspectorInstrumentation.cpp:
      * inspector/InspectorInstrumentation.h:
      * inspector/protocol/CSS.json:
      
      Source/WebInspectorUI:
      
      Purge selector profiler code from the new Web Inspector UI.
      
      Reviewed by Sam Weinig.
      
      * Localizations/en.lproj/localizedStrings.js:
      * UserInterface/CSSSelectorProfileObject.js: Removed.
      * UserInterface/CSSSelectorProfileType.js: Removed.
      * UserInterface/CSSSelectorProfileView.js: Removed.
      * UserInterface/ContentView.js:
      (WebInspector.ContentView):
      (WebInspector.ContentView.isViewable):
      * UserInterface/InspectorWebBackendCommands.js:
      * UserInterface/InstrumentSidebarPanel.js:
      (WebInspector.InstrumentSidebarPanel):
      (WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedOver):
      (WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedDown):
      (WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphClicked):
      (WebInspector.InstrumentSidebarPanel.prototype._profileTypeWasSelected):
      (WebInspector.InstrumentSidebarPanel.prototype._profilesCleared):
      * UserInterface/Main.html:
      * UserInterface/ProfileManager.js:
      (WebInspector.ProfileManager):
      (WebInspector.ProfileManager.prototype.initialize):
      (WebInspector.ProfileManager.prototype._checkForInterruptions):
      (WebInspector.ProfileManager.prototype._attemptToResumeProfiling):
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f601c10
  4. 10 Jan, 2014 1 commit
  5. 05 Dec, 2013 1 commit
    • achicu@adobe.com's avatar
      Web Inspector: [CSS Regions] Show a list of containing regions when clicking a... · 0e035b16
      achicu@adobe.com authored
      Web Inspector: [CSS Regions] Show a list of containing regions when clicking a node that is part of a flow
      https://bugs.webkit.org/show_bug.cgi?id=124614
      
      Reviewed by Timothy Hatcher.
      
      Source/WebInspectorUI:
      
      Added a new function in DOMTreeManager called getNodeContentFlowInfo that can be used
      to retrieve an object with the following structure:
      {
           "regionFlow": <Reference to the ContentFlow object referenced by the -webkit-flow-from property of the node>,
           "contentFlow": <Reference to the ContentFlow object referenced by the -webkit-flow-into property of
                           the node or a parent of the node>,
           "regions": [ list of DOMNodes representing the regions containers of the node. The node is split across all these regions. ]
      }
      
      Also, used this method to display a two new sections in the Computed Styles panel.
      1. Section "Flows": can have up to two Simple Rows: "Region Flow" and "Content Flow".
      2. Section "Container Regions" contains a DOMTreeDataGrid with the list of regions.
      
      The sections are only visible when there's content to display.
      
      Next to the "Region Flow" simple row I've added an arrow that will take the user to the "ContentFlowDOMTreeContentView" of the
      ContentFlow. The same happens for the "Content Flow", but in this case the element will also be highlighted.
      
      Part of the patch I've added the DOMTreeDataGridNode. LayerTreeDataGrid has a lot of CSS in common with it, so I
      will make another patch to refactor LayerTreeDataGrid to use DOMTreeDataGridNode as a base class.
      
      * Localizations/en.lproj/localizedStrings.js:
      * UserInterface/ComputedStyleDetailsPanel.css: Added.
      (.details-section > .content > .group > .row.simple.content-flow-link > .label):
      (.details-section > .content > .group > .row.simple.content-flow-link > .value):
      (.details-section > .content > .group > .row.simple.content-flow-link > .value > div):
      (.details-section > .content > .group > .row.simple.content-flow-link > .value > div > .icon):
      (.details-section > .content > .group > .row.simple.content-flow-link > .value > div > span):
      (.details-section > .content > .group > .row.simple.content-flow-link > .value > div > .go-to-arrow):
      (.details-section > .content > .group > .row.simple.content-flow-link:hover > .value > div > .go-to-arrow):
      * UserInterface/ComputedStyleDetailsPanel.js:
      (WebInspector.ComputedStyleDetailsPanel):
      (WebInspector.ComputedStyleDetailsPanel.prototype.get regionFlow):
      (WebInspector.ComputedStyleDetailsPanel.prototype.set regionFlow):
      (WebInspector.ComputedStyleDetailsPanel.prototype.get contentFlow):
      (WebInspector.ComputedStyleDetailsPanel.prototype.set contentFlow):
      (WebInspector.ComputedStyleDetailsPanel.prototype.get containerRegions):
      (WebInspector.ComputedStyleDetailsPanel.prototype.set containerRegions):
      (WebInspector.ComputedStyleDetailsPanel.prototype.refresh):
      (WebInspector.ComputedStyleDetailsPanel.prototype._computedStyleShowAllCheckboxValueChanged):
      (WebInspector.ComputedStyleDetailsPanel.prototype._resetFlowDetails):
      (WebInspector.ComputedStyleDetailsPanel.prototype._refreshFlowDetails.contentFlowInfoReady):
      (WebInspector.ComputedStyleDetailsPanel.prototype._refreshFlowDetails):
      (WebInspector.ComputedStyleDetailsPanel.prototype._goToRegionFlowArrowWasClicked):
      (WebInspector.ComputedStyleDetailsPanel.prototype._goToContentFlowArrowWasClicked):
      * UserInterface/DOMTreeDataGrid.css: Added.
      (.dom-tree-data-grid .data-grid):
      (.dom-tree-data-grid .data-grid table.data):
      (.dom-tree-data-grid .data-container):
      (.dom-tree-data-grid .data-container tr):
      (.dom-tree-data-grid .data-container td > div):
      (.dom-tree-data-grid .data-container .name-column):
      (.dom-tree-data-grid .data-container .name-column .icon):
      (.dom-tree-data-grid .data-container .name-column .label):
      (.dom-tree-data-grid .data-container tr:hover .name-column .label):
      (.dom-tree-data-grid .data-container .go-to-arrow):
      (.dom-tree-data-grid .data-container tr:hover .go-to-arrow):
      (.dom-tree-data-grid .data-container tbody > tr:nth-child(2n)):
      (.dom-tree-data-grid .data-container tbody > tr:nth-child(2n+1)):
      * UserInterface/DOMTreeDataGrid.js: Added.
      (WebInspector.DOMTreeDataGrid):
      (WebInspector.DOMTreeDataGrid.prototype._onmousemove):
      (WebInspector.DOMTreeDataGrid.prototype._onmouseout):
      * UserInterface/DOMTreeDataGridNode.js: Added.
      (WebInspector.DOMTreeDataGridNode):
      (WebInspector.DOMTreeDataGridNode.prototype.get domNode):
      (WebInspector.DOMTreeDataGridNode.prototype.createCellContent):
      (WebInspector.DOMTreeDataGridNode.prototype._updateNodeName):
      (WebInspector.DOMTreeDataGridNode.prototype._makeNameCell):
      (WebInspector.DOMTreeDataGridNode.prototype._updateNameCellData):
      (WebInspector.DOMTreeDataGridNode.prototype._goToArrowWasClicked):
      * UserInterface/DOMTreeManager.js:
      (WebInspector.DOMTreeManager.prototype.unregisteredNamedFlowContentElement):
      (WebInspector.DOMTreeManager.prototype.nodeRequested):
      (WebInspector.DOMTreeManager.prototype._coerceRemoteArrayOfDOMNodes):
      (WebInspector.DOMTreeManager.prototype.domNodeResolved):
      (WebInspector.DOMTreeManager.prototype.regionNodesAvailable):
      (WebInspector.DOMTreeManager.prototype.get if):
      (WebInspector.DOMTreeManager.prototype.get var):
      (WebInspector.DOMTreeManager.prototype.backendFunction.getComputedProperty):
      (WebInspector.DOMTreeManager.prototype.backendFunction.getContentFlowName):
      (WebInspector.DOMTreeManager.prototype.):
      * UserInterface/DataGrid.css:
      (.data-grid.no-header > table.header):
      (.data-grid.no-header .data-container):
      * UserInterface/DetailsSection.js:
      (WebInspector.DetailsSection):
      * UserInterface/InspectorBackend.js:
      (InspectorBackendClass.prototype._wrap):
      * UserInterface/Main.html:
      * UserInterface/ResourceSidebarPanel.js:
      (WebInspector.ResourceSidebarPanel.prototype.showContentFlowDOMTree):
      * UserInterface/RuntimeManager.js:
      (WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow):
      (WebInspector.RuntimeManager.prototype.getPropertiesForRemoteObject):
      
      LayoutTests:
      
      Added a new test to check the new WebInspector function called DOMTreeManager.getNodeContentFlowInfo.
      
      * http/tests/inspector-protocol/resources/InspectorTest.js:
      When testing the inspector code, we want to catch and log any uncaught exceptions or console.errors/asserts.
      (InspectorTest.importInspectorScripts.console.error.window.onerror):
      (InspectorTest.importInspectorScripts.console.assert):
      (InspectorTest.importInspectorScripts):
      * inspector-protocol/model/content-node-region-info-expected.txt: Added.
      * inspector-protocol/model/content-node-region-info.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e035b16
  6. 18 Nov, 2013 1 commit
  7. 25 Oct, 2013 1 commit
  8. 18 Oct, 2013 1 commit
    • achicu@adobe.com's avatar
      Web Inspector: CSS Regions: Add the list of flows in the FrameTreeElement · 3fb6c1d9
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122924
      
      Reviewed by Timothy Hatcher.
      
      Added code to collect the flows from the backend into the DOMTree object
      on the frontend. Added ContentFlow to represent the flows on the frontend
      side and created ContentFlowTreeElement to display the flows in the FrameTreeElement.
      
      * Localizations/en.lproj/localizedStrings.js:
      * Scripts/copy-user-interface-resources.sh:
      * UserInterface/CSSObserver.js:
      (WebInspector.CSSObserver.prototype.namedFlowCreated):
      (WebInspector.CSSObserver.prototype.namedFlowRemoved):
      (WebInspector.CSSObserver.prototype.regionLayoutUpdated):
      (WebInspector.CSSObserver.prototype.regionOversetChanged):
      * UserInterface/ContentFlow.js: Added.
      (WebInspector.ContentFlow):
      (WebInspector.ContentFlow.prototype.get id):
      (WebInspector.ContentFlow.prototype.get documentNodeIdentifier):
      (WebInspector.ContentFlow.prototype.get name):
      (WebInspector.ContentFlow.prototype.get overset):
      (WebInspector.ContentFlow.prototype.set overset):
      * UserInterface/ContentFlowIcon.css: Added.
      (.content-flow-icon .icon):
      * UserInterface/ContentFlowTreeElement.js: Added.
      (WebInspector.ContentFlowTreeElement):
      * UserInterface/DOMTree.js:
      (WebInspector.DOMTree):
      (WebInspector.DOMTree.prototype.get flowMap):
      (WebInspector.DOMTree.prototype.get flowsCount):
      (WebInspector.DOMTree.prototype._framePageExecutionContextChanged):
      (WebInspector.DOMTree.prototype.requestContentFlowList):
      (WebInspector.DOMTree.prototype._isContentFlowInCurrentDocument):
      (WebInspector.DOMTree.prototype._contentFlowListWasUpdated):
      (WebInspector.DOMTree.prototype._contentFlowWasAdded):
      (WebInspector.DOMTree.prototype._contentFlowWasRemoved):
      * UserInterface/DOMTreeManager.js:
      (WebInspector.DOMTreeManager):
      (WebInspector.DOMTreeManager._flowPayloadHashKey):
      (WebInspector.DOMTreeManager.prototype._buildHighlightConfig):
      (WebInspector.DOMTreeManager.prototype._createContentFlowFromPayload):
      (WebInspector.DOMTreeManager.prototype._updateContentFlowFromPayload):
      (WebInspector.DOMTreeManager.prototype.getNamedFlowCollection):
      (WebInspector.DOMTreeManager.prototype.namedFlowCreated):
      (WebInspector.DOMTreeManager.prototype.namedFlowRemoved):
      (WebInspector.DOMTreeManager.prototype._sendNamedFlowUpdateEvents):
      (WebInspector.DOMTreeManager.prototype.regionLayoutUpdated):
      (WebInspector.DOMTreeManager.prototype.regionOversetChanged):
      * UserInterface/FrameTreeElement.js:
      (WebInspector.FrameTreeElement):
      (WebInspector.FrameTreeElement.prototype.onpopulate):
      (WebInspector.FrameTreeElement.prototype.onexpand):
      (WebInspector.FrameTreeElement.prototype._childContentFlowWasAdded):
      (WebInspector.FrameTreeElement.prototype._childContentFlowWasRemoved):
      (WebInspector.FrameTreeElement.prototype._rootDOMNodeInvalidated):
      (WebInspector.FrameTreeElement.prototype._addChildForRepresentedObject):
      (WebInspector.FrameTreeElement.prototype._removeChildForRepresentedObject):
      (WebInspector.FrameTreeElement.prototype._addTreeElementForRepresentedObject):
      (WebInspector.FrameTreeElement.prototype._compareResourceTreeElements):
      (WebInspector.FrameTreeElement.prototype._insertResourceTreeElement):
      (WebInspector.FrameTreeElement.prototype._parentTreeElementForRepresentedObject):
      (WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders):
      * UserInterface/Images/ContentFlow.svg: Added.
      * UserInterface/Main.html:
      * UserInterface/ResourceSidebarPanel.js:
      (WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fb6c1d9
  9. 17 Oct, 2013 1 commit
    • graouts@apple.com's avatar
      Web Inspector: Go to line keyboard command and dialog · c0736bac
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122893
      
      Reviewed by Timothy Hatcher.
      
      Add a text input over source code text editors, centered within the width of the editor
      and towards the top of the editor, upon pressing Command+L or Control+G to match the
      behavior in Chrome.
      
      * Localizations/en.lproj/localizedStrings.js:
      New localized string "Line Number".
      
      * UserInterface/GoToLineDialog.css: Added.
      Styling for the go-to-line dialog.
      
      * UserInterface/GoToLineDialog.js: Added.
      (WebInspector.GoToLineDialog):
      Generate the DOM structure for the dialog.
      
      (WebInspector.GoToLineDialog.prototype.present):
      Present the dialog as a child of a parent element. The dialog's text field automatically
      gets focus and resets to be empty.
      
      (WebInspector.GoToLineDialog.prototype.dismiss):
      Dismiss the dialog if visible, this triggers the goToLineDialogWasDismissed delegate method.
      
      (WebInspector.GoToLineDialog.prototype.handleEvent):
      Route the various events registered in the dialog's DOM tree: input, keydown, blur, mousedown
      and click.
      
      (WebInspector.GoToLineDialog.prototype._handleInputEvent):
      Update the "non-empty" class on the dialog's element depending on the content of the dialog's
      text field. If there is content in the text field, this will make the clear icon visible.
      
      (WebInspector.GoToLineDialog.prototype._handleKeydownEvent):
      If the Esc. key is pressed when there is text in the dialog's input field, clear the input field.
      If no text is in the input field, dismiss the input field. When the Enter key is pressed, we call
      the isGoToLineDialogValueValid() method on the delegate to figure out if the text field value is
      valid. If it's not, we select the text field value so that it may be easily replaced and play
      en error sound. If it's valid, we call the goToLineDialogValueWasValidated() delegate method
      and dismiss the dialog.
      
      (WebInspector.GoToLineDialog.prototype._handleBlurEvent):
      Dismiss the dialog when its text field loses focus. This ensures that clicking anywhere outside
      of the dialog removes it from display.
      
      (WebInspector.GoToLineDialog.prototype._handleMousedownEvent):
      Upon pressing the mouse down on the clear icon, select the entire text field content (matches
      the behavior of Xcode) and prevent the default event action that would blur the text field
      which would dismiss the dialog.
      
      (WebInspector.GoToLineDialog.prototype._handleClickEvent):
      Clear the content of the dialog's text field upon clicking on its clear button.
      
      (WebInspector.GoToLineDialog.prototype._clear):
      Reset the dialog's text field's value to an empty string and remove the "non-empty" CSS class name
      controlling the display of the clear button.
      
      * UserInterface/Images/CloseWhite.svg: Added.
      Variation of the Close.svg icon with a white cross.
      
      * UserInterface/Main.html:
      Link to the newly added resources for GoToLineDialog.
      
      * UserInterface/SourceCodeTextEditor.js:
      (WebInspector.SourceCodeTextEditor):
      Register the Command+L and Control+G keyboard shortcuts to bring up the go-to-line dialog.
      
      (WebInspector.SourceCodeTextEditor.prototype.showGoToLineDialog):
      Method called upon pressing the Command+L and Control+G keyboard shorcuts creating an instance
      of a GoToDialog if necessary, becoming its delegate and presenting it in the context of the
      editor's root element.
      
      (WebInspector.SourceCodeTextEditor.prototype.isGoToLineDialogValueValid):
      Delegate method called to validate the line number presently set in the go-to-dialog's text field,
      checking it's a number between 1 and the number of lines in the source code.
      
      (WebInspector.SourceCodeTextEditor.prototype.goToLineDialogValueWasValidated):
      Delegate method called when the line number set in the go-to-dialog's text field has been validated.
      We reveal and select the line at the number provided.
      
      (WebInspector.SourceCodeTextEditor.prototype.goToLineDialogWasDismissed):
      Ensure the source code editor regains focus upon dismissing the go-to-dialog.
      
      * UserInterface/TextEditor.js:
      (WebInspector.TextEditor.prototype.revealPosition):
      Add a new opt-in option to not highlight the revealed position. The code in goToLineDialogValueWasValidated()
      sets that new flag to true to avoid an unnecessary highlight on top of the selection.
      
      (WebInspector.TextEditor.prototype.get lineCount):
      Expose the lineCount() method on the private CodeMirror instance.
      
      (WebInspector.TextEditor.prototype.focus):
      Expose the focus() method on the private CodeMirror instance.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0736bac
  10. 05 Sep, 2013 1 commit
    • joepeck@webkit.org's avatar
      Web Inspector: Breakpoint Actions · 8dbc7b8e
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120576
      
      Reviewed by Timothy Hatcher.
      
      * UserInterface/Breakpoint.js:
      (WebInspector.Breakpoint):
      (WebInspector.Breakpoint.prototype.get actions):
      (WebInspector.Breakpoint.prototype.get options):
      (WebInspector.Breakpoint.prototype.get info):
      (WebInspector.Breakpoint.prototype._serializableActions):
      Saving, restoring, and serialization.
      
      (WebInspector.Breakpoint.prototype.createAction):
      (WebInspector.Breakpoint.prototype.recreateAction):
      (WebInspector.Breakpoint.prototype.removeAction):
      (WebInspector.Breakpoint.prototype.breakpointActionDidChange):
      Modifying _actions ivar.
      
      (WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement):
      (WebInspector.Breakpoint.prototype._popoverActionsCreateAddActionButton):
      (WebInspector.Breakpoint.prototype._popoverActionsAddActionButtonClicked):
      (WebInspector.Breakpoint.prototype._popoverActionsInsertBreakpointActionView):
      (WebInspector.Breakpoint.prototype.breakpointActionViewAppendActionView):
      (WebInspector.Breakpoint.prototype.breakpointActionViewRemoveActionView):
      (WebInspector.Breakpoint.prototype.breakpointActionViewResized):
      Popover UI containing breakpoint action views and converting to and from
      having no actions.
      
      (WebInspector.Breakpoint.prototype.willDismissPopover):
      Cleanup some ivars when the popover dismisses.
      
      * UserInterface/Breakpoint.css:
      (.popover .edit-breakpoint-popover-content.wide):
      Wider setting when there are actions in the popover.
      
      (.popover .edit-breakpoint-popover-content > table > tr > th):
      Keep the title labels at the top of their section.
      
      * UserInterface/BreakpointAction.js:
      (WebInspector.BreakpointAction):
      (WebInspector.BreakpointAction.prototype.get breakpoint):
      (WebInspector.BreakpointAction.prototype.get type):
      (WebInspector.BreakpointAction.prototype.get data):
      (WebInspector.BreakpointAction.prototype.set data):
      (WebInspector.BreakpointAction.prototype.get info):
      Very basic BreakpointAction class. Notifies Breakpoint on data changes.
      Type changes are not allowed, instead just create a new BreakpointAction.
      
      * UserInterface/BreakpointActionView.css: Added.
      (.breakpoint-action-block-header):
      (.breakpoint-action-remove-button):
      (.breakpoint-action-remove-button:active):
      (.breakpoint-action-append-button):
      (.breakpoint-action-block-body):
      (.breakpoint-action-block-body > input):
      (.breakpoint-action-eval-editor):
      (.breakpoint-action-eval-editor > .CodeMirror):
      (.breakpoint-action-eval-editor > .CodeMirror-scroll):
      * UserInterface/BreakpointActionView.js: Added.
      (WebInspector.BreakpointActionView):
      (WebInspector.BreakpointActionView.displayStringForType):
      (WebInspector.BreakpointActionView.prototype.get action):
      (WebInspector.BreakpointActionView.prototype.get element):
      (WebInspector.BreakpointActionView.prototype._pickerChanged):
      (WebInspector.BreakpointActionView.prototype._appendActionButtonClicked):
      (WebInspector.BreakpointActionView.prototype._removeActionButtonClicked):
      (WebInspector.BreakpointActionView.prototype._updateBody.switch.break):
      (WebInspector.BreakpointActionView.prototype._logInputChanged):
      (WebInspector.BreakpointActionView.prototype._codeMirrorBlurred):
      (WebInspector.BreakpointActionView.prototype._codeMirrorViewportChanged):
      UI and form controls for individual breakpoint actions. The view
      wraps a single BreakpointAction, and for any actions that could affect
      other views the delegate is notified.
      
      * UserInterface/DebuggerManager.js:
      (WebInspector.DebuggerManager):
      (WebInspector.DebuggerManager.prototype._debuggerBreakpointActionType):
      When sending to the backend, make sure to send protocol enums.
      
      * UserInterface/Popover.js:
      (WebInspector.Popover.prototype.update):
      Update the popover when content changes.
      
      * UserInterface/Images/BreakpointActionAdd.svg: Added.
      * UserInterface/Images/BreakpointActionRemove.svg: Added.
      * UserInterface/InspectorBackendCommands.js:
      * UserInterface/Main.html:
      * Localizations/en.lproj/localizedStrings.js:
      Misc. New strings, images, includes.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8dbc7b8e
  11. 30 Aug, 2013 1 commit
    • joepeck@webkit.org's avatar
      Web Inspector: Breakpoints should have Automatically Continue Option · d8be1361
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120187
      
      Reviewed by Timothy Hatcher.
      
      Source/WebCore:
      
      Tests: inspector-protocol/debugger/removeBreakpoint.html
             inspector-protocol/debugger/setBreakpoint-autoContinue.html
             inspector-protocol/debugger/setBreakpoint-column.html
             inspector-protocol/debugger/setBreakpoint-condition.html
             inspector-protocol/debugger/setBreakpoint.html
      
      * inspector/Inspector.json:
      Convert the "condition" argument of setBreakpoint and setBreakpointByUrl
      to a BreakpointOptions object with optional properties. One of which
      is "condition" and a new option "autoContinue".
      
      * bindings/js/ScriptDebugServer.h:
      * bindings/js/ScriptDebugServer.cpp:
      (WebCore::ScriptDebugServer::hasBreakpoint):
      (WebCore::ScriptDebugServer::pauseIfNeeded):
      Automatically continue if the breakpoint was hit and has autoContinue.
      
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::buildObjectForBreakpointCookie):
      (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
      (WebCore::InspectorDebuggerAgent::setBreakpoint):
      (WebCore::InspectorDebuggerAgent::continueToLocation):
      (WebCore::InspectorDebuggerAgent::didParseSource):
      * inspector/ScriptBreakpoint.h:
      (WebCore::ScriptBreakpoint::ScriptBreakpoint):
      Handle the new incoming BreakpointOptions type, and set the
      autoContinue state on ScriptBreakpoints.
      
      * inspector/front-end/DebuggerModel.js:
      (WebInspector.DebuggerModel.prototype.setBreakpointByURL):
      (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
      Update old front-end to be compatible with the new API.
      
      Source/WebInspectorUI:
      
      * Localizations/en.lproj/localizedStrings.js:
      * UserInterface/Breakpoint.css:
      (#edit-breakpoint-popoover-auto-continue):
      Misc. changes for UI.
      
      * UserInterface/Breakpoint.js:
      (WebInspector.Breakpoint):
      (WebInspector.Breakpoint.prototype.get autoContinue):
      (WebInspector.Breakpoint.prototype.set autoContinue):
      (WebInspector.Breakpoint.prototype.get options):
      (WebInspector.Breakpoint.prototype.get info):
      General maintenance of the autoContinue state.
      
      (WebInspector.Breakpoint.prototype._popoverToggleEnabledCheckboxChanged):
      (WebInspector.Breakpoint.prototype._popoverToggleAutoContinueCheckboxChanged):
      (WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement):
      Edit Breakpoint UI for setting autoContinue state.
      
      * UserInterface/InspectorBackend.js:
      (InspectorBackendClass.prototype.registerCommand):
      (InspectorBackendClass.prototype._supports):
      Extension to check if a BackendCommands method supports a particular param.
      
      * UserInterface/DebuggerManager.js:
      (WebInspector.DebuggerManager):
      (WebInspector.DebuggerManager.prototype._setBreakpoint):
      * UserInterface/InspectorBackendCommands.js:
      Change to backend agent calls for the new protocol API.
      
      LayoutTests:
      
      * http/tests/inspector-protocol/resources/InspectorTest.js:
      (InspectorTest.checkForError):
      Helper for checking for, and logging, protocol error responses.
      
      * inspector/debugger/set-breakpoint.html:
      Update this test for the protocol change.
      
      * inspector-protocol/debugger/removeBreakpoint-expected.txt: Added.
      * inspector-protocol/debugger/removeBreakpoint.html: Added.
      * inspector-protocol/debugger/resources/breakpoint.js: Added.
      * inspector-protocol/debugger/setBreakpoint-autoContinue-expected.txt: Added.
      * inspector-protocol/debugger/setBreakpoint-autoContinue.html: Added.
      * inspector-protocol/debugger/setBreakpoint-column.html: Renamed from LayoutTests/inspector-protocol/debugger/column-breakpoint.html.
      * inspector-protocol/debugger/setBreakpoint-column.txt: Renamed from LayoutTests/inspector-protocol/debugger/column-breakpoint-expected.txt.
      * inspector-protocol/debugger/setBreakpoint-condition-expected.txt: Added.
      * inspector-protocol/debugger/setBreakpoint-condition.html: Added.
      * inspector-protocol/debugger/setBreakpoint-expected.txt: Added.
      * inspector-protocol/debugger/setBreakpoint.html: Added.
      Protocol tests for setting breakpoints. These test different aspects of
      the Debugger domain (setBreakpoint variants and removeBreakpoint).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8be1361
  12. 29 Aug, 2013 1 commit
    • joepeck@webkit.org's avatar
      Web Inspector: Download Web Archive of Inspected Page · e061c7f1
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119774
      
      Reviewed by Timothy Hatcher.
      
      Source/WebCore:
      
      Add PageAgent.archive which will return a Base-64 encoded web archive
      when successful. In order to then allow saving non-string files, extend
      InspectorFrontendHost.save to allow for Base-64 encoded data.
      
      * inspector/Inspector.json:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::archive):
      * inspector/InspectorPageAgent.h:
      Introduce and implement PageAgent.archive. Create a Web Archive of the
      page's main frame.
      
      * inspector/InspectorFrontendClient.h:
      * inspector/InspectorFrontendClientLocal.h:
      (WebCore::InspectorFrontendClientLocal::save):
      * inspector/InspectorFrontendHost.cpp:
      (WebCore::InspectorFrontendHost::save):
      * inspector/InspectorFrontendHost.h:
      * inspector/InspectorFrontendHost.idl:
      Extend InspectorFrontendHost.save to include a base64Encoded param.
      
      * inspector/front-end/FileManager.js:
      * inspector/front-end/InspectorFrontendHostStub.js:
      (.WebInspector.InspectorFrontendHostStub.prototype.save):
      Misc. updates to the old inspector for function changes.
      
      Source/WebInspectorUI:
      
      * UserInterface/ContentBrowser.js:
      (WebInspector.ContentBrowser.prototype._saveDataToFile):
      Allow a custom save handler which will do all the work.
      
      * UserInterface/DOMTreeContentView.js:
      (WebInspector.DOMTreeContentView):
      (WebInspector.DOMTreeContentView.prototype.get supportsSave):
      (WebInspector.DOMTreeContentView.prototype.get saveData.saveHandler):
      (WebInspector.DOMTreeContentView.prototype.get saveData):
      Allow Save keyboard shortcut to download an archive viewing the DOM Tree.
      
      * UserInterface/ResourceTreeElement.js:
      (WebInspector.ResourceTreeElement.prototype._updateStatus):
      * UserInterface/FrameTreeElement.js:
      (WebInspector.FrameTreeElement):
      (WebInspector.FrameTreeElement.prototype.updateStatusForMainFrame):
      (WebInspector.FrameTreeElement.prototype._mainResourceDidChange):
      (WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders):
      (WebInspector.FrameTreeElement.prototype._reloadPageClicked):
      (WebInspector.FrameTreeElement.prototype._downloadButtonClicked):
      (WebInspector.FrameTreeElement.prototype._updateDownloadButton):
      (WebInspector.FrameTreeElement.prototype._pageArchiveStarted):
      (WebInspector.FrameTreeElement.prototype._pageArchiveEnded):
      Move handling of main frame TreeElement buttons to FrameTreeElement.
      Add a Download button, and enable/disable it appropriately.
      
      * UserInterface/ResourceTreeElement.css:
      * UserInterface/TreeElementStatusButton.css: Copied from Source/WebInspectorUI/UserInterface/ResourceTreeElement.css.
      (.item > .status > .status-button):
      (.item > .status > .status-button > svg *):
      (.item.selected > .status > .status-button > svg *):
      (.item.selected > .status > .status-button:active > svg *):
      (.item > .status > .status-button.disabled > svg *):
      (.item.selected > .status > .status-button.disabled > svg *):
      * UserInterface/TreeElementStatusButton.js: Added.
      (WebInspector.TreeElementStatusButton):
      (WebInspector.TreeElementStatusButton.prototype.get element):
      (WebInspector.TreeElementStatusButton.prototype.get hidden):
      (WebInspector.TreeElementStatusButton.prototype.set hidden):
      (WebInspector.TreeElementStatusButton.prototype.get enabled):
      (WebInspector.TreeElementStatusButton.prototype.set enabled):
      (WebInspector.TreeElementStatusButton.prototype._clicked):
      Make buttons in the TreeElement status a generic class to share styling
      and handling of the buttons. New "disabled" state with even more
      transparent is used when the page is downloading.
      
      * UserInterface/Main.html:
      * UserInterface/Main.js:
      (WebInspector.archiveMainFrame):
      (WebInspector.canArchiveMainFrame):
      Generic API for archiving the page and determining if you can archive it.
      
      * UserInterface/InspectorBackendCommands.js:
      * UserInterface/InspectorFrontendHostStub.js:
      (.WebInspector.InspectorFrontendHostStub.prototype.save):
      * UserInterface/Images/DownloadArrow.svg: Added.
      * Localizations/en.lproj/localizedStrings.js:
      Misc. updates and new files.
      
      Source/WebKit/mac:
      
      Update to support InspectorFrontendHost.save's new base64Encoded
      parameter. It means the incoming content is binary data, not a string.
      
      * WebCoreSupport/WebInspectorClient.h:
      * WebCoreSupport/WebInspectorClient.mm:
      (WebInspectorFrontendClient::save):
      
      Source/WebKit2:
      
      Update to support InspectorFrontendHost.save's new base64Encoded
      parameter. It means the incoming content is binary data, not a string.
      
      * UIProcess/WebInspectorProxy.cpp:
      (WebKit::WebInspectorProxy::save):
      * UIProcess/WebInspectorProxy.h:
      * UIProcess/WebInspectorProxy.messages.in:
      * UIProcess/efl/WebInspectorProxyEfl.cpp:
      (WebKit::WebInspectorProxy::platformSave):
      * UIProcess/gtk/WebInspectorProxyGtk.cpp:
      (WebKit::WebInspectorProxy::platformSave):
      * UIProcess/mac/WebInspectorProxyMac.mm:
      (WebKit::WebInspectorProxy::platformSave):
      * UIProcess/qt/WebInspectorProxyQt.cpp:
      (WebKit::WebInspectorProxy::platformSave):
      * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
      (WebKit::WebInspectorFrontendClient::save):
      * WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
      * WebProcess/WebPage/WebInspector.cpp:
      (WebKit::WebInspector::save):
      * WebProcess/WebPage/WebInspector.h:
      
      LayoutTests:
      
      * inspector-protocol/page/archive-expected.txt: Added.
      * inspector-protocol/page/archive.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e061c7f1
  13. 27 Aug, 2013 1 commit
  14. 24 Aug, 2013 1 commit
    • joepeck@webkit.org's avatar
      Web Inspector: Breakpoints in the editors gutter should have a contextmenu · 7a1aa530
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120169
      
      Reviewed by Timothy Hatcher.
      
      Updated CodeMirror now has a gutterContextMenu event. Use that to give
      breakpoint related context menus. Add, Edit, Enable/Disable, Delete, and
      Reveal in Debugger Navigation Sidebar.
      
      * Localizations/en.lproj/localizedStrings.js:
      "Add Breakpoint", and "Reveal in Debugger Navigation Sidebar".
      
      * UserInterface/SourceCodeTextEditor.js:
      (WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu.addBreakpoint):
      (WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu.revealInSidebar):
      (WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu.removeBreakpoints):
      (WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu.toggleBreakpoints):
      (WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu):
      Show a context menu when clicking on the gutter for 0 breakpoints,
      1 breakpoint, or >1 breakpoints. The only tricky handler is addBreakpoint,
      since that must update the TextEditor for the new breakpoint info.
      
      * UserInterface/TextEditor.js:
      (WebInspector.TextEditor):
      (WebInspector.TextEditor.prototype._gutterContextMenu):
      Send to delegate if the delegate implements textEditorGutterContextMenu.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a1aa530
  15. 19 Aug, 2013 1 commit
  16. 11 Aug, 2013 2 commits
    • dino@apple.com's avatar
      Update localizedStrings - I think I checked in an unmerged version · b6b472c0
      dino@apple.com authored
      in the previous commit.
      
      * Localizations/en.lproj/localizedStrings.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6b472c0
    • dino@apple.com's avatar
      Bootstrap canvas profiler · 31858a66
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119652
      <rdar://problem/14703665>
      
      Reviewed by Joseph Pecoraro.
      
      Add enough to get an empty Canvas profile recording
      and displayed.
      
      * Localizations/en.lproj/localizedStrings.js: Add canvas strings.
      * UserInterface/CanvasProfileObject.js: Added. Mostly copied from CSS Selector Profiles.
      * UserInterface/CanvasProfileType.js: Added. Ditto.
      * UserInterface/CanvasDataGridNode.js: Added. Ditto.
      * UserInterface/CanvasProfileView.js: Added. Ditto.
      * UserInterface/ContentView.js:
      (WebInspector.ContentView): Add support for the new View type.
      (WebInspector.ContentView.isViewable):
      * UserInterface/InstrumentSidebarPanel.js:
      (WebInspector.InstrumentSidebarPanel): Add support for canvas profiles.
      (WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedOver):
      (WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedDown):
      (WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphClicked):
      (WebInspector.InstrumentSidebarPanel.prototype._profileTypeWasSelected):
      (WebInspector.InstrumentSidebarPanel.prototype._profilesCleared):
      * UserInterface/Main.html: Load the new files.
      * UserInterface/ProfileManager.js: New methods and support for canvas profiles.
      (WebInspector.ProfileManager):
      (WebInspector.ProfileManager.prototype.initialize):
      (WebInspector.ProfileManager.prototype.isProfilingCanvas):
      (WebInspector.ProfileManager.prototype.startProfilingCanvas):
      (WebInspector.ProfileManager.prototype.stopProfilingCanvas):
      (WebInspector.ProfileManager.prototype._checkForInterruptions):
      (WebInspector.ProfileManager.prototype._attemptToResumeProfiling):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31858a66
  17. 22 Jul, 2013 1 commit
  18. 03 Jul, 2013 1 commit
  19. 27 Jun, 2013 3 commits
    • commit-queue@webkit.org's avatar
      Web Inspector: AX: Add container ARIA roles (toolbar, main, labeled regions, etc.) · 90228e84
      commit-queue@webkit.org authored
      so the layout is more discoverable to screen reader users
      https://bugs.webkit.org/show_bug.cgi?id=118104
      
      Patch by James Craig <james@cookiecrook.com> on 2013-06-27
      Reviewed by Timothy Hatcher.
      
      Made the basic layout (toolbar, sidebars, main) of the Web Inspector understandable
      and navigable with VoiceOver.
      
      * Localizations/en.lproj/localizedStrings.js:
      * UserInterface/ButtonNavigationItem.js:
      * UserInterface/CSSStyleDetailsSidebarPanel.js:
      * UserInterface/DashboardManager.js:
      * UserInterface/Main.js:
      * UserInterface/NavigationBar.js:
      * UserInterface/NavigationItem.js:
      * UserInterface/NavigationSidebarPanel.js:
      * UserInterface/RadioButtonNavigationItem.js:
      * UserInterface/Sidebar.js:
      * UserInterface/SidebarPanel.js:
      * UserInterface/Toolbar.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90228e84
    • commit-queue@webkit.org's avatar
      Web Inspector: AX: Console log of the Inspector does not announce output for screen readers · 55b45d3f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115976
      
      Patch by James Craig <james@cookiecrook.com> on 2013-06-27
      Reviewed by Timothy Hatcher.
      
      Main console log area (div.console-messages) is now an ARIA live region (role="log")
      so screen readers speak plain text updates.
      
      Also added contextual labels (e.g. input/output) but speech output verification of
      those is currently blocked by http://webkit.org/b/118096
      
      * Localizations/en.lproj/localizedStrings.js:
      * UserInterface/ConsoleCommand.js:
      (WebInspector.ConsoleCommand.prototype.toMessageElement):
      * UserInterface/ConsoleCommandResult.js:
      (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
      * UserInterface/LogContentView.css:
      (@media reader):
      * UserInterface/LogContentView.js:
      (WebInspector.LogContentView):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55b45d3f
    • commit-queue@webkit.org's avatar
      Web Inspector: Display color picker in popover on color swatch click · 9848b0bb
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117919
      
      Patch by Matthew Holden <jftholden@yahoo.com> on 2013-06-27
      Reviewed by Timothy Hatcher.
      
      Includes fixes from second code review.
      
      * Localizations/en.lproj/localizedStrings.js:
      * UserInterface/CSSColorPicker.css: Added.
      (.colorpicker-container):
      (.colorpicker-fill-parent):
      (.colorpicker-top):
      (.colorpicker-color):
      (.colorpicker-bottom span):
      (.colorpicker-text):
      (.colorpicker-color-text-value):
      (.colorpicker-hue):
      (.colorpicker-fill):
      (.colorpicker-range-container):
      (.colorpicker-range-container *):
      (.colorpicker-range-container label):
      (.colorpicker-range-container input):
      (.colorpicker-saturation):
      (.colorpicker-value):
      (.colorpicker-dragger):
      (.colorpicker-slider):
      (.colorpicker-container .swatch):
      (.colorpicker-container .swatch-inner):
      * UserInterface/CSSColorPicker.js: Added.
      (WebInspector.CSSColorPicker.consume):
      (WebInspector.CSSColorPicker.move):
      (WebInspector.CSSColorPicker.start):
      (WebInspector.CSSColorPicker.stop):
      (WebInspector.CSSColorPicker.makeDraggable):
      (WebInspector.CSSColorPicker.hueDrag):
      (WebInspector.CSSColorPicker.colorDragStart):
      (WebInspector.CSSColorPicker.colorDrag):
      (WebInspector.CSSColorPicker.alphaDrag):
      (WebInspector.CSSColorPicker.colorSwatchClicked):
      (WebInspector.CSSColorPicker):
      (WebInspector.CSSColorPicker.prototype.get element):
      (WebInspector.CSSColorPicker.prototype.set color):
      (WebInspector.CSSColorPicker.prototype.get color):
      (WebInspector.CSSColorPicker.prototype.get outputColorFormat):
      (WebInspector.CSSColorPicker.prototype.get colorHueOnly):
      (WebInspector.CSSColorPicker.prototype.set displayText):
      (WebInspector.CSSColorPicker.prototype.shown):
      (WebInspector.CSSColorPicker.prototype._updateHelperLocations):
      (WebInspector.CSSColorPicker.prototype._updateDisplay):
      (WebInspector.CSSColorPicker.hsvaToRGBA):
      (WebInspector.CSSColorPicker.rgbaToHSVA):
      * UserInterface/CSSStyleDeclarationTextEditor.js:
      (WebInspector.CSSStyleDeclarationTextEditor.prototype.didDismissPopover):
      (WebInspector.CSSStyleDeclarationTextEditor.prototype.):
      (WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
      (WebInspector.CSSStyleDeclarationTextEditor.prototype.event.newColorText.colorTextMarker):
      (WebInspector.CSSStyleDeclarationTextEditor.prototype.event.newColorText):
      * UserInterface/Main.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9848b0bb
  20. 18 Jun, 2013 1 commit
    • timothy@apple.com's avatar
      Update breakpoints to match Xcode 5. · cc1b87a5
      timothy@apple.com authored
      This updates the breakpoint images, line colors, and moves breakpoints toggle button
      to the Debugger sidebar navigation bar.
      
      https://bugs.webkit.org/show_bug.cgi?id=117723
      
      Reviewed by Joseph Pecoraro.
      
      * Localizations/en.lproj/localizedStrings.js: Updated.
      * UserInterface/DebuggerSidebarPanel.css: Removed custom toggle button rules.
      * UserInterface/DebuggerSidebarPanel.js:
      (WebInspector.DebuggerSidebarPanel):
      (WebInspector.DebuggerSidebarPanel.prototype._breakpointsToggleButtonClicked):
      * UserInterface/Images/Breakpoint.png: Updated.
      * UserInterface/Images/Breakpoints.pdf: Added.
      * UserInterface/Images/Breakpoint@2x.png: Updated.
      * UserInterface/Images/BreakpointButton.pdf: Updated.
      * UserInterface/Images/BreakpointInactive.png: Updated.
      * UserInterface/Images/BreakpointInactive@2x.png: Updated.
      * UserInterface/Images/BreakpointInactiveButton.pdf: Updated.
      * UserInterface/Images/InstructionPointer.png: Updated.
      * UserInterface/Images/InstructionPointer@2x.png: Updated.
      * UserInterface/SourceCodeTextEditor.css:
      (.source-code.text-editor > .CodeMirror .error): Updated background-color and removed box-shadow.
      (.source-code.text-editor > .CodeMirror .warning): Ditto.
      * UserInterface/TextEditor.css:
      (.text-editor > .CodeMirror .has-breakpoint .CodeMirror-linenumber::before): Changed left position to 0.
      (.text-editor > .CodeMirror .execution-line .CodeMirror-linenumber::after): Updated position.
      (.text-editor > .CodeMirror .execution-line): Updated background-color and removed box-shadow.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc1b87a5
  21. 11 Jun, 2013 1 commit