GitLab

Use testRunner instead of layoutTestController in networkinformation, perf, plugins, pointer-lock, printing, scrollbars, and security tests
https://bugs.webkit.org/show_bug.cgi?id=89181

Reviewed by Kent Tamura.

* perf/clone-with-focus.html:
* perf/nested-combined-selectors.html:
* perf/table-rows-length-caching.html:
* platform/chromium/plugins/call-as-function.html:
* platform/chromium/plugins/get-url-with-blank-target2.html:
* platform/chromium/plugins/get-url-with-iframe-target-no-crash.html:
* platform/chromium/printing/custom-page-size-style-expected.txt:
* platform/chromium/printing/custom-page-size-style.html:
* platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html:
* platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html:
* platform/mac-wk2/plugins/contents-scale-factor.html:
* platform/mac-wk2/plugins/mouse-events-scaled.html:
* platform/mac/plugins/bindings-array-apply-crash.html:
* platform/mac/plugins/bindings-objc-long-method-name.html:
* platform/mac/plugins/bindings-objc-method-name-conversion.html:
* platform/mac/plugins/bindings-test-objc.html:
* platform/mac/plugins/call-as-function-test.html:
* platform/mac/plugins/convert-point.html:
* platform/mac/plugins/disable-plugins.html:
* platform/mac/plugins/jsobjc-dom-wrappers.html:
* platform/mac/plugins/jsobjc-simple.html:
* platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html-disabled:
* platform/mac/plugins/root-object-premature-delete-crash.html:
* platform/mac/plugins/supports-carbon-event-model.html:
* platform/mac/plugins/testplugin-onnew-onpaint.html:
* platform/mac/plugins/throw-on-dealloc.html:
* platform/mac/plugins/undefined-property-crash.html:
* platform/mac/plugins/update-widget-from-style-recalc.html:
* platform/mac/plugins/webScriptObject-exception-deadlock.html:
* platform/mac/scrollbars/key-window-not-first-responder.html:
* platform/qt/plugins/application-plugin-plugins-disabled.html:
* platform/win/plugins/call-javascript-that-destroys-plugin.html:
* platform/win/plugins/get-value-netscape-window.html:
* platform/win/plugins/iframe-inside-overflow.html:
* platform/win/plugins/npn-invalidate-rect-invalidates-window.html:
* platform/win/plugins/visibility-hidden.html:
* platform/win/plugins/window-geometry-initialized-before-set-window.html:
* platform/win/plugins/window-region-is-set-to-clip-rect.html:
* platform/win/plugins/windowless-paint-rect-coordinates.html:
* plugins/:
* pointer-lock/lock-fail-responses-expected.txt:
* pointer-lock/lock-fail-responses.html:
* pointer-lock/pointer-lock-api.html:
* pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
* pointer-lock/pointerlockchange-pointerlockerror-events.html:
* pointer-lock/pointerlocklost-event-expected.txt:
* pointer-lock/pointerlocklost-event.html:
* printing/compositing-layer-printing.html:
* printing/css2.1/README.txt:
* printing/css2.1/page-break-after-000.html:
* printing/css2.1/page-break-after-001.html:
* printing/css2.1/page-break-after-002.html:
* printing/css2.1/page-break-after-003.html:
* printing/css2.1/page-break-after-004.html:
* printing/css2.1/page-break-before-000.html:
* printing/css2.1/page-break-before-001.html:
* printing/css2.1/page-break-before-002.html:
* printing/css2.1/page-break-inside-000.html:
* printing/iframe-print.html:
* printing/media-queries-print.html:
* printing/numberOfPages-expected.txt:
* printing/page-count-layout-overflow.html:
* printing/page-count-relayout-shrink.html:
* printing/page-count-with-one-word.html:
* printing/page-format-data-display-none.html:
* printing/page-format-data-expected.txt:
* printing/page-format-data.html:
* printing/page-rule-css-text.html:
* printing/page-rule-in-media-query.html:
* printing/page-rule-selection-expected.txt:
* printing/page-rule-selection.html:
* printing/pageNumerForElementById-expected.txt:
* printing/print-close-crash.html:
* printing/pseudo-class-outside-page.html:
* printing/resources/paged-media-test-utils.js:
(pageNumberForElementShouldBe):
(numberOfPagesShouldBe):
(runPrintingTest):
* printing/return-from-printing-mode.html:
* printing/script-tests/numberOfPages.js:
* printing/script-tests/pageNumerForElementById.js:
* printing/setPrinting.html:
* printing/simultaneous-position-float-change.html:
* printing/single-line-must-not-be-split-into-two-pages.html:
* printing/width-overflow.html:
* printing/zoomed-document.html:
* scrollbars/hidden-iframe-scrollbar-crash.html:
* scrollbars/hidden-iframe-scrollbar-crash2.html:
* scrollbars/hidden-scrollbar-prevents-layout.html:
* scrollbars/overflow-custom-scrollbar-crash.html:
* scrollbars/resources/hidden-iframe-scrollbar-crash2.html:
* scrollbars/scroll-rtl-or-bt-layer.html:
* scrollbars/scrollable-iframe-remove-crash.html:
* scrollbars/scrollbar-click-does-not-blur-content.html:
* scrollbars/scrollbar-crash-on-refresh.html:
* scrollbars/scrollbar-drag-thumb-with-large-content.html:
* scrollbars/scrollbar-gradient-crash.html:
* scrollbars/scrollbar-iframe-click-does-not-blur-content.html:
* scrollbars/scrollbar-initial-position.html:
* scrollbars/scrollbar-middleclick-nopaste.html:
* scrollbars/scrollbar-miss-mousemove-disabled.html:
* scrollbars/scrollbar-miss-mousemove.html:
* scrollbars/scrollbar-owning-renderer-crash.html:
* scrollbars/scrollbar-part-created-with-no-parent-crash.html:
* scrollbars/scrollbar-percent-padding-crash.html:
* scrollbars/scrollbar-scrollbarparts-repaint-crash.html:
* scrollbars/scrollevent-iframe-no-scrolling-wheel.html:
* scrollbars/scrollevent-iframe-no-scrolling.html:
* security/autocomplete-cleared-on-back.html:
* security/block-test-no-port.html:
* security/block-test.html:
* security/set-form-autocomplete-attribute.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Antonio Gomes.

        https://bugs.webkit.org/show_bug.cgi?id=18768
        Fixed a bug in scroll flow. When we don't have scrollbars, we need to
        repaintFixedElementsAfterScrolling(), sendScrollEvent() ... as well as
        scrollContents();

        * scrollbars/resources/scrollable-iframe.html: Added.
        * scrollbars/scrollevent-iframe-no-scrolling-expected.txt: Added.
        * scrollbars/scrollevent-iframe-no-scrolling-wheel-expected.txt: Added.
        * scrollbars/scrollevent-iframe-no-scrolling-wheel.html: Added.
        * scrollbars/scrollevent-iframe-no-scrolling.html: Added.
2010-09-12  Robin Qiu  <robin.qiu@torchmobile.com.cn>

        Reviewed by Antonio Gomes.

        https://bugs.webkit.org/show_bug.cgi?id=18768
        Fixed a bug in scroll flow. When we don't have scrollbars, we need to
        repaintFixedElementsAfterScrolling(), sendScrollEvent() ... as well as
        scrollContents();

        Tests: scrollbars/scrollevent-iframe-no-scrolling-wheel.html
               scrollbars/scrollevent-iframe-no-scrolling.html

        * page/FrameView.cpp:
        (WebCore::FrameView::valueChanged): Added.
        * page/FrameView.h: Added a new method.
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::valueChanged): Added.
        (WebCore::ScrollView::updateScrollbars):
        * platform/ScrollView.h: Added a new method.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by David Hyatt.

        Fix a crash when a hidden iframe with a custom scrollbar finishes loading an image.
        https://bugs.webkit.org/show_bug.cgi?id=42724

        * scrollbars/hidden-iframe-scrollbar-crash2.html: Added.
        * scrollbars/resources/hidden-iframe-scrollbar-crash2.html: Added.
2010-08-05  Tony Chang  <tony@chromium.org>

        Reviewed by David Hyatt.

        Fix a crash when a hidden iframe with a custom scrollbar finishes loading an image.
        https://bugs.webkit.org/show_bug.cgi?id=42724

        Test: scrollbars/hidden-iframe-scrollbar-crash2.html

        * page/FrameView.cpp:
        (WebCore::FrameView::createScrollbar):
        * rendering/RenderScrollbar.cpp:
        (WebCore::RenderScrollbar::createCustomScrollbar): Pass in Frame
        (WebCore::RenderScrollbar::RenderScrollbar): Pass in Frame
        (WebCore::RenderScrollbar::owningRenderer): Use the frame to get the RenderBox
        (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
        (WebCore::RenderScrollbar::updateScrollbarParts):
        (WebCore::RenderScrollbar::updateScrollbarPart):
        * rendering/RenderScrollbar.h:
        * rendering/RenderScrollbarPart.cpp:
        (WebCore::RenderScrollbarPart::computeScrollbarWidth): null check
        (WebCore::RenderScrollbarPart::computeScrollbarHeight): null check

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Adler.

        Clicking a scrollbar blurs the currently focused element
        https://bugs.webkit.org/show_bug.cgi?id=16809

        WebKit ports that do not use native (platform) widgets for rendering the scrollbars
        are currently mismatching a common behaviour of other browser vendors (including
        Firefox and Opera): clicking on a frame scrollbar *should not* steal focus from content.
        WebKit browsers based ports that do use WebCore for handling scrollbars, like QtWebKit for
        instance, can observe the opposite behaviour.

        Patch fixes this behaviour by checking if current MouseDown event targets a frame scrollbar.
        If that is the case, it bails out and do not change focus behavior at all.

        It is important to note that the given way this is implemented by this patch, non-frame
        scrollbars (e.g. a vertical scrollbar of an overflowed textareas or divs) will keep working
        in the same way as it works currently.

        Tests: scrollbars/scrollbar-click-does-not-blur-content.html
               scrollbars/scrollbar-iframe-click-does-not-blur-content.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::dispatchMouseEve

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-06-22  David Levin  <levin@chromium.org>

        Reviewed by David Hyatt and Eric Seidel.

        REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
        https://bugs.webkit.org/show_bug.cgi?id=26326

        Test: scrollbars/scrollbar-crash-on-refresh.html

        * dom/Document.cpp:
        (WebCore::Document::detach):
        Gives the FrameView a change to do any necessary cleanup on
        Document::detach() which is where the renderArena gets detroyed.
        * page/FrameView.cpp:
        (WebCore::FrameView::detachCustomScrollbars):
        Gets rid of any custom scrollbars (if the docment supplied them).
        * page/FrameView.h:
        * platform/Scrollbar.h:
        (WebCore::Scrollbar::isCustomScrollbar):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::destroy):
        Removed the check for document()->frame().  If frame() is 0 in this code,
        then the call to animation() is also incorrect (since it does document()->frame()->animation()).
        * rendering/RenderScrollbar.h:
        (WebCore::RenderScrollbar::isCustomScrollbar):

LayoutTests:

2009-06-22  David Levin  <levin@chromium.org>

        Reviewed by David Hyatt and Eric Seidel.

        REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
        https://bugs.webkit.org/show_bug.cgi?id=26326

        Test that refreshing an iframe with custom scrollbars works without crashing.

        * scrollbars/resources/page-with-custom-scrollbars.html: Added.
        * scrollbars/scrollbar-crash-on-refresh-expected.txt: Added.
        * scrollbars/scrollbar-crash-on-refresh.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-06-17  David Levin  <levin@chromium.org>

        Reviewed by NOBODY, layout tests fix.

        https://bugs.webkit.org/show_bug.cgi?id=26326
        This reverts commit r44751.

        Once that change was checked scrollbars/scrollbar-orientation.html started
        crashing on Windows.

        * dom/Document.cpp:
        (WebCore::Document::detach):
        * page/FrameView.cpp:
        * page/FrameView.h:
        * platform/Scrollbar.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::destroy):
        * rendering/RenderScrollbar.h:

LayoutTests:

2009-06-17  David Levin  <levin@chromium.org>

        Reviewed by NOBODY, layout tests fix.

        https://bugs.webkit.org/show_bug.cgi?id=26326
        This reverts commit r44751.

        Once that change was checked scrollbars/scrollbar-orientation.html started
        crashing on Windows.

        * scrollbars/resources/page-with-custom-scrollbars.html: Removed.
        * scrollbars/scrollbar-crash-on-refresh-expected.txt: Removed.
        * scrollbars/scrollbar-crash-on-refresh.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-06-16  David Levin  <levin@chromium.org>

        Reviewed by David Hyatt.

        REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
        https://bugs.webkit.org/show_bug.cgi?id=26326

        Test: scrollbars/scrollbar-crash-on-refresh.html

        * dom/Document.cpp:
        (WebCore::Document::detach):
        Gives the FrameView a change to do any necessary cleanup on
        Document::detach() which is where the renderArena gets detroyed.
        * page/FrameView.cpp:
        (WebCore::FrameView::detachCustomScrollbars):
        Gets rid of any custom scrollbars (if the docment supplied them).
        * page/FrameView.h:
        * platform/Scrollbar.h:
        (WebCore::Scrollbar::isCustomScrollbar):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::destroy):
        Removed the check for document()->frame().  If frame() is 0 in this code,
        then the call to animation() is also incorrect (since it does document()->frame()->animation()).
        * rendering/RenderScrollbar.h:
        (WebCore::RenderScrollbar::isCustomScrollbar):

LayoutTests:

2009-06-16  David Levin  <levin@chromium.org>

        Reviewed by David Hyatt.

        REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
        https://bugs.webkit.org/show_bug.cgi?id=26326

        Test that refreshing an iframe with custom scrollbars works without crashing.

        * scrollbars/resources/page-with-custom-scrollbars.html: Added.
        * scrollbars/scrollbar-crash-on-refresh-expected.txt: Added.
        * scrollbars/scrollbar-crash-on-refresh.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Adds an complex styled scrollbar test that exercises all pseudo-elements and pseudo-classes.
        Also uses positive and negative margins on the scrollbar track and track pieces.
        Tests all the combinations of scrollbars for overflow elements, with and without resizers.

        Rubber-stamped by Dave Hyatt.

        * platform/mac/scrollbars/overflow-scrollbar-combinations-expected.checksum: Added.
        * platform/mac/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
        * platform/mac/scrollbars/overflow-scrollbar-combinations-expected.txt: Added.
        * scrollbars/overflow-scrollbar-combinations.html: Added.
        * scrollbars/resources: Added.
        * scrollbars/resources/corner-inactive.png: Added.
        * scrollbars/resources/corner.png: Added.
        * scrollbars/resources/horizontal-button-active.png: Added.
        * scrollbars/resources/horizontal-button-background-active.png: Added.
        * scrollbars/resources/horizontal-button-background-hover.png: Added.
        * scrollbars/resources/horizontal-button-background-inactive.png: Added.
        * scrollbars/resources/horizontal-button-background.png: Added.
        * scrollbars/resources/horizontal-button-hover.png: Added.
        * scrollbars/resources/horizontal-button-inactive.png: Added.
        * scrollbars/resources/horizontal-button.png: Added.
        * scrollbars/resources/horizontal-decrement-arrow.png: Added.
        * scrollbars/resources/horizontal-increment-arrow.png: Added.
        * scrollbars/resources/horizontal-thumb-active.png: Added.
        * scrollbars/resources/horizontal-thumb-hover.png: Added.
        * scrollbars/resources/horizontal-thumb-inactive.png: Added.
        * scrollbars/resources/horizontal-thumb.png: Added.
        * scrollbars/resources/horizontal-track-active.png: Added.
        * scrollbars/resources/horizontal-track-disabled.png: Added.
        * scrollbars/resources/horizontal-track-hover.png: Added.
        * scrollbars/resources/horizontal-track.png: Added.
        * scrollbars/resources/resizer-inactive.png: Added.
        * scrollbars/resources/resizer.png: Added.
        * scrollbars/resources/vertical-button-active.png: Added.
        * scrollbars/resources/vertical-button-background-active.png: Added.
        * scrollbars/resources/vertical-button-background-hover.png: Added.
        * scrollbars/resources/vertical-button-background-inactive.png: Added.
        * scrollbars/resources/vertical-button-background.png: Added.
        * scrollbars/resources/vertical-button-hover.png: Added.
        * scrollbars/resources/vertical-button-inactive.png: Added.
        * scrollbars/resources/vertical-button.png: Added.
        * scrollbars/resources/vertical-decrement-arrow.png: Added.
        * scrollbars/resources/vertical-increment-arrow.png: Added.
        * scrollbars/resources/vertical-thumb-active.png: Added.
        * scrollbars/resources/vertical-thumb-hover.png: Added.
        * scrollbars/resources/vertical-thumb-inactive.png: Added.
        * scrollbars/resources/vertical-thumb.png: Added.
        * scrollbars/resources/vertical-track-active.png: Added.
        * scrollbars/resources/vertical-track-disabled.png: Added.
        * scrollbars/resources/vertical-track-hover.png: Added.
        * scrollbars/resources/vertical-track.png: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37565 268f45cc-cd09-0410-ab3c-d52691b4dbfc