1. 02 Aug, 2012 1 commit
    • scheib@chromium.org's avatar
      Remove old Pointer Lock API. · 03edde3b
      scheib@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88892
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Removing the old Pointer Lock API as one of the final cleanup
      changes for the Update to Fullscreen style locking Spec meta
      bug https://bugs.webkit.org/show_bug.cgi?id=84402.
      
      This change primarily removes idl, access in navigator,
      one event, and supporting infrastructure in page/PointerLock.
      
      In PointerLockController changes were already noted clearly with
      TODOs differentiating old and new api sections.
      
      Test: pointer-lock/pointerlockchange-event-on-lock-lost.html
      
      * WebCore.gypi:
      * dom/Element.cpp:
      (WebCore::Element::webkitRequestPointerLock):
      * dom/EventNames.h:
      (WebCore):
      * page/Navigator.cpp:
      * page/Navigator.h:
      (WebCore):
      (Navigator):
      * page/Navigator.idl:
      * page/PointerLock.cpp: Removed.
      * page/PointerLock.h: Removed.
      * page/PointerLock.idl: Removed.
      * page/PointerLockController.cpp:
      (WebCore::PointerLockController::requestPointerLock):
      (WebCore::PointerLockController::didAcquirePointerLock):
      (WebCore::PointerLockController::didNotAcquirePointerLock):
      (WebCore::PointerLockController::didLosePointerLock):
      * page/PointerLockController.h:
      (PointerLockController):
      
      Source/WebKit/chromium:
      
      * src/WebViewImpl.cpp:
          Removed #include to old API header.
      
      LayoutTests:
      
      Tests for old API removed, and most remaining tests required only small
      changes.
      
      * platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
      * pointer-lock/lock-already-locked-expected.txt:
      * pointer-lock/lock-already-locked.html:
      * pointer-lock/lock-fail-responses-expected.txt: Removed.
      * pointer-lock/lock-fail-responses.html: Removed.
          This test only covered the old API. The related concept is tested
          for the new api in pointerlockchange-pointerlockerror-events.html.
      * pointer-lock/pointer-lock-api-expected.txt:
      * pointer-lock/pointer-lock-api.html:
      * pointer-lock/pointerlockchange-event-on-lock-lost-expected.txt: Added.
      * pointer-lock/pointerlockchange-event-on-lock-lost.html: Added.
      * pointer-lock/pointerlocklost-event-expected.txt: Removed.
      * pointer-lock/pointerlocklost-event.html: Removed.
          pointerlocklost-event.html renamed to pointerlockchange-event-on-lock-lost.html.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03edde3b
  2. 09 Jul, 2012 1 commit
    • scheib@chromium.org's avatar
      Refactor common Pointer Lock test code to a harness. · 3684f627
      scheib@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90813
      
      Reviewed by Adrienne Walker.
      
      * pointer-lock/bug90391-move-then-window-open-crash-expected.txt:
      * pointer-lock/bug90391-move-then-window-open-crash.html:
      * pointer-lock/lock-already-locked-expected.txt:
      * pointer-lock/lock-already-locked.html:
      * pointer-lock/lock-fail-responses-expected.txt:
      * pointer-lock/lock-fail-responses.html:
      * pointer-lock/mouse-event-delivery-expected.txt:
      * pointer-lock/mouse-event-delivery.html:
      * pointer-lock/pointer-lock-api-expected.txt:
      * pointer-lock/pointer-lock-api.html:
      * pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
      * pointer-lock/pointerlockchange-pointerlockerror-events.html:
      * pointer-lock/pointerlocklost-event-expected.txt:
      * pointer-lock/pointerlocklost-event.html:
      * pointer-lock/resources/pointer-lock-test-harness.js: Added.
      (doNextStep.else):
      (doNextStepWithUserGesture):
      (eventExpected.targetHanderNode.eventHandlerName):
      (eventExpected):
      (expectOnlyChangeEvent):
      (expectOnlyErrorEvent):
      (expectNoEvents):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3684f627
  3. 15 Jun, 2012 1 commit
    • scheib@chromium.org's avatar
      Add new Pointer Lock spec webkitRequestPointerLock and webkitExitPointerLock methods. · ebbfecc5
      scheib@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88891
      
      Reviewed by Dimitri Glazkov.
      
      Part of a series of refactoring changes to update pointer lock API to
      the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
      
      Entering and exiting mouse lock is provided in the new webkitRequestPointerLock and
      webkitExitPointerLock methods.
      
      Source/WebCore:
      
      Existing pointer-lock tests updated to use the new methods.
      
      * dom/Document.cpp:
      (WebCore::Document::webkitExitPointerLock):
      (WebCore):
      * dom/Document.h:
      (Document):
      * dom/Document.idl:
      * dom/Element.cpp:
      (WebCore):
      (WebCore::Element::webkitRequestPointerLock):
      * dom/Element.h:
      * dom/Element.idl:
      
      LayoutTests:
      
      Existing tests updated to use the new methods. Also, several updated to
      support manual testing.
      
      * pointer-lock/lock-already-locked-expected.txt:
      * pointer-lock/lock-already-locked.html:
      * pointer-lock/mouse-event-delivery-expected.txt:
      * pointer-lock/mouse-event-delivery.html:
      * pointer-lock/pointer-lock-api-expected.txt:
      * pointer-lock/pointer-lock-api.html:
      * pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
      * pointer-lock/pointerlockchange-pointerlockerror-events.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ebbfecc5
  4. 11 Jun, 2012 1 commit
    • scheib@chromium.org's avatar
      Add new Pointer Lock spec attribute webkitPointerLockElement. · 6ed01762
      scheib@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88799
      
      Source/WebCore:
      
      Reviewed by Dimitri Glazkov.
      
      Part of a series of refactoring changes to update pointer lock API to
      the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
      
      New attribute webkitPointerLockElement added. Follow up patches
      will remove the previous isLocked attribute. Tests updated to use
      the new attribute.
      
      * bindings/generic/RuntimeEnabledFeatures.h:
      (WebCore::RuntimeEnabledFeatures::webkitPointerLockElementEnabled):
      * dom/Document.cpp:
      (WebCore):
      (WebCore::Document::webkitPointerLockElement):
      * dom/Document.h:
      (Document):
      * dom/Document.idl:
      * page/PointerLockController.h:
      (WebCore::PointerLockController::element):
      
      Tools:
      
      Reviewed by Dimitri Glazkov.
      
      Part of a series of refactoring changes to update pointer lock API to
      the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
      
      New attribute webkitPointerLockElement added. Follow up patches
      will remove the previous isLocked attribute. Tests updated to use
      the new attribute.
      
      WebViewHost logic required modification to correctly repond to
      a lock, unlock, pointerLockElement call series. Specifically,
      unlocking must be queued after a lock command is issued always
      as the lock state may not be set yet with a lock request in flight.
      
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
      (WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
      
      LayoutTests:
      
      Part of a series of refactoring changes to update pointer lock API to
      the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
      
      New attribute webkitPointerLockElement added. Follow up patches
      will remove the previous isLocked attribute. Tests updated to use
      the new attribute.
      
      Reviewed by Dimitri Glazkov.
      
      * pointer-lock/lock-already-locked-expected.txt:
      * pointer-lock/lock-already-locked.html:
      * pointer-lock/pointer-lock-api-expected.txt:
      * pointer-lock/pointer-lock-api.html:
      * pointer-lock/pointerlocklost-event-expected.txt:
      * pointer-lock/pointerlocklost-event.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ed01762
  5. 07 Jun, 2012 1 commit
    • scheib@chromium.org's avatar
      Add new Pointer Lock spec events webkitpointerlockchange and webkitpointerlockerror · 13c96db0
      scheib@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88377
      
      Reviewed by Dimitri Glazkov.
      
      Part of a series of refactoring changes to update pointer lock API to
      the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
      
      New change and error events added. Follow up patches will remove
      the previous callbacks and pointerlocklost event. Tests updated
      to include the new events, and a new test added specifically for
      the new events, pointerlockchange-pointerlockerror-events.html.
      
      Source/WebCore:
      
      Test: pointer-lock/pointerlockchange-pointerlockerror-events.html
      
      * dom/Document.h:
      (Document):
      * dom/Document.idl:
      * dom/EventNames.h:
      (WebCore):
      * page/PointerLockController.cpp:
      (WebCore::PointerLockController::requestPointerLock):
      (WebCore::PointerLockController::didAcquirePointerLock):
      (WebCore::PointerLockController::didNotAcquirePointerLock):
      (WebCore::PointerLockController::didLosePointerLock):
      (WebCore::PointerLockController::enqueueEvent):
      (WebCore):
      * page/PointerLockController.h:
      (PointerLockController):
      
      LayoutTests:
      
      * pointer-lock/lock-already-locked-expected.txt:
      * pointer-lock/lock-already-locked.html:
      * pointer-lock/pointer-lock-api-expected.txt:
      * pointer-lock/pointer-lock-api.html:
      * pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt: Added.
      * pointer-lock/pointerlockchange-pointerlockerror-events.html: Added.
      * pointer-lock/pointerlocklost-event-expected.txt:
      * pointer-lock/pointerlocklost-event.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13c96db0
  6. 13 Jan, 2012 1 commit
  7. 22 Nov, 2011 1 commit