Commits · master · App_Technologies / webkit

15 Oct, 2012 1 commit

Calling WebCore::SharedBuffer::append(data, 0) on a shared buffer when · 18ade61c

jcivelli@chromium.org authored Oct 15, 2012

its current position is at a segment boundary (4096) ends up adding an
unitialized segment (with uninitialized memory) to the SharedBuffer.
https://bugs.webkit.org/show_bug.cgi?id=99000

Reviewed by Adam Barth.

Source/WebCore:

* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::append):

LayoutTests:

* mhtml/shared_buffer_bug-expected.txt: Added.
* mhtml/shared_buffer_bug.mht: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@131315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18ade61c

19 Jul, 2012 1 commit

[GTK] MHTML files not being loaded due to reported mime type not supported · ce442dfb

mario@webkit.org authored Jul 19, 2012

https://bugs.webkit.org/show_bug.cgi?id=89978

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Make 'message/rfc822' a supported MIME type for MHTML files in GTK.

* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::continueAfterContentPolicy): Add
'message/rfc822' to the list of MIME types to be considered to
avoid them bypasing cross-domain security checks, only for GTK.
* loader/archive/ArchiveFactory.cpp:
(WebCore::archiveMIMETypes): Add 'message/rfc822' to the list of
supported MIME types when MHTML support is enabled in GTK.

LayoutTests:

Move expectations for MHTML tests out of chromium's specific directory.

* mhtml/multi_frames_binary-expected.txt: Renamed from LayoutTests/platform/chromium/mhtml/multi_frames_binary-expected.txt.
* mhtml/multi_frames_ie-expected.txt: Renamed from LayoutTests/platform/chromium/mhtml/multi_frames_ie-expected.txt.
* mhtml/multi_frames_unmht-expected.txt: Renamed from LayoutTests/platform/chromium/mhtml/multi_frames_unmht-expected.txt.
* mhtml/page_with_css_and_js_ie-expected.txt: Renamed from LayoutTests/platform/chromium/mhtml/page_with_css_and_js_ie-expected.txt.
* mhtml/page_with_css_and_js_unmht-expected.txt: Renamed from LayoutTests/platform/chromium/mhtml/page_with_css_and_js_unmht-expected.txt.
* mhtml/page_with_image_ie-expected.txt: Renamed from LayoutTests/platform/chromium/mhtml/page_with_image_ie-expected.txt.
* mhtml/page_with_image_unmht-expected.txt: Renamed from LayoutTests/platform/chromium/mhtml/page_with_image_unmht-expected.txt.
* mhtml/simple_page_ie-expected.txt: Renamed from LayoutTests/platform/chromium/mhtml/simple_page_ie-expected.txt.
* mhtml/simple_page_unmht-expected.txt: Renamed from LayoutTests/platform/chromium/mhtml/simple_page_unmht-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ce442dfb

15 Jun, 2012 1 commit

Use testRunner instead of layoutTestController in ietestcenter, inspector,... · 08372332

rniwa@webkit.org authored Jun 15, 2012

Use testRunner instead of layoutTestController in ietestcenter, inspector, java, jquery, loader, mathml, media, and mhtml tests
https://bugs.webkit.org/show_bug.cgi?id=89176

Reviewed by Kent Tamura.

* ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm:
* inspector/audits/resources/audits-style1.css:
* inspector/console/console-long-eval-crash.html:
* inspector/extensions/extensions-audits-content-script.html:
* inspector/extensions/extensions-eval-content-script.html:
* inspector/profiler/cpu-profiler-profiling-without-inspector.html:
* inspector/timeline/timeline-animation-frame.html:
* inspector/timeline/timeline-paint.html:
* inspector/timeline/timeline-receive-response-event.html:
* inspector/timeline/timeline-timer.html:
* java/argument-to-object-type.html:
* java/array-return.html:
* java/array-sort.html:
* java/embedding-java-with-object.html:
* java/inaccessible-class.html:
* java/inline-applet-crash.html:
* java/java-and-plugins.html:
* java/lc3/:
* jquery/resources/helper.js:
* loader/go-back-to-different-window-size.html:
* loader/load-defer-resume-crash.html:
* loader/navigation-while-deferring-loads.html:
* loader/reload-subresource-when-type-changes.html:
* mathml/EmptyMFracCrash.xhtml:
* mathml/EmptyMunderOverCrash.xhtml:
* mathml/empty-mroot-crash.xhtml:
* mathml/empty-msubsup-crash.html:
* mathml/fenced-whitespace-separators-crash.html:
* mathml/msub-anonymous-child-render-crash.html:
* mathml/msubsup-no-grandchild.xhtml:
* mathml/msubsup-remove-children.xhtml:
* mathml/munderover-remove-children.html:
* mathml/operator-hijacks-fenced-node.xhtml:
* mathml/wbr-in-mroot-crash.html:
* media/W3C/w3cwrapper.js:
(test):
(async_test.t.done):
(async_test):
* media/adopt-node-crash.html:
* media/audio-controls-do-not-fade-out.html:
* media/audio-controls-rendering.html:
* media/audio-delete-while-slider-thumb-clicked.html:
* media/audio-delete-while-step-button-clicked.html:
* media/audio-garbage-collect.html:
* media/audio-no-installed-engines.html:
* media/audio-only-video-intrinsic-size.html:
* media/audio-repaint.html:
* media/context-menu-actions.html:
* media/controls-after-reload.html:
* media/controls-drag-timebar.html:
* media/controls-layout-direction.html:
* media/controls-right-click-on-timebar.html:
* media/controls-without-preload.html:
* media/crash-closing-page-with-media-as-plugin-fallback.html:
* media/fallback.html:
* media/media-blocked-by-beforeload.html:
* media/media-blocked-by-willsendrequest.html:
* media/media-controls-clone-crash.html:
* media/media-controls-invalid-url.html:
* media/media-document-audio-repaint.html:
* media/media-document-audio-size.html:
* media/media-fullscreen.js:
(canplaythrough):
* media/media-volume-slider-rendered-normal.html:
* media/no-auto-play-in-sandbox.html:
* media/remove-from-document-before-load.html:
* media/resources/foreignobject-media.svg:
* media/restore-from-page-cache.html:
* media/svg-as-image-with-media-blocked.html:
* media/video-beforeload-remove-source.html:
* media/video-canvas-alpha.html:
* media/video-canvas.html-disabled:
* media/video-click-dblckick-standalone.html:
* media/video-controls-in-media-document.html:
* media/video-controls-no-scripting.html:
* media/video-controls-toggling.html:
* media/video-controls-visible-audio-only.html:
* media/video-controls-with-mutation-event-handler.html:
* media/video-delay-load-event.html:
* media/video-display-toggle.html:
* media/video-document-types.html:
* media/video-element-other-namespace-crash.html:
* media/video-empty-source.html:
* media/video-no-audio.html:
* media/video-paint-test.js:
(init.waitForMultipleEvents):
(initAndPause.waitForMultipleEvents):
(initAndPause):
* media/video-plays-past-end-of-test.html:
* media/video-poster-blocked-by-willsendrequest.html:
* media/video-replaces-poster.html:
* media/video-source-inserted.html:
* media/video-test.js:
(endTest):
* media/video-volume-slider.html:
* media/video-zoom.html:
* mhtml/check_domain.mht:
* mhtml/multi_frames.html_original:
* mhtml/multi_frames_binary.mht:
* mhtml/multi_frames_ie.mht:
* mhtml/multi_frames_unmht.mht:
* mhtml/page_with_css_and_js_ie.mht:
* mhtml/page_with_css_and_js_unmht.mht:
* mhtml/page_with_image.html_original:
* mhtml/page_with_image_ie.mht:
* mhtml/page_with_image_unmht.mht:
* mhtml/simple_page.html_original:
* mhtml/simple_page_ie.mht:
* mhtml/simple_page_unmht.mht:
* networkinformation/resources/event-after-navigation-new.html:
* networkinformation/script-tests/event-after-navigation.js:
* platform/chromium/media/video-frame-size-change.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

08372332

16 Nov, 2011 1 commit

Make sure MHTML documents use the domain of the MHTML file. · 5de71312

jcivelli@chromium.org authored Nov 17, 2011

https://bugs.webkit.org/show_bug.cgi?id=72445

Reviewed by Adam Barth.

Source/WebCore:

* dom/Document.h:
(WebCore::Document::setBaseURL):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):

LayoutTests:

* mhtml/check_domain-expected.txt: Added.
* mhtml/check_domain.mht: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5de71312

27 Jun, 2011 1 commit

2011-06-27 Jay Civelli <jcivelli@chromium.org> · 9fe2f6a6

jcivelli@chromium.org authored Jun 27, 2011

        Reviewed by Darin Fisher.

        Adding binary part support to MHTML.
        https://bugs.webkit.org/show_bug.cgi?id=63310

        * mhtml/multi_frames_binary.mht: Added.
        * platform/chromium/mhtml/multi_frames_binary-expected.txt: Added.
2011-06-27  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Darin Fisher.

        Adding binary part support to MHTML.
        https://bugs.webkit.org/show_bug.cgi?id=63310

        * loader/archive/mhtml/MHTMLArchive.cpp:
        (WebCore::MHTMLArchive::generateMHTMLData):
        (WebCore::MHTMLArchive::generateMHTMLDataUsingBinaryEncoding):
        * loader/archive/mhtml/MHTMLArchive.h:
        * loader/archive/mhtml/MHTMLParser.cpp:
        (WebCore::MHTMLParser::parseNextPart):
        * platform/SharedBuffer.cpp:
        (WebCore::SharedBuffer::append):
        * platform/SharedBuffer.h:
        * platform/network/MIMEHeader.cpp:
        (WebCore::MIMEHeader::parseContentTransferEncoding):
        * platform/network/MIMEHeader.h:
2011-06-27  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Darin Fisher.

        Adding binary part support to MHTML.
        https://bugs.webkit.org/show_bug.cgi?id=63310

        * public/WebPageSerializer.h:
        * src/WebPageSerializer.cpp:
        (WebKit::WebPageSerializer::serializeToMHTML):
        (WebKit::WebPageSerializer::serializeToMHTMLUsingBinaryEncoding):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9fe2f6a6

24 May, 2011 1 commit

2011-05-24 Jay Civelli <jcivelli@chromium.org> · c2019dd7

jcivelli@chromium.org authored May 24, 2011

        Reviewed by Adam Barth.

        Adding MHTML reading support.
        https://bugs.webkit.org/show_bug.cgi?id=7168

        * configure.ac:
2011-05-24  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Adding MHTML reading support to WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=7168

        * mhtml/frame_0.html_original: Added.
        * mhtml/frame_1.html_original: Added.
        * mhtml/frame_2.html_original: Added.
        * mhtml/frame_4.html_original: Added.
        * mhtml/multi_frames.html_original: Added.
        * mhtml/multi_frames_ie.mht: Added.
        * mhtml/multi_frames_unmht.mht: Added.
        * mhtml/page_with_css_and_js.html_original: Added.
        * mhtml/page_with_css_and_js_ie.mht: Added.
        * mhtml/page_with_css_and_js_unmht.mht: Added.
        * mhtml/page_with_image.html_original: Added.
        * mhtml/page_with_image_ie.mht: Added.
        * mhtml/page_with_image_unmht.mht: Added.
        * mhtml/resources/red_square.png: Added.
        * mhtml/simple_page.html_original: Added.
        * mhtml/simple_page_ie.mht: Added.
        * mhtml/simple_page_unmht.mht: Added.
        * platform/chromium/mhtml/multi_frames_ie-expected.txt: Added.
        * platform/chromium/mhtml/multi_frames_unmht-expected.txt: Added.
        * platform/chromium/mhtml/page_with_css_and_js_ie-expected.txt: Added.
        * platform/chromium/mhtml/page_with_css_and_js_unmht-expected.txt: Added.
        * platform/chromium/mhtml/page_with_image_ie-expected.txt: Added.
        * platform/chromium/mhtml/page_with_image_unmht-expected.txt: Added.
        * platform/chromium/mhtml/simple_page_ie-expected.txt: Added.
        * platform/chromium/mhtml/simple_page_unmht-expected.txt: Added.
2011-05-24  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Adding MHTML reading support. That required some basic MIME header parsing.
        Modified DocumentLoader to keep a reference to the currently Archive loaded,
        so we can have different policies for loading subresources depending on the
        archive type.
        https://bugs.webkit.org/show_bug.cgi?id=7168

        * CMakeLists.txt:
        * Configurations/FeatureDefines.xcconfig:
        * GNUmakefile.am:
        * GNUmakefile.list.am:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * features.pri:
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::commitLoad):
        (WebCore::DocumentLoader::setupForReplaceByMIMEType):
        (WebCore::DocumentLoader::popArchiveForSubframe):
        (WebCore::DocumentLoader::scheduleArchiveLoad):
        * loader/DocumentLoader.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadURLIntoChildFrame):
        (WebCore::FrameLoader::loadArchive):
        (WebCore::FrameLoader::stopAllLoaders):
        (WebCore::FrameLoader::finishedLoadingDocument):
        * loader/FrameLoader.h:
        (WebCore::FrameLoader::archive):
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::start):
        * loader/archive/Archive.cpp: Added.
        * loader/archive/Archive.h:
        (WebCore::Archive::mainResource):
        * loader/archive/ArchiveFactory.cpp:
        (WebCore::archiveFactoryCreate):
        (WebCore::archiveMIMETypes):
        (WebCore::ArchiveFactory::create):
        (WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):
        * loader/archive/ArchiveFactory.h:
        * loader/archive/ArchiveResourceCollection.cpp:
        (WebCore::ArchiveResourceCollection::addAllResources):
        (WebCore::ArchiveResourceCollection::popSubframeArchive):
        * loader/archive/ArchiveResourceCollection.h:
        * loader/archive/cf/LegacyWebArchive.cpp:
        (WebCore::LegacyWebArchive::create):
        (WebCore::LegacyWebArchive::type):
        * loader/archive/cf/LegacyWebArchive.h:
        * loader/archive/mhtml/MHTMLArchive.cpp: Added.
        * loader/archive/mhtml/MHTMLArchive.h: Added.
        * loader/archive/mhtml/MHTMLParser.cpp: Added.
        * loader/archive/mhtml/MHTMLParser.h: Added.
        * platform/MIMETypeRegistry.cpp:
        (WebCore::initializeSupportedNonImageMimeTypes):
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::documentFragment):
        * platform/network/MIMEHeader.cpp: Added.
        * platform/network/MIMEHeader.h: Added.
2011-05-24  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Adding MHTML reading support to WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=7168

       * features.gypi:
2011-05-24  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Adding MHTML reading support.
        https://bugs.webkit.org/show_bug.cgi?id=7168

        * Scripts/build-webkit:
        * Scripts/old-run-webkit-tests:
        * Scripts/webkitperl/features.pm:
        * Scripts/webkitpy/layout_tests/port/test_files.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c2019dd7