1. 18 Jan, 2014 1 commit
    • andersca@apple.com's avatar
      Remove support for the viewsource attribute · 98ae35b6
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127232
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      The 'viewsource' attribute on frames is nonstandard, not used by anyone (the inspector has
      its own syntax highlighting) and not audited.
      
      This patch removes parsing of the viewsource attribute and the associated tests. A subsequent
      patch will remove the code as well.
      
      * html/HTMLFrameElementBase.cpp:
      (WebCore::HTMLFrameElementBase::parseAttribute):
      
      Source/WTF:
      
      * wtf/FeatureDefines.h:
      
      LayoutTests:
      
      * .gitattributes:
      * fast/frames/resources/viewsource-fake-image-file.png: Removed.
      * fast/frames/resources/viewsource-frame-1.html: Removed.
      * fast/frames/resources/viewsource-frame-2.html: Removed.
      * fast/frames/resources/viewsource-frame-3.html: Removed.
      * fast/frames/resources/viewsource-frame-4.html: Removed.
      * fast/frames/resources/viewsource-frame-5.html: Removed.
      * fast/frames/resources/viewsource-frame-unfinished-script.html: Removed.
      * fast/frames/resources/viewsource-frame-unfinished-textarea.html: Removed.
      * fast/frames/viewsource-attribute.html: Removed.
      * fast/frames/viewsource-empty-attribute-value-expected.txt: Removed.
      * fast/frames/viewsource-empty-attribute-value.html: Removed.
      * fast/frames/viewsource-linebreak-expected.txt: Removed.
      * fast/frames/viewsource-linebreak.html: Removed.
      * fast/frames/viewsource-link-on-href-value-expected.txt: Removed.
      * fast/frames/viewsource-link-on-href-value.html: Removed.
      * fast/frames/viewsource-on-image-file.html: Removed.
      * fast/frames/viewsource-plain-text-tags-expected.txt: Removed.
      * fast/frames/viewsource-plain-text-tags.html: Removed.
      * fast/frames/viewsource-unfinished-tags-expected.txt: Removed.
      * fast/frames/viewsource-unfinished-tags.html: Removed.
      * fast/frames/viewsource-xml-expected.txt: Removed.
      * fast/frames/viewsource-xml.html: Removed.
      * http/tests/security/resources/view-source-no-refresh.php: Removed.
      * http/tests/security/view-source-javascript-url-in-document-expected.txt: Removed.
      * http/tests/security/view-source-javascript-url-in-document.html: Removed.
      * http/tests/security/view-source-no-javascript-url-expected.txt: Removed.
      * http/tests/security/view-source-no-javascript-url.html: Removed.
      * http/tests/security/view-source-no-refresh-expected.txt: Removed.
      * http/tests/security/view-source-no-refresh.html: Removed.
      * platform/efl/fast/frames/viewsource-attribute-expected.png: Removed.
      * platform/efl/fast/frames/viewsource-attribute-expected.txt: Removed.
      * platform/efl/fast/frames/viewsource-on-image-file-expected.png: Removed.
      * platform/efl/fast/frames/viewsource-on-image-file-expected.txt: Removed.
      * platform/mac/fast/frames/viewsource-attribute-expected.png: Removed.
      * platform/mac/fast/frames/viewsource-attribute-expected.txt: Removed.
      * platform/mac/fast/frames/viewsource-on-image-file-expected.png: Removed.
      * platform/mac/fast/frames/viewsource-on-image-file-expected.txt: Removed.
      * platform/win/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98ae35b6
  2. 13 Jan, 2014 1 commit
    • commit-queue@webkit.org's avatar
      Dispatch a progress event before dispatching abort, error or timeout event · 84973bf0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=126575
      
      Source/WebCore:
      
      Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-13
      Reviewed by Alexey Proskuryakov.
      
      Added sending of progress event after readystatechange event (switching to DONE state) in case of abort, error or timeout.
      Fixed assertions in XMLHttpRequestProgressEventThrottle and XMLHttpRequestUpload.
      
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::dispatchErrorEvents): added sending of progress event before the specific error event
      * xml/XMLHttpRequestProgressEventThrottle.cpp:
      (WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): fixed assertion
      * xml/XMLHttpRequestUpload.cpp:
      (WebCore::XMLHttpRequestUpload::dispatchProgressEvent): fixed assertion
      
      LayoutTests:
      
      Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-13
      Reviewed by Alexey Proskuryakov.
      
      Updated onloadend-event-after-abort.html and onloadend-event-after-error.html to check for progress event.
      Fixed the other tests to cope with additional progress event.
      
      * http/tests/xmlhttprequest/onabort-progressevent-attributes.html:
      * http/tests/xmlhttprequest/onloadend-event-after-abort-expected.txt:
      * http/tests/xmlhttprequest/onloadend-event-after-abort.html:
      * http/tests/xmlhttprequest/onloadend-event-after-error-expected.txt:
      * http/tests/xmlhttprequest/onloadend-event-after-error.html:
      * http/tests/xmlhttprequest/simple-cross-origin-progress-events-expected.txt:
      * http/tests/xmlhttprequest/simple-cross-origin-progress-events.html:
      * http/tests/xmlhttprequest/upload-onloadend-event-after-abort.html:
      * http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84973bf0
  3. 10 Jan, 2014 1 commit
    • commit-queue@webkit.org's avatar
      Source/WebCore: Correctly set XHR loadend attributes (loaded and total). · fceceae7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120828
      
      Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-10
      Reviewed by Alexey Proskuryakov.
      
      Added correct initialization of lengthComputable, loaded and total attributes
      to XHR ProgressEvent events (load, loadstart, loadend, abort, error and timeout).
      
      XMLHttpRequestProgressEventThrottle and XMLHttpRequestUpload now keep persistent knowledge
      of m_loaded and m_total values with this patch.
      
      Code refactoring to handle event dispatching in case of error in a single manner.
      XMLHttpRequestProgressEventThrottle::dispatchProgressEvent is renamed as dispatchThrottledProgressEvent
      XMLHttpRequestProgressEventThrottle::dispatchEventAndLoadend is replaced by dispatchProgressEvent(const AtomicString&)
      
      Fixed assertion issues over bug 120828 patch
      
      Tests: http/tests/xmlhttprequest/loadstart-event-init.html
             http/tests/xmlhttprequest/onabort-progressevent-attributes.html
             http/tests/xmlhttprequest/onload-progressevent-attributes.html
             http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html
             http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html
      
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::callReadyStateChangeListener): changed readystatechange event from ProgressEvent to Event (not cancellable, not bubblable) to better match the spec
      (WebCore::XMLHttpRequest::createRequest):
      (WebCore::XMLHttpRequest::abort): code refactoring to handle error event dispatching in a single way
      (WebCore::XMLHttpRequest::networkError): code refactoring to handle error event dispatching in a single way
      (WebCore::XMLHttpRequest::abortError): code refactoring to handle error event dispatching in a single way
      (WebCore::XMLHttpRequest::didSendData):
      (WebCore::XMLHttpRequest::didReceiveData):
      (WebCore::XMLHttpRequest::dispatchErrorEvents): dispatch progress events in case of error
      (WebCore::XMLHttpRequest::didTimeout): code refactoring to handle error event dispatching in a single way
      * xml/XMLHttpRequest.h:
      * xml/XMLHttpRequestProgressEventThrottle.cpp: before the patch, the fact that a progress event is being throttled is stored indirectly (m_loaded or m_total not equal to zero). With the patch, this information is stored in m_hasThrottledProgressEvent. The m_loaded and m_total values are no longer set back to zero after a progress event is dispatched. This allows using these values to correctly initialize other ProgressEvent events (in particular loadend, abort, timeout...)
      (WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
      (WebCore::XMLHttpRequestProgressEventThrottle::dispatchThrottledProgressEvent): always update the new m_loaded and m_total values. If progress event is not sent as part of the function call, store the fact that a progress event is being throttled through m_hasThrottledProgressEvent.
      (WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): used to send any ProgressEvent event that is not be throttled
      (WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent): after the call, no progress event is throttled anymore
      (WebCore::XMLHttpRequestProgressEventThrottle::fired): after the call, no progress event is throttled anymore
      (WebCore::XMLHttpRequestProgressEventThrottle::hasEventToDispatch):
      (WebCore::XMLHttpRequestProgressEventThrottle::suspend):
      * xml/XMLHttpRequestProgressEventThrottle.h: introduced m_hasThrottledProgressEvent which stores whether a progress event is being throttled and m_computableLength which is used to initialize ProgressEvent computableLength
      * xml/XMLHttpRequestUpload.cpp:
      (WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload):
      (WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
      * xml/XMLHttpRequestUpload.h: introduced m_loaded, m_total and m_lengthComputable, similarly to XMLHttpRequestProgressEventThrottle
      
      LayoutTests: Correctly set XHR loadend event attributes (loaded and total).
      https://bugs.webkit.org/show_bug.cgi?id=120828
      
      Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-10
      Reviewed by Alexey Proskuryakov.
      
      Tests for abort, load, loadstart and loadend ProgressEvent events for XMLHttpRequest and XMLHttpRequestUpload
      
      * fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Changed to correct event values
      * http/tests/xmlhttprequest/loadstart-event-init-expected.txt: Added.
      * http/tests/xmlhttprequest/loadstart-event-init.html: Added.
      * http/tests/xmlhttprequest/onabort-progressevent-attributes-expected.txt: Added.
      * http/tests/xmlhttprequest/onabort-progressevent-attributes.html: Added.
      * http/tests/xmlhttprequest/onload-progressevent-attributes-expected.txt: Added.
      * http/tests/xmlhttprequest/onload-progressevent-attributes.html: Added.
      * http/tests/xmlhttprequest/upload-onabort-progressevent-attributes-expected.txt: Added.
      * http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html: Added.
      * http/tests/xmlhttprequest/upload-onload-progressevent-attributes-expected.txt: Added.
      * http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fceceae7
  4. 09 Jan, 2014 1 commit
    • seokju@webkit.org's avatar
      Web Inspector: Remove unused overriding protocols. · cb8504d4
      seokju@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=126630
      
      Reviewed by Timothy Hatcher.
      
      Source/WebCore:
      
      No new tests, No change in behavior.
      
      Remove unused overriding protocols as these are not used anymore in Frontned.
      -Page.setGeolocationOverride
      -Page.clearGeolocationOverride
      -Page.canOverrideGeolocation
      -Page.setDeviceOrientationOverride
      -Page.clearDeviceOrientationOverride
      -Page.canOverrideGeolocation
      -Network.setUserAgentOverride
      
      * Modules/geolocation/GeolocationController.cpp:
      (WebCore::GeolocationController::GeolocationController):
      (WebCore::GeolocationController::create):
      (WebCore::GeolocationController::positionChanged):
      (WebCore::provideGeolocationTo):
      * Modules/geolocation/GeolocationController.h:
      * dom/DeviceOrientationController.cpp:
      (WebCore::DeviceOrientationController::DeviceOrientationController):
      (WebCore::DeviceOrientationController::create):
      (WebCore::DeviceOrientationController::didChangeDeviceOrientation):
      (WebCore::provideDeviceOrientationTo):
      * dom/DeviceOrientationController.h:
      * inspector/InspectorInstrumentation.cpp:
      * inspector/InspectorInstrumentation.h:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::InspectorPageAgent):
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::disable):
      * inspector/InspectorResourceAgent.h:
      * inspector/protocol/Network.json:
      * inspector/protocol/Page.json:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::userAgent):
      
      Source/WebInspectorUI:
      
      Update InspectorWebBackendCommands.js after removing unused overriding protocols.
      
      * UserInterface/InspectorWebBackendCommands.js:
      * UserInterface/Legacy/6.0/InspectorWebBackendCommands.js:
      * UserInterface/Legacy/7.0/InspectorWebBackendCommands.js:
      * Versions/Inspector-iOS-6.0.json:
      * Versions/Inspector-iOS-7.0.json:
      
      LayoutTests:
      
      * http/tests/inspector/extensions-useragent-expected.txt: Removed.
      * http/tests/inspector/extensions-useragent.html: Removed.
      * inspector/device-orientation-success-expected.txt: Removed.
      * inspector/device-orientation-success.html: Removed.
      * inspector/geolocation-error-expected.txt: Removed.
      * inspector/geolocation-error.html: Removed.
      * inspector/geolocation-success-expected.txt: Removed.
      * inspector/geolocation-success.html: Removed.
      * inspector/geolocation-watchPosition-expected.txt: Removed.
      * inspector/geolocation-watchPosition.html: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb8504d4
  5. 08 Jan, 2014 2 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r161532. · 2408d03b
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/161532
      https://bugs.webkit.org/show_bug.cgi?id=126677
      
      Caused lots of assertion failures (Requested by ap on
      #webkit).
      
      Source/WebCore:
      
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::callReadyStateChangeListener):
      (WebCore::XMLHttpRequest::createRequest):
      (WebCore::XMLHttpRequest::abort):
      (WebCore::XMLHttpRequest::networkError):
      (WebCore::XMLHttpRequest::abortError):
      (WebCore::XMLHttpRequest::didSendData):
      (WebCore::XMLHttpRequest::didReceiveData):
      (WebCore::XMLHttpRequest::didTimeout):
      * xml/XMLHttpRequest.h:
      * xml/XMLHttpRequestProgressEventThrottle.cpp:
      (WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
      (WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent):
      (WebCore::XMLHttpRequestProgressEventThrottle::dispatchEventAndLoadEnd):
      (WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent):
      (WebCore::XMLHttpRequestProgressEventThrottle::fired):
      (WebCore::XMLHttpRequestProgressEventThrottle::hasEventToDispatch):
      (WebCore::XMLHttpRequestProgressEventThrottle::suspend):
      * xml/XMLHttpRequestProgressEventThrottle.h:
      * xml/XMLHttpRequestUpload.cpp:
      (WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload):
      (WebCore::XMLHttpRequestUpload::dispatchEventAndLoadEnd):
      * xml/XMLHttpRequestUpload.h:
      
      LayoutTests:
      
      * fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
      * http/tests/xmlhttprequest/loadstart-event-init-expected.txt: Removed.
      * http/tests/xmlhttprequest/loadstart-event-init.html: Removed.
      * http/tests/xmlhttprequest/onabort-progressevent-attributes-expected.txt: Removed.
      * http/tests/xmlhttprequest/onabort-progressevent-attributes.html: Removed.
      * http/tests/xmlhttprequest/onload-progressevent-attributes-expected.txt: Removed.
      * http/tests/xmlhttprequest/onload-progressevent-attributes.html: Removed.
      * http/tests/xmlhttprequest/upload-onabort-progressevent-attributes-expected.txt: Removed.
      * http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html: Removed.
      * http/tests/xmlhttprequest/upload-onload-progressevent-attributes-expected.txt: Removed.
      * http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2408d03b
    • commit-queue@webkit.org's avatar
      Source/WebCore: Correctly set XHR loadend attributes (loaded and total). · 035fd017
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120828
      
      Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-08
      Reviewed by Alexey Proskuryakov.
      
      Added correct initialization of lengthComputable, loaded and total attributes
      to XHR ProgressEvent events (load, loadstart, loadend, abort, error and timeout).
      
      XMLHttpRequestProgressEventThrottle and XMLHttpRequestUpload now keep persistent knowledge
      of m_loaded and m_total values with this patch.
      
      Code refactoring to handle event dispatching in case of error in a single manner.
      XMLHttpRequestProgressEventThrottle::dispatchProgressEvent is renamed as dispatchThrottledProgressEvent
      XMLHttpRequestProgressEventThrottle::dispatchEventAndLoadend is replaced by dispatchProgressEvent(const AtomicString&)
      
      Tests: http/tests/xmlhttprequest/loadstart-event-init.html
             http/tests/xmlhttprequest/onabort-progressevent-attributes.html
             http/tests/xmlhttprequest/onload-progressevent-attributes.html
             http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html
             http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html
      
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::callReadyStateChangeListener): changed readystatechange event from ProgressEvent to Event (not cancellable, not bubblable) to better match the spec
      (WebCore::XMLHttpRequest::createRequest):
      (WebCore::XMLHttpRequest::abort): code refactoring to handle error event dispatching in a single way
      (WebCore::XMLHttpRequest::networkError): code refactoring to handle error event dispatching in a single way
      (WebCore::XMLHttpRequest::abortError): code refactoring to handle error event dispatching in a single way
      (WebCore::XMLHttpRequest::didSendData):
      (WebCore::XMLHttpRequest::didReceiveData):
      (WebCore::XMLHttpRequest::dispatchErrorEvents): dispatch progress events in case of error
      (WebCore::XMLHttpRequest::didTimeout): code refactoring to handle error event dispatching in a single way
      * xml/XMLHttpRequest.h:
      * xml/XMLHttpRequestProgressEventThrottle.cpp: before the patch, the fact that a progress event is being throttled is stored indirectly (m_loaded or m_total not equal to zero). With the patch, this information is stored in m_hasThrottledProgressEvent. The m_loaded and m_total values are no longer set back to zero after a progress event is dispatched. This allows using these values to correctly initialize other ProgressEvent events (in particular loadend, abort, timeout...)
      (WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
      (WebCore::XMLHttpRequestProgressEventThrottle::dispatchThrottledProgressEvent): always update the new m_loaded and m_total values. If progress event is not sent as part of the function call, store the fact that a progress event is being throttled through m_hasThrottledProgressEvent.
      (WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): used to send any ProgressEvent event that is not be throttled
      (WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent): after the call, no progress event is throttled anymore
      (WebCore::XMLHttpRequestProgressEventThrottle::fired): after the call, no progress event is throttled anymore
      (WebCore::XMLHttpRequestProgressEventThrottle::hasEventToDispatch):
      (WebCore::XMLHttpRequestProgressEventThrottle::suspend):
      * xml/XMLHttpRequestProgressEventThrottle.h: introduced m_hasThrottledProgressEvent which stores whether a progress event is being throttled and m_computableLength which is used to initialize ProgressEvent computableLength
      * xml/XMLHttpRequestUpload.cpp:
      (WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload):
      (WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
      * xml/XMLHttpRequestUpload.h: introduced m_loaded, m_total and m_lengthComputable, similarly to XMLHttpRequestProgressEventThrottle
      
      LayoutTests: Correctly set XHR loadend event attributes (loaded and total).
      https://bugs.webkit.org/show_bug.cgi?id=120828
      
      Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-08
      Reviewed by Alexey Proskuryakov.
      
      Tests for abort, load, loadstart and loadend ProgressEvent events for XMLHttpRequest and XMLHttpRequestUpload
      
      * fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Changed to correct event values
      * http/tests/xmlhttprequest/loadstart-event-init-expected.txt: Added.
      * http/tests/xmlhttprequest/loadstart-event-init.html: Added.
      * http/tests/xmlhttprequest/onabort-progressevent-attributes-expected.txt: Added.
      * http/tests/xmlhttprequest/onabort-progressevent-attributes.html: Added.
      * http/tests/xmlhttprequest/onload-progressevent-attributes-expected.txt: Added.
      * http/tests/xmlhttprequest/onload-progressevent-attributes.html: Added.
      * http/tests/xmlhttprequest/upload-onabort-progressevent-attributes-expected.txt: Added.
      * http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html: Added.
      * http/tests/xmlhttprequest/upload-onload-progressevent-attributes-expected.txt: Added.
      * http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      035fd017
  6. 07 Jan, 2014 1 commit
    • jer.noble@apple.com's avatar
      HTML5 video tag Does Not Load in Apache htaccess/htpasswd Protected Directory · f628b340
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=40382
      
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      Test: http/tests/media/video-auth.html
      
      Adopt a new AVFoundation API to handle authentication challenge generated while loading
      media through an AVAsset. The authentication request comes through as a
      NSURLAuthenticationChallenge, and is wrapped in a WebCore::AuthenticationChallenge
      by MediaPlayerPrivateAVFoundationObjC, and is sent up to the HTMLMediaElement to handle.
      The HTMLMediaElement creates a ResourceRequest, and passes the challenge up to the
      ResourceLoadNotifier.
      
      To allow the HTMLMediaElement to initiate handling an AuthenticationChallenge without
      actually creating a ResourceLoader, allow ResourceLoaderDelegate to accept a unique
      identifier and a DocumentLoader in lieu of a ResourceLoader.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::parseAttribute):
      * html/HTMLMediaElement.h:
      * loader/ResourceLoadNotifier.cpp:
      (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge):
      (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge):
      * loader/ResourceLoadNotifier.h:
      * platform/graphics/MediaPlayer.cpp:
      (WebCore::MediaPlayer::shouldWaitForResponseToAuthenticationChallenge):
      * platform/graphics/MediaPlayer.h:
      (WebCore::MediaPlayerClient::mediaPlayerShouldWaitForResponseToAuthenticationChallenge):
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForResponseToAuthenticationChallenge):
      (-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForResponseToAuthenticationChallenge:]):
      
      LayoutTests:
      
      * http/tests/media/resources/video-auth.php: Added.
      * http/tests/media/video-auth-expected.txt: Added.
      * http/tests/media/video-auth.html: Added.
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f628b340
  7. 03 Jan, 2014 1 commit
  8. 24 Dec, 2013 2 commits
  9. 23 Dec, 2013 1 commit
  10. 17 Dec, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Web Inspector: Remove InspectorFrontendHost.setInjectedScriptForOrigin · d0f39a5d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125906
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-12-17
      Reviewed by Timothy Hatcher.
      
      Source/WebCore:
      
      Remove stale code related to a since removed feature,
      Inspector extensions. This allows us to remove a number
      of entry points into InspectorAgent.
      
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::InspectorAgent):
      (WebCore::InspectorAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorAgent.h:
      (WebCore::InspectorAgent::create):
      Remove setInjectedScriptForOrigin and InjectedScript management.
      
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      * inspector/InspectorController.h:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorFrontendHost.h:
      * inspector/InspectorFrontendHost.idl:
      Remove the API and calling through InspectorController.
      
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
      (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
      (WebCore::InspectorInstrumentation::didCommitLoadImpl):
      Remove now unnecessary calls into InspectorAgent.
      
      LayoutTests:
      
      * http/tests/inspector/injected-script-for-origin-expected.txt: Removed.
      * http/tests/inspector/injected-script-for-origin.html: Removed.
      * http/tests/inspector/resources/injected-script-for-origin-frame.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0f39a5d
  11. 13 Dec, 2013 2 commits
    • joepeck@webkit.org's avatar
      Web Inspector: Move Inspector and Debugger protocol domains into JavaScriptCore · 4591f9bc
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125707
      
      Reviewed by Timothy Hatcher.
      
      Source/JavaScriptCore:
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * GNUmakefile.am:
      * inspector/protocol/Debugger.json: Renamed from Source/WebCore/inspector/protocol/Debugger.json.
      * inspector/protocol/GenericTypes.json: Added.
      * inspector/protocol/InspectorDomain.json: Renamed from Source/WebCore/inspector/protocol/InspectorDomain.json.
      Add new files to inspector generation.
      
      * inspector/scripts/CodeGeneratorInspector.py:
      (Generator.go):
      Only build TypeBuilder output if the domain only has types. Avoid
      backend/frontend dispatchers and backend commands.
      
      (TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
      (format_setter_value_expression):
      (Generator.process_command):
      (Generator.generate_send_method):
      * inspector/scripts/CodeGeneratorInspectorStrings.py:
      Export and name the get{JS,Web}EnumConstant function.
      
      Source/WebCore:
      
        - Switch TypeBuilder::Page::SearchMatch to TypeBuilder::GenericTypes::SearchMatch
          which comes from InspectorJSTypeBuilders.
        - Remove domains that moved to JavaScriptCore.
      
      No new tests, this only moves code around. There are no functional changes.
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * GNUmakefile.am:
      Add new files.
      
      * inspector/ContentSearchUtils.cpp:
      (WebCore::ContentSearchUtils::buildObjectForSearchMatch):
      (WebCore::ContentSearchUtils::searchInTextByLines):
      * inspector/ContentSearchUtils.h:
      * inspector/InspectorAgent.cpp:
      * inspector/InspectorAgent.h:
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::searchInResource):
      * inspector/InspectorPageAgent.h:
      * inspector/protocol/Page.json:
      Update includes and type builder type names.
      
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::breakpointActionTypeForString):
      (WebCore::InspectorDebuggerAgent::searchInContent):
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
      Use the new getEnum function names.
      
      Source/WebInspectorUI:
      
      * UserInterface/InspectorJSBackendCommands.js:
      * UserInterface/InspectorWebBackendCommands.js:
      Regenerate now that domains have moved around.
      
      LayoutTests:
      
      * http/tests/inspector-protocol/resources/InspectorTest.js:
      (InspectorTest.checkForError):
      Since having a protocol error is likely wrong, make the output
      for it as detailed as possible.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4591f9bc
    • joepeck@webkit.org's avatar
      Web Inspector: Add Inspector Code Generation to JavaScriptCore for Runtime Domain · 8be4912d
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125595
      
      Reviewed by Timothy Hatcher.
      
      * GNUmakefile.am:
      
      Source/JavaScriptCore:
      
        - Move CodeGeneration scripts from WebCore into JavaScriptCore/inspector/scripts
        - For ports that build WebKit frameworks separately, export the scripts as PrivateHeaders
        - Update CodeGeneratorInspector.py in a few ways:
          - output dynamic filenames, so JavaScriptCore generates InspectorJSFoo.* and WebCore generates InspectorWebFoo.*
          - take in more then one protocol JSON file. The first contains domains to generate, the others are dependencies
            that are generated elsewhere that we can depend on for Types.
        - Add DerivedSources build step to generate the Inspector Interfaces
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
      * JavaScriptCore.vcxproj/copy-files.cmd:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      Add scripts and code generation.
      
      * inspector/protocol/Runtime.json: Renamed from Source/WebCore/inspector/protocol/Runtime.json.
      Move protocol file into JavaScriptCore so its types will be generated in JavaScriptCore.
      
      * inspector/scripts/CodeGeneratorInspector.py: Renamed from Source/WebCore/inspector/CodeGeneratorInspector.py.
      Updates to the script as listed above.
      
      * inspector/scripts/CodeGeneratorInspectorStrings.py: Renamed from Source/WebCore/inspector/CodeGeneratorInspectorStrings.py.
      * inspector/scripts/generate-combined-inspector-json.py: Renamed from Source/WebCore/inspector/Scripts/generate-combined-inspector-json.py.
      Moved from WebCore into JavaScriptCore for code generation.
      
      Source/WebCore:
      
        - CodeGeneration changed to output Frontend and Backend dispatchers
          in namespace Inspector. So update all the agent's appropriately.
        - Update Derived Sources code generation to use the Scripts that had
          moved to JavaScriptCore. Some ports just use JSC/inspector/scripts
          directly, but others have to use the Scripts exported by JSC
          in JavaScriptCore's PrivateHeaders.
        - Add ForwardingHeaders for the files generated in JavaScriptCore.
        - Update the names of Inspector DerivedSources files, since they
          were renamed to InspectorWeb*.
      
      No new tests, this only moves code around. There are no functional changes.
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * ForwardingHeaders/inspector/InspectorJSBackendDispatchers.h: Added.
      * ForwardingHeaders/inspector/InspectorJSFrontendDispatchers.h: Added.
      * ForwardingHeaders/inspector/InspectorJSTypeBuilders.h: Added.
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.vcxproj/build-generated-files.sh:
      * WebCore.xcodeproj/project.pbxproj:
      Remove files, rename files, update code generation.
      
      * make-generated-sources.sh:
      Update this standalone developer script to fill in the new InspectorScripts variable.
      
      * inspector/ConsoleMessage.h:
      * inspector/InjectedScriptHost.cpp:
      * inspector/InspectorAgent.cpp:
      * inspector/InspectorAgent.h:
      * inspector/InspectorApplicationCacheAgent.cpp:
      * inspector/InspectorApplicationCacheAgent.h:
      * inspector/InspectorCSSAgent.h:
      * inspector/InspectorCanvasAgent.cpp:
      * inspector/InspectorCanvasAgent.h:
      * inspector/InspectorConsoleAgent.cpp:
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorController.cpp:
      * inspector/InspectorDOMAgent.cpp:
      * inspector/InspectorDOMAgent.h:
      * inspector/InspectorDOMDebuggerAgent.cpp:
      * inspector/InspectorDOMDebuggerAgent.h:
      * inspector/InspectorDOMStorageAgent.cpp:
      * inspector/InspectorDOMStorageAgent.h:
      * inspector/InspectorDatabaseAgent.cpp:
      * inspector/InspectorDatabaseAgent.h:
      * inspector/InspectorDatabaseResource.cpp:
      * inspector/InspectorDatabaseResource.h:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorFrontendClientLocal.cpp:
      * inspector/InspectorHeapProfilerAgent.h:
      * inspector/InspectorIndexedDBAgent.cpp:
      * inspector/InspectorIndexedDBAgent.h:
      * inspector/InspectorInputAgent.h:
      * inspector/InspectorLayerTreeAgent.cpp:
      * inspector/InspectorLayerTreeAgent.h:
      * inspector/InspectorMemoryAgent.cpp:
      * inspector/InspectorMemoryAgent.h:
      * inspector/InspectorPageAgent.cpp:
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorProfilerAgent.cpp:
      * inspector/InspectorProfilerAgent.h:
      * inspector/InspectorResourceAgent.cpp:
      * inspector/InspectorResourceAgent.h:
      * inspector/InspectorRuntimeAgent.h:
      * inspector/InspectorTimelineAgent.cpp:
      * inspector/InspectorTimelineAgent.h:
      * inspector/InspectorWorkerAgent.cpp:
      * inspector/InspectorWorkerAgent.h:
      * inspector/PageRuntimeAgent.h:
      * inspector/ScriptCallFrame.cpp:
      * inspector/WorkerInspectorController.cpp:
      * inspector/WorkerRuntimeAgent.h:
      Updates header names and class namespace changes.
      
      Source/WebInspectorUI:
      
      * Scripts/copy-user-interface-resources.sh:
      Copy all the different backend commands files.
      
      * Scripts/update-InspectorBackendCommands.rb:
      Update with respect to new script location and new file names.
      
      * WebInspectorUI.xcodeproj/project.pbxproj:
      Remove Inputs and Outputs of build phase, which were wrong.
      Now this build phase always runs, and not by accident.
      
      * UserInterface/InspectorJSBackendCommands.js: Added.
      * UserInterface/InspectorWebBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/InspectorBackendCommands.js.
      * UserInterface/Legacy/6.0/InspectorWebBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Legacy/6.0/InspectorBackendCommands.js.
      * UserInterface/Legacy/7.0/InspectorWebBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Legacy/7.0/InspectorBackendCommands.js.
      * UserInterface/LoadInspectorBackendCommands.js:
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
      
      LayoutTests:
      
      * http/tests/inspector-protocol/resources/InspectorTest.js:
      (InspectorTest.importInspectorScripts):
      Update for the new backend commands files.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8be4912d
  12. 05 Dec, 2013 1 commit
    • achicu@adobe.com's avatar
      Web Inspector: [CSS Regions] Show a list of containing regions when clicking a... · 0e035b16
      achicu@adobe.com authored
      Web Inspector: [CSS Regions] Show a list of containing regions when clicking a node that is part of a flow
      https://bugs.webkit.org/show_bug.cgi?id=124614
      
      Reviewed by Timothy Hatcher.
      
      Source/WebInspectorUI:
      
      Added a new function in DOMTreeManager called getNodeContentFlowInfo that can be used
      to retrieve an object with the following structure:
      {
           "regionFlow": <Reference to the ContentFlow object referenced by the -webkit-flow-from property of the node>,
           "contentFlow": <Reference to the ContentFlow object referenced by the -webkit-flow-into property of
                           the node or a parent of the node>,
           "regions": [ list of DOMNodes representing the regions containers of the node. The node is split across all these regions. ]
      }
      
      Also, used this method to display a two new sections in the Computed Styles panel.
      1. Section "Flows": can have up to two Simple Rows: "Region Flow" and "Content Flow".
      2. Section "Container Regions" contains a DOMTreeDataGrid with the list of regions.
      
      The sections are only visible when there's content to display.
      
      Next to the "Region Flow" simple row I've added an arrow that will take the user to the "ContentFlowDOMTreeContentView" of the
      ContentFlow. The same happens for the "Content Flow", but in this case the element will also be highlighted.
      
      Part of the patch I've added the DOMTreeDataGridNode. LayerTreeDataGrid has a lot of CSS in common with it, so I
      will make another patch to refactor LayerTreeDataGrid to use DOMTreeDataGridNode as a base class.
      
      * Localizations/en.lproj/localizedStrings.js:
      * UserInterface/ComputedStyleDetailsPanel.css: Added.
      (.details-section > .content > .group > .row.simple.content-flow-link > .label):
      (.details-section > .content > .group > .row.simple.content-flow-link > .value):
      (.details-section > .content > .group > .row.simple.content-flow-link > .value > div):
      (.details-section > .content > .group > .row.simple.content-flow-link > .value > div > .icon):
      (.details-section > .content > .group > .row.simple.content-flow-link > .value > div > span):
      (.details-section > .content > .group > .row.simple.content-flow-link > .value > div > .go-to-arrow):
      (.details-section > .content > .group > .row.simple.content-flow-link:hover > .value > div > .go-to-arrow):
      * UserInterface/ComputedStyleDetailsPanel.js:
      (WebInspector.ComputedStyleDetailsPanel):
      (WebInspector.ComputedStyleDetailsPanel.prototype.get regionFlow):
      (WebInspector.ComputedStyleDetailsPanel.prototype.set regionFlow):
      (WebInspector.ComputedStyleDetailsPanel.prototype.get contentFlow):
      (WebInspector.ComputedStyleDetailsPanel.prototype.set contentFlow):
      (WebInspector.ComputedStyleDetailsPanel.prototype.get containerRegions):
      (WebInspector.ComputedStyleDetailsPanel.prototype.set containerRegions):
      (WebInspector.ComputedStyleDetailsPanel.prototype.refresh):
      (WebInspector.ComputedStyleDetailsPanel.prototype._computedStyleShowAllCheckboxValueChanged):
      (WebInspector.ComputedStyleDetailsPanel.prototype._resetFlowDetails):
      (WebInspector.ComputedStyleDetailsPanel.prototype._refreshFlowDetails.contentFlowInfoReady):
      (WebInspector.ComputedStyleDetailsPanel.prototype._refreshFlowDetails):
      (WebInspector.ComputedStyleDetailsPanel.prototype._goToRegionFlowArrowWasClicked):
      (WebInspector.ComputedStyleDetailsPanel.prototype._goToContentFlowArrowWasClicked):
      * UserInterface/DOMTreeDataGrid.css: Added.
      (.dom-tree-data-grid .data-grid):
      (.dom-tree-data-grid .data-grid table.data):
      (.dom-tree-data-grid .data-container):
      (.dom-tree-data-grid .data-container tr):
      (.dom-tree-data-grid .data-container td > div):
      (.dom-tree-data-grid .data-container .name-column):
      (.dom-tree-data-grid .data-container .name-column .icon):
      (.dom-tree-data-grid .data-container .name-column .label):
      (.dom-tree-data-grid .data-container tr:hover .name-column .label):
      (.dom-tree-data-grid .data-container .go-to-arrow):
      (.dom-tree-data-grid .data-container tr:hover .go-to-arrow):
      (.dom-tree-data-grid .data-container tbody > tr:nth-child(2n)):
      (.dom-tree-data-grid .data-container tbody > tr:nth-child(2n+1)):
      * UserInterface/DOMTreeDataGrid.js: Added.
      (WebInspector.DOMTreeDataGrid):
      (WebInspector.DOMTreeDataGrid.prototype._onmousemove):
      (WebInspector.DOMTreeDataGrid.prototype._onmouseout):
      * UserInterface/DOMTreeDataGridNode.js: Added.
      (WebInspector.DOMTreeDataGridNode):
      (WebInspector.DOMTreeDataGridNode.prototype.get domNode):
      (WebInspector.DOMTreeDataGridNode.prototype.createCellContent):
      (WebInspector.DOMTreeDataGridNode.prototype._updateNodeName):
      (WebInspector.DOMTreeDataGridNode.prototype._makeNameCell):
      (WebInspector.DOMTreeDataGridNode.prototype._updateNameCellData):
      (WebInspector.DOMTreeDataGridNode.prototype._goToArrowWasClicked):
      * UserInterface/DOMTreeManager.js:
      (WebInspector.DOMTreeManager.prototype.unregisteredNamedFlowContentElement):
      (WebInspector.DOMTreeManager.prototype.nodeRequested):
      (WebInspector.DOMTreeManager.prototype._coerceRemoteArrayOfDOMNodes):
      (WebInspector.DOMTreeManager.prototype.domNodeResolved):
      (WebInspector.DOMTreeManager.prototype.regionNodesAvailable):
      (WebInspector.DOMTreeManager.prototype.get if):
      (WebInspector.DOMTreeManager.prototype.get var):
      (WebInspector.DOMTreeManager.prototype.backendFunction.getComputedProperty):
      (WebInspector.DOMTreeManager.prototype.backendFunction.getContentFlowName):
      (WebInspector.DOMTreeManager.prototype.):
      * UserInterface/DataGrid.css:
      (.data-grid.no-header > table.header):
      (.data-grid.no-header .data-container):
      * UserInterface/DetailsSection.js:
      (WebInspector.DetailsSection):
      * UserInterface/InspectorBackend.js:
      (InspectorBackendClass.prototype._wrap):
      * UserInterface/Main.html:
      * UserInterface/ResourceSidebarPanel.js:
      (WebInspector.ResourceSidebarPanel.prototype.showContentFlowDOMTree):
      * UserInterface/RuntimeManager.js:
      (WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow):
      (WebInspector.RuntimeManager.prototype.getPropertiesForRemoteObject):
      
      LayoutTests:
      
      Added a new test to check the new WebInspector function called DOMTreeManager.getNodeContentFlowInfo.
      
      * http/tests/inspector-protocol/resources/InspectorTest.js:
      When testing the inspector code, we want to catch and log any uncaught exceptions or console.errors/asserts.
      (InspectorTest.importInspectorScripts.console.error.window.onerror):
      (InspectorTest.importInspectorScripts.console.assert):
      (InspectorTest.importInspectorScripts):
      * inspector-protocol/model/content-node-region-info-expected.txt: Added.
      * inspector-protocol/model/content-node-region-info.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e035b16
  13. 27 Nov, 2013 1 commit
    • calvaris@igalia.com's avatar
      [GStreamer] Invalid command line error when visiting www.chessbase.com · 1c443bb5
      calvaris@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124715
      
      Reviewed by Philippe Normand.
      
      Source/WebCore:
      
      We were not handling the HTTP errors in the WebKit GStreamer
      source and therefore the 404 error page was being 'decoded'. As no
      decoder could be found (for obvious reasons), playback failed, but
      it should be failing for the source not being found instead of the
      decoding problem.
      
      Test: http/tests/media/video-error-does-not-exist.html
      
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      (StreamingClient::handleResponseReceived): Handle HTTP errors in
      the source and raise a GStreamer error to the pipeline.
      
      LayoutTests:
      
      Copied and adapted for HTTP from
      media/video-error-does-not-exist.html.
      
      * http/tests/media/video-error-does-not-exist-expected.txt: Added.
      * http/tests/media/video-error-does-not-exist.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c443bb5
  14. 25 Nov, 2013 1 commit
    • commit-queue@webkit.org's avatar
      [GStreamer] Seeking fails on media content provided by servers not supporting Range requests · 72ba7372
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85994
      
      Patch by Andres Gomez <agomez@igalia.com> on 2013-11-25
      Reviewed by Philippe Normand.
      
      Source/WebCore:
      
      Based on the patch written by Andre Moreira Magalhaes.
      
      When the GStreamer web source was doing a "Range" request we were
      expecting to receive a 206 status reply with the "Content-Range"
      header and just the requested data. Supporting "Range" requests is
      not mandatory so, for the servers not supporting it they will be
      replying with a 200 status and the whole content of the media
      element. Now, we are properly handling these replies too.
      
      Test: http/tests/media/media-seeking-no-ranges-server.html
      
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      (StreamingClient::handleResponseReceived): Do not fail when
      receiving 200 as response for HTTP range requests.
      (StreamingClient::handleDataReceived): Manually seek on stream
      when receiving the full data after a seek.
      
      LayoutTests:
      
      Added test to check that seeking media files on http servers not
      supporting "Range" requests doesn't trigger an error.
      
      * http/tests/media/media-seeking-no-ranges-server-expected.txt: Added.
      * http/tests/media/media-seeking-no-ranges-server.html: Added.
      * http/tests/media/resources/load-video.php: Added support for new
      "ranges" paramenter.
      * http/tests/media/resources/serve-video.php: Added support for
      new "ranges" paramenter. When "ranges" is "no" we always answer
      the HTTP status "200 OK" and send the whole file.
      * platform/mac/TestExpectations: New test skipped in Mac port as
      media playback download control is passed to AVFoundation that
      doesn't like fancy PHP URLs like the one used in the test and, in
      addition, they won't care about HTTP servers not supporting
      "Range" requests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72ba7372
  15. 15 Nov, 2013 1 commit
    • achicu@adobe.com's avatar
      Web Inspector: DOM.performSearch should accept a list of context nodes · 1aa38677
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124390
      
      Reviewed by Timothy Hatcher.
      
      Source/WebCore:
      
      Extracted the code in InspectorDOMAgent::performSearch into its own helper class
      called InspectorNodeFinder. Also added a new array parameter called "nodeIds"
      that can be used to limit the search results to just partial subtrees.
      
      Tests: inspector-protocol/dom/dom-search-crash.html
             inspector-protocol/dom/dom-search-with-context.html
             inspector-protocol/dom/dom-search.html
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * inspector/protocol/DOM.json:
      * inspector/InspectorAllInOne.cpp:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::performSearch):
      * inspector/InspectorDOMAgent.h:
      * inspector/InspectorNodeFinder.cpp: Added.
      (WebCore::stripCharacters):
      (WebCore::InspectorNodeFinder::InspectorNodeFinder):
      (WebCore::InspectorNodeFinder::performSearch):
      (WebCore::InspectorNodeFinder::searchUsingDOMTreeTraversal):
      (WebCore::InspectorNodeFinder::matchesAttribute):
      (WebCore::InspectorNodeFinder::matchesElement):
      (WebCore::InspectorNodeFinder::searchUsingXPath):
      (WebCore::InspectorNodeFinder::searchUsingCSSSelectors):
      * inspector/InspectorNodeFinder.h: Added.
      (WebCore::InspectorNodeFinder::results):
      
      LayoutTests:
      
      Added new inspector-protocol tests to check for the DOM.performSearch implementation.
      Also, ported an existing test from the old "inspector" format.
      
      * http/tests/inspector-protocol/resources/InspectorDOMListener.js: Added boilerplate code that
      can be used to track node ids and class names.
      (createDOMListener.createNodeAttributesMap):
      (createDOMListener.collectNode):
      (createDOMListener.onSetChildNodes):
      (createDOMListener.onChildNodeRemoved):
      (createDOMListener.onChildNodeInserted):
      (createDOMListener.return.getNodeById):
      (createDOMListener.return.getNodeIdentifier):
      * http/tests/inspector-protocol/resources/InspectorTest.js:
      (InspectorFrontendAPI.dispatchMessageAsync): Added a way to catch all the messages received in the inspector.
      It is useful for debugging the test file.
      (InspectorTest.addEventListener): Helper method to register multiple handlers for the same event.
      * inspector-protocol/dom/dom-search-crash-expected.txt: Added.
      * inspector-protocol/dom/dom-search-crash.html: Added.
      * inspector-protocol/dom/dom-search-expected.txt: Added.
      * inspector-protocol/dom/dom-search-with-context-expected.txt: Added.
      * inspector-protocol/dom/dom-search-with-context.html: Added.
      * inspector-protocol/dom/dom-search.html: Added.
      * inspector-protocol/dom/resources/dom-search-crash-iframe.html: Cloned from inspector/dom/resources/dom-search-crash-iframe.html
      * inspector-protocol/dom/resources/dom-search-iframe.html: Added.
      * inspector-protocol/dom/resources/dom-search-queries.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1aa38677
  16. 12 Nov, 2013 1 commit
    • achicu@adobe.com's avatar
      Web Inspector: Crash when closing the Inspector while debugging an exception... · ff170404
      achicu@adobe.com authored
      Web Inspector: Crash when closing the Inspector while debugging an exception inside a breakpoint condition.
      https://bugs.webkit.org/show_bug.cgi?id=124078
      
      Reviewed by Joseph Pecoraro.
      
      Source/JavaScriptCore:
      
      The crash would happen because the Debugger is not designed to support nested
      breaks. For example, when the debugger handles a breakpoint and the Inspector
      executes a console command that would hit the breakpoint again, the Debugger
      will just ignore the breakpoint.
      
      There were no checks for conditions and actions. Because of that conditions and actions
      could trigger exceptions and breakpoints. This patch disables that functionality as it
      cannot be supported without a bigger rewrite of the code.
      
      * debugger/Debugger.cpp:
      (JSC::TemporaryPausedState::TemporaryPausedState):
      (JSC::TemporaryPausedState::~TemporaryPausedState):
      (JSC::Debugger::hasBreakpoint):
      (JSC::Debugger::pauseIfNeeded):
      * debugger/Debugger.h:
      
      LayoutTests:
      
      Checking that the debugger will not crash nor stall when exceptions are throw while the debugger
      is already paused. The cases when that can happen include breakpoint conditions, actions, eval
      or runtime object inspection.
      
      The current behavior was to ignore the exceptions or breakpoints while executing "console commands"
      when the debugger was already paused. I'm extending this mechanism to breakpoint conditions and
      actions as the Debugger is not designed to support nested "debugger breaks".
      
      * http/tests/inspector-protocol/resources/protocol-test.js:
      (closeTest): Avoid having internals.closeDummyInspectorFrontend and testRunner.notifyDone
      in the same function. The debugger will not have a chance to exit the temporary EventLoop
      before loading the next test.
      * inspector-protocol/debugger/breakpoint-action-detach-expected.txt: Added.
      * inspector-protocol/debugger/breakpoint-action-detach.html: Added.
      * inspector-protocol/debugger/breakpoint-action-with-exception-expected.txt: Added.
      * inspector-protocol/debugger/breakpoint-action-with-exception.html: Added.
      * inspector-protocol/debugger/breakpoint-condition-detach-expected.txt: Added.
      * inspector-protocol/debugger/breakpoint-condition-detach.html: Added.
      * inspector-protocol/debugger/breakpoint-condition-with-exception-expected.txt: Added.
      * inspector-protocol/debugger/breakpoint-condition-with-exception.html: Added.
      * inspector-protocol/debugger/breakpoint-eval-with-exception-expected.txt: Added.
      * inspector-protocol/debugger/breakpoint-eval-with-exception.html: Added.
      * inspector-protocol/debugger/breakpoint-inside-conditons-and-actions-expected.txt: Added.
      * inspector-protocol/debugger/breakpoint-inside-conditons-and-actions.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff170404
  17. 10 Nov, 2013 1 commit
    • akling@apple.com's avatar
      RenderIFrame should display its name correctly in DRT output. · 27c741cd
      akling@apple.com authored
      <https://webkit.org/b/124117>
      
      Source/WebCore:
      
      Nuke an age-old FIXME about making RenderIFrame show its true name
      in DRT output. No more "RenderPartObject {IFRAME}"!
      
      Reviewed by Anders Carlsson.
      
      LayoutTests:
      
      Rebaseline results now that RenderIFrame correctly dumps its name
      as "RenderIFrame".
      
      Reviewed by Anders Carlsson.
      
      * compositing/iframes/composited-iframe-scroll-expected.txt:
      * compositing/iframes/iframe-content-flipping-expected.txt:
      * compositing/iframes/nested-iframe-scrolling-expected.txt:
      * fast/css/replaced-element-implicit-size-expected.txt:
      * fast/css/resize-corner-tracking-expected.txt:
      * fast/dom/attr_dead_doc-expected.txt:
      * fast/frames/content-opacity-1-expected.txt:
      * fast/frames/content-opacity-2-expected.txt:
      * fast/frames/iframe-scaling-with-scroll-expected.txt:
      * fast/frames/iframe-text-contents-expected.txt:
      * fast/frames/paint-iframe-background-expected.txt:
      * fast/repaint/4774354-expected.txt:
      * fast/repaint/iframe-scroll-repaint-expected.txt:
      * fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
      * fast/replaced/percent-height-in-anonymous-block-expected.txt:
      * http/tests/misc/acid3-expected.txt:
      * media/media-document-audio-repaint-expected.txt:
      * platform/efl/compositing/iframes/composited-iframe-alignment-expected.txt:
      * platform/efl/compositing/iframes/iframe-copy-on-scroll-expected.txt:
      * platform/efl/compositing/iframes/iframe-in-composited-layer-expected.txt:
      * platform/efl/css2.1/20110323/absolute-replaced-height-004-expected.txt:
      * platform/efl/css2.1/20110323/absolute-replaced-height-005-expected.txt:
      * platform/efl/css2.1/20110323/absolute-replaced-height-007-expected.txt:
      * platform/efl/css2.1/20110323/absolute-replaced-height-011-expected.txt:
      * platform/efl/css2.1/20110323/absolute-replaced-height-012-expected.txt:
      * platform/efl/css2.1/20110323/absolute-replaced-height-014-expected.txt:
      * platform/efl/css2.1/20110323/absolute-replaced-height-018-expected.txt:
      * platform/efl/css2.1/20110323/absolute-replaced-height-019-expected.txt:
      * platform/efl/css2.1/20110323/absolute-replaced-height-021-expected.txt:
      * platform/efl/css2.1/20110323/absolute-replaced-height-025-expected.txt:
      * platform/efl/css2.1/20110323/absolute-replaced-height-026-expected.txt:
      * platform/efl/css2.1/20110323/absolute-replaced-height-028-expected.txt:
      * platform/efl/css2.1/20110323/absolute-replaced-height-032-expected.txt:
      * platform/efl/css2.1/20110323/absolute-replaced-height-033-expected.txt:
      * platform/efl/css2.1/20110323/absolute-replaced-height-035-expected.txt:
      * platform/efl/css2.1/20110323/block-replaced-height-004-expected.txt:
      * platform/efl/css2.1/20110323/block-replaced-height-005-expected.txt:
      * platform/efl/css2.1/20110323/block-replaced-height-007-expected.txt:
      * platform/efl/css2.1/20110323/float-replaced-height-004-expected.txt:
      * platform/efl/css2.1/20110323/float-replaced-height-005-expected.txt:
      * platform/efl/css2.1/20110323/float-replaced-height-007-expected.txt:
      * platform/efl/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
      * platform/efl/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
      * platform/efl/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
      * platform/efl/css2.1/20110323/inline-replaced-height-004-expected.txt:
      * platform/efl/css2.1/20110323/inline-replaced-height-005-expected.txt:
      * platform/efl/css2.1/20110323/inline-replaced-height-007-expected.txt:
      * platform/efl/editing/pasteboard/4631972-expected.txt:
      * platform/efl/editing/selection/4776665-expected.txt:
      * platform/efl/editing/selection/4960137-expected.txt:
      * platform/efl/editing/selection/4975120-expected.txt:
      * platform/efl/editing/selection/drag-in-iframe-expected.txt:
      * platform/efl/editing/selection/drag-to-contenteditable-iframe-expected.txt:
      * platform/efl/editing/selection/iframe-expected.txt:
      * platform/efl/editing/selection/select-all-iframe-expected.txt:
      * platform/efl/fast/block/basic/013-expected.txt:
      * platform/efl/fast/block/positioning/window-height-change-expected.txt:
      * platform/efl/fast/css/line-height-overflow-expected.txt:
      * platform/efl/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
      * platform/efl/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
      * platform/efl/fast/flexbox/016-expected.txt:
      * platform/efl/fast/forms/basic-textareas-expected.txt:
      * platform/efl/fast/forms/tabbing-input-iframe-expected.txt:
      * platform/efl/fast/forms/targeted-frame-submission-expected.txt:
      * platform/efl/fast/frames/001-expected.txt:
      * platform/efl/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
      * platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
      * platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
      * platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
      * platform/efl/fast/frames/flattening/iframe-flattening-nested-expected.txt:
      * platform/efl/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
      * platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
      * platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
      * platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
      * platform/efl/fast/frames/flattening/iframe-flattening-simple-expected.txt:
      * platform/efl/fast/frames/frameElement-iframe-expected.txt:
      * platform/efl/fast/frames/iframe-option-crash-expected.txt:
      * platform/efl/fast/frames/iframe-scrolling-attribute-expected.txt:
      * platform/efl/fast/frames/iframe-with-frameborder-expected.txt:
      * platform/efl/fast/frames/onlyCommentInIFrame-expected.txt:
      * platform/efl/fast/frames/take-focus-from-iframe-expected.txt:
      * platform/efl/fast/frames/viewsource-attribute-expected.txt:
      * platform/efl/fast/frames/viewsource-on-image-file-expected.txt:
      * platform/efl/fast/images/favicon-as-image-expected.txt:
      * platform/efl/fast/overflow/scrollRevealButton-expected.txt:
      * platform/efl/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
      * platform/efl/fast/repaint/line-flow-with-floats-1-expected.txt:
      * platform/efl/fast/repaint/line-flow-with-floats-10-expected.txt:
      * platform/efl/fast/repaint/line-flow-with-floats-2-expected.txt:
      * platform/efl/fast/repaint/line-flow-with-floats-3-expected.txt:
      * platform/efl/fast/repaint/line-flow-with-floats-4-expected.txt:
      * platform/efl/fast/repaint/line-flow-with-floats-5-expected.txt:
      * platform/efl/fast/repaint/line-flow-with-floats-6-expected.txt:
      * platform/efl/fast/repaint/line-flow-with-floats-7-expected.txt:
      * platform/efl/fast/repaint/line-flow-with-floats-8-expected.txt:
      * platform/efl/fast/repaint/line-flow-with-floats-9-expected.txt:
      * platform/efl/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
      * platform/efl/fast/replaced/007-expected.txt:
      * platform/efl/fast/replaced/border-radius-clip-expected.txt:
      * platform/efl/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
      * platform/efl/fast/replaced/replaced-breaking-expected.txt:
      * platform/efl/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
      * platform/efl/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
      * platform/efl/fast/table/quote-text-around-iframe-expected.txt:
      * platform/efl/fast/text/selection-hard-linebreak-expected.txt:
      * platform/efl/http/tests/loading/simple-subframe-expected.txt:
      * platform/efl/http/tests/local/file-url-sent-as-referer-expected.txt:
      * platform/efl/http/tests/misc/acid3-expected.txt:
      * platform/efl/http/tests/misc/favicon-as-image-expected.txt:
      * platform/efl/http/tests/misc/frame-access-during-load-expected.txt:
      * platform/efl/http/tests/misc/iframe404-expected.txt:
      * platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt:
      * platform/efl/http/tests/multipart/invalid-image-data-standalone-expected.txt:
      * platform/efl/media/media-document-audio-repaint-expected.txt:
      * platform/efl/svg/hixie/rendering-model/003-expected.txt:
      * platform/efl/svg/in-html/by-reference-expected.txt:
      * platform/efl/tables/mozilla/bugs/bug131020-expected.txt:
      * platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
      * platform/efl/tables/mozilla/bugs/bug4527-expected.txt:
      * platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
      * platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
      * platform/gtk/css2.1/20110323/absolute-replaced-height-004-expected.txt:
      * platform/gtk/css2.1/20110323/absolute-replaced-height-005-expected.txt:
      * platform/gtk/css2.1/20110323/absolute-replaced-height-007-expected.txt:
      * platform/gtk/css2.1/20110323/absolute-replaced-height-011-expected.txt:
      * platform/gtk/css2.1/20110323/absolute-replaced-height-012-expected.txt:
      * platform/gtk/css2.1/20110323/absolute-replaced-height-014-expected.txt:
      * platform/gtk/css2.1/20110323/absolute-replaced-height-018-expected.txt:
      * platform/gtk/css2.1/20110323/absolute-replaced-height-019-expected.txt:
      * platform/gtk/css2.1/20110323/absolute-replaced-height-021-expected.txt:
      * platform/gtk/css2.1/20110323/absolute-replaced-height-025-expected.txt:
      * platform/gtk/css2.1/20110323/absolute-replaced-height-026-expected.txt:
      * platform/gtk/css2.1/20110323/absolute-replaced-height-028-expected.txt:
      * platform/gtk/css2.1/20110323/absolute-replaced-height-032-expected.txt:
      * platform/gtk/css2.1/20110323/absolute-replaced-height-033-expected.txt:
      * platform/gtk/css2.1/20110323/absolute-replaced-height-035-expected.txt:
      * platform/gtk/css2.1/20110323/block-replaced-height-004-expected.txt:
      * platform/gtk/css2.1/20110323/block-replaced-height-005-expected.txt:
      * platform/gtk/css2.1/20110323/block-replaced-height-007-expected.txt:
      * platform/gtk/css2.1/20110323/float-replaced-height-004-expected.txt:
      * platform/gtk/css2.1/20110323/float-replaced-height-005-expected.txt:
      * platform/gtk/css2.1/20110323/float-replaced-height-007-expected.txt:
      * platform/gtk/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
      * platform/gtk/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
      * platform/gtk/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
      * platform/gtk/css2.1/20110323/inline-replaced-height-004-expected.txt:
      * platform/gtk/css2.1/20110323/inline-replaced-height-005-expected.txt:
      * platform/gtk/css2.1/20110323/inline-replaced-height-007-expected.txt:
      * platform/gtk/editing/execCommand/find-after-replace-expected.txt:
      * platform/gtk/editing/execCommand/paste-1-expected.txt:
      * platform/gtk/editing/pasteboard/4631972-expected.txt:
      * platform/gtk/editing/pasteboard/copy-standalone-image-expected.txt:
      * platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
      * platform/gtk/editing/pasteboard/paste-2-expected.txt:
      * platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
      * platform/gtk/editing/selection/4776665-expected.txt:
      * platform/gtk/editing/selection/4960137-expected.txt:
      * platform/gtk/editing/selection/4975120-expected.txt:
      * platform/gtk/editing/selection/drag-in-iframe-expected.txt:
      * platform/gtk/editing/selection/drag-to-contenteditable-iframe-expected.txt:
      * platform/gtk/editing/selection/iframe-expected.txt:
      * platform/gtk/editing/selection/select-all-iframe-expected.txt:
      * platform/gtk/fast/block/basic/013-expected.txt:
      * platform/gtk/fast/block/positioning/window-height-change-expected.txt:
      * platform/gtk/fast/css/line-height-overflow-expected.txt:
      * platform/gtk/fast/css/resize-corner-tracking-expected.txt:
      * platform/gtk/fast/css/resize-corner-tracking-transformed-iframe-expected.txt:
      * platform/gtk/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
      * platform/gtk/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
      * platform/gtk/fast/flexbox/016-expected.txt:
      * platform/gtk/fast/forms/basic-textareas-expected.txt:
      * platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
      * platform/gtk/fast/forms/targeted-frame-submission-expected.txt:
      * platform/gtk/fast/frames/001-expected.txt:
      * platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
      * platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
      * platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
      * platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
      * platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt:
      * platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
      * platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
      * platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
      * platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
      * platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.txt:
      * platform/gtk/fast/frames/frameElement-iframe-expected.txt:
      * platform/gtk/fast/frames/iframe-option-crash-expected.txt:
      * platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt:
      * platform/gtk/fast/frames/iframe-with-frameborder-expected.txt:
      * platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
      * platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt:
      * platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
      * platform/gtk/fast/frames/viewsource-attribute-expected.txt:
      * platform/gtk/fast/frames/viewsource-on-image-file-expected.txt:
      * platform/gtk/fast/images/favicon-as-image-expected.txt:
      * platform/gtk/fast/overflow/scrollRevealButton-expected.txt:
      * platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
      * platform/gtk/fast/repaint/iframe-scroll-repaint-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-1-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-10-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-2-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-3-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-4-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-5-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-6-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-7-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-8-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-9-expected.txt:
      * platform/gtk/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
      * platform/gtk/fast/replaced/007-expected.txt:
      * platform/gtk/fast/replaced/border-radius-clip-expected.txt:
      * platform/gtk/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
      * platform/gtk/fast/replaced/replaced-breaking-expected.txt:
      * platform/gtk/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
      * platform/gtk/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
      * platform/gtk/fast/table/quote-text-around-iframe-expected.txt:
      * platform/gtk/fast/text/selection-hard-linebreak-expected.txt:
      * platform/gtk/http/tests/loading/simple-subframe-expected.txt:
      * platform/gtk/http/tests/local/file-url-sent-as-referer-expected.txt:
      * platform/gtk/http/tests/misc/favicon-as-image-expected.txt:
      * platform/gtk/http/tests/misc/frame-access-during-load-expected.txt:
      * platform/gtk/http/tests/misc/iframe404-expected.txt:
      * platform/gtk/http/tests/misc/location-replace-crossdomain-expected.txt:
      * platform/gtk/http/tests/multipart/invalid-image-data-standalone-expected.txt:
      * platform/gtk/media/media-document-audio-repaint-expected.txt:
      * platform/gtk/plugins/iframe-plugin-bgcolor-expected.txt:
      * platform/gtk/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
      * platform/gtk/svg/custom/embedding-external-svgs-expected.txt:
      * platform/gtk/svg/hixie/rendering-model/003-expected.txt:
      * platform/gtk/svg/in-html/by-reference-expected.txt:
      * platform/gtk/tables/mozilla/bugs/bug131020-expected.txt:
      * platform/gtk/tables/mozilla/bugs/bug38916-expected.txt:
      * platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
      * platform/iphone-simulator/text-autosizing/contenteditable-expected.txt:
      * platform/mac-mountainlion/editing/selection/4975120-expected.txt:
      * platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt:
      * platform/mac-mountainlion/fast/forms/tabbing-input-iframe-expected.txt:
      * platform/mac-mountainlion/fast/frames/take-focus-from-iframe-expected.txt:
      * platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt:
      * platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt:
      * platform/mac-wk2/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
      * platform/mac/compositing/iframes/composited-iframe-alignment-expected.txt:
      * platform/mac/compositing/iframes/iframe-copy-on-scroll-expected.txt:
      * platform/mac/compositing/iframes/iframe-in-composited-layer-expected.txt:
      * platform/mac/css2.1/20110323/absolute-replaced-height-004-expected.txt:
      * platform/mac/css2.1/20110323/absolute-replaced-height-005-expected.txt:
      * platform/mac/css2.1/20110323/absolute-replaced-height-007-expected.txt:
      * platform/mac/css2.1/20110323/absolute-replaced-height-011-expected.txt:
      * platform/mac/css2.1/20110323/absolute-replaced-height-012-expected.txt:
      * platform/mac/css2.1/20110323/absolute-replaced-height-014-expected.txt:
      * platform/mac/css2.1/20110323/absolute-replaced-height-018-expected.txt:
      * platform/mac/css2.1/20110323/absolute-replaced-height-019-expected.txt:
      * platform/mac/css2.1/20110323/absolute-replaced-height-021-expected.txt:
      * platform/mac/css2.1/20110323/absolute-replaced-height-025-expected.txt:
      * platform/mac/css2.1/20110323/absolute-replaced-height-026-expected.txt:
      * platform/mac/css2.1/20110323/absolute-replaced-height-028-expected.txt:
      * platform/mac/css2.1/20110323/absolute-replaced-height-032-expected.txt:
      * platform/mac/css2.1/20110323/absolute-replaced-height-033-expected.txt:
      * platform/mac/css2.1/20110323/absolute-replaced-height-035-expected.txt:
      * platform/mac/css2.1/20110323/block-replaced-height-004-expected.txt:
      * platform/mac/css2.1/20110323/block-replaced-height-005-expected.txt:
      * platform/mac/css2.1/20110323/block-replaced-height-007-expected.txt:
      * platform/mac/css2.1/20110323/float-replaced-height-004-expected.txt:
      * platform/mac/css2.1/20110323/float-replaced-height-005-expected.txt:
      * platform/mac/css2.1/20110323/float-replaced-height-007-expected.txt:
      * platform/mac/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
      * platform/mac/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
      * platform/mac/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
      * platform/mac/css2.1/20110323/inline-replaced-height-004-expected.txt:
      * platform/mac/css2.1/20110323/inline-replaced-height-005-expected.txt:
      * platform/mac/css2.1/20110323/inline-replaced-height-007-expected.txt:
      * platform/mac/editing/execCommand/find-after-replace-expected.txt:
      * platform/mac/editing/execCommand/paste-1-expected.txt:
      * platform/mac/editing/pasteboard/4631972-expected.txt:
      * platform/mac/editing/pasteboard/copy-standalone-image-expected.txt:
      * platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
      * platform/mac/editing/pasteboard/paste-2-expected.txt:
      * platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.txt:
      * platform/mac/editing/selection/4776665-expected.txt:
      * platform/mac/editing/selection/4960137-expected.txt:
      * platform/mac/editing/selection/4975120-expected.txt:
      * platform/mac/editing/selection/drag-in-iframe-expected.txt:
      * platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:
      * platform/mac/editing/selection/iframe-expected.txt:
      * platform/mac/editing/selection/select-all-iframe-expected.txt:
      * platform/mac/fast/block/basic/013-expected.txt:
      * platform/mac/fast/block/positioning/window-height-change-expected.txt:
      * platform/mac/fast/css/line-height-overflow-expected.txt:
      * platform/mac/fast/css/resize-corner-tracking-transformed-iframe-expected.txt:
      * platform/mac/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
      * platform/mac/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
      * platform/mac/fast/flexbox/016-expected.txt:
      * platform/mac/fast/forms/basic-textareas-expected.txt:
      * platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
      * platform/mac/fast/forms/targeted-frame-submission-expected.txt:
      * platform/mac/fast/frames/001-expected.txt:
      * platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
      * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
      * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
      * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
      * platform/mac/fast/frames/flattening/iframe-flattening-nested-expected.txt:
      * platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
      * platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
      * platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
      * platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
      * platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt:
      * platform/mac/fast/frames/frameElement-iframe-expected.txt:
      * platform/mac/fast/frames/iframe-option-crash-expected.txt:
      * platform/mac/fast/frames/iframe-scrolling-attribute-expected.txt:
      * platform/mac/fast/frames/iframe-with-frameborder-expected.txt:
      * platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
      * platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
      * platform/mac/fast/frames/viewsource-attribute-expected.txt:
      * platform/mac/fast/frames/viewsource-on-image-file-expected.txt:
      * platform/mac/fast/images/favicon-as-image-expected.txt:
      * platform/mac/fast/overflow/scrollRevealButton-expected.txt:
      * platform/mac/fast/repaint/4774354-expected.txt:
      * platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
      * platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
      * platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
      * platform/mac/fast/replaced/007-expected.txt:
      * platform/mac/fast/replaced/border-radius-clip-expected.txt:
      * platform/mac/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
      * platform/mac/fast/replaced/replaced-breaking-expected.txt:
      * platform/mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
      * platform/mac/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
      * platform/mac/fast/table/quote-text-around-iframe-expected.txt:
      * platform/mac/fast/text/selection-hard-linebreak-expected.txt:
      * platform/mac/http/tests/loading/simple-subframe-expected.txt:
      * platform/mac/http/tests/local/file-url-sent-as-referer-expected.txt:
      * platform/mac/http/tests/misc/acid3-expected.txt:
      * platform/mac/http/tests/misc/favicon-as-image-expected.txt:
      * platform/mac/http/tests/misc/frame-access-during-load-expected.txt:
      * platform/mac/http/tests/misc/iframe404-expected.txt:
      * platform/mac/http/tests/misc/location-replace-crossdomain-expected.txt:
      * platform/mac/http/tests/multipart/invalid-image-data-standalone-expected.txt:
      * platform/mac/plugins/update-widget-from-style-recalc-expected.txt:
      * platform/mac/plugins/update-widget-from-style-recalc.html:
      * platform/mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
      * platform/mac/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
      * platform/mac/svg/custom/embedding-external-svgs-expected.txt:
      * platform/mac/svg/hixie/rendering-model/003-expected.txt:
      * platform/mac/svg/in-html/by-reference-expected.txt:
      * platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
      * platform/mac/tables/mozilla/bugs/bug38916-expected.txt:
      * platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
      * platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
      * platform/win-xp/media/media-document-audio-repaint-expected.txt:
      * platform/win/http/tests/misc/acid3-expected.txt:
      * plugins/iframe-plugin-bgcolor-expected.txt:
      * printing/iframe-print-expected.txt:
      * scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
      * scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
      * svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
      * tables/mozilla/bugs/bug137388-1-expected.txt:
      * tables/mozilla/bugs/bug137388-2-expected.txt:
      * tables/mozilla/bugs/bug137388-3-expected.txt:
      * tables/mozilla/bugs/bug50695-2-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27c741cd
  18. 07 Nov, 2013 1 commit
    • m.pakula@samsung.com's avatar
      Unreviewed gardening · 1b586c09
      m.pakula@samsung.com authored
      Adjust test expectations after r158743.
      
      * fullscreen/video-controls-override-expected.txt:
      * http/tests/media/video-cookie-expected.txt:
      * media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt:
      * media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt:
      * media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt:
      * media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt:
      * media/context-menu-actions-expected.txt:
      * media/media-can-play-flac-audio-expected.txt:
      * media/media-volume-slider-rendered-below-expected.txt:
      * media/media-volume-slider-rendered-normal-expected.txt:
      * media/track/audio/audio-track-mkv-vorbis-addtrack-expected.txt:
      * media/track/audio/audio-track-mkv-vorbis-enabled-expected.txt:
      * media/track/track-cue-mutable-text-expected.txt:
      * media/track/track-cue-rendering-mode-changed-expected.txt:
      * media/track/track-language-preference-expected.txt:
      * media/track/video/video-track-mkv-theora-addtrack-expected.txt:
      * media/video-controls-fullscreen-volume-expected.txt:
      * media/video-controls-toggling-expected.txt:
      * media/video-controls-visible-exiting-fullscreen-expected.txt:
      * media/video-seek-past-end-paused-expected.txt:
      * platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
      * platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt:
      * platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
      * platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt:
      * platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
      * platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
      * platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt:
      * platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt:
      * platform/efl/media/media-can-play-webm-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b586c09
  19. 06 Nov, 2013 1 commit
    • cfleizach@apple.com's avatar
      AX: Audio and Video attachments are not output to VoiceOver · 825194c1
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123479
      
      Reviewed by Mario Sanchez Prada.
      
      Source/WebCore:
      
      Video and audio elements don't appear as distinct objects in the AX hierarchy,
      nor are they treated as replaceable objects when emitting the text. We should
      treat these characters like attachments, for one. On the Mac platform, we should
      also identify them with special subroles.
      
      Tests: platform/mac/accessibility/media-emits-object-replacement.html
             platform/mac/accessibility/media-role-descriptions.html
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::isGenericFocusableElement):
      * accessibility/AccessibilityObject.h:
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (createAccessibilityRoleMap):
      (-[WebAccessibilityObjectWrapper subrole]):
      (-[WebAccessibilityObjectWrapper roleDescription]):
      * editing/TextIterator.cpp:
      (WebCore::isRendererReplacedElement):
      
      LayoutTests:
      
      Making media elements int replaced elements has the unfortunate side-effect
      of causing a new line to be inserted into any test using a <video> or <audio> tag.
      
      * compositing/video/video-poster-expected.txt:
      * compositing/video/video-reflection-expected.txt:
      * compositing/visibility/visibility-simple-video-layer-expected.txt:
      * fast/css/first-letter-block-form-controls-crash-expected.txt:
      * fast/css/relative-position-replaced-in-table-display-crash-expected.txt:
      * fast/forms/access-key-for-all-elements-expected.txt:
      * fast/forms/form-associated-element-crash3-expected.txt:
      * fast/multicol/renderer-positioned-assert-crash-expected.txt:
      * fast/regions/full-screen-video-from-region-expected.txt:
      * fast/runin/nonblock-runin-expected.txt:
      * fast/spatial-navigation/snav-media-elements-expected.txt:
      * fullscreen/full-screen-crash-offsetLeft-expected.txt:
      * fullscreen/full-screen-no-style-sharing-expected.txt:
      * fullscreen/full-screen-stacking-context-expected.txt:
      * fullscreen/video-controls-drag-expected.txt:
      * fullscreen/video-controls-timeline-expected.txt:
      * fullscreen/video-cursor-auto-hide-expected.txt:
      * fullscreen/video-specified-size-expected.txt:
      * http/tests/appcache/video-expected.txt:
      * http/tests/media/pdf-served-as-pdf-expected.txt:
      * http/tests/media/reload-after-dialog-expected.txt:
      * http/tests/media/text-served-as-text-expected.txt:
      * http/tests/media/video-accept-encoding-expected.txt:
      * http/tests/media/video-buffered-range-contains-currentTime-expected.txt:
      * http/tests/media/video-cross-site-expected.txt:
      * http/tests/media/video-error-abort-expected.txt:
      * http/tests/media/video-load-suspend-expected.txt:
      * http/tests/media/video-play-progress-expected.txt:
      * http/tests/media/video-play-stall-before-meta-data-expected.txt:
      * http/tests/media/video-preload-expected.txt:
      * http/tests/media/video-redirect-expected.txt:
      * http/tests/media/video-referer-expected.txt:
      * http/tests/media/video-served-as-text-expected.txt:
      * http/tests/media/video-throttled-load-metadata-expected.txt:
      * http/tests/misc/empty-urls-expected.txt:
      * http/tests/security/contentSecurityPolicy/media-src-allowed-expected.txt:
      * http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
      * http/tests/security/local-video-poster-from-remote-expected.txt:
      * http/tests/security/local-video-source-from-remote-expected.txt:
      * http/tests/security/local-video-src-from-remote-expected.txt:
      * http/tests/security/text-track-crossorigin-expected.txt:
      * media/W3C/audio/events/event_canplay-expected.txt:
      * media/W3C/audio/events/event_canplay_manual-expected.txt:
      * media/W3C/audio/events/event_canplaythrough-expected.txt:
      * media/W3C/audio/events/event_canplaythrough_manual-expected.txt:
      * media/W3C/audio/events/event_loadeddata-expected.txt:
      * media/W3C/audio/events/event_loadeddata_manual-expected.txt:
      * media/W3C/audio/events/event_loadedmetadata-expected.txt:
      * media/W3C/audio/events/event_loadedmetadata_manual-expected.txt:
      * media/W3C/audio/events/event_loadstart-expected.txt:
      * media/W3C/audio/events/event_loadstart_manual-expected.txt:
      * media/W3C/audio/events/event_order_canplay_canplaythrough-expected.txt:
      * media/W3C/audio/events/event_order_canplay_playing-expected.txt:
      * media/W3C/audio/events/event_order_loadedmetadata_loadeddata-expected.txt:
      * media/W3C/audio/events/event_order_loadstart_progress-expected.txt:
      * media/W3C/audio/events/event_pause_manual-expected.txt:
      * media/W3C/audio/events/event_play-expected.txt:
      * media/W3C/audio/events/event_play_manual-expected.txt:
      * media/W3C/audio/events/event_playing-expected.txt:
      * media/W3C/audio/events/event_playing_manual-expected.txt:
      * media/W3C/audio/events/event_progress-expected.txt:
      * media/W3C/audio/events/event_progress_manual-expected.txt:
      * media/W3C/audio/events/event_timeupdate-expected.txt:
      * media/W3C/audio/events/event_timeupdate_manual-expected.txt:
      * media/W3C/audio/networkState/networkState_during_loadstart-expected.txt:
      * media/W3C/audio/paused/paused_false_during_play-expected.txt:
      * media/W3C/audio/paused/paused_true_during_pause-expected.txt:
      * media/W3C/audio/readyState/readyState_during_canplay-expected.txt:
      * media/W3C/audio/readyState/readyState_during_canplaythrough-expected.txt:
      * media/W3C/audio/readyState/readyState_during_loadeddata-expected.txt:
      * media/W3C/audio/readyState/readyState_during_loadedmetadata-expected.txt:
      * media/W3C/audio/readyState/readyState_during_playing-expected.txt:
      * media/W3C/video/canPlayType/canPlayType_application_octet_stream-expected.txt:
      * media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_1-expected.txt:
      * media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_2-expected.txt:
      * media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_3-expected.txt:
      * media/W3C/video/canPlayType/canPlayType_bogus_type-expected.txt:
      * media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
      * media/W3C/video/canPlayType/canPlayType_method_exists-expected.txt:
      * media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
      * media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
      * media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
      * media/W3C/video/currentSrc/currentSrc_empty_if_no_src-expected.txt:
      * media/W3C/video/currentSrc/currentSrc_property_exists-expected.txt:
      * media/W3C/video/error/error_null-expected.txt:
      * media/W3C/video/error/error_onerror_called_on_bogus_source-expected.txt:
      * media/W3C/video/error/error_property_exists-expected.txt:
      * media/W3C/video/events/event_canplay-expected.txt:
      * media/W3C/video/events/event_canplay_manual-expected.txt:
      * media/W3C/video/events/event_canplaythrough-expected.txt:
      * media/W3C/video/events/event_canplaythrough_manual-expected.txt:
      * media/W3C/video/events/event_loadeddata-expected.txt:
      * media/W3C/video/events/event_loadeddata_manual-expected.txt:
      * media/W3C/video/events/event_loadedmetadata-expected.txt:
      * media/W3C/video/events/event_loadedmetadata_manual-expected.txt:
      * media/W3C/video/events/event_loadstart-expected.txt:
      * media/W3C/video/events/event_loadstart_manual-expected.txt:
      * media/W3C/video/events/event_order_canplay_canplaythrough-expected.txt:
      * media/W3C/video/events/event_order_canplay_playing-expected.txt:
      * media/W3C/video/events/event_order_loadedmetadata_loadeddata-expected.txt:
      * media/W3C/video/events/event_order_loadstart_progress-expected.txt:
      * media/W3C/video/events/event_pause_manual-expected.txt:
      * media/W3C/video/events/event_play-expected.txt:
      * media/W3C/video/events/event_play_manual-expected.txt:
      * media/W3C/video/events/event_playing-expected.txt:
      * media/W3C/video/events/event_playing_manual-expected.txt:
      * media/W3C/video/events/event_progress-expected.txt:
      * media/W3C/video/events/event_progress_manual-expected.txt:
      * media/W3C/video/events/event_timeupdate-expected.txt:
      * media/W3C/video/events/event_timeupdate_manual-expected.txt:
      * media/W3C/video/networkState/networkState_during_loadstart-expected.txt:
      * media/W3C/video/networkState/networkState_during_progress-expected.txt:
      * media/W3C/video/networkState/networkState_initial-expected.txt:
      * media/W3C/video/networkState/networkState_property_exists-expected.txt:
      * media/W3C/video/paused/paused_false_during_play-expected.txt:
      * media/W3C/video/paused/paused_true_during_pause-expected.txt:
      * media/W3C/video/preload/preload_property_exists-expected.txt:
      * media/W3C/video/preload/preload_reflects_auto_value-expected.txt:
      * media/W3C/video/preload/preload_reflects_bogus_value-expected.txt:
      * media/W3C/video/preload/preload_reflects_empty-expected.txt:
      * media/W3C/video/preload/preload_reflects_metadata-expected.txt:
      * media/W3C/video/preload/preload_reflects_no_value-expected.txt:
      * media/W3C/video/preload/preload_reflects_none-expected.txt:
      * media/W3C/video/preload/preload_reflects_none_autoplay-expected.txt:
      * media/W3C/video/readyState/readyState_during_canplay-expected.txt:
      * media/W3C/video/readyState/readyState_during_canplaythrough-expected.txt:
      * media/W3C/video/readyState/readyState_during_loadeddata-expected.txt:
      * media/W3C/video/readyState/readyState_during_loadedmetadata-expected.txt:
      * media/W3C/video/readyState/readyState_during_playing-expected.txt:
      * media/W3C/video/readyState/readyState_initial-expected.txt:
      * media/W3C/video/readyState/readyState_property_exists-expected.txt:
      * media/W3C/video/src/src_reflects_attribute_not_source_elements-expected.txt:
      * media/W3C/video/src/src_reflects_no_value-expected.txt:
      * media/W3C/video/src/src_removal_does_not_trigger_loadstart-expected.txt:
      * media/audio-mpeg-supported-expected.txt:
      * media/audio-mpeg4-supported-expected.txt:
      * media/audio-only-video-intrinsic-size-expected.txt:
      * media/auto-play-in-sandbox-with-allow-scripts-expected.txt:
      * media/before-load-member-access-expected.txt:
      * media/broken-video-expected.txt:
      * media/constructors-expected.txt:
      * media/controls-css-overload-expected.txt:
      * media/controls-drag-timebar-expected.txt:
      * media/controls-layout-direction-expected.txt:
      * media/controls-right-click-on-timebar-expected.txt:
      * media/csp-blocks-video-expected.txt:
      * media/event-attributes-expected.txt:
      * media/media-blocked-by-beforeload-expected.txt:
      * media/media-blocked-by-willsendrequest-expected.txt:
      * media/media-can-play-mpeg-audio-expected.txt:
      * media/media-can-play-mpeg4-video-expected.txt:
      * media/media-can-play-octet-stream-expected.txt:
      * media/media-can-play-type-expected.txt:
      * media/media-can-play-wav-audio-expected.txt:
      * media/media-captions-expected.txt:
      * media/media-captions-no-controls-expected.txt:
      * media/media-controller-expected.txt:
      * media/media-controller-playback-expected.txt:
      * media/media-controller-playbackrate-expected.txt:
      * media/media-controller-time-clamp-expected.txt:
      * media/media-controller-time-constant-expected.txt:
      * media/media-controller-time-expected.txt:
      * media/media-controller-timeupdate-expected.txt:
      * media/media-controller-unpause-expected.txt:
      * media/media-controls-invalid-url-expected.txt:
      * media/media-ended-expected.txt:
      * media/media-extension-with-fragment-expected.txt:
      * media/media-fragments/TC0001-expected.txt:
      * media/media-fragments/TC0002-expected.txt:
      * media/media-fragments/TC0003-expected.txt:
      * media/media-fragments/TC0004-expected.txt:
      * media/media-fragments/TC0005-expected.txt:
      * media/media-fragments/TC0006-expected.txt:
      * media/media-fragments/TC0009-expected.txt:
      * media/media-fragments/TC0011-expected.txt:
      * media/media-fragments/TC0012-expected.txt:
      * media/media-fragments/TC0014-expected.txt:
      * media/media-fragments/TC0015-expected.txt:
      * media/media-fragments/TC0017-expected.txt:
      * media/media-fragments/TC0024-expected.txt:
      * media/media-fragments/TC0027-expected.txt:
      * media/media-fragments/TC0028-expected.txt:
      * media/media-fragments/TC0029-expected.txt:
      * media/media-fragments/TC0030-expected.txt:
      * media/media-fragments/TC0031-expected.txt:
      * media/media-fragments/TC0032-expected.txt:
      * media/media-fragments/TC0033-expected.txt:
      * media/media-fragments/TC0034-expected.txt:
      * media/media-fragments/TC0035-expected.txt:
      * media/media-fragments/TC0036-expected.txt:
      * media/media-fragments/TC0037-expected.txt:
      * media/media-fragments/TC0038-expected.txt:
      * media/media-fragments/TC0039-expected.txt:
      * media/media-fragments/TC0044-expected.txt:
      * media/media-fragments/TC0051-expected.txt:
      * media/media-fragments/TC0052-expected.txt:
      * media/media-fragments/TC0053-expected.txt:
      * media/media-fragments/TC0054-expected.txt:
      * media/media-fragments/TC0055-expected.txt:
      * media/media-fragments/TC0058-expected.txt:
      * media/media-fragments/TC0059-expected.txt:
      * media/media-fragments/TC0061-expected.txt:
      * media/media-fragments/TC0062-expected.txt:
      * media/media-fragments/TC0063-expected.txt:
      * media/media-fragments/TC0064-expected.txt:
      * media/media-fragments/TC0065-expected.txt:
      * media/media-fragments/TC0066-expected.txt:
      * media/media-fragments/TC0067-expected.txt:
      * media/media-fragments/TC0068-expected.txt:
      * media/media-fragments/TC0069-expected.txt:
      * media/media-fragments/TC0070-expected.txt:
      * media/media-fragments/TC0071-expected.txt:
      * media/media-fragments/TC0072-expected.txt:
      * media/media-fragments/TC0073-expected.txt:
      * media/media-fragments/TC0074-expected.txt:
      * media/media-fragments/TC0075-expected.txt:
      * media/media-fragments/TC0076-expected.txt:
      * media/media-fragments/TC0077-expected.txt:
      * media/media-fragments/TC0078-expected.txt:
      * media/media-fragments/TC0079-expected.txt:
      * media/media-fragments/TC0080-expected.txt:
      * media/media-fragments/TC0081-expected.txt:
      * media/media-fragments/TC0082-expected.txt:
      * media/media-fragments/TC0083-expected.txt:
      * media/media-fragments/TC0084-expected.txt:
      * media/media-fragments/TC0085-expected.txt:
      * media/media-fragments/TC0086-expected.txt:
      * media/media-fragments/TC0087-expected.txt:
      * media/media-fragments/TC0088-expected.txt:
      * media/media-fragments/TC0089-expected.txt:
      * media/media-fragments/TC0090-expected.txt:
      * media/media-fragments/TC0091-expected.txt:
      * media/media-fragments/TC0092-expected.txt:
      * media/media-fragments/TC0093-expected.txt:
      * media/media-fragments/TC0094-expected.txt:
      * media/media-fullscreen-inline-expected.txt:
      * media/media-preload-no-delay-loadevent-expected.txt:
      * media/no-autoplay-with-user-gesture-requirement-expected.txt:
      * media/nodesFromRect-shadowContent-expected.txt:
      * media/restore-from-page-cache-expected.txt:
      * media/sources-fallback-codecs-expected.txt:
      * media/track/add-and-remove-track-expected.txt:
      * media/track/audio-track-expected.txt:
      * media/track/opera/interfaces/TextTrack/addCue-expected.txt:
      * media/track/opera/interfaces/TextTrack/removeCue-expected.txt:
      * media/track/opera/interfaces/TextTrackCue/align-expected.txt:
      * media/track/opera/interfaces/TextTrackCue/endTime-expected.txt:
      * media/track/opera/interfaces/TextTrackCue/id-expected.txt:
      * media/track/opera/interfaces/TextTrackCue/pauseOnExit-expected.txt:
      * media/track/opera/interfaces/TextTrackCue/startTime-expected.txt:
      * media/track/opera/interfaces/TextTrackCue/track-expected.txt:
      * media/track/opera/interfaces/TextTrackCueList/getCueById-expected.txt:
      * media/track/opera/interfaces/TextTrackCueList/length-expected.txt:
      * media/track/text-track-cue-is-reachable-expected.txt:
      * media/track/text-track-is-reachable-expected.txt:
      * media/track/track-active-cues-expected.txt:
      * media/track/track-add-remove-cue-expected.txt:
      * media/track/track-add-track-expected.txt:
      * media/track/track-addtrack-kind-expected.txt:
      * media/track/track-automatic-subtitles-expected.txt:
      * media/track/track-css-all-cues-expected.txt:
      * media/track/track-css-cue-lifetime-expected.txt:
      * media/track/track-css-matching-default-expected.txt:
      * media/track/track-css-matching-expected.txt:
      * media/track/track-css-matching-lang-expected.txt:
      * media/track/track-css-matching-timestamps-expected.txt:
      * media/track/track-css-property-whitelist-expected.txt:
      * media/track/track-css-user-override-expected.txt:
      * media/track/track-cue-container-rendering-position-expected.txt:
      * media/track/track-cue-empty-text-crash-expected.txt:
      * media/track/track-cue-inline-assertion-crash-expected.txt:
      * media/track/track-cue-mutable-expected.txt:
      * media/track/track-cue-mutable-fragment-expected.txt:
      * media/track/track-cue-negative-timestamp-expected.txt:
      * media/track/track-cue-nothing-to-render-expected.txt:
      * media/track/track-cue-overlap-snap-to-lines-not-set-expected.txt:
      * media/track/track-cue-rendering-empty-cue-crash-expected.txt:
      * media/track/track-cue-rendering-expected.txt:
      * media/track/track-cue-rendering-on-resize-expected.txt:
      * media/track/track-cue-rendering-rtl-expected.txt:
      * media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt:
      * media/track/track-cue-rendering-tree-is-removed-properly-expected.txt:
      * media/track/track-cue-rendering-with-padding-expected.txt:
      * media/track/track-cues-cuechange-expected.txt:
      * media/track/track-cues-enter-exit-expected.txt:
      * media/track/track-cues-missed-expected.txt:
      * media/track/track-cues-pause-on-exit-expected.txt:
      * media/track/track-cues-seeking-expected.txt:
      * media/track/track-cues-sorted-before-dispatch-expected.txt:
      * media/track/track-default-attribute-expected.txt:
      * media/track/track-disabled-addcue-expected.txt:
      * media/track/track-disabled-expected.txt:
      * media/track/track-element-load-event-expected.txt:
      * media/track/track-in-band-cues-added-once-expected.txt:
      * media/track/track-in-band-duplicate-tracks-when-source-changes-expected.txt:
      * media/track/track-in-band-expected.txt:
      * media/track/track-in-band-legacy-api-expected.txt:
      * media/track/track-in-band-style-expected.txt:
      * media/track/track-kind-expected.txt:
      * media/track/track-large-timestamp-expected.txt:
      * media/track/track-legacyapi-with-automatic-mode-expected.txt:
      * media/track/track-load-from-element-readyState-expected.txt:
      * media/track/track-load-from-src-readyState-expected.txt:
      * media/track/track-long-captions-file-expected.txt:
      * media/track/track-mode-disabled-crash-expected.txt:
      * media/track/track-mode-expected.txt:
      * media/track/track-mode-not-changed-by-new-track-expected.txt:
      * media/track/track-mode-triggers-loading-expected.txt:
      * media/track/track-remove-active-cue-crash-expected.txt:
      * media/track/track-remove-by-setting-innerHTML-expected.txt:
      * media/track/track-remove-quickly-expected.txt:
      * media/track/track-text-track-cue-list-expected.txt:
      * media/track/track-texttracks-expected.txt:
      * media/track/track-webvtt-tc000-empty-expected.txt:
      * media/track/track-webvtt-tc001-utf8-expected.txt:
      * media/track/track-webvtt-tc002-bom-expected.txt:
      * media/track/track-webvtt-tc003-newlines-expected.txt:
      * media/track/track-webvtt-tc004-magic-header-expected.txt:
      * media/track/track-webvtt-tc005-header-comment-expected.txt:
      * media/track/track-webvtt-tc006-cue-identifiers-expected.txt:
      * media/track/track-webvtt-tc007-cue-no-id-expected.txt:
      * media/track/track-webvtt-tc008-timings-no-hours-expected.txt:
      * media/track/track-webvtt-tc009-timings-hour-expected.txt:
      * media/track/track-webvtt-tc010-no-timings-expected.txt:
      * media/track/track-webvtt-tc011-blank-lines-expected.txt:
      * media/track/track-webvtt-tc013-settings-expected.txt:
      * media/track/track-webvtt-tc014-alignment-expected.txt:
      * media/track/track-webvtt-tc015-positioning-expected.txt:
      * media/track/track-webvtt-tc016-align-positioning-expected.txt:
      * media/track/track-webvtt-tc017-line-position-expected.txt:
      * media/track/track-webvtt-tc018-align-text-line-position-expected.txt:
      * media/track/track-webvtt-tc019-cue-size-expected.txt:
      * media/track/track-webvtt-tc020-cue-size-align-expected.txt:
      * media/track/track-webvtt-tc021-valign-expected.txt:
      * media/track/track-webvtt-tc022-entities-expected.txt:
      * media/track/track-webvtt-tc023-markup-expected.txt:
      * media/track/track-webvtt-tc024-timestamp-expected.txt:
      * media/track/track-webvtt-tc025-class-markup-expected.txt:
      * media/track/track-webvtt-tc026-voice-expected.txt:
      * media/track/track-webvtt-tc027-empty-cue-expected.txt:
      * media/track/track-webvtt-tc028-unsupported-markup-expected.txt:
      * media/track/track-word-breaking-expected.txt:
      * media/track/tracklist-is-reachable-expected.txt:
      * media/track/video-track-expected.txt:
      * media/unsupported-rtsp-expected.txt:
      * media/unsupported-tracks-expected.txt:
      * media/video-append-source-expected.txt:
      * media/video-autoplay-expected.txt:
      * media/video-beforeload-remove-source-expected.txt:
      * media/video-buffered-expected.txt:
      * media/video-canvas-drawing-expected.txt:
      * media/video-canvas-drawing-output-expected.txt:
      * media/video-controls-captions-trackmenu-hide-on-click-outside-expected.txt:
      * media/video-controls-captions-trackmenu-includes-enabled-track-expected.txt:
      * media/video-controls-expected.txt:
      * media/video-controls-transformed-expected.txt:
      * media/video-controls-with-mutation-event-handler-expected.txt:
      * media/video-controls-zoomed-expected.txt:
      * media/video-currentTime-delay-expected.txt:
      * media/video-currentTime-expected.txt:
      * media/video-currentTime-set-expected.txt:
      * media/video-currentTime-set2-expected.txt:
      * media/video-delay-load-event-expected.txt:
      * media/video-display-aspect-ratio-expected.txt:
      * media/video-dom-autoplay-expected.txt:
      * media/video-dom-preload-expected.txt:
      * media/video-dom-src-expected.txt:
      * media/video-duration-known-after-eos-expected.txt:
      * media/video-error-does-not-exist-expected.txt:
      * media/video-load-networkState-expected.txt:
      * media/video-load-preload-metadata-expected.txt:
      * media/video-load-preload-none-expected.txt:
      * media/video-load-readyState-expected.txt:
      * media/video-load-require-user-gesture-expected.txt:
      * media/video-loop-expected.txt:
      * media/video-mouse-focus-expected.txt:
      * media/video-muted-expected.txt:
      * media/video-no-autoplay-expected.txt:
      * media/video-pause-empty-events-expected.txt:
      * media/video-pause-immediately-expected.txt:
      * media/video-play-empty-events-expected.txt:
      * media/video-play-pause-events-expected.txt:
      * media/video-play-pause-exception-expected.txt:
      * media/video-play-require-user-gesture-expected.txt:
      * media/video-playbackrate-expected.txt:
      * media/video-played-collapse-expected.txt:
      * media/video-played-ranges-1-expected.txt:
      * media/video-played-reset-expected.txt:
      * media/video-plays-past-end-of-test-expected.txt:
      * media/video-poster-blocked-by-willsendrequest-expected.txt:
      * media/video-poster-delayed-expected.txt:
      * media/video-poster-expected.txt:
      * media/video-poster-scale-expected.txt:
      * media/video-preload-expected.txt:
      * media/video-replaces-poster-expected.txt:
      * media/video-reverse-play-duration-expected.txt:
      * media/video-seek-after-end-expected.txt:
      * media/video-seek-by-small-increment-expected.txt:
      * media/video-seek-multiple-expected.txt:
      * media/video-seek-no-src-exception-expected.txt:
      * media/video-seek-past-end-playing-expected.txt:
      * media/video-seekable-expected.txt:
      * media/video-seeking-expected.txt:
      * media/video-set-rate-from-pause-expected.txt:
      * media/video-single-valid-source-expected.txt:
      * media/video-size-expected.txt:
      * media/video-source-error-expected.txt:
      * media/video-source-error-no-candidate-expected.txt:
      * media/video-source-expected.txt:
      * media/video-source-inserted-expected.txt:
      * media/video-source-load-expected.txt:
      * media/video-source-none-supported-expected.txt:
      * media/video-source-type-expected.txt:
      * media/video-src-blob-expected.txt:
      * media/video-src-change-expected.txt:
      * media/video-src-empty-expected.txt:
      * media/video-src-expected.txt:
      * media/video-src-invalid-poster-expected.txt:
      * media/video-src-invalid-remove-expected.txt:
      * media/video-src-none-expected.txt:
      * media/video-src-plus-source-expected.txt:
      * media/video-src-remove-expected.txt:
      * media/video-src-set-expected.txt:
      * media/video-src-source-expected.txt:
      * media/video-timeupdate-during-playback-expected.txt:
      * media/video-timeupdate-reverse-play-expected.txt:
      * media/video-volume-expected.txt:
      * media/video-width-height-expected.txt:
      * platform/mac/accessibility/media-element-expected.txt:
      * platform/mac/accessibility/media-emits-object-replacement-expected.txt: Added.
      * platform/mac/accessibility/media-emits-object-replacement.html: Added.
      * platform/mac/accessibility/media-role-descriptions-expected.txt: Added.
      * platform/mac/accessibility/media-role-descriptions.html: Added.
      * platform/mac/compositing/video/video-object-fit-expected.txt:
      * platform/mac/fullscreen/video-controls-override-expected.txt:
      * platform/mac/media/media-can-play-wav-audio-expected.txt:
      * platform/mac/media/media-can-play-webm-expected.txt:
      * platform/mac/media/video-seek-past-end-paused-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      825194c1
  20. 05 Nov, 2013 1 commit
  21. 01 Nov, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Expose setApplicationCacheOriginQuota via window.internals · f40ba124
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87838
      
      Patch by Afonso R. Costa Jr. <afonso.costa@samsung.com> on 2013-11-01
      Reviewed by Joseph Pecoraro.
      
      Source/WebCore:
      
      Also reset the default origin quota in resetToConsistentState().
      
      * testing/Internals.cpp: Add setApplicationCacheOriginQuota.
      (WebCore::Internals::resetToConsistentState): Reset the default origin
      quota.
      (WebCore::Internals::setApplicationCacheOriginQuota): Added.
      * testing/Internals.h: Add setApplicationCacheOriginQuota.
      * testing/Internals.idl: Ditto.
      
      Source/WebKit:
      
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add
      symbols for setApplicationCacheOriginQuota from Internals.
      
      Tools:
      
      * DumpRenderTree/TestRunner.cpp: Move setApplicationCacheOriginQuota
      to window.internals
      (TestRunner::staticFunctions):
      * DumpRenderTree/TestRunner.h: Ditto.
      * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setApplicationCacheOriginQuota.
      * DumpRenderTree/efl/TestRunnerEfl.cpp: Ditto.
      * DumpRenderTree/gtk/TestRunnerGtk.cpp: Ditto.
      * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
      * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Ditto.
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
      * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
      
      LayoutTests:
      
      * http/tests/appcache/origin-quota-continued-download-multiple-manifests.html: Updated
      to use setApplicationCacheOriginQuota from window.internals
      * http/tests/appcache/origin-quota-continued-download.html: Ditto.
      * http/tests/appcache/origin-quota.html: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f40ba124
  22. 31 Oct, 2013 1 commit
    • ap@apple.com's avatar
      REGRESSION(r158333): http/tests/xmlhttprequest/response-encoding.html and... · 2a262349
      ap@apple.com authored
      REGRESSION(r158333): http/tests/xmlhttprequest/response-encoding.html and xmlhttprequest-overridemimetype-content-type-header.html are failing
      https://bugs.webkit.org/show_bug.cgi?id=123548
      
      Reviewed by Brady Eidson.
      
      Source/WebCore:
      
      We had code that made sure that cached 200 responses weren't used for conditional
      requests. But it didn't work the other way - cached 304 responses got reused for
      subsequent unconditional requests!
      
      Adding the test uncovered this bug.
      
      * loader/cache/CachedRawResource.cpp: (WebCore::shouldIgnoreHeaderForCacheReuse):
      Should never ignore conditional headers. Code in determineRevalidationPolicy
      was already undoing this for conditional requests, but we also shouldn't use
      WebCore cache if it holds a 304 response to conditional request.
      
      * loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::determineRevalidationPolicy):
      Even though the changed code is only for raw resources, I think that we can never
      get a conditional request here any more.
      
      LayoutTests:
      
      * TestExpectations: Unskip tests that used to be affected by response-empty-arraybuffer.html
      
      * http/tests/xmlhttprequest/response-empty-arraybuffer-expected.txt:
      * http/tests/xmlhttprequest/response-empty-arraybuffer.html:
      Fix a stupid typo. This test actually fully passes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a262349
  23. 30 Oct, 2013 1 commit
  24. 28 Oct, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Methods on window.internals shouldn't pass a document. · 3e466981
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107301
      
      Patch by Afonso R. Costa Jr. <afonso.costa@samsung.com> on 2013-10-28
      Reviewed by Alexey Proskuryakov.
      
      Each 'Internals' instance is associated with a 'Document'. So, it
      is not necessary to pass a document as argument. Only nodesFromRect and
      layerTreeAsText methods were kept because, in some Layout Tests, the
      'Document' object is not the same used by Internals::contextDocument.
      
      Source/WebCore:
      
      * testing/Internals.cpp: Removed 'document' parameter.
      (WebCore::Internals::animationsAreSuspended):
      (WebCore::Internals::suspendAnimations):
      (WebCore::Internals::resumeAnimations):
      (WebCore::Internals::inspectorHighlightRects):
      (WebCore::Internals::inspectorHighlightObject):
      (WebCore::Internals::setScrollViewPosition):
      (WebCore::Internals::setPagination):
      (WebCore::Internals::configurationForViewport):
      (WebCore::Internals::paintControlTints):
      (WebCore::Internals::setDelegatesScrolling):
      (WebCore::Internals::touchPositionAdjustedToBestClickableNode):
      (WebCore::Internals::touchNodeAdjustedToBestClickableNode):
      (WebCore::Internals::touchPositionAdjustedToBestContextMenuNode):
      (WebCore::Internals::touchNodeAdjustedToBestContextMenuNode):
      (WebCore::Internals::bestZoomableAreaForTouchPoint):
      (WebCore::Internals::lastSpellCheckRequestSequence):
      (WebCore::Internals::lastSpellCheckProcessedSequence):
      (WebCore::Internals::wheelEventHandlerCount):
      (WebCore::Internals::touchEventHandlerCount):
      (WebCore::Internals::setBatteryStatus):
      (WebCore::Internals::setNetworkInformation):
      (WebCore::Internals::setDeviceProximity):
      (WebCore::Internals::hasSpellingMarker):
      (WebCore::Internals::hasAutocorrectedMarker):
      (WebCore::Internals::isOverwriteModeEnabled):
      (WebCore::Internals::toggleOverwriteModeEnabled):
      (WebCore::Internals::consoleMessageArgumentCounts):
      (WebCore::Internals::hasGrammarMarker):
      (WebCore::Internals::numberOfScrollableAreas):
      (WebCore::Internals::isPageBoxVisible):
      (WebCore::Internals::repaintRectsAsText):
      (WebCore::Internals::scrollingStateTreeAsText):
      (WebCore::Internals::mainThreadScrollingReasons):
      (WebCore::Internals::nonFastScrollableRects):
      (WebCore::Internals::garbageCollectDocumentResources):
      (WebCore::Internals::insertAuthorCSS):
      (WebCore::Internals::insertUserCSS):
      (WebCore::Internals::shortcutIconURLs):
      (WebCore::Internals::allIconURLs):
      (WebCore::Internals::setHeaderHeight):
      (WebCore::Internals::setFooterHeight):
      (WebCore::Internals::webkitWillEnterFullScreenForElement):
      (WebCore::Internals::webkitDidEnterFullScreenForElement):
      (WebCore::Internals::webkitWillExitFullScreenForElement):
      (WebCore::Internals::webkitDidExitFullScreenForElement):
      (WebCore::Internals::startTrackingRepaints):
      (WebCore::Internals::stopTrackingRepaints):
      (WebCore::Internals::getCurrentCursorInfo):
      * testing/Internals.h:
      (WebCore::Internals::setPagination):
      * testing/Internals.idl:
      
      LayoutTests:
      
      * animations/added-while-suspended.html: Removed 'document' parameter.
      * animations/play-state-suspend.html:
      * animations/stop-animation-on-suspend.html:
      * animations/suspend-resume-animation-events.html:
      * animations/suspend-resume-animation.html:
      * animations/suspend-transform-animation.html:
      * batterystatus/resources/event-after-navigation-new.html:
      * batterystatus/script-tests/add-listener-from-callback.js:
      (firstListener):
      * batterystatus/script-tests/basic-all-types-of-events.js:
      * batterystatus/script-tests/basic-operation.js:
      * batterystatus/script-tests/multiple-frames.js:
      * batterystatus/script-tests/updates.js:
      (setBatteryStatus):
      * compositing/columns/ancestor-clipped-in-paginated.html:
      * compositing/columns/clipped-in-paginated.html:
      * compositing/columns/composited-columns-vertical-rl.html:
      * compositing/columns/composited-in-paginated-rl.html:
      * compositing/columns/composited-in-paginated-writing-mode-rl.html:
      * compositing/columns/composited-in-paginated.html:
      * compositing/columns/composited-lr-paginated-repaint.html:
      * compositing/columns/composited-rl-paginated-repaint.html:
      * compositing/columns/geometry-map-paginated-assert.html:
      * compositing/columns/hittest-composited-in-paginated.html:
      * compositing/columns/rotated-in-paginated.html:
      * compositing/columns/untransformed-composited-in-paginated.html:
      * compositing/iframes/iframe-composited-scrolling.html:
      * compositing/layer-creation/fixed-position-in-view-dynamic.html:
      * compositing/layer-creation/fixed-position-no-content-scroll-reason.html:
      * compositing/layer-creation/fixed-position-out-of-view-dynamic.html:
      * compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html:
      * compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html:
      * compositing/overflow/dynamic-composited-scrolling-status.html:
      * compositing/overflow/scrolling-without-painting.html:
      * compositing/overflow/updating-scrolling-content.html:
      * compositing/repaint/absolute-painted-into-composited-ancestor.html:
      * compositing/repaint/fixed-background-scroll.html:
      * compositing/repaint/invalidations-on-composited-layers.html:
      * compositing/repaint/positioned-movement.html:
      * compositing/repaint/repaint-on-layer-grouping-change.html:
      * compositing/repaint/resize-repaint.html:
      * compositing/repaint/scroll-fixed-layer-no-content.html:
      * compositing/repaint/scroll-fixed-layer-out-of-view.html:
      * editing/caret/selection-with-caret-type-progress.html:
      * editing/execCommand/overtype.html:
      * editing/selection/block-cursor-overtype-mode.html:
      * editing/spelling/design-mode-spellcheck-off.html:
      * editing/spelling/grammar-edit-word-expected.txt:
      * editing/spelling/grammar-edit-word.html:
      * editing/spelling/grammar-markers-hidpi.html:
      * editing/spelling/grammar-markers.html:
      * editing/spelling/grammar.html:
      * editing/spelling/script-tests/spellcheck-paste.js:
      (verifyMarker):
      * editing/spelling/script-tests/spelling-attribute-at-child.js:
      (childHasSpellingMarker):
      * editing/spelling/script-tests/spelling-attribute-change.js:
      (testSpellCheckingEnabled):
      * editing/spelling/script-tests/spelling-backspace-between-lines.js:
      (testWithDelete):
      (testWithForwardDelete):
      * editing/spelling/script-tests/spelling-hasspellingmarker.js:
      (hasMarked):
      * editing/spelling/spellcheck-async-mutation.html:
      * editing/spelling/spellcheck-attribute-expected.txt:
      * editing/spelling/spellcheck-attribute.html:
      * editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
      * editing/spelling/spellcheck-paste-continuous-disabled.html:
      * editing/spelling/spellcheck-paste-disabled-expected.txt:
      * editing/spelling/spellcheck-paste-disabled.html:
      * editing/spelling/spellcheck-sequencenum.html:
      * editing/spelling/spelling-attribute-change-expected.txt:
      * editing/spelling/spelling-backspace-between-lines-expected.txt:
      * editing/spelling/spelling-linebreak.html:
      * fast/box-shadow/shadow-repaint.html:
      * fast/css/webkit-mask-crash-fieldset-legend.html:
      * fast/css/webkit-mask-crash-figure.html:
      * fast/css/webkit-mask-crash-table.html:
      * fast/css/webkit-mask-crash-td-2.html:
      * fast/css/webkit-mask-crash-td.html:
      * fast/dom/icon-url-change.html:
      * fast/dom/icon-url-list-apple-touch.html:
      * fast/dom/icon-url-list.html:
      * fast/dom/icon-url-property.html:
      * fast/events/mouse-cursor-change.html:
      * fast/events/mouse-cursor-image-set.html:
      * fast/events/mouse-cursor-multiframecur.html:
      * fast/events/mouse-cursor-no-mousemove.html:
      * fast/events/mouse-cursor.html:
      * fast/events/touch/touch-handler-count-expected.txt:
      * fast/events/touch/touch-handler-count.html:
      * fast/events/touch/touch-input-element-change-documents-expected.txt:
      * fast/events/touch/touch-input-element-change-documents.html:
      * fast/multicol/hit-test-gap-between-pages-flipped.html:
      * fast/multicol/hit-test-gap-between-pages.html:
      * fast/multicol/pagination-h-horizontal-bt.html:
      * fast/multicol/pagination-h-horizontal-tb.html:
      * fast/multicol/pagination-h-vertical-lr.html:
      * fast/multicol/pagination-h-vertical-rl.html:
      * fast/multicol/pagination-v-horizontal-bt.html:
      * fast/multicol/pagination-v-horizontal-tb.html:
      * fast/multicol/pagination-v-vertical-lr.html:
      * fast/multicol/pagination-v-vertical-rl.html:
      * fast/multicol/pagination/BottomToTop-bt.html:
      * fast/multicol/pagination/BottomToTop-lr.html:
      * fast/multicol/pagination/BottomToTop-rl.html:
      * fast/multicol/pagination/BottomToTop-tb.html:
      * fast/multicol/pagination/LeftToRight-bt.html:
      * fast/multicol/pagination/LeftToRight-lr.html:
      * fast/multicol/pagination/LeftToRight-rl.html:
      * fast/multicol/pagination/LeftToRight-tb.html:
      * fast/multicol/pagination/RightToLeft-bt.html:
      * fast/multicol/pagination/RightToLeft-lr.html:
      * fast/multicol/pagination/RightToLeft-rl.html:
      * fast/multicol/pagination/RightToLeft-tb.html:
      * fast/multicol/pagination/TopToBottom-bt.html:
      * fast/multicol/pagination/TopToBottom-lr.html:
      * fast/multicol/pagination/TopToBottom-rl.html:
      * fast/multicol/pagination/TopToBottom-tb.html:
      * fast/multicol/shrink-to-column-height-for-pagination.html:
      * fast/repaint/background-shorthand-with-gradient-and-height-changes.html:
      * fast/repaint/obscured-background-no-repaint.html:
      * fast/repaint/resources/text-based-repaint.js:
      (runRepaintTest):
      * fast/scrolling/resources/scrollable-area.js:
      (end):
      * fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html:
      * fast/viewport/viewport-1.html:
      * fast/viewport/viewport-10.html:
      * fast/viewport/viewport-100.html:
      * fast/viewport/viewport-101.html:
      * fast/viewport/viewport-102.html:
      * fast/viewport/viewport-103.html:
      * fast/viewport/viewport-104.html:
      * fast/viewport/viewport-105.html:
      * fast/viewport/viewport-106.html:
      * fast/viewport/viewport-107.html:
      * fast/viewport/viewport-108.html:
      * fast/viewport/viewport-109.html:
      * fast/viewport/viewport-11.html:
      * fast/viewport/viewport-110.html:
      * fast/viewport/viewport-111.html:
      * fast/viewport/viewport-112.html:
      * fast/viewport/viewport-113.html:
      * fast/viewport/viewport-114.html:
      * fast/viewport/viewport-115.html:
      * fast/viewport/viewport-116.html:
      * fast/viewport/viewport-117.html:
      * fast/viewport/viewport-118.html:
      * fast/viewport/viewport-119.html:
      * fast/viewport/viewport-12.html:
      * fast/viewport/viewport-120.html:
      * fast/viewport/viewport-121.html:
      * fast/viewport/viewport-122.html:
      * fast/viewport/viewport-123.html:
      * fast/viewport/viewport-124.html:
      * fast/viewport/viewport-125.html:
      * fast/viewport/viewport-126.html:
      * fast/viewport/viewport-127.html:
      * fast/viewport/viewport-128.html:
      * fast/viewport/viewport-129.html:
      * fast/viewport/viewport-13.html:
      * fast/viewport/viewport-130.html:
      * fast/viewport/viewport-131.html:
      * fast/viewport/viewport-132.html:
      * fast/viewport/viewport-133.html:
      * fast/viewport/viewport-134.html:
      * fast/viewport/viewport-14.html:
      * fast/viewport/viewport-15.html:
      * fast/viewport/viewport-16.html:
      * fast/viewport/viewport-17.html:
      * fast/viewport/viewport-18.html:
      * fast/viewport/viewport-19.html:
      * fast/viewport/viewport-2.html:
      * fast/viewport/viewport-20.html:
      * fast/viewport/viewport-21.html:
      * fast/viewport/viewport-22.html:
      * fast/viewport/viewport-23.html:
      * fast/viewport/viewport-24.html:
      * fast/viewport/viewport-25.html:
      * fast/viewport/viewport-26.html:
      * fast/viewport/viewport-27.html:
      * fast/viewport/viewport-28.html:
      * fast/viewport/viewport-29.html:
      * fast/viewport/viewport-3.html:
      * fast/viewport/viewport-30.html:
      * fast/viewport/viewport-31.html:
      * fast/viewport/viewport-32.html:
      * fast/viewport/viewport-33.html:
      * fast/viewport/viewport-34.html:
      * fast/viewport/viewport-35.html:
      * fast/viewport/viewport-36.html:
      * fast/viewport/viewport-37.html:
      * fast/viewport/viewport-38.html:
      * fast/viewport/viewport-39.html:
      * fast/viewport/viewport-4.html:
      * fast/viewport/viewport-40.html:
      * fast/viewport/viewport-41.html:
      * fast/viewport/viewport-42.html:
      * fast/viewport/viewport-43.html:
      * fast/viewport/viewport-44.html:
      * fast/viewport/viewport-45.html:
      * fast/viewport/viewport-46.html:
      * fast/viewport/viewport-47.html:
      * fast/viewport/viewport-48.html:
      * fast/viewport/viewport-49.html:
      * fast/viewport/viewport-5.html:
      * fast/viewport/viewport-50.html:
      * fast/viewport/viewport-51.html:
      * fast/viewport/viewport-52.html:
      * fast/viewport/viewport-53.html:
      * fast/viewport/viewport-54.html:
      * fast/viewport/viewport-55.html:
      * fast/viewport/viewport-56.html:
      * fast/viewport/viewport-57.html:
      * fast/viewport/viewport-58.html:
      * fast/viewport/viewport-59.html:
      * fast/viewport/viewport-6.html:
      * fast/viewport/viewport-60.html:
      * fast/viewport/viewport-61.html:
      * fast/viewport/viewport-62.html:
      * fast/viewport/viewport-63.html:
      * fast/viewport/viewport-64.html:
      * fast/viewport/viewport-65.html:
      * fast/viewport/viewport-66.html:
      * fast/viewport/viewport-67.html:
      * fast/viewport/viewport-68.html:
      * fast/viewport/viewport-69.html:
      * fast/viewport/viewport-7.html:
      * fast/viewport/viewport-70.html:
      * fast/viewport/viewport-71.html:
      * fast/viewport/viewport-72.html:
      * fast/viewport/viewport-73.html:
      * fast/viewport/viewport-74.html:
      * fast/viewport/viewport-75.html:
      * fast/viewport/viewport-76.html:
      * fast/viewport/viewport-77.html:
      * fast/viewport/viewport-78.html:
      * fast/viewport/viewport-79.html:
      * fast/viewport/viewport-8.html:
      * fast/viewport/viewport-80.html:
      * fast/viewport/viewport-81.html:
      * fast/viewport/viewport-82.html:
      * fast/viewport/viewport-83.html:
      * fast/viewport/viewport-84.html:
      * fast/viewport/viewport-85.html:
      * fast/viewport/viewport-86.html:
      * fast/viewport/viewport-87.html:
      * fast/viewport/viewport-88.html:
      * fast/viewport/viewport-9.html:
      * fast/viewport/viewport-90.html:
      * fast/viewport/viewport-91.html:
      * fast/viewport/viewport-legacy-handheldfriendly.html:
      * fast/viewport/viewport-legacy-mobileoptimized-2.html:
      * fast/viewport/viewport-legacy-mobileoptimized-3.html:
      * fast/viewport/viewport-legacy-mobileoptimized.html:
      * fast/viewport/viewport-legacy-ordering-1.html:
      * fast/viewport/viewport-legacy-ordering-2.html:
      * fast/viewport/viewport-legacy-ordering-3.html:
      * fast/viewport/viewport-legacy-ordering-4.html:
      * fast/viewport/viewport-legacy-ordering-5.html:
      * fast/viewport/viewport-legacy-ordering-6.html:
      * fast/viewport/viewport-legacy-ordering-7.html:
      * fast/viewport/viewport-legacy-ordering-8.html:
      * fast/viewport/viewport-legacy-ordering-9.html:
      * fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html:
      * fast/viewport/viewport-legacy-xhtmlmp-ordering.html:
      * fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html:
      * fast/viewport/viewport-legacy-xhtmlmp.html:
      * fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html:
      * fast/viewport/viewport-limits-adjusted-for-no-user-scale.html:
      * fast/viewport/viewport-warnings-1.html:
      * fast/viewport/viewport-warnings-2.html:
      * fast/viewport/viewport-warnings-3.html:
      * fast/viewport/viewport-warnings-4.html:
      * fast/viewport/viewport-warnings-5.html:
      * fast/viewport/viewport-warnings-6.html:
      * fullscreen/video-cursor-auto-hide-expected.txt:
      * fullscreen/video-cursor-auto-hide.html:
      * http/tests/inspector-enabled/resources/console-clear-arguments-test.js:
      (dumpConsoleMessageArgumentCounts):
      * http/tests/inspector/elements-test.js:
      * networkinformation/resources/event-after-navigation-new.html:
      * networkinformation/script-tests/add-listener-from-callback.js:
      (firstListener):
      * networkinformation/script-tests/basic-all-types-of-events.js:
      * networkinformation/script-tests/basic-operation.js:
      * networkinformation/script-tests/multiple-frames.js:
      * networkinformation/script-tests/updates.js:
      (setNetworkInformation):
      * platform/efl-wk2/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
      * platform/mac-wk2/tiled-drawing/clamp-out-of-bounds-scrolls.html:
      * platform/mac-wk2/tiled-drawing/fixed/absolute-inside-fixed.html:
      * platform/mac-wk2/tiled-drawing/fixed/absolute-inside-out-of-view-fixed.html:
      * platform/mac-wk2/tiled-drawing/fixed/fixed-in-overflow.html:
      * platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex.html:
      * platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view.html:
      * platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html:
      * platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed.html:
      * platform/mac-wk2/tiled-drawing/fixed/four-bars.html:
      * platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view.html:
      * platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset.html:
      * platform/mac-wk2/tiled-drawing/fixed/nested-fixed.html:
      * platform/mac-wk2/tiled-drawing/fixed/percentage-inside-fixed.html:
      * platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-in-frame.html:
      * platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-with-page-scale.html:
      * platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing.html:
      * platform/mac-wk2/tiled-drawing/scrolling-tree-after-scroll.html:
      * platform/mac-wk2/tiled-drawing/scrolling-tree-slow-scrolling.html:
      * platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle.html:
      * platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle.html:
      * platform/mac-wk2/tiled-drawing/slow-scrolling.html:
      * platform/mac-wk2/tiled-drawing/sticky/negative-scroll-offset.html:
      * platform/mac-wk2/tiled-drawing/sticky/sticky-horizontal.html:
      * platform/mac-wk2/tiled-drawing/sticky/sticky-vertical.html:
      * platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
      * platform/mac/editing/spelling/autocorrection-blockquote-crash.html:
      * platform/mac/editing/spelling/delete-into-misspelled-word.html:
      * platform/mac/editing/spelling/editing-multiple-words-with-markers.html:
      * platform/mac/editing/spelling/editing-word-with-marker-1.html:
      * platform/mac/editing/spelling/editing-word-with-marker-2.html:
      * platform/mac/editing/spelling/move-cursor-around-misspelled-word.html:
      * platform/win/editing/spelling/spelling-backspace-between-lines-expected.txt:
      * printing/page-format-data-expected.txt:
      * printing/page-format-data.html:
      * proximity/add-listener-from-callback.html:
      * proximity/basic-operation.html:
      * proximity/multiple-frames.html:
      * proximity/resources/event-after-navigation-new.html:
      * proximity/updates.html:
      * scrollingcoordinator/resources/non-fast-scrollable-region-testing.js:
      (runNonFastScrollableRegionTest):
      * touchadjustment/big-div.html:
      * touchadjustment/event-triggered-widgets.html:
      * touchadjustment/iframe.html:
      * touchadjustment/nested-shadow-node.html:
      * touchadjustment/resources/touchadjustment.js:
      (testTouchPoint):
      (testTouchPointContextMenu):
      (adjustTouchPoint):
      (adjustTouchPointContextMenu):
      * touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset.html:
      * touchadjustment/scroll-offset.html:
      * touchadjustment/search-cancel.html:
      * touchadjustment/zoom-basic.html:
      * touchadjustment/zoom-fatfinger.html:
      * transitions/created-while-suspended.html:
      * transitions/started-while-suspended.html:
      * transitions/suspend-transform-transition.html:
      * userscripts/insert-stylesheets.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e466981
  25. 25 Oct, 2013 3 commits
    • achicu@adobe.com's avatar
      Web Inspector: CSS Regions: Add layout tests for the new events in the DOMTreeManager · 93225e79
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123361
      
      Reviewed by Timothy Hatcher.
      
      Created a test to check that WebInspector.DOMTree.Event.ContentFlowWasAdded and
      WebInspector.DOMTree.Event.ContentFlowWasRemoved are dispatched when a flow is added
      and removed.
      
      * http/tests/inspector-protocol/resources/InspectorTest.js:
      (InspectorTest.assert): Similar to InspectorTest.log, but also takes a boolean and prefixes the message
      with "FAIL" or "PASS" depending on the value.
      (InspectorTest.importInspectorScripts): Added the required CSS Agent scripts to enable the flow thread events.
      * inspector-protocol/model/content-flow-list-expected.txt: Added.
      * inspector-protocol/model/content-flow-list.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93225e79
    • hmuller@adobe.com's avatar
      [CSS Shapes] CORS-enabled fetch for shape image values · b1e2528a
      hmuller@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123114
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      Access to shape images is now controlled by CORS CSS shape per
      http://dev.w3.org/csswg/css-shapes/#shape-outside-property.
      Previously shape images had to be same-origin.
      
      Shape image URL access is defined by the same logic that defines
      canvas tainting: same-origin and data URLs are allowed and images
      with a "Access-Control-Allow-Origin:" header that's either "*" or
      that matches the document's origin.
      
      A PotentiallyCrossOriginEnabled RequestOriginPolicy was added to
      ResourceLoaderOptions, to indicate that a "potentially CORS-enabled fetch"
      was to be undertaken. The CSSImageValue::cachedImage() method handles this
      option by effectively setting the "Origin:" request header (see
      updateRequestForAccessControl() in CrossOriginAccessControl.cpp).
      StyleResolver::loadPendingShapeImage() uses the new ResourceLoaderOption.
      
      The static ShapeInsideInfo and ShapeOutsideInfo isEnabledFor() method
      now performs the CORS check for image valued shapes. The private
      isOriginClean() method from CanvasRenderingContext2D has been moved to
      the CachedImage class so that it can be shared by the Canvas and Shape
      implementations. It checks the response headers per the CORS spec.
      
      Test: http/tests/security/shape-image-cors.html
      
      * css/CSSImageValue.cpp:
      (WebCore::CSSImageValue::cachedImage): Handle the new ResourceLoaderOption.
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::loadPendingShapeImage): Set the new ResourceLoaderOption.
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::createPattern): Use the CachedImage::isOriginClean().
      * loader/ResourceLoaderOptions.h: Added PotentiallyCrossOriginEnabled to RequestOriginPolicy.
      * loader/cache/CachedImage.cpp:
      (WebCore::CachedImage::isOriginClean): Migrated from CanvasRenderingContext2D.
      * loader/cache/CachedImage.h:
      * rendering/shapes/ShapeInfo.cpp:
      (WebCore::::checkImageOrigin): Do the CORS check and log an error message if neccessary.
      * rendering/shapes/ShapeInfo.h:
      * rendering/shapes/ShapeInsideInfo.cpp:
      (WebCore::ShapeInsideInfo::isEnabledFor): Call checkImageOrigin() for images.
      * rendering/shapes/ShapeOutsideInfo.cpp:
      (WebCore::ShapeOutsideInfo::isEnabledFor): Ditto.
      
      LayoutTests:
      
      Verify that images not allowed by CORS don't affect the layout
      and that same-origin images, data URLs, and images with a
      "Access-Control-Allow-Origin: *" header do define the layout.
      Added a simple PHP script that optionally adds the allow origin header.
      
      Replaced and renamed the original shape same-origin-only test.
      
      * http/tests/security/resources/image-access-control.php: Added.
      * http/tests/security/shape-image-cors-expected.html: Added.
      * http/tests/security/shape-image-cors.html: Added.
      * http/tests/security/shape-inside-image-origin-expected.txt: Removed.
      * http/tests/security/shape-inside-image-origin.html: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1e2528a
    • oliver@apple.com's avatar
      Improve JSC Parser error messages · 039f9247
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123341
      
      Reviewed by Andreas Kling.
      
      Source/JavaScriptCore:
      
      This patch moves away from the current cludgy mechanisms used to produce
      error messages and moves to something closer to case by case errors.
      
      This results in a large change size as previously we may just have
      'failIfFalse(foo)', but now the logic becomes either
      'failIfFalseWithMessage(foo, "Cannot do blah with ", foo->thing())'
      Or alternatively
      
      if (!foo)
          check for 'interesting' errors, before falling back to generic error
      
      This means that this patch is large, but produces no semantic changes, and
      only hits slow (e.g. error) paths.
      
      * parser/Parser.cpp:
      (JSC::::Parser):
      (JSC::::parseSourceElements):
      (JSC::::parseVarDeclaration):
      (JSC::::parseConstDeclaration):
      (JSC::::parseDoWhileStatement):
      (JSC::::parseWhileStatement):
      (JSC::::parseVarDeclarationList):
      (JSC::::createBindingPattern):
      (JSC::::parseDeconstructionPattern):
      (JSC::::parseConstDeclarationList):
      (JSC::::parseForStatement):
      (JSC::::parseBreakStatement):
      (JSC::::parseContinueStatement):
      (JSC::::parseReturnStatement):
      (JSC::::parseThrowStatement):
      (JSC::::parseWithStatement):
      (JSC::::parseSwitchStatement):
      (JSC::::parseSwitchClauses):
      (JSC::::parseSwitchDefaultClause):
      (JSC::::parseTryStatement):
      (JSC::::parseDebuggerStatement):
      (JSC::::parseBlockStatement):
      (JSC::::parseStatement):
      (JSC::::parseFormalParameters):
      (JSC::::parseFunctionBody):
      (JSC::stringForFunctionMode):
      (JSC::::parseFunctionInfo):
      (JSC::::parseFunctionDeclaration):
      (JSC::::parseExpressionOrLabelStatement):
      (JSC::::parseExpressionStatement):
      (JSC::::parseIfStatement):
      (JSC::::parseExpression):
      (JSC::::parseAssignmentExpression):
      (JSC::::parseConditionalExpression):
      (JSC::::parseBinaryExpression):
      (JSC::::parseProperty):
      (JSC::::parseObjectLiteral):
      (JSC::::parseStrictObjectLiteral):
      (JSC::::parseArrayLiteral):
      (JSC::::parsePrimaryExpression):
      (JSC::::parseArguments):
      (JSC::::parseMemberExpression):
      (JSC::operatorString):
      (JSC::::parseUnaryExpression):
      (JSC::::printUnexpectedTokenText):
      * parser/Parser.h:
      (JSC::Scope::hasDeclaredVariable):
      (JSC::Scope::hasDeclaredParameter):
      (JSC::Parser::hasDeclaredVariable):
      (JSC::Parser::hasDeclaredParameter):
      (JSC::Parser::setErrorMessage):
      
      LayoutTests:
      
      Update a vast array of layout test results
      
      * fast/events/window-onerror5-expected.txt:
      * js/basic-strict-mode-expected.txt:
      * js/break-ASI-expected.txt:
      * js/dom/assign-expected.txt:
      * js/dom/object-extra-comma-expected.txt:
      * js/dom/parse-error-external-script-in-eval-expected.txt:
      * js/dom/parse-error-external-script-in-new-Function-expected.txt:
      * js/dom/reserved-words-as-property-expected.txt:
      * js/function-constructor-error-expected.txt:
      * js/function-declaration-expected.txt:
      * js/function-toString-object-literals-expected.txt:
      * js/function-toString-parentheses-expected.txt:
      * js/js-continue-break-restrictions-expected.txt:
      * js/kde/garbage-n-expected.txt:
      * js/kde/parse-expected.txt:
      * js/no-semi-insertion-at-end-of-script-expected.txt:
      * js/object-literal-syntax-expected.txt:
      * js/parser-xml-close-comment-expected.txt:
      * js/regexp-compile-crash-expected.txt:
      * js/script-tests/function-constructor-error.js:
      * js/script-tests/reserved-words-strict.js:
      (isReserved):
      * sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.1_T2-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.1_T3-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.2_T2-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.2_T3-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.3_T2-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.4_T2-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A4_T1-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A4_T4-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.1-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.10-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.12-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.13-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.14-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.16-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.17-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.2-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.20-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.22-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.24-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.25-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.3-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.4-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.5-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.8-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.9-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.10-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.11-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.16-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.27-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.5-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.6-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.7-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.9-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.2_T2-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.3_T1-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.3_T3-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.5_T1-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.5_T3-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.2_T1-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.3_T1-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.3_T3-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.5_T1-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.5_T3-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T7-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T8-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T9-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T1-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T3-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T6-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A10_T4-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A10_T8-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A11_T4-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A11_T8-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A4-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T5-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T6-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T8-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T9-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T4-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T5-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T6-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T7-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.4_T1-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T6-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T7-expected.txt:
      * sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T8-expected.txt:
      * sputnik/Conformance/08_Types/8.2_The_Null_Type/S8.2_A2-expected.txt:
      * sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T3-expected.txt:
      * sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T3-expected.txt:
      * sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T1-expected.txt:
      * sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T2-expected.txt:
      * sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T3-expected.txt:
      * sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T4-expected.txt:
      * sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T1-expected.txt:
      * sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T2-expected.txt:
      * sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T3-expected.txt:
      * sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T4-expected.txt:
      * sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A2_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T5-expected.txt:
      * sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T10-expected.txt:
      * sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T11-expected.txt:
      * sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T12-expected.txt:
      * sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T13-expected.txt:
      * sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T14-expected.txt:
      * sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T15-expected.txt:
      * sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T4-expected.txt:
      * sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T5-expected.txt:
      * sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T6-expected.txt:
      * sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T7-expected.txt:
      * sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T8-expected.txt:
      * sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T9-expected.txt:
      * sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T4-expected.txt:
      * sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T5-expected.txt:
      * sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T6-expected.txt:
      * sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T7-expected.txt:
      * sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T8-expected.txt:
      * sputnik/Conformance/12_Statement/12.4_Expression_Statement/S12.4_A1-expected.txt:
      * sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A11-expected.txt:
      * sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A9_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A12-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A13_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A15-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T4-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T5-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T6-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A13_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A15-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T4-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T5-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T6-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11.1_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12.1_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4.1-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7.1_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7.1_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A13_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A15-expected.txt:
      * sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T4-expected.txt:
      * sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A6-expected.txt:
      * sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T4-expected.txt:
      * sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A6-expected.txt:
      * sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T1-expected.txt:
      * sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T10-expected.txt:
      * sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T2-expected.txt:
      * sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T3-expected.txt:
      * sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T4-expected.txt:
      * sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T5-expected.txt:
      * sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T6-expected.txt:
      * sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T7-expected.txt:
      * sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T8-expected.txt:
      * sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T9-expected.txt:
      * sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.1_eval/S15.1.2.1_A2_T2-expected.txt:
      * sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/15.3.4.2_Function.prototype.toString/S15.3.4.2_A1_T1-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      039f9247
  26. 24 Oct, 2013 1 commit
    • achicu@adobe.com's avatar
      Web Inspector: Add a way to test the Manager and model classes · 1a45048e
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123223
      
      Reviewed by Timothy Hatcher.
      
      Source/WebInspectorUI:
      
      Moved some global functions out of Main.js, so that they can be used in the
      layout tests without including Main.js.
      
      * UserInterface/Main.html: Referenced the new JS files.
      * UserInterface/Main.js:
      * UserInterface/MessageDispatcher.js: Added.
      (WebInspector.dispatchNextQueuedMessageFromBackend):
      (WebInspector.dispatchMessageFromBackend):
      * UserInterface/URLUtilities.js: Added.
      (removeURLFragment):
      (relativePath):
      (parseURL):
      (absoluteURL):
      (parseLocationQueryParameters):
      (parseQueryString):
      (WebInspector.displayNameForURL):
      (WebInspector.displayNameForHost):
      * UserInterface/Utilities.js:
      
      LayoutTests:
      
      Added the first new WebInspector layout test file. The test is using InspectorTest.importInspectorScripts
      to bootstrap some of the managers/observers/models from the new WebInspector.
      
      * http/tests/inspector-protocol/resources/InspectorTest.js:
      (InspectorTest.importScript):
      (InspectorTest.importInspectorScripts):
      * inspector-protocol/model/main-frame-resource-expected.txt: Added.
      * inspector-protocol/model/main-frame-resource.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a45048e
  27. 23 Oct, 2013 1 commit
  28. 17 Oct, 2013 1 commit
  29. 14 Oct, 2013 2 commits
    • achicu@adobe.com's avatar
      The content of the DOM panel for iframes is not updated until the "onload" event · 7e05a123
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122653
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Test: http/tests/inspector-protocol/loading-iframe-document-node.html
      
      Renamed InspectorDOMAgent::loadEventFired to InspectorDOMAgent::didCommitLoad and moved the call site
      from InspectorInstrumentation::loadEventFiredImpl to InspectorInstrumentation::didCommitLoadImpl.
      This is to make sure that it will invalidate the content of the iframe as soon as the frame navigates
      to a different page. This way the new node can be retrieved as soon as the page has some content, and
      not just when the page is fully loaded.
      
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::didCommitLoad): Renamed from loadEventFired, as it is now called from
      didCommitLoadImpl instead.
      (WebCore::InspectorDOMAgent::frameDocumentUpdated): Updated comment to point to the new function name.
      * inspector/InspectorDOMAgent.h:
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::loadEventFiredImpl): Removed call do InspectorDOMAgent.loadEventFired.
      (WebCore::InspectorInstrumentation::didCommitLoadImpl): Added call to InspectorDOMAgent.didCommitLoad.
      
      LayoutTests:
      
      Added test to check that immediately after the scripting context is created, the
      inspector already has access to the nodeId of the document of the iframe.
      
      * http/tests/inspector-protocol/loading-iframe-document-node-expected.txt: Added.
      * http/tests/inspector-protocol/loading-iframe-document-node.html: Added.
      * http/tests/inspector-protocol/resources/slow-test-page.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e05a123
    • hmuller@adobe.com's avatar
      [CSS Shapes] Image valued shape-outside shapes should update the layout after... · b5abde39
      hmuller@adobe.com authored
      [CSS Shapes] Image valued shape-outside shapes should update the layout after the image has been loaded
      https://bugs.webkit.org/show_bug.cgi?id=122340
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Ensure that the an image-valued shape-outside layout is updated after the image has
      been loaded.
      
      Test: http/tests/css/css-image-valued-shape.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::imageChanged): Added code for the shape-outside case.
      (WebCore::RenderBlock::updateShapeInsideInfoAfterStyleChange): Ditto.
      * rendering/RenderElement.cpp:
      (WebCore::RenderElement::~RenderElement): Ditto.
      (WebCore::RenderElement::setStyle): Ditto.
      
      LayoutTests:
      
      Verify that an image-valued shape-outside layout is updated after the image has been loaded.
      
      * http/tests/css/css-image-valued-shape-expected.txt: Added.
      * http/tests/css/css-image-valued-shape.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5abde39
  30. 09 Oct, 2013 1 commit
    • achicu@adobe.com's avatar
      Web Inspector: [CSS Regions] Display the correct fragment boxes for content inside flow threads · 051b43b9
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122291
      
      Reviewed by Timothy Hatcher.
      
      Source/WebCore:
      
      Tests: inspector/elements/highlight-regions-flow-horiz-bt.html
             inspector/elements/highlight-regions-flow-transform-horiz-bt.html
             inspector/elements/highlight-regions-flow-transform-vert-lr.html
             inspector/elements/highlight-regions-flow-transform-vert-rl.html
             inspector/elements/highlight-regions-flow-transform.html
             inspector/elements/highlight-regions-flow-vert-lr.html
             inspector/elements/highlight-regions-flow-vert-rl.html
             inspector/elements/highlight-regions-flow.html
      
      Nodes inside a RenderFlowThread can be split across multiple regions. This patch adds the required
      code to compute "fragments" for each region. Each fragment will display its own label.
      
      There are a couple of changes:
      1. The node highlight object now has a "scroll" property to hold the main view's scroll offset.
      2. There's a "fragment" array to get a list of quads for each renderer fragment. Renderers outside
      RenderFlowThreads will just have one fragment.
      3. ElementInfo now has two more properties: "regionFlowInfo" (renamed from former flowInfo) and "contentFlowInfo".
      If the renderer is a RenderRegion it will have a regionFlowInfo. If the renderer is inside a RenderFlowThread
      then it will have a "contentFlowInfo".
      
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::getHighlight): It should now take a "region" parameter to customize the output for a specific
      containing region.
      (WebCore::buildObjectForHighlight):
      (WebCore::buildObjectForCSSRegionContentClip): We need to know how to clip the fragments inside regions.
      (WebCore::buildObjectForRendererFragments): Extracted code from buildObjectForHighlight and added
      the new regions lookup code.
      (WebCore::buildObjectForElementInfo): Extracted from buildObjectForHighlight.
      (WebCore::InspectorOverlay::buildObjectForHighlightedNode):
      (WebCore::InspectorOverlay::drawQuadHighlight):
      * inspector/InspectorOverlayPage.css: There can be multiple labels on screen at once, so I've
      created the #element-title-template element that we clone for each label. .element-title-container is now
      holding all the .element-title elements, so that we can remove them all at once.
      (.element-title-container):
      (.element-title):
      (#element-title-template):
      (.tag-name):
      (.node-id):
      (.class-name):
      * inspector/InspectorOverlayPage.html:
      * inspector/InspectorOverlayPage.js:
      (reset):
      (_toggleOptionalValue):
      (_createElementTitle): Creates an element populated with data read from elementInfo.
      (_drawElementTitle): Added code to create more labels for multiple fragments.
      (_drawRegionsHighlight):
      (_drawFragmentHighlight):
      (drawNodeHighlight): Consolidated the scroll property into a canvas.transform.
      
      LayoutTests:
      
      Added tests to check the result of the InspectorOverlay when it inspects nodes inside RenderFlowThreads.
      
      * http/tests/inspector/elements-test.js:
      * inspector/elements/highlight-regions-flow-expected.txt: Added.
      * inspector/elements/highlight-regions-flow-horiz-bt-expected.txt: Added.
      * inspector/elements/highlight-regions-flow-horiz-bt.html: Added.
      * inspector/elements/highlight-regions-flow-transform-expected.txt: Added.
      * inspector/elements/highlight-regions-flow-transform-horiz-bt-expected.txt: Added.
      * inspector/elements/highlight-regions-flow-transform-horiz-bt.html: Added.
      * inspector/elements/highlight-regions-flow-transform-vert-lr-expected.txt: Added.
      * inspector/elements/highlight-regions-flow-transform-vert-lr.html: Added.
      * inspector/elements/highlight-regions-flow-transform-vert-rl-expected.txt: Added.
      * inspector/elements/highlight-regions-flow-transform-vert-rl.html: Added.
      * inspector/elements/highlight-regions-flow-transform.html: Added.
      * inspector/elements/highlight-regions-flow-vert-lr-expected.txt: Added.
      * inspector/elements/highlight-regions-flow-vert-lr.html: Added.
      * inspector/elements/highlight-regions-flow-vert-rl-expected.txt: Added.
      * inspector/elements/highlight-regions-flow-vert-rl.html: Added.
      * inspector/elements/highlight-regions-flow.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      051b43b9
  31. 04 Oct, 2013 1 commit
    • mark.lam@apple.com's avatar
      Change ScriptDebugServer to use DebuggerCallFrame instead of JavaScriptCallFrame. · af032dd5
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121969.
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore: 
      
      1. Make JavaScriptCallFrame a thin shell around the DebuggerCallFrame.
         DebuggerCallFrame now tracks whether it is valid instead of needing
         JavaScriptCallFrame do it.
      2. ScriptDebugServer now only instantiates an DebuggerCallFrame when needed
         just before it pauses and calls back to its client, and then invalidates
         it immediately when the callback returns. Every subsequent callback to
         the client will use a new instance of the DebuggerCallFrame.
      3. Similarly, ScriptDebugServer now only creates a JavaScriptCallFrame when
         it "pauses".
      4. DebuggerCallFrame only creates its caller DebuggerCallFrame when
         it is needed i.e. when the client calls callerFrame(). Similarly,
         JavaScriptCallFrame only creates its caller when it's requested.
      5. DebuggerCallFrame's line() and column() now returns a base-zero int.
      6. WebScriptDebugDelegate now only caches the functionName of the frame
         instead of the entire DebuggerCallFrame because that is all that is
         needed.
      7. Also removed evaluateInGlobalCallFrame() which is not used anywhere.
      
      * debugger/Debugger.cpp:
      * debugger/Debugger.h:
      * debugger/DebuggerCallFrame.cpp:
      (JSC::DebuggerCallFrame::DebuggerCallFrame):
      (JSC::DebuggerCallFrame::callerFrame):
      (JSC::DebuggerCallFrame::dynamicGlobalObject):
      (JSC::DebuggerCallFrame::sourceId):
      (JSC::DebuggerCallFrame::functionName):
      (JSC::DebuggerCallFrame::scope):
      (JSC::DebuggerCallFrame::type):
      (JSC::DebuggerCallFrame::thisValue):
      (JSC::DebuggerCallFrame::evaluate):
      (JSC::DebuggerCallFrame::evaluateWithCallFrame):
      (JSC::DebuggerCallFrame::invalidate):
      (JSC::DebuggerCallFrame::positionForCallFrame):
      (JSC::DebuggerCallFrame::sourceIdForCallFrame):
      (JSC::DebuggerCallFrame::thisValueForCallFrame):
      * debugger/DebuggerCallFrame.h:
      (JSC::DebuggerCallFrame::create):
      (JSC::DebuggerCallFrame::exec):
      (JSC::DebuggerCallFrame::line):
      (JSC::DebuggerCallFrame::column):
      (JSC::DebuggerCallFrame::position):
      (JSC::DebuggerCallFrame::isValid):
      * interpreter/StackVisitor.cpp:
      
      Source/WebCore: 
      
      Tests: inspector-protocol/debugger/call-frame-function-name.html
             inspector-protocol/debugger/call-frame-this-host.html
             inspector-protocol/debugger/call-frame-this-nonstrict.html
             inspector-protocol/debugger/call-frame-this-strict.html
      
      1. Make JavaScriptCallFrame a thin shell around the DebuggerCallFrame.
         DebuggerCallFrame now tracks whether it is valid instead of needing
         JavaScriptCallFrame do it.
      2. ScriptDebugServer now only instantiates an DebuggerCallFrame when needed
         just before it pauses and calls back to its client, and then invalidates
         it immediately when the callback returns. Every subsequent callback to
         the client will use a new instance of the DebuggerCallFrame.
      3. Similarly, ScriptDebugServer now only creates a JavaScriptCallFrame when
         it "pauses".
      4. DebuggerCallFrame only creates its caller DebuggerCallFrame when
         it is needed i.e. when the client calls callerFrame(). Similarly,
         JavaScriptCallFrame only creates its caller when it's requested.
      5. DebuggerCallFrame's line() and column() now returns a base-zero int.
      6. WebScriptDebugDelegate now only caches the functionName of the frame
         instead of the entire DebuggerCallFrame because that is all that is
         needed.
      7. Also removed evaluateInGlobalCallFrame() which is not used anywhere.
      
      * bindings/js/JSJavaScriptCallFrameCustom.cpp:
      (WebCore::JSJavaScriptCallFrame::thisObject):
      * bindings/js/JavaScriptCallFrame.cpp:
      (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
      (WebCore::JavaScriptCallFrame::caller):
      * bindings/js/JavaScriptCallFrame.h:
      (WebCore::JavaScriptCallFrame::create):
      (WebCore::JavaScriptCallFrame::sourceID):
      (WebCore::JavaScriptCallFrame::position):
      (WebCore::JavaScriptCallFrame::line):
      (WebCore::JavaScriptCallFrame::column):
      (WebCore::JavaScriptCallFrame::functionName):
      (WebCore::JavaScriptCallFrame::type):
      (WebCore::JavaScriptCallFrame::scopeChain):
      (WebCore::JavaScriptCallFrame::dynamicGlobalObject):
      (WebCore::JavaScriptCallFrame::thisValue):
      (WebCore::JavaScriptCallFrame::evaluate):
      * bindings/js/ScriptDebugServer.cpp:
      (WebCore::DebuggerCallFrameScope::DebuggerCallFrameScope):
      (WebCore::DebuggerCallFrameScope::~DebuggerCallFrameScope):
      (WebCore::ScriptDebugServer::ScriptDebugServer):
      (WebCore::ScriptDebugServer::setBreakpoint):
      (WebCore::ScriptDebugServer::removeBreakpoint):
      (WebCore::ScriptDebugServer::hasBreakpoint):
      (WebCore::ScriptDebugServer::evaluateBreakpointAction):
      (WebCore::ScriptDebugServer::breakProgram):
      (WebCore::ScriptDebugServer::stepOverStatement):
      (WebCore::ScriptDebugServer::stepOutOfFunction):
      (WebCore::ScriptDebugServer::currentDebuggerCallFrame):
      (WebCore::ScriptDebugServer::dispatchDidPause):
      (WebCore::ScriptDebugServer::updateCallFrame):
      (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
      (WebCore::ScriptDebugServer::pauseIfNeeded):
      (WebCore::ScriptDebugServer::callEvent):
      (WebCore::ScriptDebugServer::returnEvent):
      (WebCore::ScriptDebugServer::willExecuteProgram):
      (WebCore::ScriptDebugServer::didExecuteProgram):
      * bindings/js/ScriptDebugServer.h:
      * bindings/js/WorkerScriptDebugServer.cpp:
      (WebCore::WorkerScriptDebugServer::willExecuteProgram):
      
      Source/WebKit/mac: 
      
      1. Make JavaScriptCallFrame a thin shell around the DebuggerCallFrame.
         DebuggerCallFrame now tracks whether it is valid instead of needing
         JavaScriptCallFrame do it.
      2. ScriptDebugServer now only instantiates an DebuggerCallFrame when needed
         just before it pauses and calls back to its client, and then invalidates
         it immediately when the callback returns. Every subsequent callback to
         the client will use a new instance of the DebuggerCallFrame.
      3. Similarly, ScriptDebugServer now only creates a JavaScriptCallFrame when
         it "pauses".
      4. DebuggerCallFrame only creates its caller DebuggerCallFrame when
         it is needed i.e. when the client calls callerFrame(). Similarly,
         JavaScriptCallFrame only creates its caller when it's requested.
      5. DebuggerCallFrame's line() and column() now returns a base-zero int.
      6. WebScriptDebugDelegate now only caches the functionName of the frame
         instead of the entire DebuggerCallFrame because that is all that is
         needed.
      7. Also removed evaluateInGlobalCallFrame() which is not used anywhere.
      
      * WebView/WebScriptDebugDelegate.mm:
      (-[WebScriptCallFramePrivate dealloc]):
      (-[WebScriptCallFrame _initWithGlobalObject:functionName:exceptionValue:JSC::]):
      (-[WebScriptCallFrame functionName]):
      (-[WebScriptCallFrame exception]):
      * WebView/WebScriptDebugger.mm:
      (WebScriptDebugger::exception):
      
      LayoutTests: 
      
      * http/tests/inspector/debugger-test.js:
      (initialize_DebuggerTest):
      * inspector-protocol/debugger/call-frame-function-name-expected.txt: Added.
      * inspector-protocol/debugger/call-frame-function-name.html: Added.
      * inspector-protocol/debugger/call-frame-this-host-expected.txt: Added.
      * inspector-protocol/debugger/call-frame-this-host.html: Added.
      * inspector-protocol/debugger/call-frame-this-nonstrict-expected.txt: Added.
      * inspector-protocol/debugger/call-frame-this-nonstrict.html: Added.
      * inspector-protocol/debugger/call-frame-this-strict-expected.txt: Added.
      * inspector-protocol/debugger/call-frame-this-strict.html: Added.
      * inspector/debugger/pause-in-internal-script-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af032dd5
  32. 03 Oct, 2013 2 commits
  33. 30 Sep, 2013 1 commit
    • weinig@apple.com's avatar
      Remove support for DOMFileSystem · 7df82b33
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122137
      
      Reviewed by Anders Carlsson.
      
      .: 
      
      * Source/autotools/SetupWebKitFeatures.m4:
      * Source/cmake/OptionsBlackBerry.cmake:
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      
      Source/JavaScriptCore: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore: 
      
      * Files elided *
      
      Source/WebKit/blackberry: 
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::init):
      (BlackBerry::WebKit::WebPage::clearWebFileSystem):
      * WebCoreSupport/AboutDataEnableFeatures.in:
      
      Source/WebKit/efl: 
      
      * ewk/ewk_settings.cpp:
      (ewk_settings_file_system_path_set):
      
      Source/WebKit/mac: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WTF: 
      
      * wtf/FeatureDefines.h:
      
      Tools: 
      
      * Scripts/webkitperl/FeatureList.pm:
      * Scripts/webkitpy/style/checkers/cpp.py:
      (check_spacing):
      * Scripts/webkitpy/style/checkers/cpp_unittest.py:
      (CppStyleTest.test_spacing_for_binary_ops):
      * qmake/mkspecs/features/features.pri:
      
      LayoutTests: 
      
      * fast/dom/MutationObserver/filesystem-callback-delivery-expected.txt: Removed.
      * fast/dom/MutationObserver/filesystem-callback-delivery.html: Removed.
      * fast/filesystem: Removed.
      * fast/filesystem/async-operations-expected.txt: Removed.
      * fast/filesystem/async-operations.html: Removed.
      * fast/filesystem/cross-filesystem-op-expected.txt: Removed.
      * fast/filesystem/cross-filesystem-op.html: Removed.
      * fast/filesystem/directory-entry-to-uri-expected.txt: Removed.
      * fast/filesystem/directory-entry-to-uri.html: Removed.
      * fast/filesystem/entry-points-missing-arguments-expected.txt: Removed.
      * fast/filesystem/entry-points-missing-arguments.html: Removed.
      * fast/filesystem/file-after-reload-crash-expected.txt: Removed.
      * fast/filesystem/file-after-reload-crash.html: Removed.
      * fast/filesystem/file-entry-to-uri-expected.txt: Removed.
      * fast/filesystem/file-entry-to-uri.html: Removed.
      * fast/filesystem/file-from-file-entry-expected.txt: Removed.
      * fast/filesystem/file-from-file-entry.html: Removed.
      * fast/filesystem/file-metadata-after-write-expected.txt: Removed.
      * fast/filesystem/file-metadata-after-write.html: Removed.
      * fast/filesystem/file-writer-abort-continue-expected.txt: Removed.
      * fast/filesystem/file-writer-abort-continue.html: Removed.
      * fast/filesystem/file-writer-abort-depth-expected.txt: Removed.
      * fast/filesystem/file-writer-abort-depth.html: Removed.
      * fast/filesystem/file-writer-abort-expected.txt: Removed.
      * fast/filesystem/file-writer-abort.html: Removed.
      * fast/filesystem/file-writer-empty-blob-expected.txt: Removed.
      * fast/filesystem/file-writer-empty-blob.html: Removed.
      * fast/filesystem/file-writer-events-expected.txt: Removed.
      * fast/filesystem/file-writer-events.html: Removed.
      * fast/filesystem/file-writer-gc-blob-expected.txt: Removed.
      * fast/filesystem/file-writer-gc-blob.html: Removed.
      * fast/filesystem/file-writer-truncate-extend-expected.txt: Removed.
      * fast/filesystem/file-writer-truncate-extend.html: Removed.
      * fast/filesystem/file-writer-write-overlapped-expected.txt: Removed.
      * fast/filesystem/file-writer-write-overlapped.html: Removed.
      * fast/filesystem/filesystem-missing-arguments-expected.txt: Removed.
      * fast/filesystem/filesystem-missing-arguments.html: Removed.
      * fast/filesystem/filesystem-no-callback-null-ptr-crash-expected.txt: Removed.
      * fast/filesystem/filesystem-no-callback-null-ptr-crash.html: Removed.
      * fast/filesystem/filesystem-reference-expected.txt: Removed.
      * fast/filesystem/filesystem-reference.html: Removed.
      * fast/filesystem/filesystem-unserializable-expected.txt: Removed.
      * fast/filesystem/filesystem-unserializable.html: Removed.
      * fast/filesystem/filesystem-uri-origin-expected.txt: Removed.
      * fast/filesystem/filesystem-uri-origin.html: Removed.
      * fast/filesystem/flags-passing-expected.txt: Removed.
      * fast/filesystem/flags-passing.html: Removed.
      * fast/filesystem/input-access-entries-expected.txt: Removed.
      * fast/filesystem/input-access-entries.html: Removed.
      * fast/filesystem/not-enough-arguments-expected.txt: Removed.
      * fast/filesystem/not-enough-arguments.html: Removed.
      * fast/filesystem/op-copy-expected.txt: Removed.
      * fast/filesystem/op-copy.html: Removed.
      * fast/filesystem/op-get-entry-expected.txt: Removed.
      * fast/filesystem/op-get-entry.html: Removed.
      * fast/filesystem/op-get-metadata-expected.txt: Removed.
      * fast/filesystem/op-get-metadata.html: Removed.
      * fast/filesystem/op-get-parent-expected.txt: Removed.
      * fast/filesystem/op-get-parent.html: Removed.
      * fast/filesystem/op-move-expected.txt: Removed.
      * fast/filesystem/op-move.html: Removed.
      * fast/filesystem/op-read-directory-expected.txt: Removed.
      * fast/filesystem/op-read-directory.html: Removed.
      * fast/filesystem/op-remove-expected.txt: Removed.
      * fast/filesystem/op-remove.html: Removed.
      * fast/filesystem/op-restricted-chars-expected.txt: Removed.
      * fast/filesystem/op-restricted-chars.html: Removed.
      * fast/filesystem/op-restricted-names-expected.txt: Removed.
      * fast/filesystem/op-restricted-names.html: Removed.
      * fast/filesystem/op-restricted-unicode-expected.txt: Removed.
      * fast/filesystem/op-restricted-unicode.html: Removed.
      * fast/filesystem/read-directory-expected.txt: Removed.
      * fast/filesystem/read-directory.html: Removed.
      * fast/filesystem/resources: Removed.
      * fast/filesystem/resources/async-operations.js: Removed.
      * fast/filesystem/resources/directory-entry-to-uri.js: Removed.
      * fast/filesystem/resources/file-entry-to-uri-sync.js: Removed.
      * fast/filesystem/resources/file-entry-to-uri.js: Removed.
      * fast/filesystem/resources/file-from-file-entry-sync.js: Removed.
      * fast/filesystem/resources/file-from-file-entry.js: Removed.
      * fast/filesystem/resources/file-writer-abort-continue.js: Removed.
      * fast/filesystem/resources/file-writer-abort-depth.js: Removed.
      * fast/filesystem/resources/file-writer-abort.js: Removed.
      * fast/filesystem/resources/file-writer-empty-blob.js: Removed.
      * fast/filesystem/resources/file-writer-events.js: Removed.
      * fast/filesystem/resources/file-writer-gc-blob.js: Removed.
      * fast/filesystem/resources/file-writer-sync-truncate-extend.js: Removed.
      * fast/filesystem/resources/file-writer-sync-write-overlapped.js: Removed.
      * fast/filesystem/resources/file-writer-truncate-extend.js: Removed.
      * fast/filesystem/resources/file-writer-utils.js: Removed.
      * fast/filesystem/resources/file-writer-write-overlapped.js: Removed.
      * fast/filesystem/resources/fs-test-util.js: Removed.
      * fast/filesystem/resources/fs-worker-common.js: Removed.
      * fast/filesystem/resources/op-copy.js: Removed.
      * fast/filesystem/resources/op-get-entry.js: Removed.
      * fast/filesystem/resources/op-get-metadata.js: Removed.
      * fast/filesystem/resources/op-get-parent.js: Removed.
      * fast/filesystem/resources/op-move.js: Removed.
      * fast/filesystem/resources/op-read-directory.js: Removed.
      * fast/filesystem/resources/op-remove.js: Removed.
      * fast/filesystem/resources/op-restricted-chars.js: Removed.
      * fast/filesystem/resources/op-restricted-names.js: Removed.
      * fast/filesystem/resources/op-restricted-unicode.js: Removed.
      * fast/filesystem/resources/op-tests-helper.js: Removed.
      * fast/filesystem/resources/shared-worker-stub.js: Removed.
      * fast/filesystem/resources/simple-persistent-sync.js: Removed.
      * fast/filesystem/resources/simple-persistent.js: Removed.
      * fast/filesystem/resources/simple-readonly.js: Removed.
      * fast/filesystem/resources/simple-required-arguments-getdirectory.js: Removed.
      * fast/filesystem/resources/simple-required-arguments-getfile.js: Removed.
      * fast/filesystem/resources/simple-required-arguments-getmetadata.js: Removed.
      * fast/filesystem/resources/simple-required-arguments-remove.js: Removed.
      * fast/filesystem/resources/simple-temporary-sync.js: Removed.
      * fast/filesystem/resources/simple-temporary.js: Removed.
      * fast/filesystem/resources/sync-operations.js: Removed.
      * fast/filesystem/script-tests: Removed.
      * fast/filesystem/script-tests/TEMPLATE.html: Removed.
      * fast/filesystem/script-tests/filesystem-reference.js: Removed.
      * fast/filesystem/script-tests/filesystem-unserializable.js: Removed.
      * fast/filesystem/script-tests/flags-passing.js: Removed.
      * fast/filesystem/script-tests/read-directory.js: Removed.
      * fast/filesystem/simple-persistent-expected.txt: Removed.
      * fast/filesystem/simple-persistent.html: Removed.
      * fast/filesystem/simple-readonly-expected.txt: Removed.
      * fast/filesystem/simple-readonly-file-object-expected.txt: Removed.
      * fast/filesystem/simple-readonly-file-object.html: Removed.
      * fast/filesystem/simple-readonly.html: Removed.
      * fast/filesystem/simple-required-arguments-getdirectory-expected.txt: Removed.
      * fast/filesystem/simple-required-arguments-getdirectory.html: Removed.
      * fast/filesystem/simple-required-arguments-getfile-expected.txt: Removed.
      * fast/filesystem/simple-required-arguments-getfile.html: Removed.
      * fast/filesystem/simple-required-arguments-getmetadata-expected.txt: Removed.
      * fast/filesystem/simple-required-arguments-getmetadata.html: Removed.
      * fast/filesystem/simple-required-arguments-remove-expected.txt: Removed.
      * fast/filesystem/simple-required-arguments-remove.html: Removed.
      * fast/filesystem/simple-temporary-expected.txt: Removed.
      * fast/filesystem/simple-temporary.html: Removed.
      * fast/filesystem/workers: Removed.
      * fast/filesystem/workers/async-operations-expected.txt: Removed.
      * fast/filesystem/workers/async-operations.html: Removed.
      * fast/filesystem/workers/detached-frame-crash-expected.txt: Removed.
      * fast/filesystem/workers/detached-frame-crash.html: Removed.
      * fast/filesystem/workers/file-entry-to-uri-sync-expected.txt: Removed.
      * fast/filesystem/workers/file-entry-to-uri-sync.html: Removed.
      * fast/filesystem/workers/file-from-file-entry-expected.txt: Removed.
      * fast/filesystem/workers/file-from-file-entry-sync-expected.txt: Removed.
      * fast/filesystem/workers/file-from-file-entry-sync.html: Removed.
      * fast/filesystem/workers/file-from-file-entry.html: Removed.
      * fast/filesystem/workers/file-writer-empty-blob-expected.txt: Removed.
      * fast/filesystem/workers/file-writer-empty-blob.html: Removed.
      * fast/filesystem/workers/file-writer-events-expected.txt: Removed.
      * fast/filesystem/workers/file-writer-events-shared-worker-expected.txt: Removed.
      * fast/filesystem/workers/file-writer-events-shared-worker.html: Removed.
      * fast/filesystem/workers/file-writer-events.html: Removed.
      * fast/filesystem/workers/file-writer-gc-blob-expected.txt: Removed.
      * fast/filesystem/workers/file-writer-gc-blob.html: Removed.
      * fast/filesystem/workers/file-writer-sync-truncate-extend-expected.txt: Removed.
      * fast/filesystem/workers/file-writer-sync-truncate-extend.html: Removed.
      * fast/filesystem/workers/file-writer-sync-write-overlapped-expected.txt: Removed.
      * fast/filesystem/workers/file-writer-sync-write-overlapped.html: Removed.
      * fast/filesystem/workers/file-writer-truncate-extend-expected.txt: Removed.
      * fast/filesystem/workers/file-writer-truncate-extend.html: Removed.
      * fast/filesystem/workers/file-writer-write-overlapped-expected.txt: Removed.
      * fast/filesystem/workers/file-writer-write-overlapped.html: Removed.
      * fast/filesystem/workers/resources: Removed.
      * fast/filesystem/workers/resources/detached-frame-crash-frame.html: Removed.
      * fast/filesystem/workers/resources/detached-frame-crash-worker.js: Removed.
      * fast/filesystem/workers/simple-persistent-expected.txt: Removed.
      * fast/filesystem/workers/simple-persistent-sync-expected.txt: Removed.
      * fast/filesystem/workers/simple-persistent-sync.html: Removed.
      * fast/filesystem/workers/simple-persistent.html: Removed.
      * fast/filesystem/workers/simple-temporary-expected.txt: Removed.
      * fast/filesystem/workers/simple-temporary-sync-expected.txt: Removed.
      * fast/filesystem/workers/simple-temporary-sync.html: Removed.
      * fast/filesystem/workers/simple-temporary.html: Removed.
      * fast/filesystem/workers/sync-operations-expected.txt: Removed.
      * fast/filesystem/workers/sync-operations.html: Removed.
      * fast/forms/file/input-file-entries-expected.txt: Removed.
      * fast/forms/file/input-file-entries.html: Removed.
      * http/tests/filesystem: Removed.
      * http/tests/filesystem/no-cache-filesystem-url-expected.txt: Removed.
      * http/tests/filesystem/no-cache-filesystem-url.html: Removed.
      * http/tests/filesystem/resolve-uri-expected.txt: Removed.
      * http/tests/filesystem/resolve-uri.html: Removed.
      * http/tests/filesystem/resources: Removed.
      * http/tests/filesystem/resources/fs-test-util.js: Removed.
      * http/tests/filesystem/resources/fs-worker-common.js: Removed.
      * http/tests/filesystem/resources/fs-worker-test-util.js: Removed.
      * http/tests/filesystem/script-tests: Removed.
      * http/tests/filesystem/script-tests/TEMPLATE.html: Removed.
      * http/tests/filesystem/script-tests/resolve-uri.js: Removed.
      * http/tests/filesystem/workers: Removed.
      * http/tests/filesystem/workers/resolve-url-expected.txt: Removed.
      * http/tests/filesystem/workers/resolve-url-sync-expected.txt: Removed.
      * http/tests/filesystem/workers/resolve-url-sync.html: Removed.
      * http/tests/filesystem/workers/resolve-url.html: Removed.
      * http/tests/filesystem/workers/script-tests: Removed.
      * http/tests/filesystem/workers/script-tests/TEMPLATE.html: Removed.
      * http/tests/filesystem/workers/script-tests/resolve-url-sync.js: Removed.
      * http/tests/inspector/filesystem: Removed.
      * http/tests/inspector/filesystem/delete-entry-expected.txt: Removed.
      * http/tests/inspector/filesystem/delete-entry.html: Removed.
      * http/tests/inspector/filesystem/directory-tree-expected.txt: Removed.
      * http/tests/inspector/filesystem/directory-tree.html: Removed.
      * http/tests/inspector/filesystem/filesystem-test.js: Removed.
      * http/tests/inspector/filesystem/request-directory-content-expected.txt: Removed.
      * http/tests/inspector/filesystem/request-directory-content.html: Removed.
      * http/tests/inspector/filesystem/request-file-content-expected.txt: Removed.
      * http/tests/inspector/filesystem/request-file-content.html: Removed.
      * http/tests/inspector/filesystem/request-filesystem-root-expected.txt: Removed.
      * http/tests/inspector/filesystem/request-filesystem-root.html: Removed.
      * http/tests/inspector/filesystem/request-metadata-expected.txt: Removed.
      * http/tests/inspector/filesystem/request-metadata.html: Removed.
      * http/tests/security/contentSecurityPolicy/filesystem-urls-match-self-expected.txt: Removed.
      * http/tests/security/contentSecurityPolicy/filesystem-urls-match-self.html: Removed.
      * http/tests/security/filesystem-iframe-from-remote-expected.txt: Removed.
      * http/tests/security/filesystem-iframe-from-remote.html: Removed.
      * http/tests/security/mixedContent/filesystem-url-in-iframe-expected.txt: Removed.
      * http/tests/security/mixedContent/filesystem-url-in-iframe.html: Removed.
      * http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Removed.
      * http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Removed.
      * http/tests/websocket/tests/hybi/send-file-blob-fail.html: Removed.
      * http/tests/websocket/tests/hybi/send-file-blob.html: Removed.
      * http/tests/workers/resources/sync-operations.js:
      (onmessage):
      * http/tests/workers/terminate-during-sync-operation-expected.txt: Removed.
      * http/tests/workers/terminate-during-sync-operation.html: Removed.
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7df82b33