1. 07 Sep, 2013 1 commit
    • mark.lam@apple.com's avatar
      Change LayoutTests' c* files to use pre and post js files in LayoutTests/resources. · 06155302
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120986.
      
      Rubber stamped by Filip Pizlo.
      
      * canvas/philip/tests/2d.composite.globalComposite.html:
      * compositing/repaint/shrink-layer.html:
      * css1/units/rounding.html:
      * css3/calc/color-hsl.html:
      * css3/calc/color-rgb.html:
      * css3/calc/font-size-fractional.html:
      * css3/calc/font-size.html:
      * css3/calc/font.html:
      * css3/calc/getComputedStyle-margin-percentage.html:
      * css3/calc/line-height.html:
      * css3/calc/margin.html:
      * css3/calc/table-border-spacing.html:
      * css3/calc/table-calcs.html:
      * css3/calc/zoom-with-em.html:
      * css3/compositing/background-blend-mode-property-parsing.html:
      * css3/compositing/background-blend-mode-property.html:
      * css3/compositing/blend-mode-property-parsing-invalid.html:
      * css3/compositing/blend-mode-property-parsing.html:
      * css3/compositing/blend-mode-property.html:
      * css3/compositing/should-have-compositing-layer.html:
      * css3/filters/custom-with-at-rule-syntax/parsing-at-rule-invalid.html:
      * css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid.html:
      * css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid.html:
      * css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid.html:
      * css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-invalid.html:
      * css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-valid.html:
      * css3/filters/custom-with-at-rule-syntax/parsing-mix-property-invalid.html:
      * css3/filters/custom-with-at-rule-syntax/parsing-mix-property-valid.html:
      * css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid.html:
      * css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid.html:
      * css3/filters/custom-with-at-rule-syntax/parsing-src-property-invalid.html:
      * css3/filters/custom-with-at-rule-syntax/parsing-src-property-valid.html:
      * css3/filters/custom/custom-filter-crash-inline-computed-style.html:
      * css3/filters/custom/custom-filter-mix-bindings.html:
      * css3/filters/custom/custom-filter-property-computed-style.html:
      * css3/filters/custom/custom-filter-property-parsing-invalid.html:
      * css3/filters/custom/custom-filter-property-parsing.html:
      * css3/filters/custom/effect-custom-disabled.html:
      * css3/filters/effect-reference-delete-crash.html:
      * css3/filters/effect-reference-reset-style-delete-crash.html:
      * css3/filters/filter-property-computed-style.html:
      * css3/filters/filter-property-parsing-invalid.html:
      * css3/filters/filter-property-parsing.html:
      * css3/filters/filter-property.html:
      * css3/filters/script-tests/TEMPLATE.html:
      * css3/filters/should-not-have-compositing-layer.html:
      * css3/flexbox/align-absolute-child.html:
      * css3/flexbox/css-properties.html:
      * css3/flexbox/display-flexbox-set-get.html:
      * css3/flexbox/flex-align-baseline.html:
      * css3/flexbox/flex-flow-initial.html:
      * css3/flexbox/flex-longhand-parsing.html:
      * css3/flexbox/flex-property-parsing.html:
      * css3/flexbox/flexitem-no-margin-collapsing.html:
      * css3/flexbox/overflow-keep-scrollpos.html:
      * css3/font-feature-settings-parsing.html:
      * css3/supports-cssom.html:
      * css3/supports-dom-api.html:
      * css3/supports.html:
      * css3/unicode-bidi-insolate-parse.html:
      * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle.html:
      * css3/zoom-coords.xhtml:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06155302
  2. 23 Apr, 2013 1 commit
    • ch.dumez@sisa.samsung.com's avatar
      Global constructors should be configurable and not enumerable · 0051b742
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=110573
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore:
      
      Update JSObject::deleteProperty() so that mark to set the property
      value to undefined if it is in static hashtable of properties. The
      previous code was not doing anything in this case and this meant
      we could not remove builtin DOMWindow properties such as
      "ProgressEvent" even if marked as Deletable.
      
      * runtime/JSObject.cpp:
      (JSC::JSObject::deleteProperty):
      * runtime/Lookup.h:
      (JSC):
      (JSC::putEntry):
      (JSC::lookupPut):
      
      Source/WebCore:
      
      Update JSC Code generator so that global constructors now have the following
      attributes:
      { [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true }
      instead of previously:
      { [[Writable]]: true, [[Enumerable]]: true, [[Configurable]]: false }
      
      The new behavior is according to the Web IDL specification (section 4.4):
      http://dev.w3.org/cvsweb/~checkout~/2006/webapi/WebIDL/Overview.html?rev=1.617;content-type=text%2Fhtml#es-interfaces
      
      This also matches the behavior of Firefox.
      
      Tests: fast/js/global-constructors-attributes.html
             fast/js/global-constructors-deletable.html
      
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateAttributesHashTable):
      
      LayoutTests:
      
      Add new tests to make sure that the global constructors have the
      right attributes and to check that they are 'Deletable'.
      
      * canvas/philip/tests/type.delete-expected.txt: Removed.
      * canvas/philip/tests/type.delete.html: Removed. It was checking that global constructor
      could NOT be deleted, which is no longer according to the Web IDL specification.
      * fast/dom/constructed-objects-prototypes-expected.txt:
      * fast/dom/script-tests/constructed-objects-prototypes.js: Update test to hardcode a few
      global constructors as they are no longer enumerable.
      * fast/js/getOwnPropertyDescriptor-expected.txt:
      * fast/js/global-constructors.html: Removed. It was relying on the global constructors
      to be 'Enumerable', which is not to the latest Web IDL specification.
      * fast/js/global-constructors-attributes-expected.txt: Added.
      * fast/js/global-constructors-attributes.html: Added.
      * fast/js/global-constructors-deletable-expected.txt: Added.
      * fast/js/global-constructors-deletable.html: Added.
      * fast/js/global-constructors-expected.txt: Removed.
      * fast/js/resources/getOwnPropertyDescriptor.js:
      * fast/js/script-tests/global-constructors-attributes.js: Added.
      * fast/js/script-tests/global-constructors-deletable.js: Added.
      * fast/js/script-tests/global-constructors.js: Removed.
      * platform/efl/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
      * platform/efl/fast/js/global-constructors-expected.txt: Removed.
      * platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
      * platform/gtk/fast/js/global-constructors-expected.txt: Removed.
      * platform/mac/fast/js/global-constructors-expected.txt: Removed.
      * platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
      * platform/qt/fast/js/global-constructors-expected.txt: Removed.
      * platform/win/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
      * platform/win/fast/js/global-constructors-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0051b742
  3. 02 Dec, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Extend JavaScript support for blending in canvas · 47203e16
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101804
      
      Patch by Rik Cabanier <cabanier@adobe.com> on 2012-12-02
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      Added parsing code and variables to support additional canvas blend modes
      see spec: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#canvascompositingandblending
      
      Test: canvas/philip/tests/2d.composite.globalComposite.html
      
      * html/HTMLImageElement.cpp:
      (WebCore::HTMLImageElement::parseAttribute):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::State::State):
      (WebCore::CanvasRenderingContext2D::State::operator=):
      (WebCore::CanvasRenderingContext2D::globalCompositeOperation):
      (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
      (WebCore::CanvasRenderingContext2D::drawImageFromRect):
      * html/canvas/CanvasRenderingContext2D.h:
      (State):
      * platform/graphics/GraphicsTypes.cpp:
      (WebCore):
      (WebCore::parseCompositeAndBlendOperator):
      (WebCore::compositeOperatorName):
      * platform/graphics/GraphicsTypes.h:
      
      LayoutTests:
      
      Added a test that checks that all blendingmodes are supported
      
      * canvas/philip/tests/2d.composite.globalComposite-expected.txt: Added.
      * canvas/philip/tests/2d.composite.globalComposite.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47203e16
  4. 13 Nov, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r134345. · a5d24144
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/134345
      https://bugs.webkit.org/show_bug.cgi?id=102106
      
      Incomplete support for NATIVE_TYPE_ERR in objc and other
      bindings (Requested by jsbell on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13
      
      Source/WebCore:
      
      * Modules/mediastream/MediaConstraintsImpl.cpp:
      (WebCore::MediaConstraintsImpl::create):
      * Modules/mediastream/MediaStreamTrackList.cpp:
      (WebCore::MediaStreamTrackList::add):
      (WebCore::MediaStreamTrackList::remove):
      * Modules/mediastream/RTCDataChannel.cpp:
      (WebCore::RTCDataChannel::setBinaryType):
      * Modules/mediastream/RTCIceCandidate.cpp:
      (WebCore::RTCIceCandidate::create):
      * Modules/mediastream/RTCPeerConnection.cpp:
      (WebCore::RTCPeerConnection::parseConfiguration):
      (WebCore::RTCPeerConnection::createOffer):
      (WebCore::RTCPeerConnection::createAnswer):
      (WebCore::RTCPeerConnection::setLocalDescription):
      (WebCore::RTCPeerConnection::setRemoteDescription):
      (WebCore::RTCPeerConnection::addIceCandidate):
      (WebCore::RTCPeerConnection::addStream):
      (WebCore::RTCPeerConnection::removeStream):
      * Modules/mediastream/RTCSessionDescription.cpp:
      (WebCore::RTCSessionDescription::create):
      (WebCore::RTCSessionDescription::setType):
      * bindings/js/CallbackFunction.cpp:
      (WebCore::checkFunctionOnlyCallback):
      * bindings/js/JSCustomXPathNSResolver.cpp:
      (WebCore::JSCustomXPathNSResolver::create):
      * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
      (WebCore::JSHTMLOptionsCollection::add):
      * bindings/js/JSHTMLSelectElementCustom.cpp:
      (WebCore::selectIndexSetter):
      * bindings/js/JSMutationObserverCustom.cpp:
      (WebCore::JSMutationObserverConstructor::constructJSMutationObserver):
      * bindings/js/JSSQLResultSetRowListCustom.cpp:
      (WebCore::JSSQLResultSetRowList::item):
      * bindings/js/JSSQLTransactionCustom.cpp:
      (WebCore::JSSQLTransaction::executeSql):
      * bindings/js/JSSQLTransactionSyncCustom.cpp:
      (WebCore::JSSQLTransactionSync::executeSql):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateParametersCheck):
      * bindings/scripts/CodeGeneratorObjC.pm:
      (GenerateImplementation):
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateFunctionCallString):
      * bindings/v8/V8Callback.h:
      (WebCore::createFunctionOnlyCallback):
      * bindings/v8/V8Collection.cpp:
      (WebCore::toOptionsCollectionSetter):
      * bindings/v8/custom/V8DocumentCustom.cpp:
      (WebCore::V8Document::evaluateCallback):
      * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
      (WebCore::V8HTMLOptionsCollection::addCallback):
      * bindings/v8/custom/V8MutationObserverCustom.cpp:
      (WebCore::V8MutationObserver::constructorCallback):
      * bindings/v8/custom/V8SQLTransactionCustom.cpp:
      (WebCore::V8SQLTransaction::executeSqlCallback):
      * bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
      (WebCore::V8SQLTransactionSync::executeSqlCallback):
      * dom/DOMCoreException.idl:
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::insertAdjacentElement):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::webkitAddKey):
      * html/HTMLOptionsCollection.cpp:
      (WebCore::HTMLOptionsCollection::add):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::drawImage):
      (WebCore::CanvasRenderingContext2D::createPattern):
      (WebCore::CanvasRenderingContext2D::putImageData):
      (WebCore::CanvasRenderingContext2D::webkitPutImageDataHD):
      * page/Crypto.cpp:
      (WebCore::Crypto::getRandomValues):
      * page/DOMSelection.cpp:
      (WebCore::DOMSelection::extend):
      * svg/properties/SVGTransformListPropertyTearOff.h:
      (WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):
      
      LayoutTests:
      
      * canvas/philip/tests/2d.drawImage.null.html:
      * canvas/philip/tests/2d.imageData.put.null.html:
      * canvas/philip/tests/2d.pattern.image.null.html:
      * editing/selection/extend-expected.txt:
      * fast/dom/Geolocation/argument-types-expected.txt:
      * fast/dom/Geolocation/not-enough-arguments-expected.txt:
      * fast/dom/Geolocation/script-tests/argument-types.js:
      (test):
      * fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt:
      * fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt:
      * fast/js/select-options-add-expected.txt:
      * fast/mediastream/RTCIceCandidate-expected.txt:
      * fast/mediastream/RTCPeerConnection-expected.txt:
      * fast/mediastream/RTCSessionDescription-expected.txt:
      * media/encrypted-media/encrypted-media-syntax-expected.txt:
      * media/encrypted-media/encrypted-media-syntax.html:
      * media/video-test.js:
      * platform/chromium/fast/dynamic/insertAdjacentElement-expected.txt:
      * security/crypto-random-values-types-expected.txt:
      * svg/dom/SVGTransformList-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5d24144
  5. 12 Nov, 2012 1 commit
    • arv@chromium.org's avatar
      Replace DOMException TYPE_MISMATCH_ERR with TypeError · 04fc7b0e
      arv@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101604
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      DOMException.TYPE_MISMATCH_ERR is deprecated in favor of using TypeError.
      
      We have historically used TYPE_MISMATCH_ERR as a blanket DOMException code when
      the spec mandates TypeError being thrown.
      
      Updated existing tests.
      
      * Modules/mediastream/MediaConstraintsImpl.cpp:
      * Modules/mediastream/MediaStreamTrackList.cpp:
      * Modules/mediastream/PeerConnection00.cpp:
      * Modules/mediastream/RTCDataChannel.cpp:
      * Modules/mediastream/RTCIceCandidate.cpp:
      * Modules/mediastream/RTCPeerConnection.cpp:
      * Modules/mediastream/RTCSessionDescription.cpp:
      * Modules/mediastream/SessionDescription.cpp:
      * bindings/js/CallbackFunction.cpp:
      * bindings/js/JSCustomXPathNSResolver.cpp:
      * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
      * bindings/js/JSHTMLSelectElementCustom.cpp:
      * bindings/js/JSMutationObserverCustom.cpp:
      * bindings/js/JSSQLResultSetRowListCustom.cpp:
      * bindings/js/JSSQLTransactionCustom.cpp:
      * bindings/js/JSSQLTransactionSyncCustom.cpp:
      * bindings/scripts/CodeGeneratorJS.pm:
      * bindings/scripts/CodeGeneratorObjC.pm:
      * bindings/scripts/CodeGeneratorV8.pm:
      * bindings/v8/V8Callback.h:
      * bindings/v8/V8Collection.cpp:
      * bindings/v8/custom/V8DocumentCustom.cpp:
      * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
      * bindings/v8/custom/V8MutationObserverCustom.cpp:
      * bindings/v8/custom/V8SQLTransactionCustom.cpp:
      * bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
      * dom/DOMCoreException.idl:
      * html/HTMLElement.cpp:
      * html/HTMLMediaElement.cpp:
      * html/HTMLOptionsCollection.cpp:
      * html/canvas/CanvasRenderingContext2D.cpp:
      * page/Crypto.cpp:
      * page/DOMSelection.cpp:
      * svg/properties/SVGTransformListPropertyTearOff.h:
      
      LayoutTests:
      
      Update the tests to test for TypeError instead of DOMException with the TYPE_MISMATCH_ERR code.
      
      * canvas/philip/tests/2d.drawImage.null.html:
      * canvas/philip/tests/2d.imageData.put.null.html:
      * canvas/philip/tests/2d.pattern.image.null.html:
      * editing/selection/extend-expected.txt:
      * fast/dom/Geolocation/argument-types-expected.txt:
      * fast/dom/Geolocation/not-enough-arguments-expected.txt:
      * fast/dom/Geolocation/script-tests/argument-types.js:
      * fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt:
      * fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt:
      * fast/js/select-options-add-expected.txt:
      * fast/mediastream/RTCIceCandidate-expected.txt:
      * fast/mediastream/RTCPeerConnection-expected.txt:
      * fast/mediastream/RTCSessionDescription-expected.txt:
      * fast/mediastream/SessionDescription-expected.txt:
      * fast/mediastream/peerconnection-addstream-expected.txt:
      * fast/mediastream/peerconnection-iceoptions-expected.txt:
      * fast/mediastream/peerconnection-iceoptions.html:
      * fast/mediastream/peerconnection-removestream-expected.txt:
      * media/encrypted-media/encrypted-media-syntax.html:
      * media/video-test.js:
      * platform/chromium/fast/dynamic/insertAdjacentElement-expected.txt:
      * security/crypto-random-values-types-expected.txt:
      * svg/dom/SVGTransformList-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04fc7b0e
  6. 10 Sep, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Font value should be parsed as a individual property · 5fb51dca
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96271
      
      Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-09-10
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      Parsing the font value as an individual CSS property instead of a style
      body should make it significantly more effective and will not
      validate something like ctx.font = "25px serif; background: green".
      
      Updated canvas/philip/tests/2d.text.font.parse.invalid.html to cover
      this use case.
      
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::setFont):
      
      LayoutTests:
      
      Updated test to the latest W3C approved version. It adds a test
      that verifies this fix.
      
      * canvas/philip/tests/2d.text.font.parse.invalid.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fb51dca
  7. 20 Aug, 2012 3 commits
    • commit-queue@webkit.org's avatar
      2d.imageData.object.wrap.html has wrong expectations · 972ccb53
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94089
      
      Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-08-20
      Reviewed by Kenneth Rohde Christiansen.
      
      Updating and renaming the test to match new version in W3C approved tests.
      
      * canvas/philip/tests/2d.imageData.object.clamp-expected.txt: Renamed from LayoutTests/canvas/philip/tests/2d.imageData.object.wrap-expected.txt.
      * canvas/philip/tests/2d.imageData.object.clamp.html: Renamed from LayoutTests/canvas/philip/tests/2d.imageData.object.wrap.html.
      * platform/chromium/TestExpectations: Unskipping.
      * platform/efl/Skipped: Unskipping.
      * platform/gtk/TestExpectations: Unskipping.
      * platform/mac/Skipped: Unskipping.
      * platform/qt/Skipped: Unskipping.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      972ccb53
    • commit-queue@webkit.org's avatar
      Update canvas tests that are using CanvasPixelArray · b33844d1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94474
      
      Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-20
      Reviewed by Andreas Kling.
      
      CanvasPixelArray is deprecated. W3C already updated these tests on the
      approved tests repository. Using Uint8ClampedArray, they now pass on
      WebKit.
      
      * canvas/philip/tests/2d.imageData.create1.type.html:
      * canvas/philip/tests/2d.imageData.create2.type.html:
      * canvas/philip/tests/2d.imageData.get.type.html:
      * platform/chromium/TestExpectations:
      * platform/efl/Skipped:
      * platform/gtk/TestExpectations:
      * platform/mac/canvas/philip/tests/2d.imageData.create1.type-expected.txt: Removed.
      * platform/mac/canvas/philip/tests/2d.imageData.create2.type-expected.txt: Removed.
      * platform/mac/canvas/philip/tests/2d.imageData.get.type-expected.txt: Removed.
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b33844d1
    • commit-queue@webkit.org's avatar
      The 2d.imageData.object.round canvas test is failing · 2da5f0f9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=40272
      
      Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-08-20
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WTF:
      
      According to the Uint8ClampedArray spec (http://www.khronos.org/registry/typedarray/specs/latest/#7.1)
      which references WebIDL's clamping rules, with implications defined in http://www.w3.org/TR/WebIDL/#es-octet
      we need to round to nearest integer, and to the even one if exactly halfway in between.
      As a solution: applying C99's lrint which, in default rounding mode, does that.
      
      The updated version of test 2d.imageData.object.round.html test passes now.
      
      * wtf/MathExtras.h:
      (lrint): Assembly based implementation for MSVC under X86, otherwise falling back to casting.
      * wtf/Uint8ClampedArray.h:
      (WTF::Uint8ClampedArray::set): lrint instead of simple rounding.
      
      LayoutTests:
      
      Fixing expectations for the imageData rounding test, unskipping the tests on all ports.
      
      * canvas/philip/tests/2d.imageData.object.round.html: Fixing expected results according to "round to even in halfway case".
      * fast/canvas/canvas-ImageData-behaviour-expected.txt: Fixing expected results according to "round to even in halfway case".
      * fast/canvas/canvas-ImageData-behaviour.js: Fixing expected results according to "round to even in halfway case".
      * platform/chromium/TestExpectations: Updating bug id for 2d.imageData.object.round.html and for wrap case, adding SVG case for rebaselining.
      * platform/efl/Skipped: 2d.imageData.object.round.html
      * platform/efl/TestExpectations: Moving 2d.imageData.object.wrap.html case here with new bug id.
      * platform/gtk/TestExpectations: Unskippng 2d.imageData.object.round.html, updating bug id for wrap case.
      * platform/mac/Skipped: Unskipping 2d.imageData.object.round.html.
      * platform/qt/Skipped: Unskipping 2d.imageData.object.round.html.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2da5f0f9
  8. 15 Aug, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Relative units are not set when the canvas has not parent · 74d3b69c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93840
      
      Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-15
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore:
      
      Set the default font when no parent style is set. It will make
      possible to apply relative units when a parent is not set.
      
      No new tests, unskipped the existing ones.
      
      * css/StyleBuilder.cpp:
      (WebCore::ApplyPropertyFontSize::applyValue):
      Make it possible to apply relative units if a parent style exist but
      not a parent node. It works like this for em and ex, but not for
      percent units.
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore):
      (WebCore::CanvasRenderingContext2D::setFont):
      
      LayoutTests:
      
      Unskipped tests that will now pass, removed wrong expectations
      and updated test case which was fixed by the W3C.
      
      * canvas/philip/tests/2d.text.font.parse.size.percentage.default.html:
      This test case was fixed on W3C upstream:
      https://www.w3.org/Bugs/Public/show_bug.cgi?id=18522
      * fast/canvas/canvas-font-ex-units-crash-expected.txt:
      * fast/canvas/script-tests/canvas-font-ex-units-crash.js:
      * platform/chromium/TestExpectations:
      * platform/chromium/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt: Removed.
      * platform/chromium/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt: Removed.
      * platform/efl/Skipped:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/mac/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt: Removed.
      * platform/mac/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt: Removed.
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74d3b69c
  9. 15 Jun, 2012 1 commit
  10. 04 Jan, 2012 1 commit
  11. 11 Nov, 2011 1 commit
    • commit-queue@webkit.org's avatar
      Update expected results for composited canvas operations · d0b58d2c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71995
      
      Patch by Ben Wells <benwells@chromium.org> on 2011-11-11
      Reviewed by Kenneth Russell.
      
      * canvas/philip/tests/2d.composite.uncovered.image.copy-expected.txt:
      * canvas/philip/tests/2d.composite.uncovered.image.destination-atop-expected.txt:
      * canvas/philip/tests/2d.composite.uncovered.image.destination-in-expected.txt:
      * canvas/philip/tests/2d.composite.uncovered.image.source-in-expected.txt:
      * canvas/philip/tests/2d.composite.uncovered.image.source-out-expected.txt:
      * canvas/philip/tests/2d.composite.uncovered.pattern.copy-expected.txt:
      * platform/chromium/test_expectations.txt:
      * platform/gtk/Skipped:
      * platform/mac/Skipped:
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0b58d2c
  12. 29 Aug, 2011 1 commit
  13. 11 Jul, 2011 1 commit
  14. 14 Jun, 2011 1 commit
  15. 27 May, 2011 1 commit
    • andreas.kling@nokia.com's avatar
      2011-05-27 Andreas Kling <kling@webkit.org> · 295e78b2
      andreas.kling@nokia.com authored
              Reviewed by Benjamin Poulain.
      
              Update RGBA color serialization to match HTML5.
              https://bugs.webkit.org/show_bug.cgi?id=61449
      
              HTML5 now specifies that fully transparent colors should have their alpha value
              serialized to "0" rather than "0.0" (followed by any number of extra zeroes.)
      
              The number of decimals for alpha values between 0 and 1 is not specified,
              so match Gecko and Presto by returning the lowest number of decimals needed
              to represent the number. (No more trailing zeroes.)
      
              * platform/graphics/Color.cpp:
              (WebCore::Color::serialized):
      2011-05-27  Andreas Kling  <kling@webkit.org>
      
              Reviewed by Benjamin Poulain.
      
              Update RGBA color serialization to match HTML5.
              https://bugs.webkit.org/show_bug.cgi?id=61449
      
              Update tests to reflect the new behavior.
      
              * canvas/philip/tests/2d.fillStyle.get.transparent.html:
              * canvas/philip/tests/2d.shadow.attributes.shadowColor.initial.html:
              * canvas/philip/tests/2d.shadow.attributes.shadowColor.valid.html:
              * editing/style/inline-style-container-expected.txt
              * editing/style/script-tests/inline-style-container.js:
              * fast/canvas/canvas-color-clamping-expected.txt:
              * fast/canvas/canvas-color-serialization-expected.txt:
              * fast/canvas/canvas-currentColor-expected.txt:
              * fast/canvas/script-tests/canvas-color-clamping.js:
              * fast/canvas/script-tests/canvas-color-serialization.js:
              * fast/canvas/script-tests/canvas-currentColor.js:
              * fast/dom/canvasContext2d-element-attribute-js-null-expected.txt:
              * fast/dom/canvasContext2d-element-attribute-js-null.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      295e78b2
  16. 25 May, 2011 1 commit
  17. 23 Feb, 2011 1 commit
  18. 28 Dec, 2010 1 commit
    • inferno@chromium.org's avatar
      2010-12-28 Abhishek Arya <inferno@chromium.org> · fe68f979
      inferno@chromium.org authored
              Reviewed by Kenneth Russell.
      
              Fix crash with invalid font in m_fontList by not drawing text when a custom font is in the
              process of loading.
              https://bugs.webkit.org/show_bug.cgi?id=51681
      
              Test: canvas/philip/tests/2d.text-custom-font-load-crash.html
      
              * html/canvas/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::drawTextInternal): bail out if a custom font is loading.
              * platform/graphics/Font.cpp:
              (WebCore::Font::operator==): Replace condition with new function loadingCustomFonts()
              (WebCore::Font::drawText): Replace condition with new function loadingCustomFonts()
              (WebCore::Font::drawEmphasisMarks): Replace condition with new function loadingCustomFonts()
              * platform/graphics/Font.h:
              (WebCore::Font::loadingCustomFonts): new function that returns if a custom font is loading.
      2010-12-28  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Kenneth Russell.
      
              Tests that we do not crash when drawing text during custom font load.
              https://bugs.webkit.org/show_bug.cgi?id=51681
      
              * canvas/philip/tests/2d.text-custom-font-load-crash-expected.txt: Added.
              * canvas/philip/tests/2d.text-custom-font-load-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe68f979
  19. 11 Nov, 2010 1 commit
    • chang.shu@nokia.com's avatar
      2010-11-11 Chang Shu <chang.shu@nokia.com> · f7269e04
      chang.shu@nokia.com authored
              Reviewed by Csaba Osztrogonác  <ossy@webkit.org>.
      
              Clean up LayoutTests/canvas/philip/tests/security* tests
              https://bugs.webkit.org/show_bug.cgi?id=49317
      
              The security tests require httpd and should be in http/tests/canvas/philip/tests.
      
              * canvas/philip/tests/security.drawImage.canvas-expected.txt: Removed.
              * canvas/philip/tests/security.drawImage.canvas.html: Removed.
              * canvas/philip/tests/security.drawImage.image-expected.txt: Removed.
              * canvas/philip/tests/security.drawImage.image.html: Removed.
              * canvas/philip/tests/security.pattern.canvas.fillStyle-expected.txt: Removed.
              * canvas/philip/tests/security.pattern.canvas.fillStyle.html: Removed.
              * canvas/philip/tests/security.pattern.canvas.strokeStyle-expected.txt: Removed.
              * canvas/philip/tests/security.pattern.canvas.strokeStyle.html: Removed.
              * canvas/philip/tests/security.pattern.canvas.timing-expected.txt: Removed.
              * canvas/philip/tests/security.pattern.canvas.timing.html: Removed.
              * canvas/philip/tests/security.pattern.create-expected.txt: Removed.
              * canvas/philip/tests/security.pattern.create.html: Removed.
              * canvas/philip/tests/security.pattern.cross-expected.txt: Removed.
              * canvas/philip/tests/security.pattern.cross.html: Removed.
              * canvas/philip/tests/security.pattern.image.fillStyle-expected.txt: Removed.
              * canvas/philip/tests/security.pattern.image.fillStyle.html: Removed.
              * canvas/philip/tests/security.pattern.image.strokeStyle-expected.txt: Removed.
              * canvas/philip/tests/security.pattern.image.strokeStyle.html: Removed.
              * canvas/philip/tests/security.reset-expected.txt: Removed.
              * canvas/philip/tests/security.reset.html: Removed.
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/mac-leopard/Skipped:
              * platform/qt/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7269e04
  20. 09 Nov, 2010 1 commit
  21. 07 Nov, 2010 2 commits
    • andreas.kling@nokia.com's avatar
      2010-11-07 Andreas Kling <kling@webkit.org> · 5a34d564
      andreas.kling@nokia.com authored
              Unreviewed, rebaselining failures on Leopard and Snow Leopard after r71481.
      
              * canvas/philip/tests/2d.imageData.get.source.negative-expected.txt:
              * canvas/philip/tests/security.pattern.canvas.timing-expected.txt:
              * canvas/philip/tests/security.pattern.create-expected.txt:
              * canvas/philip/tests/security.pattern.cross-expected.txt:
              * canvas/philip/tests/security.pattern.image.fillStyle-expected.txt:
              * canvas/philip/tests/security.pattern.image.strokeStyle-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.broken-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.null-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create1.type-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create2.type-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.imageData.get.type-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.line.cap.closed-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.line.join.parallel-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.line.miter.lineedge-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.missingargs-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.path.rect.winding-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.broken-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.incomplete-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.blur-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.x-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.y-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.shadow.gradient.basic-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.ideographic-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.top-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.basic-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.complex-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.system-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/2d.text.measure.width.space-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt:
              * platform/mac-snowleopard/canvas/philip/tests/type.prototype-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a34d564
    • andreas.kling@nokia.com's avatar
      2010-10-18 Andreas Kling <kling@webkit.org> · 7817c169
      andreas.kling@nokia.com authored
              Reviewed by James Robinson.
      
              Update our clone of Philip Taylor's canvas test suite
              https://bugs.webkit.org/show_bug.cgi?id=47707
      
              Source: http://dvcs.w3.org/hg/html/file/df23d00a3395/tests/submission/PhilipTaylor
      
              * canvas/philip/README: Added, contains link to upstream revision.
              * canvas/philip/: Synced with upstream.
              * platform/gtk/Skipped: Skipped new failing tests.
              * platform/mac/Skipped: Ditto.
              * platform/qt/Skipped: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7817c169
  22. 03 Nov, 2010 2 commits
  23. 29 Oct, 2010 1 commit
  24. 14 Oct, 2010 1 commit
  25. 29 Sep, 2010 1 commit
    • eric@webkit.org's avatar
      2010-09-29 Eric Seidel <eric@webkit.org> · 716b00a1
      eric@webkit.org authored
              Unreviewed, rolling out r68568.
              http://trac.webkit.org/changeset/68568
              https://bugs.webkit.org/show_bug.cgi?id=46439
      
              Failing tests on both Leopard and Snow Leopard
      
              * canvas/philip/tests/2d.composite.operation.darker-expected.txt:
              * canvas/philip/tests/2d.composite.operation.highlight-expected.txt:
              * canvas/philip/tests/2d.composite.uncovered.fill.copy-expected.txt:
              * canvas/philip/tests/2d.composite.uncovered.fill.destination-atop-expected.txt:
              * canvas/philip/tests/2d.composite.uncovered.fill.destination-in-expected.txt:
              * canvas/philip/tests/2d.composite.uncovered.fill.source-in-expected.txt:
              * canvas/philip/tests/2d.composite.uncovered.fill.source-out-expected.txt:
              * canvas/philip/tests/2d.composite.uncovered.image.copy-expected.txt:
              * canvas/philip/tests/2d.composite.uncovered.image.destination-atop-expected.txt:
              * canvas/philip/tests/2d.composite.uncovered.image.destination-in-expected.txt:
              * canvas/philip/tests/2d.composite.uncovered.image.source-in-expected.txt:
              * canvas/philip/tests/2d.composite.uncovered.image.source-out-expected.txt:
              * canvas/philip/tests/2d.composite.uncovered.pattern.copy-expected.txt:
              * canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop-expected.txt:
              * canvas/philip/tests/2d.composite.uncovered.pattern.destination-in-expected.txt:
              * canvas/philip/tests/2d.composite.uncovered.pattern.source-in-expected.txt:
              * canvas/philip/tests/2d.composite.uncovered.pattern.source-out-expected.txt:
              * canvas/philip/tests/2d.drawImage.incomplete-expected.txt:
              * canvas/philip/tests/2d.drawImage.null-expected.txt:
              * canvas/philip/tests/2d.fillStyle.parse.current.basic-expected.txt:
              * canvas/philip/tests/2d.fillStyle.parse.current.changed-expected.txt:
              * canvas/philip/tests/2d.fillStyle.parse.current.removed-expected.txt:
              * canvas/philip/tests/2d.fillStyle.parse.system-expected.txt:
              * canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt:
              * canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt:
              * canvas/philip/tests/2d.gradient.radial.inside2-expected.txt:
              * canvas/philip/tests/2d.gradient.radial.inside3-expected.txt:
              * canvas/philip/tests/2d.gradient.radial.negative-expected.txt:
              * canvas/philip/tests/2d.gradient.radial.outside1-expected.txt:
              * canvas/philip/tests/2d.imageData.create1.type-expected.txt:
              * canvas/philip/tests/2d.imageData.create2.type-expected.txt:
              * canvas/philip/tests/2d.imageData.get.source.negative-expected.txt:
              * canvas/philip/tests/2d.imageData.get.type-expected.txt:
              * canvas/philip/tests/2d.line.cap.closed-expected.txt:
              * canvas/philip/tests/2d.line.join.parallel-expected.txt:
              * canvas/philip/tests/2d.line.miter.lineedge-expected.txt:
              * canvas/philip/tests/2d.missingargs-expected.txt:
              * canvas/philip/tests/2d.path.rect.winding-expected.txt:
              * canvas/philip/tests/2d.pattern.image.broken-expected.txt:
              * canvas/philip/tests/2d.pattern.image.incomplete-expected.txt:
              * canvas/philip/tests/2d.pattern.image.null-expected.txt:
              * canvas/philip/tests/2d.pattern.image.undefined-expected.txt:
              * canvas/philip/tests/2d.shadow.enable.blur-expected.txt:
              * canvas/philip/tests/2d.shadow.enable.x-expected.txt:
              * canvas/philip/tests/2d.shadow.enable.y-expected.txt:
              * canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt:
              * canvas/philip/tests/2d.shadow.gradient.basic-expected.txt:
              * canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt:
              * canvas/philip/tests/2d.strokeRect.zero.4-expected.txt:
              * canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt:
              * canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt:
              * canvas/philip/tests/2d.text.draw.baseline.ideographic-expected.txt:
              * canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt:
              * canvas/philip/tests/2d.text.draw.baseline.top-expected.txt:
              * canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt:
              * canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt:
              * canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt:
              * canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt:
              * canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt:
              * canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt:
              * canvas/philip/tests/2d.text.font.parse.basic-expected.txt:
              * canvas/philip/tests/2d.text.font.parse.complex-expected.txt:
              * canvas/philip/tests/2d.text.font.parse.invalid-expected.txt:
              * canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt:
              * canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt:
              * canvas/philip/tests/2d.text.font.parse.system-expected.txt:
              * canvas/philip/tests/2d.text.measure.width.space-expected.txt:
              * canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt:
              * canvas/philip/tests/type.prototype-expected.txt:
              * platform/mac/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      716b00a1
  26. 28 Sep, 2010 1 commit
  27. 23 Sep, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-09-23 Matthew Delaney <mdelaney@apple.com> · da4a2afa
      commit-queue@webkit.org authored
              Reviewed by Oliver Hunt.
      
              context.drawImage with (source rect's height) = -(input image's native height) draws nothing
              https://bugs.webkit.org/show_bug.cgi?id=46243
      
              These test simply exercise using negative widths and heights for the source rect in ctx.drawImage calls.
      
              * canvas/philip/tests/2d.drawImage.negativeSourceHeight-expected.txt: Added.
              * canvas/philip/tests/2d.drawImage.negativeSourceHeight.html: Added.
              * canvas/philip/tests/2d.drawImage.negativeSourceHeight2-expected.txt: Added.
              * canvas/philip/tests/2d.drawImage.negativeSourceHeight2.html: Added.
              * canvas/philip/tests/2d.drawImage.negativeSourceHeightAndWidth-expected.txt: Added.
              * canvas/philip/tests/2d.drawImage.negativeSourceHeightAndWidth.html: Added.
      2010-09-23  Matthew Delaney  <mdelaney@apple.com>
      
              Reviewed by Oliver Hunt.
      
              context.drawImage with (source rect's height) = -(input image's native height) draws nothing
              https://bugs.webkit.org/show_bug.cgi?id=46243
      
              This patch changes canvasrenderingcontext2d's drawImage with an image element to
              normalize the source and dest rects to acheive the desired canvas spec behavior
              of allowing negative widths and heights that don't cause flipping and fix the
              adverse behavior of specifying a source rect height of negative the source image's height
      
              Tests: canvas/philip/tests/2d.drawImage.negativeSourceHeight.html
                     canvas/philip/tests/2d.drawImage.negativeSourceHeight2.html
                     canvas/philip/tests/2d.drawImage.negativeSourceHeightAndWidth.html
      
              * html/canvas/CanvasRenderingContext2D.cpp: Normalize rects in drawImage before calling
              lower level draw calls.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68176 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da4a2afa
  28. 18 Sep, 2010 2 commits
    • dglazkov@chromium.org's avatar
      2010-09-18 Dimitri Glazkov <dglazkov@chromium.org> · 47921722
      dglazkov@chromium.org authored
              Unreviewed, rolling out r67792.
              http://trac.webkit.org/changeset/67792
              https://bugs.webkit.org/show_bug.cgi?id=45976
      
              Broke over a hundred SVG tests.
      
              * canvas/philip/tests/2d.drawImage.negativeOneDest-expected.txt: Removed.
              * canvas/philip/tests/2d.drawImage.negativeOneDest.html: Removed.
              * canvas/philip/tests/2d.drawImage.negativeOneSource-expected.txt: Removed.
              * canvas/philip/tests/2d.drawImage.negativeOneSource.html: Removed.
      2010-09-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Unreviewed, rolling out r67792.
              http://trac.webkit.org/changeset/67792
              https://bugs.webkit.org/show_bug.cgi?id=45976
      
              Broke over a hundred SVG tests.
      
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::drawImage):
              (WebCore::GraphicsContext::drawImageBuffer):
              * platform/graphics/GraphicsContext.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47921722
    • commit-queue@webkit.org's avatar
      2010-09-18 Matthew Delaney <mdelaney@apple.com> · 8b822414
      commit-queue@webkit.org authored
              Reviewed by Oliver Hunt.
      
              Canvas drawImage with source or destination widths/heights of -1 renders incorrectly.
              https://bugs.webkit.org/show_bug.cgi?id=45976
      
              * canvas/philip/tests/2d.drawImage.negativeOneDest-expected.txt: Added.
              * canvas/philip/tests/2d.drawImage.negativeOneDest.html: Added. Tests that using -1
              for the destination width/height renders correctly.
              * canvas/philip/tests/2d.drawImage.negativeOneSource-expected.txt: Added.
              * canvas/philip/tests/2d.drawImage.negativeOneSource.html: Added. Tests that using -1
              for the source width/height renders correctly.
      2010-09-18  Matthew Delaney  <mdelaney@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Canvas drawImage with source or destination widths/heights of -1 renders incorrectly.
              https://bugs.webkit.org/show_bug.cgi?id=45976
      
              Specifying a -1 width or height for either the source or destination rectangle in drawImage
              get improperly drawn with -1 replaced as the corresponding image width or height. This was because
              the value -1 was being passed around to signal non-specified widths and heights and thus was
              interpreted lower down in the drawImage implementation which disallowed any calls that actually
              wanted to use -1 as the widths or heights. Fixed this by moving the default logic up and not using
              -1 in-band signaling to denote default behavior.
      
              Tests: canvas/philip/tests/2d.drawImage.negativeOneDest.html
                     canvas/philip/tests/2d.drawImage.negativeOneSource.html
      
              * platform/graphics/GraphicsContext.cpp: Removed -1 in-band signals and replaced cascased calls to have
              the desired replaces for unspecified widths and heights earlier on.
              * platform/graphics/GraphicsContext.h: Removed faulty default value.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b822414
  29. 27 Aug, 2010 1 commit
  30. 30 Jul, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-07-30 Matthew Delaney <mdelaney@apple.com> · 453bda46
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              ctx.clearRect improperly clears shadow
              https://bugs.webkit.org/show_bug.cgi?id=43213
      
              * canvas/philip/tests/2d.clearRect+fillRect.alpha0-expected.txt: Added.
              * canvas/philip/tests/2d.clearRect+fillRect.alpha0.5-expected.txt: Added.
              * canvas/philip/tests/2d.clearRect+fillRect.alpha0.5.html: Added.
              Same as above but with alpha of one half.
              * canvas/philip/tests/2d.clearRect+fillRect.alpha0.html: Added.
              Tests that clearing rect with alpha or 0 has no unwanted side-effects
              * canvas/philip/tests/2d.clearRect+fillRect.basic-expected.txt: Added.
              * canvas/philip/tests/2d.clearRect+fillRect.basic.html: Added.
              Tests clearing a rect and then filling back over doesn't show any
              side effects (such as caused by not ignoring/restoring appropriate
              context attributes).
              * platform/mac/Skipped: unskipping now passing test
      2010-07-30  Matthew Delaney  <mdelaney@apple.com>
      
              Reviewed by Darin Adler.
      
              ctx.clearRect improperly clears shadow
              https://bugs.webkit.org/show_bug.cgi?id=43213
      
              Tests: canvas/philip/tests/2d.clearRect+fillRect.alpha0.5.html
                     canvas/philip/tests/2d.clearRect+fillRect.alpha0.html
                     canvas/philip/tests/2d.clearRect+fillRect.basic.html
      
              * html/canvas/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::setAllAttributesToDefault):
              Added a new method to wipe out all context attributes to their defaults.
              (WebCore::CanvasRenderingContext2D::clearRect):
              Updated clearRect to ignore shadow, alpha, and global composite attributes
              when clearing the input rect to match the canvas spec.
              * html/canvas/CanvasRenderingContext2D.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      453bda46
  31. 27 Jul, 2010 1 commit
    • andreas.kling@nokia.com's avatar
      2010-07-23 Helder Correia <heldercorreia@codeaurora.org> · 03a4d018
      andreas.kling@nokia.com authored
              Reviewed by Darin Adler.
      
              Canvas tests 2d.imageData.object.round and 2d.imageData.object.wrap are
              failing. For canvas image data manipulation, the values passed should
              be truncated and wrapped. Also fix the canvas-ImageData-behaviour test
              to expect wrapping rather than clamping, and add some new checkings.
              https://bugs.webkit.org/show_bug.cgi?id=40272
      
              * runtime/JSByteArray.h:
              (JSC::JSByteArray::setIndex):
              (JSC::JSByteArray::JSByteArray):
      2010-07-23  Helder Correia  <heldercorreia@codeaurora.org>
      
              Reviewed by Darin Adler.
      
              Canvas tests 2d.imageData.object.round and 2d.imageData.object.wrap are
              failing. For canvas image data manipulation, the values passed should
              be truncated and wrapped. Also fix the canvas-ImageData-behaviour test
              to expect wrapping rather than clamping, and add some new checkings.
              https://bugs.webkit.org/show_bug.cgi?id=40272
      
              * canvas/philip/tests/2d.imageData.object.round-expected.txt:
              * canvas/philip/tests/2d.imageData.object.round.html:
              * canvas/philip/tests/2d.imageData.object.wrap-expected.txt:
              * fast/canvas/canvas-ImageData-behaviour-expected.txt:
              * fast/canvas/canvas-ImageData-behaviour.js:
              * platform/mac/Skipped:
              * platform/qt/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03a4d018
  32. 20 Jul, 2010 1 commit
  33. 19 Jul, 2010 1 commit
  34. 17 Jul, 2010 1 commit
  35. 13 Jul, 2010 1 commit