1. 23 Jan, 2014 1 commit
    • ossy@webkit.org's avatar
      Unreviewed gardening. · a18f28e1
      ossy@webkit.org authored
      Move fast/harness/sample-fail-mismatch-reftest.html to the platform
      independent TestExpectations, since all ports skip it as expected.
      
      * TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a18f28e1
  2. 22 Jan, 2014 1 commit
  3. 18 Jan, 2014 1 commit
  4. 08 Jan, 2014 1 commit
    • antti@apple.com's avatar
      REGRESSION (r161195): Acid2 regression tests frequently fail · 83cd80d8
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126432
      
      Source/WebCore: 
      
      Reviewed by Anders Carlsson.
              
      We would occasionally dump the render tree before the actual last resource on the page was loaded.
      The problematic resource is an image loaded by an <object> tag nested as fallback of another <object>.
      
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::renderFallbackContent):
              
          Force style recalc when rendering fallback content. The current mechanism for triggering the fallback content load
          requires a style recalc.
      
      LayoutTests: 
      
      Reviewed by Anders Carlsson.
      
      * TestExpectations: acid2 is no longer flaky.
      * fast/overflow/overflow-height-float-not-removed-crash3-expected.txt: whitespace change.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83cd80d8
  5. 07 Jan, 2014 1 commit
    • commit-queue@webkit.org's avatar
      Add Support for the semantics element. · c2c226b5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100626
      
      Source/WebCore:
      
      Patch by Frédéric Wang <fred.wang@free.fr> on 2014-01-07
      Reviewed by Chris Fleizach.
      
      Tests: mathml/presentation/semantics-2.html
             mathml/presentation/semantics-3.html
             mathml/presentation/semantics-4.html
      
      This provides a complete support for the semantics element. When the first child is a content MathML, an annotation can be selected and displayed. The selection algorithm is identical to Gecko's one. The recognized annotations are text (e.g. LaTeX), presentation MathML, SVG and HTML.
      
      * mathml/MathMLElement.cpp:
      (WebCore::MathMLElement::childShouldCreateRenderer):
      (WebCore::MathMLElement::attributeChanged):
      (WebCore::MathMLElement::isPresentationMathML):
      * mathml/MathMLElement.h:
      (WebCore::MathMLElement::isMathMLToken):
      (WebCore::MathMLElement::isSemanticAnnotation):
      (WebCore::MathMLElement::isPresentationMathML):
      (WebCore::MathMLElement::updateSelectedChild):
      * mathml/MathMLInlineContainerElement.h:
      * mathml/MathMLSelectElement.cpp:
      (WebCore::MathMLSelectElement::getSelectedActionChildAndIndex):
      (WebCore::MathMLSelectElement::getSelectedActionChild):
      (WebCore::MathMLSelectElement::getSelectedSemanticsChild):
      (WebCore::MathMLSelectElement::updateSelectedChild):
      (WebCore::MathMLSelectElement::toggle):
      * mathml/MathMLSelectElement.h:
      * mathml/MathMLTextElement.h:
      * mathml/mathattrs.in:
      * mathml/mathtags.in:
      
      LayoutTests:
      
      Patch by Frédéric Wang <fred.wang@free.fr> on 2014-01-07
      Reviewed by Chris Fleizach.
      
      * TestExpectations:
      * mathml/presentation/semantics-2-expected.html: Added.
      * mathml/presentation/semantics-2.html: Added.
      * mathml/presentation/semantics-3-expected.html: Added.
      * mathml/presentation/semantics-3.html: Added.
      * mathml/presentation/semantics-4-expected.html: Added.
      * mathml/presentation/semantics-4.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2c226b5
  6. 06 Jan, 2014 1 commit
  7. 25 Dec, 2013 3 commits
  8. 24 Dec, 2013 2 commits
  9. 19 Dec, 2013 2 commits
  10. 06 Dec, 2013 1 commit
    • commit-queue@webkit.org's avatar
      [CSS Shapes] ShapeOutsideInfo needs to use the parent's writing mode when calculating offsets · 3b5bb143
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124680
      
      Patch by Rob Buis <rob.buis@samsung.com> on 2013-12-06
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      Do not take the writing-mode property on the float into account for shape-outside.
      Add a virtual method writingMode() in order to do this for shape-outside but
      keep old behavior (element writingMode) for shape-inside.
      
      Change existing test floats/shape-outside-floats-different-writing-modes.html to test the
      new behavior.
      
      * rendering/shapes/ShapeInfo.cpp:
      (WebCore::::computedShape):
      * rendering/shapes/ShapeInfo.h:
      (WebCore::ShapeInfo::writingMode):
      * rendering/shapes/ShapeOutsideInfo.cpp:
      (WebCore::ShapeOutsideInfo::writingMode):
      * rendering/shapes/ShapeOutsideInfo.h:
      
      LayoutTests:
      
      Make sure the writing-mode property on the float is not taken into account for shape-outside.
      Adapt highlight-shape-outside.html so it sets the writing-mode on the container div, not the float.
      However because of earlier unreliability in EFL/GTK, skip the test for now.
      
      * TestExpectations:
      * fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes.html:
      * inspector-protocol/model/highlight-shape-outside-expected.txt:
      * inspector-protocol/model/highlight-shape-outside.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b5bb143
  11. 03 Dec, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Add an MathMLSelectElement class to implement <maction> and <semantics>. · 4b77b7b4
      commit-queue@webkit.org authored
      <https://webkit.org/b/120058>
      
      Patch by Frédéric Wang <fred.wang@free.fr> on 2013-12-03
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Tests: mathml/presentation/maction-dynamic.html
             mathml/presentation/maction.html
             mathml/presentation/semantics.html
      
      This adds a new MathMLSelectElement class to prepare the implementation
      of the <maction> and <semantics> elements, for which only one "selected"
      child is visible. We now simply display the first child of the
      <semantics> element instead of hiding the annotations and this allows to
      handle the use case of SVG-in-MathML as generated by Instiki when
      bug 124128 is fixed ; Gecko's selection algorithm will be implemented
      later (bug 100626). We now also rely on the @actiontype and @selection
      attributes to select the visible <maction> child ; It remains to deal
      with the user interaction (bug 85734).
      
      * CMakeLists.txt: add the new files.
      * GNUmakefile.list.am: ditto
      * Target.pri: ditto
      * WebCore.vcxproj/WebCore.vcxproj: ditto
      * WebCore.vcxproj/WebCore.vcxproj.filters: ditto
      * WebCore.xcodeproj/project.pbxproj: ditto
      * css/mathml.css: remove the CSS rule for annotation/annotation-xml.
      * mathml/MathMLAllInOne.cpp: add the new cpp file.
      * mathml/MathMLSelectElement.cpp: Added.
      (WebCore::MathMLSelectElement::MathMLSelectElement):
      (WebCore::MathMLSelectElement::create):
      (WebCore::MathMLSelectElement::createRenderer):
      (WebCore::MathMLSelectElement::childShouldCreateRenderer):
      (WebCore::MathMLSelectElement::finishParsingChildren):
      (WebCore::MathMLSelectElement::childrenChanged):
      (WebCore::MathMLSelectElement::attributeChanged):
      (WebCore::MathMLSelectElement::updateSelectedChild): basic implementation for maction, semantics, maction@actiontype and maction@selection.
      * mathml/MathMLSelectElement.h: Added.
      * mathml/mathattrs.in: add actiontype and selection attributes.
      * mathml/mathtags.in: set element classes for maction, semantics, annotation and annotation-xml.
      
      LayoutTests:
      
      New tests for the selection of the visible child in the <maction> and <semantics> elements.
      
      * mathml/presentation/maction-dynamic-expected.html: Added.
      * mathml/presentation/maction-dynamic.html: Added.
      * mathml/presentation/maction-expected.html: Added.
      * mathml/presentation/maction.html: Added.
      * mathml/presentation/semantics-expected.html: Added.
      * mathml/presentation/semantics.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b77b7b4
  12. 02 Dec, 2013 1 commit
  13. 28 Nov, 2013 1 commit
  14. 25 Nov, 2013 1 commit
  15. 22 Nov, 2013 2 commits
  16. 13 Nov, 2013 2 commits
  17. 08 Nov, 2013 1 commit
    • mrobinson@webkit.org's avatar
      [MathML] Center of stretched curly bracket not always vertically centered · b39d0738
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123715
      
      Reviewed by Brent Fulgham.
      
      Source/WebCore:
      
      * rendering/mathml/RenderMathMLOperator.cpp:
      (WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Update an assertion and
      handle the case where two glyph pieces abut.
      (WebCore::RenderMathMLOperator::paint): Do not offset the center glyph by y().
      
      LayoutTests:
      
      * TestExpectations: Unskip mo-stretch.html. It was skipped originally,
      because MathML is changing rapidly, but we need it to test these changes.
      * mathml/presentation/mo-stretch.html: Update to show stretching characteristics
      of all stretchable glyphs.
      * platform/gtk/mathml/presentation/mo-stretch-expected.png:
      * platform/gtk/mathml/presentation/mo-stretch-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b39d0738
  18. 05 Nov, 2013 2 commits
  19. 04 Nov, 2013 3 commits
  20. 31 Oct, 2013 3 commits
    • ap@apple.com's avatar
      Enable WebCrypto on Mac · 13a73330
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123587
      
      Reviewed by Anders Carlsson.
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig: Do it.
      
      Source/WebCore:
      
      * Configurations/FeatureDefines.xcconfig: Enable it.
      
      * bindings/js/JSCryptoAlgorithmDictionary.cpp: Build fix.
      
      * crypto/CryptoAlgorithmRegistry.cpp: (WebCore::CryptoAlgorithmRegistry::getIdentifierForName):
      Special case empty keys to avoid upsetting HashMap.
      
      * crypto/algorithms/CryptoAlgorithmSHA1.cpp: (WebCore::CryptoAlgorithmSHA1::create):
      Build fix. Can't use make_unique, because constructor is private.
      
      Source/WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig: Do it.
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig: Do it.
      
      LayoutTests:
      
      * TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      Only skipping on specific platforms now.
      
      * crypto: Added.
      * crypto/crypto-gc-expected.txt: Copied from LayoutTests/security/crypto-gc-expected.txt.
      * crypto/crypto-gc.html: Copied from LayoutTests/security/crypto-gc.html.
      * crypto/crypto-random-values-expected.txt: Copied from LayoutTests/security/crypto-random-values-expected.txt.
      * crypto/crypto-random-values-limits-expected.txt: Copied from LayoutTests/security/crypto-random-values-limits-expected.txt.
      * crypto/crypto-random-values-limits.html: Copied from LayoutTests/security/crypto-random-values-limits.html.
      * crypto/crypto-random-values-types-expected.txt: Copied from LayoutTests/security/crypto-random-values-types-expected.txt.
      * crypto/crypto-random-values-types.html: Copied from LayoutTests/security/crypto-random-values-types.html.
      * crypto/crypto-random-values.html: Copied from LayoutTests/security/crypto-random-values.html.
      * crypto/subtle: Added.
      * crypto/subtle/argument-conversion-expected.txt: Copied from LayoutTests/security/crypto-subtle-arguments-expected.txt.
      * crypto/subtle/argument-conversion.html: Copied from LayoutTests/security/crypto-subtle-arguments.html.
      * crypto/subtle/gc-2-expected.txt: Copied from LayoutTests/security/crypto-subtle-gc-2-expected.txt.
      * crypto/subtle/gc-2.html: Copied from LayoutTests/security/crypto-subtle-gc-2.html.
      * crypto/subtle/gc-3-expected.txt: Copied from LayoutTests/security/crypto-subtle-gc-3-expected.txt.
      * crypto/subtle/gc-3.html: Copied from LayoutTests/security/crypto-subtle-gc-3.html.
      * crypto/subtle/gc-expected.txt: Copied from LayoutTests/security/crypto-subtle-gc-expected.txt.
      * crypto/subtle/gc.html: Copied from LayoutTests/security/crypto-subtle-gc.html.
      * crypto/subtle/resources: Added.
      * crypto/subtle/resources/common.js: Copied from LayoutTests/security/resources/common.js.
      * crypto/subtle/sha-1-expected.txt: Copied from LayoutTests/security/crypto-subtle-sha1-expected.txt.
      * crypto/subtle/sha-1.html: Copied from LayoutTests/security/crypto-subtle-sha1.html.
      * security/crypto-gc-expected.txt: Removed.
      * security/crypto-gc.html: Removed.
      * security/crypto-random-values-expected.txt: Removed.
      * security/crypto-random-values-limits-expected.txt: Removed.
      * security/crypto-random-values-limits.html: Removed.
      * security/crypto-random-values-types-expected.txt: Removed.
      * security/crypto-random-values-types.html: Removed.
      * security/crypto-random-values.html: Removed.
      * security/crypto-subtle-arguments-expected.txt: Removed.
      * security/crypto-subtle-arguments.html: Removed.
      * security/crypto-subtle-gc-2-expected.txt: Removed.
      * security/crypto-subtle-gc-2.html: Removed.
      * security/crypto-subtle-gc-3-expected.txt: Removed.
      * security/crypto-subtle-gc-3.html: Removed.
      * security/crypto-subtle-gc-expected.txt: Removed.
      * security/crypto-subtle-gc.html: Removed.
      * security/crypto-subtle-sha1-expected.txt: Removed.
      * security/crypto-subtle-sha1.html: Removed.
      * security/resources/common.js: Removed.
      Moved tests from security/ to crypto/.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13a73330
    • ap@apple.com's avatar
      [WebCrypto] Add SHA-1 · d23ff7fa
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123582
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Tests: security/crypto-subtle-arguments.html
             security/crypto-subtle-sha1.html
      
      * WebCore.xcodeproj/project.pbxproj: Added new files.
      
      * bindings/js/JSSubtleCryptoCustom.cpp:
      (WebCore::createAlgorithmFromJSValue):
      (WebCore::sequenceOfCryptoOperationDataFromJSValue):
      (WebCore::JSSubtleCrypto::digest):
      * crypto/SubtleCrypto.idl:
      Added bindings for crypto.digest.
      
      * crypto/algorithms: Added.
      * crypto/algorithms/CryptoAlgorithmSHA1.cpp: Added.
      * crypto/algorithms/CryptoAlgorithmSHA1.h: Added.
      * crypto/mac/CryptoAlgorithmRegistryMac.cpp:
      (WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Register SHA-1.
      
      * crypto/mac/CryptoAlgorithmSHA1Mac.cpp: Added.
      (WebCore::CryptoAlgorithmSHA1::digest): Performs the work synchronously, because
      otherwise we'd have to copy the data first, which is crazy for something as simple
      as hashing. We can change to a dispatch queue later if we find that it's actually
      better to copy and do the work asynchronously.
      
      LayoutTests: 
      
      * security/resources/common.js: Added from Blink.
      (importTestKeys):
      (asciiToArrayBuffer):
      (printRejectedResult):
      (printAcceptedResult):
      (failAndFinishJSTest):
      
      * security/crypto-subtle-arguments-expected.txt: Added.
      * security/crypto-subtle-arguments.html: Added.
      Added tests for how bindings treat crazy arguments. Heavily based on a test from Blink.
      
      * security/crypto-subtle-sha1-expected.txt: Added.
      * security/crypto-subtle-sha1.html: Added.
      Test that SHA-1 works.
      
      * TestExpectations: Skip these tests everywhere for now.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d23ff7fa
    • ap@apple.com's avatar
      REGRESSION(r158333): http/tests/xmlhttprequest/response-encoding.html and... · 2a262349
      ap@apple.com authored
      REGRESSION(r158333): http/tests/xmlhttprequest/response-encoding.html and xmlhttprequest-overridemimetype-content-type-header.html are failing
      https://bugs.webkit.org/show_bug.cgi?id=123548
      
      Reviewed by Brady Eidson.
      
      Source/WebCore:
      
      We had code that made sure that cached 200 responses weren't used for conditional
      requests. But it didn't work the other way - cached 304 responses got reused for
      subsequent unconditional requests!
      
      Adding the test uncovered this bug.
      
      * loader/cache/CachedRawResource.cpp: (WebCore::shouldIgnoreHeaderForCacheReuse):
      Should never ignore conditional headers. Code in determineRevalidationPolicy
      was already undoing this for conditional requests, but we also shouldn't use
      WebCore cache if it holds a 304 response to conditional request.
      
      * loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::determineRevalidationPolicy):
      Even though the changed code is only for raw resources, I think that we can never
      get a conditional request here any more.
      
      LayoutTests:
      
      * TestExpectations: Unskip tests that used to be affected by response-empty-arraybuffer.html
      
      * http/tests/xmlhttprequest/response-empty-arraybuffer-expected.txt:
      * http/tests/xmlhttprequest/response-empty-arraybuffer.html:
      Fix a stupid typo. This test actually fully passes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a262349
  21. 30 Oct, 2013 4 commits
  22. 29 Oct, 2013 2 commits
  23. 26 Oct, 2013 1 commit
  24. 25 Oct, 2013 1 commit
  25. 24 Oct, 2013 1 commit