1. 04 Sep, 2008 1 commit
  2. 10 Aug, 2008 2 commits
  3. 08 Aug, 2008 2 commits
    • cwzwarich@webkit.org's avatar
      2008-08-08 Cameron Zwarich <cwzwarich@uwaterloo.ca> · ef627558
      cwzwarich@webkit.org authored
              Reviewed by Oliver.
      
              Bug 20330: JSCore crash loading any filehurricane media page
              <https://bugs.webkit.org/show_bug.cgi?id=20330>
      
              Fix a typo in the constant loading patch. Also, add a case for
              op_unexpected_load to CodeBlock::dump().
      
              JavaScriptCore:
      
              * VM/CodeBlock.cpp:
              (KJS::CodeBlock::dump):
              * VM/CodeGenerator.cpp:
              (KJS::CodeGenerator::addUnexpectedConstant):
      
              LayoutTests:
      
              * fast/js/resources/unexpected-constant-crash.js: Added.
              * fast/js/unexpected-constant-crash-expected.txt: Added.
              * fast/js/unexpected-constant-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef627558
    • britto@apple.com's avatar
      2008-08-08 Maxime Britto <britto@apple.com> · 04ae7985
      britto@apple.com authored
              Reviewed by Adele.
      
              Test: fast/events/scroll-to-anchor-in-overflow-hidden.html
              https://bugs.webkit.org/show_bug.cgi?id=20270
              Jump to an anchor wasn't working when the overflow:hidden CSS attribute was set on the page.
      
              * WebCore.base.exp:
              * dom/Element.cpp:
              (WebCore::Element::scrollIntoView):
              (WebCore::Element::scrollIntoViewIfNeeded):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::gotoAnchor):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::handleMouseDraggedEvent):
              * page/Frame.cpp:
              (WebCore::Frame::revealSelection):
              (WebCore::Frame::revealCaret):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollRectToVisible): Takes a new parameter "scrollToAnchor" since it's a special case of scroll. It passes this new bool to canBeProgrammaticallyScrolled. 
              (WebCore::RenderLayer::autoscroll):
              * rendering/RenderLayer.h:
              * rendering/RenderListBox.h:
              (WebCore::RenderListBox::canBeProgramaticallyScrolled):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::canBeProgramaticallyScrolled): If the call is coming from a scrollToAnchor we don't need scrollBars to accept.
              * rendering/RenderObject.h:
              * rendering/RenderTextControl.h:
              (WebCore::RenderTextControl::canBeProgramaticallyScrolled):
      
      2008-08-08  Maxime Britto  <britto@apple.com>
      
              Reviewed by Adele.
      
              * WebView/WebFrame.mm:
              (-[WebFrame _scrollDOMRangeToVisible:]):
      
      2008-08-08  Maxime Britto  <britto@apple.com>
      
              Reviewed by Adele.
              https://bugs.webkit.org/show_bug.cgi?id=20270
              This test is automatic and can also be run manually.
      
              * fast/events/scroll-to-anchor-in-overflow-hidden-expected.txt: Added.
              * fast/events/scroll-to-anchor-in-overflow-hidden.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04ae7985
  4. 06 Aug, 2008 4 commits
    • ddkilzer@apple.com's avatar
      WebCore: · e6e7d429
      ddkilzer@apple.com authored
              Bug 20038: REGRESSION (r35151): Can't post comments on flickr.com
      
              <https://bugs.webkit.org/show_bug.cgi?id=20038>
              <rdar://problem/6092270>
      
              Reviewed by Eric Seidel.
      
              Test: fast/forms/submit-to-url-fragment.html
      
              The problem was that isFormSubmission was not being set to true in
              FrameLoader::loadWithDocumentLoader() when we were actually
              submitting a form, causing the page to scroll instead of the form to
              be submitted.
      
              The isFormSubmission variable wasn't set to true because a FormState
              object was not being created in
              FrameLoader::loadFrameRequestWithFormAndValues().
      
              The FormState object was not being created because
              HTMLFormElement::submit(Event*, bool activateSubmitButton) would
              only set FrameLoader::m_formAboutToBeSubmitted to the current form
              if there was a "text field" element in the form (type = text,
              password, search or isindex).
      
              Thus when FrameLoader::submitForm(const FrameLoadRequest&, Event*)
              called FrameLoader::loadFrameRequestWithFormAndValues(), a null
              HTMLFormElement pointer would be sent and cause the above failures.
      
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::submit): Call new
              FrameLoader::setFormAboutToBeSubmitted() method outside the for
              loop so we always set FrameLoader::m_formAboutToBeSubmitted exactly
              once for any form submission.  The FrameLoader::recordFormValue()
              method is only called with the name/value pair of each text field.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::setFormAboutToBeSubmitted): Added method that
              only sets m_formAboutToBeSubmitted.
              (WebCore::FrameLoader::recordFormValue): Removed
              PassRefPtr<HTMLFormElement> argument since this method only sets
              name/value pairs on m_formValuesAboutToBeSubmitted now.
              (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Create a
              FormState object as long as submitForm is not null so that other
              FrameLoader methods know when a form is being submitted.
              * loader/FrameLoader.h:
      
      LayoutTests:
      
              Bug 20038: REGRESSION (r35151): Can't post comments on flickr.com
      
              <https://bugs.webkit.org/show_bug.cgi?id=20038>
              <rdar://problem/6092270>
      
              Reviewed by Eric Seidel.
      
              * fast/forms/submit-to-url-fragment-expected.txt: Added.
              * fast/forms/submit-to-url-fragment.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6e7d429
    • ddkilzer@apple.com's avatar
      WebCore: · d5bccb54
      ddkilzer@apple.com authored
              Images using QT plugin do not display correctly
      
              <https://bugs.webkit.org/show_bug.cgi?id=9214>
              <rdar://problem/5683413>
      
              Reviewed by Darin.
      
              Tests: fast/images/embed-image.html
                     fast/images/object-image.html
      
              Use RenderImage instead of RenderPartObject for a renderer when
              the <embed> tag references an image.  Extract common code from
              HTMLEmbedElement and HTMLObjectElement into HTMLPlugInImageElement.
      
              * WebCore.xcodeproj/project.pbxproj: Added new source files.
      
              * html/HTMLEmbedElement.cpp: Cleaned up #include statements.
              (WebCore::HTMLEmbedElement::HTMLEmbedElement): Extend
              HTMLPlugInImageElement which extends HTMLPlugInElement.
              (WebCore::HTMLEmbedElement::parseMappedAttribute): Split codeAttr
              and srcAttr cases.  Create or clear HTMLImageLoader as needed for
              srcAttr.
              (WebCore::HTMLEmbedElement::rendererIsNeeded): Use
              HTMLPlugInElement::rendererIsNeeded() for images.
              (WebCore::HTMLEmbedElement::createRenderer): Create a
              RenderImage instead of a RenderPartObject for images.
              (WebCore::HTMLEmbedElement::attach): Create HTMLImageLoader,
              load image and populate RenderImage for images.
              (WebCore::HTMLEmbedElement::updateWidget): Don't call
              RenderPartObject::updateWidget() for images.
              (WebCore::HTMLEmbedElement::imageSourceAttributeName): Added.
              * html/HTMLEmbedElement.h: Removed unneeded namespace and class
              declarations.  Extend HTMLPlugInImageElement which extends
              HTMLPlugInElement.
              (WebCore::HTMLEmbedElement::imageSourceAttributeName): Added.
              (WebCore::HTMLEmbedElement::serviceType): Moved to
              HTMLPlugInImageElement.
              (WebCore::HTMLEmbedElement::url): Ditto.
      
              * html/HTMLObjectElement.cpp: Cleaned up #include statements.
              (WebCore::HTMLObjectElement::attach): Removed local variable.
              (WebCore::HTMLObjectElement::isImageType): Moved to
              HTMLPlugInImageElement.
              * html/HTMLObjectElement.h: Extend HTMLPlugInImageElement which
              extends HTMLPlugInElement.
              (WebCore::HTMLObjectElement::isImageType): Moved to
              HTMLPlugInImageElement.
              (WebCore::HTMLObjectElement::serviceType): Ditto.
              (WebCore::HTMLObjectElement::url): Ditto.
      
              * html/HTMLPlugInImageElement.cpp: Added.
              (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Added.
              (WebCore::HTMLPlugInImageElement::~HTMLPlugInImageElement): Added.
              (WebCore::HTMLPlugInImageElement::isImageType): Moved from
              HTMLObjectElement.
              * html/HTMLPlugInImageElement.h: Added.
              (WebCore::HTMLPlugInImageElement::isImageType): Added from
              HTMLObjectElement.
              (WebCore::HTMLPlugInImageElement::serviceType): Ditto.
              (WebCore::HTMLPlugInImageElement::url): Ditto.
      
              * rendering/HitTestResult.cpp:
              (WebCore::HitTestResult::absoluteImageURL): Return urlString
              for embed elements with images.
      
      LayoutTests:
      
              Images using QT plugin do not display correctly
      
              <https://bugs.webkit.org/show_bug.cgi?id=9214>
              <rdar://problem/5683413>
      
              Reviewed by Darin.
      
              Test images rendered by both embed and object elements.
      
              * fast/images/embed-image.html: Added.
              * fast/images/object-image.html: Added.
              * platform/mac/fast/images/embed-image-expected.checksum: Added.
              * platform/mac/fast/images/embed-image-expected.png: Added.
              * platform/mac/fast/images/embed-image-expected.txt: Added.
              * platform/mac/fast/images/object-image-expected.checksum: Added.
              * platform/mac/fast/images/object-image-expected.png: Added.
              * platform/mac/fast/images/object-image-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5bccb54
    • cfleizach@apple.com's avatar
      7291279f
    • cwzwarich@webkit.org's avatar
      2008-08-06 Cameron Zwarich <cwzwarich@webkit.org> · 300bb756
      cwzwarich@webkit.org authored
              Reviewed by Maciej.
      
              Bug 20286: Load constants all at once instead of using op_load
              <https://bugs.webkit.org/show_bug.cgi?id=20286>
      
              Load constants all at once into temporary registers instead of using
              individual instances of op_load.
      
              This is a 2.6% speedup on SunSpider.
      
              JavaScriptCore:
      
              * JavaScriptCore.exp:
              * VM/CodeBlock.cpp:
              (KJS::CodeBlock::dump):
              (KJS::CodeBlock::mark):
              * VM/CodeBlock.h:
              * VM/CodeGenerator.cpp:
              (KJS::CodeGenerator::CodeGenerator):
              (KJS::CodeGenerator::newTemporary):
              (KJS::CodeGenerator::addConstant):
              (KJS::CodeGenerator::addUnexpectedConstant):
              (KJS::CodeGenerator::emitLoad):
              (KJS::CodeGenerator::emitUnexpectedLoad):
              (KJS::CodeGenerator::emitNewError):
              * VM/CodeGenerator.h:
              * VM/Machine.cpp:
              (KJS::slideRegisterWindowForCall):
              (KJS::Machine::unwindCallFrame):
              (KJS::Machine::throwException):
              (KJS::Machine::execute):
              (KJS::Machine::privateExecute):
              * VM/Machine.h:
              * VM/Opcode.h:
              * VM/RegisterID.h:
              (KJS::RegisterID::RegisterID):
              (KJS::RegisterID::makeConstant):
              (KJS::RegisterID::isTemporary):
              * kjs/NodeInfo.h:
              * kjs/Parser.cpp:
              (KJS::Parser::didFinishParsing):
              * kjs/Parser.h:
              (KJS::Parser::parse):
              * kjs/grammar.y:
              * kjs/nodes.cpp:
              (KJS::NullNode::emitCode):
              (KJS::BooleanNode::emitCode):
              (KJS::NumberNode::emitCode):
              (KJS::StringNode::emitCode):
              (KJS::ArrayNode::emitCode):
              (KJS::DeleteResolveNode::emitCode):
              (KJS::DeleteValueNode::emitCode):
              (KJS::VoidNode::emitCode):
              (KJS::ConstDeclNode::emitCodeSingle):
              (KJS::ReturnNode::emitCode):
              (KJS::ScopeNode::ScopeNode):
              (KJS::ProgramNode::ProgramNode):
              (KJS::ProgramNode::create):
              (KJS::EvalNode::EvalNode):
              (KJS::EvalNode::create):
              (KJS::FunctionBodyNode::FunctionBodyNode):
              (KJS::FunctionBodyNode::create):
              (KJS::FunctionBodyNode::emitCode):
              * kjs/nodes.h:
              (KJS::ScopeNode::neededConstants):
      
              LayoutTests:
      
              * fast/js/constant-count-expected.txt: Added.
              * fast/js/constant-count.html: Added.
              * fast/js/deep-recursion-test.html:
              * fast/js/resources/constant-count.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      300bb756
  5. 05 Aug, 2008 2 commits
  6. 04 Aug, 2008 5 commits
    • mitz@apple.com's avatar
      WebCore: · 10ff0de8
      mitz@apple.com authored
      2008-08-04  Bernhard Kruepl  <kruepl@dbai.tuwien.ac.at>
      
              Reviewed by Dave Hyatt.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=19094
              Corrected offsetTop for table cells by subtracting borderTopExtra
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::offsetTop):
      
      LayoutTests:
      
      2008-08-04  Bernhard Kruepl  <kruepl@dbai.tuwien.ac.at>
      
              Reviewed by Dave Hyatt.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=19094
              Tests for offsetTop of table cells updated so that they don't include borderExtraTop
      
              * fast/dom/Element/offsetTop-table-cell-expected.txt:
              * fast/dom/Element/offsetTop-table-cell.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10ff0de8
    • weinig@apple.com's avatar
      2008-08-04 Sam Weinig <sam@webkit.org> · a4aad8d9
      weinig@apple.com authored
              Rubber-stamped by Dan Bernstein.
      
              Fix typo in Skipped lists.
      
              * platform/mac-tiger/Skipped:
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4aad8d9
    • dino@apple.com's avatar
      2008-08-04 Dean Jackson <dino@apple.com> · bb12e44a
      dino@apple.com authored
              Reviewed by Dave Hyatt.
      
              Improve AnimationController
              https://bugs.webkit.org/show_bug.cgi?id=19938
      
              - Transition class is now called Animation
              - new state-based AnimationController that can support CSS Animations
              - add support for -webkit-transition-delay
              - remove -webkit-transition-repeat-count (since it never existed officially)
              - updates the -webkit-transition shorthand to reflect removing repeat count
              - updates the Transition class so that properties can be shared with animations
              - adds a "now" keyword for -webkit-transition-delay
              - adds a new change type for style (changed by animation)
              - adds new event names (although they are not dispatched yet)
              - makes text stroke and text fill colors returned by RenderStyle const
      
              Tests:
              - manual-tests/transition-left.html
              - manual-tests/transition-delay.html
              - manual-tests/transition-timing-functions.html
      
              * css/CSSComputedStyleDeclaration.cpp:
              * css/CSSParser.cpp:
              * css/CSSParser.h:
              * css/CSSPropertyNames.in:
              * css/CSSStyleSelector.cpp:
              * css/CSSStyleSelector.h:
              * css/CSSTimingFunctionValue.h:
              * css/CSSValue.h:
              * css/CSSValueKeywords.in:
              * css/WebKitCSSTransformValue.cpp:
              * dom/Document.cpp:
              * dom/Document.h:
              * dom/Element.cpp:
              * dom/EventNames.h:
              * dom/Node.cpp:
              * dom/Node.h:
              * history/CachedPage.cpp:
              * page/AnimationController.cpp:
              * page/AnimationController.h:
              * page/Frame.cpp:
              * rendering/RenderObject.cpp:
              * rendering/RenderWidget.cpp:
              * rendering/style/RenderStyle.cpp:
              * rendering/style/RenderStyle.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb12e44a
    • weinig@apple.com's avatar
      2008-08-04 Sam Weinig <sam@webkit.org> · 0477951b
      weinig@apple.com authored
              Reviewed by Dan Bernstein.
      
              Update skipped lists for renamed tests.
      
              * platform/mac-tiger/Skipped:
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0477951b
    • weinig@apple.com's avatar
      WebCore: · 11b02038
      weinig@apple.com authored
      2008-08-02  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Implement the Access-control for Cross Site requests
              preflight cache.
      
              Tests: http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html
                     http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method.html
                     http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html
                     http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html
      
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/KURL.h:
              (WTF::):
              * platform/KURLHash.h: Added.
              (WebCore::KURLHash::hash):
              (WebCore::KURLHash::equal):
              (WTF::):
              * xml/XMLHttpRequest.cpp:
              (WebCore::PreflightResultCacheItem::PreflightResultCacheItem):
              (WebCore::preflightResultCache):
              (WebCore::appendPreflightResultCacheEntry):
              (WebCore::canSkipPrelight):
              (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
              (WebCore::parseAccessControlAllowList):
              (WebCore::parseAccessControlMaxAge):
              (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
      
      LayoutTests:
      
      2008-08-04  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Tests for the Access-control for Cross Site requests
              preflight cache.
      
              * ChangeLog:
              * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-expected.txt: Added.
              * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header-expected.txt: Added.
              * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html: Added.
              * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method-expected.txt: Added.
              * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method.html: Added.
              * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout-expected.txt: Added.
              * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html: Added.
              * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html: Added.
              * http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-invalidation.php: Added.
              * http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-timeout.php: Added.
              * http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache.php: Added.
              * http/tests/xmlhttprequest/resources/portabilityLayer.php: Added.
              * http/tests/xmlhttprequest/resources/reset-temp-file.php: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11b02038
  7. 03 Aug, 2008 2 commits
  8. 31 Jul, 2008 3 commits
    • ddkilzer@apple.com's avatar
      Updated test results for DumpRenderTree fix in r35497 · c1889c5c
      ddkilzer@apple.com authored
              * svg/custom/image-with-prefix-in-webarchive-expected.webarchive:
              Contents of the main resource are now displayed instead of encoded
              data.
              * svg/webarchive/svg-cursor-subresources-expected.webarchive: Ditto.
              * svg/webarchive/svg-feimage-subresources-expected.webarchive: Ditto.
              * svg/webarchive/svg-script-subresouces-expected.webarchive: Ditto.
              Also updated MIME types for JavaScript source now that we don't
              mangle application/x-javascript into text/javascript.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1889c5c
    • ddkilzer@apple.com's avatar
      Fix layout test results for webarchive/test-xml-stylesheet.xml · 719388a1
      ddkilzer@apple.com authored
      WebKit:
      
              Fix layout test results for webarchive/test-xml-stylesheet.xml
      
              Reviewed by Darin.
      
              * WebKit.xcodeproj/project.pbxproj: Added WebHTMLRepresentationInternal.h.
              Changed WebHTMLRepresentationInternal.h and WebHTMLRepresentationPrivate.h
              to private so they're copied into PrivateHeaders.
      
      WebKit/mac:
      
              Fix layout test results for webarchive/test-xml-stylesheet.xml
      
              Reviewed by Darin.
      
              Needed to expose -[WebHTMLRepresentation supportedNonImageMIMETypes]
              for DumpRenderTree.
      
              * WebView/WebHTMLRepresentationInternal.h: Added.
      
      WebKitTools:
      
              Fix layout test results for webarchive/test-xml-stylesheet.xml
      
              Reviewed by Darin.
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (convertMIMEType): Work around the "text/xml" local file type
              regression in Leopard using the BUILDING_ON_LEOPARD macro.  Also
              stop mangling "application/x-javascript" into "text/javascript".
              (convertWebResourceDataToString): When checking whether to dump a
              resource as text, also check to see if the MIME type is in the
              -[WebHTMLRepresentation supportedNonImageMIMETypes] array.
              * DumpRenderTree/mac/DumpRenderTreeMac.h: Added BUILDING_ON_LEOPARD
              macro.
      
      LayoutTests:
      
              Fix layout test results for webarchive/test-xml-stylesheet.xml
      
              Reviewed by Darin.
      
              * platform/mac/webarchive/test-xml-stylesheet-expected.txt:
              Removed unused test results.
      
              * webarchive/test-duplicate-resources-expected.webarchive: Updated
              results now that we don't mangle application/x-javascript into
              text/javascript.
              * webarchive/test-script-src-expected.webarchive: Ditto.
      
              * webarchive/test-xml-stylesheet-expected.webarchive: Updated
              results now that we handle application/xml correctly.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      719388a1
    • cfleizach@apple.com's avatar
      <rdar://problem/3563671> VO doesn't highlight characters when interacting when... · e282b51f
      cfleizach@apple.com authored
      <rdar://problem/3563671> VO doesn't highlight characters when interacting when static text in web areas
      
      Add ability to get bounds for individual characters through accessibility
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e282b51f
  9. 30 Jul, 2008 1 commit
    • weinig@apple.com's avatar
      WebCore: · aa998806
      weinig@apple.com authored
      2008-07-29  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Darin Adler.
      
              Update Cross-site XMLHttpRequests using Access control to
              the latest spec. (Editor's Draft 8 July 2008)
      
              - This leaves us at about the same place as we previously were
                still needing preflight caching and better redirect support.
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * xml/AccessControlList.cpp: Removed.
              * xml/AccessControlList.h: Removed.
              * xml/AccessItem.cpp: Removed.
              * xml/AccessItem.h: Removed.
              * xml/AccessItemRule.cpp: Removed.
              * xml/AccessItemRule.h: Removed.
              * xml/XMLHttpRequest.cpp:
              (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist):
              (WebCore::XMLHttpRequest::XMLHttpRequest):
              (WebCore::XMLHttpRequest::isSimpleCrossSiteAccessRequest):
              (WebCore::XMLHttpRequest::makeCrossSiteAccessRequest):
              (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
              (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
              (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
              (WebCore::XMLHttpRequest::abort):
              (WebCore::XMLHttpRequest::clearRequest):
              (WebCore::XMLHttpRequest::didFinishLoading):
              (WebCore::XMLHttpRequest::didFinishLoadingPreflight):
              (WebCore::XMLHttpRequest::accessControlCheck):
              (WebCore::XMLHttpRequest::didReceiveResponse):
              (WebCore::parseAccessControlAllowList):
              (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
              * xml/XMLHttpRequest.h:
      
      LayoutTests:
      
      2008-07-29  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Darin Adler.
      
              Update Cross-site XMLHttpRequests using Access control to
              the latest spec. (Editor's Draft 8 July 2008)
      
              - Update syntax in tests a remove tests for removed features.
      
              * http/tests/xmlhttprequest/access-control-basic-allow-async.html:
              * http/tests/xmlhttprequest/access-control-basic-blacklist-request-headers-expected.txt: Removed.
              * http/tests/xmlhttprequest/access-control-basic-blacklist-request-headers.html: Removed.
              * http/tests/xmlhttprequest/access-control-basic-exclude.html: Removed.
              * http/tests/xmlhttprequest/access-control-basic-non-simple-allow-async-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow-async-expected.txt.
              * http/tests/xmlhttprequest/access-control-basic-non-simple-allow-async.html: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow-async.html.
              * http/tests/xmlhttprequest/access-control-basic-non-simple-allow-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow-expected.txt.
              * http/tests/xmlhttprequest/access-control-basic-non-simple-allow.html: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow.html.
              * http/tests/xmlhttprequest/access-control-basic-not-get-allow-async-expected.txt: Removed.
              * http/tests/xmlhttprequest/access-control-basic-not-get-allow-async.html: Removed.
              * http/tests/xmlhttprequest/access-control-basic-not-get-allow-expected.txt: Removed.
              * http/tests/xmlhttprequest/access-control-basic-not-get-allow.html: Removed.
              * http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
              * http/tests/xmlhttprequest/resources/access-control-basic-allow-print-headers.cgi:
              * http/tests/xmlhttprequest/resources/access-control-basic-allow-star.cgi:
              * http/tests/xmlhttprequest/resources/access-control-basic-allow.cgi:
              * http/tests/xmlhttprequest/resources/access-control-basic-exclude.cgi: Removed.
              * http/tests/xmlhttprequest/resources/access-control-basic-get-fail-non-simple.cgi:
              * http/tests/xmlhttprequest/resources/access-control-basic-non-get-allow.cgi:
              * http/tests/xmlhttprequest/resources/access-control-basic-whitelist-response-headers.cgi:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa998806
  10. 29 Jul, 2008 7 commits
    • weinig@apple.com's avatar
      WebCore: · a244b918
      weinig@apple.com authored
      2008-07-29  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              <rdar://problem/6084585> Investigate upload progress events.
      
              - Add progress notifications for data being sent via a ResourceHandle.
              - Add XMLHttpRequestUpload support.
      
              Upload notifications only work on the Mac right now as the CFNetwork API
              on windows does not expose enough information.
      
              Tests: http/tests/xmlhttprequest/upload-onload-event.html
                     http/tests/xmlhttprequest/upload-onloadstart-event.html
                     http/tests/xmlhttprequest/upload-onprogress-event.html
                     http/tests/xmlhttprequest/upload-progress-events.html
      
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * bindings/js/JSEventTargetBase.cpp:
              (WebCore::toJS):
              * bindings/js/JSXMLHttpRequestCustom.cpp:
              (WebCore::JSXMLHttpRequest::mark):
              * bindings/js/JSXMLHttpRequestUploadCustom.cpp: Added.
              (WebCore::JSXMLHttpRequestUpload::mark):
              (WebCore::JSXMLHttpRequestUpload::onabort):
              (WebCore::JSXMLHttpRequestUpload::setOnabort):
              (WebCore::JSXMLHttpRequestUpload::onerror):
              (WebCore::JSXMLHttpRequestUpload::setOnerror):
              (WebCore::JSXMLHttpRequestUpload::onload):
              (WebCore::JSXMLHttpRequestUpload::setOnload):
              (WebCore::JSXMLHttpRequestUpload::onloadstart):
              (WebCore::JSXMLHttpRequestUpload::setOnloadstart):
              (WebCore::JSXMLHttpRequestUpload::onprogress):
              (WebCore::JSXMLHttpRequestUpload::setOnprogress):
              (WebCore::JSXMLHttpRequestUpload::addEventListener):
              (WebCore::JSXMLHttpRequestUpload::removeEventListener):
              (WebCore::JSXMLHttpRequestUpload::dispatchEvent):
              * dom/EventTarget.cpp:
              (WebCore::EventTarget::toXMLHttpRequestUpload):
              * dom/EventTarget.h:
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::didSendData):
              * loader/ResourceLoader.h:
              * loader/SubresourceLoader.cpp:
              (WebCore::SubresourceLoader::didSendData):
              * loader/SubresourceLoader.h:
              * loader/SubresourceLoaderClient.h:
              (WebCore::SubresourceLoaderClient::didSendData):
              * page/DOMWindow.idl:
              * platform/network/FormData.cpp:
              (WebCore::FormData::FormData):
              * platform/network/FormData.h:
              (WebCore::FormData::alwaysStream):
              (WebCore::FormData::setAlwaysStream):
              * platform/network/ResourceHandleClient.h:
              (WebCore::ResourceHandleClient::didSendData):
              * platform/network/mac/FormDataStreamMac.h:
              * platform/network/mac/FormDataStreamMac.mm:
              (WebCore::getStreamFormDataMap):
              (WebCore::getStreamResourceHandleMap):
              (WebCore::associateStreamWithResourceHandle):
              (WebCore::disassociateStreamWithResourceHandle):
              (WebCore::DidSendDataCallbackData::DidSendDataCallbackData):
              (WebCore::performDidSendDataCallback):
              (WebCore::formCreate):
              (WebCore::formFinalize):
              (WebCore::formRead):
              (WebCore::setHTTPBody):
              (WebCore::httpBodyFromStream):
              * platform/network/mac/ResourceHandleMac.mm:
              (WebCore::ResourceHandle::start):
              (WebCore::ResourceHandle::cancel):
              (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
              (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
              (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::XMLHttpRequest):
              (WebCore::XMLHttpRequest::~XMLHttpRequest):
              (WebCore::XMLHttpRequest::upload):
              (WebCore::XMLHttpRequest::open):
              (WebCore::XMLHttpRequest::send):
              (WebCore::XMLHttpRequest::createRequest):
              (WebCore::XMLHttpRequest::abort):
              (WebCore::XMLHttpRequest::networkError):
              (WebCore::XMLHttpRequest::abortError):
              (WebCore::XMLHttpRequest::didSendData):
              * xml/XMLHttpRequest.h:
              (WebCore::XMLHttpRequest::optionalUpload):
              * xml/XMLHttpRequest.idl:
              * xml/XMLHttpRequestUpload.cpp: Added.
              (WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload):
              (WebCore::XMLHttpRequestUpload::addEventListener):
              (WebCore::XMLHttpRequestUpload::removeEventListener):
              (WebCore::XMLHttpRequestUpload::dispatchEvent):
              (WebCore::XMLHttpRequestUpload::dispatchXMLHttpRequestProgressEvent):
              (WebCore::XMLHttpRequestUpload::dispatchAbortEvent):
              (WebCore::XMLHttpRequestUpload::dispatchErrorEvent):
              (WebCore::XMLHttpRequestUpload::dispatchLoadEvent):
              (WebCore::XMLHttpRequestUpload::dispatchLoadStartEvent):
              (WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
              * xml/XMLHttpRequestUpload.h: Added.
              (WebCore::XMLHttpRequestUpload::create):
              (WebCore::XMLHttpRequestUpload::toXMLHttpRequestUpload):
              (WebCore::XMLHttpRequestUpload::associatedXMLHttpRequest):
              (WebCore::XMLHttpRequestUpload::disconnectXMLHttpRequest):
              (WebCore::XMLHttpRequestUpload::setOnAbortListener):
              (WebCore::XMLHttpRequestUpload::onAbortListener):
              (WebCore::XMLHttpRequestUpload::setOnErrorListener):
              (WebCore::XMLHttpRequestUpload::onErrorListener):
              (WebCore::XMLHttpRequestUpload::setOnLoadListener):
              (WebCore::XMLHttpRequestUpload::onLoadListener):
              (WebCore::XMLHttpRequestUpload::setOnLoadStartListener):
              (WebCore::XMLHttpRequestUpload::onLoadStartListener):
              (WebCore::XMLHttpRequestUpload::setOnProgressListener):
              (WebCore::XMLHttpRequestUpload::onProgressListener):
              (WebCore::XMLHttpRequestUpload::eventListeners):
              (WebCore::XMLHttpRequestUpload::refEventTarget):
              (WebCore::XMLHttpRequestUpload::derefEventTarget):
              * xml/XMLHttpRequestUpload.idl: Added.
      
      LayoutTests:
      
      2008-07-29  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              <rdar://problem/6084585> Investigate upload progress events
      
              * fast/dom/Window/window-properties-expected.txt:
              * http/tests/xmlhttprequest/upload-onload-event-expected.txt: Added.
              * http/tests/xmlhttprequest/upload-onload-event.html: Added.
              * http/tests/xmlhttprequest/upload-onloadstart-event-expected.txt: Added.
              * http/tests/xmlhttprequest/upload-onloadstart-event.html: Added.
              * http/tests/xmlhttprequest/upload-onprogress-event-expected.txt: Added.
              * http/tests/xmlhttprequest/upload-onprogress-event.html: Added.
              * http/tests/xmlhttprequest/upload-progress-events-expected.txt: Added.
              * http/tests/xmlhttprequest/upload-progress-events.html: Added.
              * platform/win/Skipped: Skip new tests on windows where the feature is not
              implemented yet.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a244b918
    • britto@apple.com's avatar
      2008-07-29 Maxime Britto <britto@apple.com> · d20e87b0
      britto@apple.com authored
              Reviewed by adele.
      
              Test: fast/events/autoscroll-in-textfield.html
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::canBeProgramaticallyScrolled): reverted a bad change introduced in r35244
              nb:the test case introduced in r35244 is still working.
      
      2008-07-29  Maxime Britto  <britto@apple.com>
      
              Reviewed by adele.
              This test verifies that the autoscroll works within textfields.
      
              * fast/events/autoscroll-in-textfield-expected.txt: Added.
              * fast/events/autoscroll-in-textfield.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d20e87b0
    • mitz@apple.com's avatar
      Rubber-stamped by Mark Rowe. · 632c6a66
      mitz@apple.com authored
              - update results for console.group and console.groupEnd
      
              * fast/dom/Window/window-properties-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      632c6a66
    • adele@apple.com's avatar
      WebCore: · da72583e
      adele@apple.com authored
      2008-07-29  Adele Peterson  <adele@apple.com>
      
              Reviewed by Sammy Weinig.
      
              Fix for <rdar://problem/6103024>
              When a QT movie is loaded directly in the browser, I can't pause it by single-clicking on the video
      
              Test: media/video-click-dlbclick-standalone.html
      
              * loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler): For standalone media documents,
              match the default Quicktime plugin behavior to allow clicking and double-clicking to pause and play the media.
              * loader/MediaDocument.h: Added defaultEventHandler.
      
              * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::defaultEventHandler): Return early if the event has been handled.
              * rendering/MediaControlElements.cpp:
              (WebCore::MediaControlMuteButtonElement::defaultEventHandler): Correct what was probably a typo.  Instead of "event->defaultHandled()",
               it is supposed to be "event->setDefaultHandled()".
              (WebCore::MediaControlPlayButtonElement::defaultEventHandler): ditto.
              (WebCore::MediaControlSeekButtonElement::defaultEventHandler): ditto.
              (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): ditto.
      
      LayoutTests:
      
      2008-07-29  Adele Peterson  <adele@apple.com>
      
              Reviewed by Sammy Weinig.
      
              Test for <rdar://problem/6103024>
              When a QT movie is loaded directly in the browser, I can't pause it by single-clicking on the video
      
              * media/video-click-dlbclick-standalone-expected.txt: Added.
              * media/video-click-dlbclick-standalone.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da72583e
    • mitz@apple.com's avatar
      WebCore: · 3fce1b33
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/6059648> Some content not visible when the window is short at courtneyalbright.com
      
              Test: fast/overflow/float-in-relpositioned.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::lowestPosition): Add this block's relative offset
              to floats' and positioned objects' lowest position.
              (WebCore::RenderBlock::rightmostPosition): Ditto.
              (WebCore::RenderBlock::leftmostPosition): Ditto.
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::lowestPosition): Removed redundant test.
              (WebCore::RenderBox::rightmostPosition): Ditto.
              (WebCore::RenderBox::leftmostPosition): Ditto.
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - test, updated test and results for <rdar://problem/6059648> Some content not visible when the window is short at courtneyalbright.com
      
              * fast/overflow/float-in-relpositioned.html: Added.
              * fast/repaint/containing-block-position-change.html: Changed to avoid
              a full repaint due to a scroll bar appearing.
              * platform/mac/fast/clip/015-expected.txt:
              * platform/mac/fast/overflow/float-in-relpositioned-expected.checksum: Added.
              * platform/mac/fast/overflow/float-in-relpositioned-expected.png: Added.
              * platform/mac/fast/overflow/float-in-relpositioned-expected.txt: Added.
              * platform/mac/fast/repaint/clipped-relative-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fce1b33
    • mitz@apple.com's avatar
      WebCore: · 72cc551d
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/6048566> Repaint original element's position, not its offset position
      
              Test: fast/repaint/layout-state-relative.html
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::absolutePosition): Changed the LayoutState-enabled
              code path to account for the object's relative offset.
              (WebCore::RenderBox::computeAbsoluteRepaintRect): Ditto.
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - repaint test for <rdar://problem/6048566> Repaint original element's position, not its offset position
      
              * fast/repaint/layout-state-relative.html: Added.
              * platform/mac/fast/repaint/layout-state-relative-expected.checksum: Added.
              * platform/mac/fast/repaint/layout-state-relative-expected.png: Added.
              * platform/mac/fast/repaint/layout-state-relative-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72cc551d
    • hyatt@apple.com's avatar
      2008-07-29 David Hyatt <hyatt@apple.com> · 41445e75
      hyatt@apple.com authored
              Add a layout test for using multiple variable declaration blocks in a single style rule.
      
              * fast/css/variables/alternate-syntax/multiple-blocks-test.html: Added.
              * fast/css/variables/multiple-blocks-test.html: Added.
              * platform/mac/fast/css/variables/multiple-blocks-test-expected.checksum: Added.
              * platform/mac/fast/css/variables/multiple-blocks-test-expected.png: Added.
              * platform/mac/fast/css/variables/multiple-blocks-test-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41445e75
  11. 28 Jul, 2008 2 commits
    • beidson@apple.com's avatar
      WebCore: · d485d2d3
      beidson@apple.com authored
      2008-07-28  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Sam Weinig
      
              Test: security/autocomplete-cleared-on-back.html
      
              <rdar://problem/6093281> - autocomplete="off" should work when going back
      
              Taken care of in two ways:
              1 - Listening for the page cache notification to clear the form, in cases where the page
                  is being restored from the page cache
              2 - Not saving such form elements when doing the normal "save state" to a history item,
                  for cases with no page cache
      
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::~HTMLFormElement):
              (WebCore::HTMLFormElement::parseMappedAttribute):
              (WebCore::HTMLFormElement::didRestoreFromCache):
              (WebCore::HTMLFormElement::willMoveToNewOwnerDocument):
              (WebCore::HTMLFormElement::didMoveToNewOwnerDocument):
              * html/HTMLFormElement.h:
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::~HTMLInputElement):
              (WebCore::HTMLInputElement::setInputType):
              (WebCore::HTMLInputElement::saveState):
              (WebCore::HTMLInputElement::parseMappedAttribute):
              (WebCore::HTMLInputElement::needsCacheCallback):
              (WebCore::HTMLInputElement::registerForCacheCallbackIfNeeded): Only register if the type or attribute
                indicate we should.
              (WebCore::HTMLInputElement::unregisterForCacheCallbackIfNeeded): Only unregister if both the type
                and attribute are clear of needing registration.
              (WebCore::HTMLInputElement::didRestoreFromCache):
              (WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
              (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
              * html/HTMLInputElement.h:
      
      LayoutTests:
      
      2008-07-28  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Sam Weinig
      
              <rdar://problem/6093281> - autocomplete="off" should work when going back
      
              * security/autocomplete-cleared-on-back-expected.txt: Added.
              * security/autocomplete-cleared-on-back.html: Added.
              * security/resources: Added.
              * security/resources/autocomplete-cleared-on-back2.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d485d2d3
    • andersca@apple.com's avatar
      ../../../../../../LayoutTests: · a3339376
      andersca@apple.com authored
      2008-07-28  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam.
      
              <rdar://problem/6098335>
              https://bugs.webkit.org/show_bug.cgi?id=20150
              
              Add tests.
              
              * http/tests/xmlhttprequest/resources/forbidden.txt: Added.
              * http/tests/xmlhttprequest/resources/redirect.php: Added.
              * http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt: Added.
              * http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html: Added.
      
      ../../../../../../WebCore:
      
      2008-07-28  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam.
      
              <rdar://problem/6098335>
              https://bugs.webkit.org/show_bug.cgi?id=20150
              
              Handle willSendRequest correctly.
      
              * loader/SubresourceLoader.cpp:
              (WebCore::SubresourceLoader::willSendRequest):
              Make sure to keep the previous URL around so we know when to call willSendRequest.
              
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::processSyncLoadResults):
              Abort if we don't have access to the response URL.
              
              (WebCore::XMLHttpRequest::willSendRequest):
              Dispatch a network error if we can't access the new URL.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3339376
  12. 27 Jul, 2008 3 commits
    • weinig@apple.com's avatar
      WebCore: · bb635d6b
      weinig@apple.com authored
      2008-07-27  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Oliver Hunt.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=20176
              querySelectorAll id optimization no longer working
      
              Turn the querySelector/querySelectorAll id optimization back on
              for only strict and almost strict mode.  In quirks mode, the optimiztion
              won't work as the id match is not case sensitive.
      
              Tests: fast/dom/SelectorAPI/caseID-almost-strict.html
                     fast/dom/SelectorAPI/caseID-strict.html
                     fast/dom/SelectorAPI/caseID.html
      
              * dom/Node.cpp:
              (WebCore::Node::querySelector):
              (WebCore::Node::querySelectorAll):
              * dom/SelectorNodeList.cpp:
              (WebCore::createSelectorNodeList):
              * dom/SelectorNodeList.h:
      
      LayoutTests:
      
      2008-07-27  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Oliver Hunt.
      
              Tests for https://bugs.webkit.org/show_bug.cgi?id=20176
              querySelectorAll id optimization no longer working
      
              * fast/dom/SelectorAPI/caseID-almost-strict-expected.txt: Added.
              * fast/dom/SelectorAPI/caseID-almost-strict.html: Added.
              * fast/dom/SelectorAPI/caseID-expected.txt: Added.
              * fast/dom/SelectorAPI/caseID-strict-expected.txt: Added.
              * fast/dom/SelectorAPI/caseID-strict.html: Added.
              * fast/dom/SelectorAPI/caseID.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb635d6b
    • ddkilzer@apple.com's avatar
      WebCore: · 5c3992e3
      ddkilzer@apple.com authored
      2008-07-21  Anatoli Papirovski  <apapirovski@mac.com>
      
              Reviewed by Dave Hyatt.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=14346
              Modified the css parser:
              - not to fail when closing braces are not found for
                a declaration at the end of the file
              - not to accept "!important fail" as valid
              - to keep accepting @import when it comes after invalid @ rules
              - not to drop the whole @media block when there's an error before the
                closing brace
              + some other minor css parsing revisions.
      
              CSSGrammar.y tweaked by David Kilzer to fix Tiger builds.
      
              * css/CSSGrammar.y:
      
      LayoutTests:
      
      2008-07-21  Anatoli Papirovski  <apapirovski@mac.com>
      
              Reviewed by Dave Hyatt.
      
              Updated layout CSS2.1 test suite tests related to css parsing:
              https://bugs.webkit.org/show_bug.cgi?id=14346
      
              * platform/mac/css2.1/t040105-import-01-b-expected.checksum:
              * platform/mac/css2.1/t040105-import-01-b-expected.png:
              * platform/mac/css2.1/t040105-import-01-b-expected.txt:
              * platform/mac/css2.1/t0402-syntax-05-f-expected.checksum:
              * platform/mac/css2.1/t0402-syntax-05-f-expected.png:
              * platform/mac/css2.1/t0402-syntax-05-f-expected.txt:
              * platform/mac/css2.1/t0402-syntax-06-f-expected.checksum:
              * platform/mac/css2.1/t0402-syntax-06-f-expected.png:
              * platform/mac/css2.1/t0402-syntax-06-f-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c3992e3
    • mrowe@apple.com's avatar
      2008-07-26 Mark Rowe <mrowe@apple.com> · 80fc0c74
      mrowe@apple.com authored
              Update some layout test results.
      
              * fast/dom/Window/window-properties-expected.txt:
              * fast/dom/domListEnumeration-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80fc0c74
  13. 26 Jul, 2008 6 commits
    • mitz@apple.com's avatar
      Rubber-stamped by Sam Weinig. · 53f3c160
      mitz@apple.com authored
              - update test and expected results for attributes added to
                HTMLFormElement and HTMLSelectElement.
      
              * fast/dom/domListEnumeration-expected.txt:
              * fast/dom/resources/domListEnumeration.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53f3c160
    • mrowe@apple.com's avatar
      2008-07-26 Michelangelo De Simone <michelangelo@me.com> · 9b77ca84
      mrowe@apple.com authored
              Reviewed by Adele Petersen.
      
              Added the simple willValidate attribute to form controls according to
              WebForms 2 spec.
      
              URL: http://www.w3.org/TR/web-forms-2/#willvalidate
      
              Tests: fast/forms/willvalidate-000.html
                     fast/forms/willvalidate-001.html
                     fast/forms/willvalidate-002.html
                     fast/forms/willvalidate-003.html
                     fast/forms/willvalidate-004.html
                     fast/forms/willvalidate-005.html
                     fast/forms/willvalidate-006.html
                     fast/forms/willvalidate-007.html
                     fast/forms/willvalidate-008.html
                     fast/forms/willvalidate-009.html
      
              * html/HTMLButtonElement.h: Added willValidate(), always false.
              * html/HTMLButtonElement.idl: willValidate attribute exposed.
              * html/HTMLFieldSetElement.h: Added willValidate(), always false.
              * html/HTMLFieldSetElement.idl: willValidate attribute exposed.
              * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::willValidate):
              Added base willValidate() implementation.
              * html/HTMLFormControlElement.h: Added willValidate().
              * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::willValidate):
              Added willValidate(), checks for input type.
              * html/HTMLInputElement.h: Added willValidate()
              * html/HTMLInputElement.idl: willValidate attribute exposed.
              * html/HTMLSelectElement.idl: willValidate attribute exposed.
              * html/HTMLTextAreaElement.idl: willValidate attribute exposed.
      
      2008-07-26  Michelangelo De Simone  <m.des@mac.com>
      
              Reviewed by Adele Petersen.
      
              Test suite for the willValidate form controls attribute.
      
              * fast/forms/willvalidate-000-expected.txt: Added.
              * fast/forms/willvalidate-000.html: Added.
              * fast/forms/willvalidate-001-expected.txt: Added.
              * fast/forms/willvalidate-001.html: Added.
              * fast/forms/willvalidate-002-expected.txt: Added.
              * fast/forms/willvalidate-002.html: Added.
              * fast/forms/willvalidate-003-expected.txt: Added.
              * fast/forms/willvalidate-003.html: Added.
              * fast/forms/willvalidate-004-expected.txt: Added.
              * fast/forms/willvalidate-004.html: Added.
              * fast/forms/willvalidate-005-expected.txt: Added.
              * fast/forms/willvalidate-005.html: Added.
              * fast/forms/willvalidate-006-expected.txt: Added.
              * fast/forms/willvalidate-006.html: Added.
              * fast/forms/willvalidate-007-expected.txt: Added.
              * fast/forms/willvalidate-007.html: Added.
              * fast/forms/willvalidate-008-expected.txt: Added.
              * fast/forms/willvalidate-008.html: Added.
              * fast/forms/willvalidate-009-expected.txt: Added.
              * fast/forms/willvalidate-009.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b77ca84
    • mitz@apple.com's avatar
      Rubber-stamped by Mark Rowe. · 96630e06
      mitz@apple.com authored
              * platform/win/Skipped: Added fast/text/international/bidi-AN-after-empty-run.html
              (<rdar://problem/5075790>) and svg/custom/stroke-width-click.svg
              (<rdar://problem/5539822>).
              * platform/win/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
              Updated results for the new way path data is dumped after
              <http://trac.webkit.org/changeset/34117>.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96630e06
    • weinig@apple.com's avatar
      Add radar number to ChangeLog · 40230b2f
      weinig@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40230b2f
    • weinig@apple.com's avatar
      WebCore: · c9685f3e
      weinig@apple.com authored
      2008-07-26  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=20122
              REGRESSION (r35075-r35110): Cannot enlarge images at Apple Store product page
      
              Use strict parsing when in AlmostStrict mode.
      
              Tests: fast/dom/SelectorAPI/dumpNodeList-almost-strict.html
                     fast/dom/SelectorAPI/id-fastpath-almost-strict.html
                     fast/dom/SelectorAPI/id-fastpath-strict.html
      
              * dom/Node.cpp:
              (WebCore::Node::querySelector):
              (WebCore::Node::querySelectorAll):
      
      LayoutTests:
      
      2008-07-26  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=20122
              REGRESSION (r35075-r35110): Cannot enlarge images at Apple Store product page
      
              - Additionally, fix some errors introduced in old tests.
      
              * fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt: Added.
              * fast/dom/SelectorAPI/dumpNodeList-almost-strict.html: Added.
              * fast/dom/SelectorAPI/dumpNodeList-expected.txt:
              * fast/dom/SelectorAPI/dumpNodeList.html:
              * fast/dom/SelectorAPI/id-fastpath-almost-strict-expected.txt: Added.
              * fast/dom/SelectorAPI/id-fastpath-almost-strict.html: Added.
              * fast/dom/SelectorAPI/id-fastpath-strict-expected.txt: Added.
              * fast/dom/SelectorAPI/id-fastpath-strict.html: Added.
              * fast/dom/SelectorAPI/resources/id-fastpath-almost-strict.js: Added.
              * fast/dom/SelectorAPI/resources/id-fastpath-strict.js: Added.
              * fast/dom/SelectorAPI/resources/id-fastpath.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9685f3e
    • mitz@apple.com's avatar
      - move Leopard-only expected failure results back to mac-leopard; these · b19af4b4
      mitz@apple.com authored
                are covered by <rdar://problem/5539818> and <rdar://problem/5539820>.
      
              * platform/mac-leopard/http: Added.
              * platform/mac-leopard/http/tests: Added.
              * platform/mac-leopard/http/tests/security: Copied from platform/mac/http/tests/security.
              * platform/mac-leopard/security: Copied from platform/mac/security.
              * platform/mac/http/tests/security: Removed.
              * platform/mac/http/tests/security/dataURL: Removed.
              * platform/mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
              * platform/mac/security: Removed.
              * platform/mac/security/block-test-expected.txt: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b19af4b4