GitLab

https://bugs.webkit.org/show_bug.cgi?id=127264

Reviewed by Anders Carlsson.

.:

* CMakeLists.txt:
* Source/CMakeLists.txt:
* Source/cmake/FindEGL.cmake:
* Source/cmake/OptionsCommon.cmake:

Source/Platform:

* CMakeLists.txt: Removed.

Source/WebCore:

* CMakeLists.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.

.: 

* CMakeLists.txt:
* Source/cmake/OptionsCommon.cmake:

Source/JavaScriptCore: 

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::cacheFlush):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):
(JSC::ARMv7Assembler::cacheFlush):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):
* heap/MachineStackMarker.cpp:
(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):
(JSC::freePlatformThreadRegisters):
* jit/ExecutableAllocator.h:

Source/WebCore: 

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::readPixels):
* platform/graphics/ImageBuffer.cpp:
* platform/graphics/ImageBufferData.h:
* platform/graphics/IntPoint.h:
* platform/graphics/IntRect.h:
* platform/graphics/IntSize.h:
* platform/graphics/MediaPlayer.cpp:
* platform/graphics/NativeImagePtr.h:
* platform/graphics/OpenGLESShims.h:
* platform/graphics/Path.cpp:
(WebCore::Path::addPathForRoundedRect):
* platform/graphics/Path.h:
* platform/graphics/PlatformLayer.h:
* platform/graphics/filters/CustomFilterValidatedProgram.cpp:
* platform/graphics/filters/CustomFilterValidatedProgram.h:
* platform/graphics/filters/FilterOperation.h:
* platform/graphics/gpu/DrawingBuffer.cpp:
* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::getGraphicsResetStatusARB):
* platform/graphics/opengl/Extensions3DOpenGLES.h:
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::reshapeFBOs):
* platform/network/NetworkStateNotifier.h:
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleInternal.h:
* platform/network/ResourceRequestBase.cpp:

Tools: 

* DumpRenderTree/DumpRenderTree.h:
* DumpRenderTree/PixelDumpSupport.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.

.: 

* CMakeLists.txt:

Source/WebCore: 

* Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::initProtocolHandlerWhitelist):
* UseJSC.cmake:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
* bindings/js/GCController.cpp:
(WebCore::GCController::GCController):
(WebCore::GCController::garbageCollectSoon):
* bindings/js/GCController.h:

Source/WebKit2: 

* Scripts/generate-forwarding-headers.pl:

Tools: 

* Scripts/webkitpy/common/config/watchlist:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=125512

Reviewed by Martin Robinson.

.:

* CMakeLists.txt: make JavaScriptCore always be a shared library for the GTK+ port.
* Source/cmake/WebKitHelpers.cmake: make -fvisibility=hidden not be applied for GTK+,
visibility of some symbols is required for threading to be initialized properly by
WebKit2 processes, and we will rely on a linker script that will be added later on,
for production builds.

Source/JavaScriptCore:

* CMakeLists.txt: use target type instead of SHARED_CORE to decide whether
JavaScriptCore is a shared library, since it's always shared for GTK+ regardless
of SHARED_CORE.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=118367

Reviewed by Ryosuke Niwa.

.:

* CMakeLists.txt:
* Source/CMakeLists.txt:
* Source/cmake/FindEGL.cmake:
* Source/cmake/FindOpenGLES2.cmake: Added.
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/OptionsNix.cmake: Added.

Source/Platform:

* CMakeLists.txt: Added.
* PlatformNix.cmake: Added.

Source/WebCore:

No new tests needed.

* CMakeLists.txt:
* PlatformNix.cmake: Added.

Source/WTF:

* wtf/FeatureDefines.h:
* wtf/Platform.h:
* wtf/PlatformNix.cmake: Added.

Tools:

* Scripts/build-webkit:
* Scripts/run-nix-tests: Added.
* Scripts/run-webkit-tests:
* Scripts/update-webkit-libs-jhbuild:
* Scripts/update-webkitnix-libs: Added.
* Scripts/webkitdirs.pm:
(determineArchitecture):
(argumentsForConfiguration):
(jscProductDir):
(builtDylibPathForName):
(determineIsNix):
(isNix):
(isAppleWebKit):
(launcherPath):
(launcherName):
(checkRequiredSystemConfig):
(copyInspectorFrontendFiles):
(jhbuildWrapperPrefixIfNeeded):
(buildCMakeProjectOrExit):
(cmakeBasedPortName):
* Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(EflWK2Port.build_webkit_command):
(NixPort):
(NixPort.build_webkit_command):
* Scripts/webkitpy/port/factory.py:
(platform_options):
(PortFactory):
* Scripts/webkitpy/port/nix.py: Added.
(NixPort):
(NixPort._wk2_port_name):
(NixPort.determine_full_port_name):
(NixPort.__init__):
(NixPort._port_flag_for_scripts):
(NixPort.setup_test_run):
(NixPort.setup_environ_for_server):
(NixPort.default_timeout_ms):
(NixPort.clean_up_test_run):
(NixPort._generate_all_test_configurations):
(NixPort._path_to_driver):
(NixPort._path_to_image_diff):
(NixPort._image_diff_command):
(NixPort._search_paths):
(NixPort.show_results_html_file):
(NixPort._port_specific_expectations_files):
(NixPort.default_baseline_search_path):
* Scripts/webkitpy/port/nix_unittest.py: Added.
(NixPortTest):
(NixPortTest._assert_search_path):
(NixPortTest._assert_expectations_files):
(NixPortTest.test_baseline_search_path):
(NixPortTest.test_expectations_files):
(NixPortTest.test_default_timeout_ms):
* jhbuild/jhbuild-wrapper:
(determine_platform):
* nix/common.py: Added.
(script_path):
(top_level_path):
* nix/jhbuild.modules: Added.
* nix/jhbuildrc: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=122542

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-09
Reviewed by Csaba Osztrogonác.

.:

* CMakeLists.txt:

Source/JavaScriptCore:

* CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=116662

Reviewed by Gyuyoung Kim.

Use ${MSVC_CXX_ARCHITECTURE_ID} instead of ${CMAKE_SYSTEM_PROCESSOR}, since
the later one just resolves to the host processor on Windows.

* CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114554

Reviewed by Gyuyoung Kim.

Using variables as target names is very uncommon in CMake.
The usual way to specify the name of the resulting binary
is to set the OUTPUT_NAME target property.

.:

* CMakeLists.txt:
* Source/CMakeLists.txt:
* Source/PlatformEfl.cmake:
* Source/PlatformGTK.cmake:
* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/WebKitHelpers.cmake:
* Source/cmake/gtest/CMakeLists.txt:

Source/JavaScriptCore:

* CMakeLists.txt:
* shell/CMakeLists.txt:

Source/WebCore:

* CMakeLists.txt:

Source/WebKit:

* CMakeLists.txt:
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:

Source/WebKit/efl:

* ewebkit.pc.in:

Source/WebKit2:

* CMakeLists.txt:
* PlatformEfl.cmake:
* efl/ewebkit2.pc.in:

Source/WTF:

* wtf/CMakeLists.txt:

Tools:

* DumpRenderTree/efl/CMakeLists.txt:
* EWebLauncher/CMakeLists.txt:
* ImageDiff/CMakeLists.txt:
* MiniBrowser/efl/CMakeLists.txt:
* TestWebKitAPI/CMakeLists.txt:
* WebKitTestRunner/CMakeLists.txt:
* WebKitTestRunner/PlatformEfl.cmake:
* WinCELauncher/CMakeLists.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=115967

Reviewed by Laszlo Gombos.

.:

* CMakeLists.txt: Add GTK+ to the list of ports.
* Source/CMakeLists.txt: We do not try to build WebCoreTestSupport when WebCore is disabled.
* Source/cmake/FindGAIL3.cmake: Added.
* Source/cmake/FindGDK3.cmake: Added.
* Source/cmake/FindGStreamer.cmake: Use the passed in minimum version.
* Source/cmake/FindGTK3.cmake: Added.
* Source/cmake/FindXt.cmake: Added.
* Source/cmake/OptionsEfl.cmake: Pass in the minimum version.
* Source/cmake/OptionsGTK.cmake: Added.

Source/JavaScriptCore:

* PlatformGTK.cmake: Added.
* shell/PlatformGTK.cmake: Added.

Source/WTF:

* wtf/PlatformGTK.cmake: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=114243

Reviewed by Geoffrey Garen.

Setting the CMAKE_BUILD_TYPE causes some problem with Visual Studio.
Adopt the current usage of the variable to better CMake style.

* CMakeLists.txt:
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/OptionsEfl.cmake:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97592

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-01-29
Reviewed by Kenneth Rohde Christiansen.

Capture the minimum version information for the tools that are required
to build WebKit for all CMake based build systems.

* CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=104773

Patch by Halton Huo <halton.huo@intel.com> on 2013-01-28
Reviewed by Laszlo Gombos.

Debug build without -DSHARED_CORE=ON will fail because libwebcore_efl.a
is too big (>4G) to archive. The solution is simply to abort cmake in
this condition and notify developer.

* CMakeLists.txt:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsCommon.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=103605

Patch by Halton Huo <halton.huo@intel.com> on 2012-12-05
Reviewed by Laszlo Gombos.

Update cmake files(.cmake, CMakeLists.txt) with following style rules:
1. Indentation
1.1 Use spaces, not tabs.
1.2 Four spaces as indent.
2. Spacing
2.1 Place one space between control statements and their parentheses.
    For eg, if (), else (), elseif (), endif (), foreach (),
    endforeach (), while (), endwhile (), break ().
2.2 Do not place spaces between function and macro statements and
    their parentheses. For eg, macro(), endmacro(), function(),
    endfunction().
2.3 Do not place spaces between a command or function or macro and its
    parentheses, or between a parenthesis and its content. For eg,
    message("testing") not message( "testing") or message ("testing" )
2.4 No space at line ending.
3. Lowercase when call commands macros and functions. For eg,
   add_executable() not ADD_EXECUTABLE(), set() not SET().

.:

* CMakeLists.txt:
* Source/CMakeLists.txt:
* Source/PlatformEfl.cmake:
* Source/cmake/EFLHelpers.cmake:
* Source/cmake/FindATK.cmake:
* Source/cmake/FindCFLite.cmake:
* Source/cmake/FindCairo.cmake:
* Source/cmake/FindDBus.cmake:
* Source/cmake/FindDirectX.cmake:
* Source/cmake/FindE_DBus.cmake:
* Source/cmake/FindEcore.cmake:
* Source/cmake/FindEdje.cmake:
* Source/cmake/FindEet.cmake:
* Source/cmake/FindEeze.cmake:
* Source/cmake/FindEfreet.cmake:
* Source/cmake/FindEina.cmake:
* Source/cmake/FindElementary.cmake:
* Source/cmake/FindEnchant.cmake:
* Source/cmake/FindEvas.cmake:
* Source/cmake/FindFontconfig.cmake:
* Source/cmake/FindGLIB.cmake:
* Source/cmake/FindGStreamer.cmake:
* Source/cmake/FindGperf.cmake:
* Source/cmake/FindHarfBuzz.cmake:
* Source/cmake/FindICU.cmake:
* Source/cmake/FindLibSoup.cmake:
* Source/cmake/FindQuickTimeSDK.cmake:
* Source/cmake/FindSqlite.cmake:
* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsWinCE.cmake:
* Source/cmake/OptionsWindows.cmake:
* Source/cmake/WebKitFS.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/WebKitHelpers.cmake:
* Source/cmake/WebKitMacros.cmake:
* Source/cmake/WebKitPackaging.cmake:
* Source/cmake/gtest/CMakeLists.txt:

Source/JavaScriptCore:

* CMakeLists.txt:
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:
* PlatformWinCE.cmake:
* shell/CMakeLists.txt:
* shell/PlatformBlackBerry.cmake:
* shell/PlatformEfl.cmake:
* shell/PlatformWinCE.cmake:

Source/WebCore:

* CMakeLists.txt:
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:
* PlatformWinCE.cmake:
* UseJSC.cmake:
* UseV8.cmake:

Source/WebKit:

* CMakeLists.txt:
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:
* PlatformWinCE.cmake:

Source/WebKit/efl:

* DefaultTheme/CMakeLists.txt:

Source/WebKit2:

* CMakeLists.txt:
* PlatformEfl.cmake:
* win/WebKit2ExportGenerator.vcproj:
* win/WebKit2ExportGeneratorCommon.vsprops:

Source/WTF:

* CMakeLists.txt:
* wtf/CMakeLists.txt:
* wtf/PlatformBlackBerry.cmake:
* wtf/PlatformEfl.cmake:
* wtf/PlatformWinCE.cmake:

Tools:

* CMakeLists.txt:
* DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
* DumpRenderTree/efl/CMakeLists.txt:
* EWebLauncher/CMakeLists.txt:
* EWebLauncher/ControlTheme/CMakeLists.txt:
* MiniBrowser/efl/CMakeLists.txt:
* TestWebKitAPI/CMakeLists.txt:
* TestWebKitAPI/PlatformEfl.cmake:
* WebKitTestRunner/CMakeLists.txt:
* WebKitTestRunner/PlatformEfl.cmake:
* WinCELauncher/CMakeLists.txt:
* clang/ReportMemoryUsagePlugin/CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=103918

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-12-05
Reviewed by Gyuyoung Kim.

Turn on building Tools by default only if ENABLE_TOOLS is not explicitly set
(enabled or disabled) and the Tools directory exists for all CMake based ports.

This change enables the possibility to build WebKit even if the Tools directory
does not exists.

* CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=103820

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-12-03
Reviewed by Gyuyoung Kim.

.:

To create a WebKit2-only build for EFL use the following command:
build-webkit --efl --cmakeargs="-DENABLE_WEBKIT=OFF".

* CMakeLists.txt: Turn on WebKit1 support if it is not explicitly set (enabled or disabled) for
all CMake based ports.

* Source/cmake/OptionsEfl.cmake: Enable WebKit2
for the EFL port if it is not explicitly set (enabled or disabled).

Tools:

Set ENABLE_WEBKIT2 to OFF if build-webkit was run with --no-webkit2.
Never set ENABLE_WEBKIT in build-webkit. This will simplyfy invoking
cmake directly. Initialize $cmakeArgs to avoid potential
warnings when running the script.

* Scripts/build-webkit:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://trac.webkit.org/changeset/130656
https://bugs.webkit.org/show_bug.cgi?id=97592

Broke CMake build on Windows

* CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@131266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=97592

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Capture the minimum version information for the tools that are required
to build the EFL port (or more generally WebKit).

* CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[CMake] Change hardcoded 'lib' and 'bin' in CMakeLists.txt to 'LIB_INSTALL_DIR' and 'EXEC_INSTALL_DIR'.
https://bugs.webkit.org/show_bug.cgi?id=97419

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-24
Reviewed by Gyuyoung Kim.

Use the value of LIB_INSTALL_DIR and EXEC_INSTALL_DIR instead of
hardcoding 'lib' and 'bin' for CMAKE_{ARCHIVE,LIBRARY,RUNTIME}_OUTPUT_DIRECTORY.

* CMakeLists.txt:
Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".
Use ${EXEC_INSTALL_DIR} instead of hardcoding "bin".

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=92682

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-09-10
Reviewed by Csaba Osztrogonác.

.:

Added LLInt to CMake buildsystem and enabled it by default on EFL.
Note that Ruby is not enforced: a secondary check is done when LLInt
is enabled on the JSC's CMakeLists.txt.

* CMakeLists.txt:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Generate the headers needed by LLint when LLint is enabled.

* CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=93450

Reviewed by Daniel Bates.

Following the discussion in bug 93189, it was decided that bumping
the minimum required version from 2.8.0 to 2.8.3 was a good thing
due to additional features, such as improved
FIND_PACKAGE_HANDLE_STANDARD_ARGS() support and better argument
handling in the PKG_CHECK_MODULES() call.

CMake 2.8.3 was released almost two years ago, so people are
expected to have it or a later version installed.

* CMakeLists.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=91221

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-13
Reviewed by Rob Buis.

.:

Make the flag reusable across the ports using CMake. We are about to enable the WTF,
WebCore and WebKit 2 API's at Tools/TestWebKitAPI and other ports using CMake can get
it almost for free.

* CMakeLists.txt:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/WebKit:

Build unit tests only if ENABLE_API_TESTS is set.

* PlatformEfl.cmake:

Source/WebKit2:

Build unit tests only if ENABLE_API_TESTS is set.

* PlatformEfl.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=90602

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-06
Reviewed by Chang Shu.

.:

CTest was enabled for all the ports, but used only by EFL. Now
ENABLE_API_TESTS has to be defined, which will also build gtest.

* CMakeLists.txt:
* Source/CMakeLists.txt:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/gtest/CMakeLists.txt: Added.

Source/WebKit:

Removed gtest since it is now built as a separated component.
This will allow us to share it with WebKit 2 API tests.

* PlatformEfl.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=87251

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-02
Reviewed by Daniel Bates.

.:

Enable CTest on the root CMakeLists.txt as it is expected
to be here. This will create a new build target ("make test")
to run all the API unit tests.

* CMakeLists.txt:

Source/WebKit:

Add every test to the test runner build target.

* PlatformEfl.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=84229

CMake caches ONLY_BUILD_JAVASCRIPTCORE=1 and will reuse the setting for
subsequent builds, stopping WebCore from being built ever again.

Instead of trying to emulate a build target using command line options,
just build the existing jsc target directly.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-18
Reviewed by Rob Buis.

.:

* CMakeLists.txt:

Tools:

* Scripts/build-jsc:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=83573

Reviewed by Daniel Bates.

We need this variable when ports want to generate files in the WebKit target.

* CMakeLists.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72815

Reviewed by Daniel Bates.

Don't define the generic features for every port again.
Add a few macros for reusing the central defined options.

* CMakeLists.txt:
* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsWinCE.cmake:
* Source/cmake/WebKitFeatures.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=80911

Reviewed by Adam Barth.

.:

* CMakeLists.txt: Define WTF_DIR

Source/JavaScriptCore:

Update the various build systems to depend on Source/WTF headers
as well as remove references to Platform.h (since it's now moved).

* CMakeLists.txt:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:

Source/WebCore:

* CMakeLists.txt:
 - Look for headers in Source/WTF as well.

Source/WebKit:

* CMakeLists.txt: Look for headers in Source/WTF.

Source/WebKit/qt:

Fix WTF header include paths since although
Source/WTF is included, no longer are all the
subdirectories (thus "RefPtr.h" can't work).

* Api/qwebdatabase_p.h:
* Api/qwebscriptworld_p.h:
* Api/qwebsecurityorigin_p.h:
* WebCoreSupport/InspectorClientQt.h:
* WebCoreSupport/QtFallbackWebPopup.h:
* WebCoreSupport/QtWebComboBox.h:
* declarative/experimental/experimental.pri:
* declarative/public.pri:
* tests/MIMESniffing/MIMESniffing.pro:

Source/WebKit2:

Update to not depend on "Foo.h" includes for WTF headers.

* Shared/qt/QtNetworkReplyData.h:
* Shared/qt/QtNetworkRequestData.cpp:
* Shared/qt/QtNetworkRequestData.h:

Source/WTF:

Update build systems to account for the new location of Platform.h

* GNUmakefile.list.am:
* WTF.gypi:
* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.vcproj/work-around-vs-dependency-tracking-bugs.py:
(react_to_vsprops_changes):
* WTF.xcodeproj/project.pbxproj:
* config.h: I don't think this change is 100% correct (but seemed to be needed to make qt-wk2 build)
 - This dependency on JSC should be removed regardless (in a later patch).
* wtf/Platform.h: Renamed from Source/JavaScriptCore/wtf/Platform.h.

Tools:

Update include paths for Source/WTF.

* DumpRenderTree/efl/CMakeLists.txt:
* DumpRenderTree/qt/DumpRenderTree.pro:
* QtTestBrowser/QtTestBrowser.pro:
* Scripts/build-webkit: Build Source/WTF on AppleWin as well.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@111504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=80469

Reviewed by Antonio Gomes.

.:

* CMakeLists.txt: Do not set the CMAKE_LINK_INTERFACE_LIBRARIES
variable here; it was introduced in CMake 2.8.7 so we can't depend
on it as we actually support CMake >= 2.8.0.

Source/JavaScriptCore:

* CMakeLists.txt: Manually set the LINK_INTERFACE_LIBRARIES target
property on the library being created.

Source/WebCore:

No new tests, this is a buildsystem change.

* CMakeLists.txt: Manually set the LINK_INTERFACE_LIBRARIES target
property on the library being created.

Source/WebKit:

* CMakeLists.txt: Manually set the LINK_INTERFACE_LIBRARIES target
property on the library being created.

Source/WebKit2:

* CMakeLists.txt: Manually set the LINK_INTERFACE_LIBRARIES target
property on the library being created.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=80282

Reviewed by Antonio Gomes.

.:

Remove transitive library dependencies; they are especially
dangerous when one ends up linking against WTF, JSC and then WTF
again, since some symbols will not be defined.

Passing --no-copy-dt-needed-entries and --as-needed to the linker
(which some recent Linux distros do by default) makes the issue
even more evident.

* CMakeLists.txt: Set CMAKE_LINK_INTERFACE_LIBRARIES to an empty
list to prevent implicit transitive library dependencies from
being created by default.

Source/WebCore:

No new tests, this is a buildsystem change.

Remove transitive library dependencies; they are especially
dangerous when one ends up linking against WTF, JSC and then WTF
again, since some symbols will not be defined.

Passing --no-copy-dt-needed-entries and --as-needed to the linker
(which some recent Linux distros do by default) makes the issue
even more evident.

* CMakeLists.txt: Explicitly link to WTF as WebCore uses symbols
from it.
* PlatformEfl.cmake: Explicitly link against libjpeg and libpng.

Tools:

Remove transitive library dependencies; they are especially
dangerous when one ends up linking against WTF, JSC and then WTF
again, since some symbols will not be defined.

Passing --no-copy-dt-needed-entries and --as-needed to the linker
(which some recent Linux distros do by default) makes the issue
even more evident.

* DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,
as the other libraries have the needed symbols. Explicitly link
against fontconfig.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@109983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=79896

Patch by Kangil Han <kangil.han@samsung.com> on 2012-03-05
Reviewed by Daniel Bates.

Add WebCoreTestSupport library for DRT in CMake.
We will use internals object by linking this library on DRT.

.:

* CMakeLists.txt:

Source/WebCore:

* CMakeLists.txt:
* UseJSC.cmake:
* UseV8.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@109787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=79857

Reviewed by Eric Seidel.

.:

* CMakeLists.txt: Put static libraries in ${CMAKE_BINARY_DIR} too
to have them grouped with the shared ones.

Source/JavaScriptCore:

To help the efforts in bug 75673 to move WTF out of
JavaScriptCore, act more like the other ports and remove the
possibility of building WTF as a shared library.

It does not make much sense to, for example, ship WTF as a
separate .so with webkit-efl packages, and it should be small
enough not to cause problems during linking.

* wtf/CMakeLists.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@109197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=78198

Reviewed by Daniel Bates.

CMake variable is only written by uppercase.

* CMakeLists.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=77928

Reviewed by Daniel Bates.

CMake has used *Programs* directory for executable. In addition, shared libraries are being
built in source directory. It is better to set common places in order to maintain executable
and libraries. *bin* is for executable and *lib* is for library.

.:

* CMakeLists.txt: Set library output path.
* Source/cmake/WebKitFS.cmake: Remove *Programs* creation.

Source/JavaScriptCore:

* shell/CMakeLists.txt: Change *Programs* with *bin*.

Source/WebKit2:

* CMakeLists.txt:

Tools:

* DumpRenderTree/efl/CMakeLists.txt:
* EWebLauncher/CMakeLists.txt:
* Scripts/run-launcher:
* Scripts/webkitdirs.pm:
(jscProductDir):
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._path_to_driver):
(EflPort._path_to_image_diff):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=77826

Reviewed by Daniel Bates.

Do not build Tools when jsc is only built. Build breaks occur because
Tools is built together when building jsc.

* CMakeLists.txt: Build Tools directory when ENABLE_TOOLS is on.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=74979

Reviewed by Rob Buis.

Towards adding CMake support to script Tools/Scripts/build-jsc, add a CMake
option to only build JavaScriptCore.

* CMakeLists.txt: Defined ENABLE_WEBCORE to build WebCore. If the option
ONLY_BUILD_JAVASCRIPTCORE is specified then don't build WebCore, WebKit, or WebKit2.
* Source/CMakeLists.txt:
* Source/cmake/WebKitFS.cmake:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72685

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-23
Reviewed by Brent Fulgham.

.:

Move most of the top-level code in Source/CMakeLists.txt to
CMakeLists.txt. This allows us to replace some INCLUDE() hacks with
proper ADD_SUBDIRECTORY() calls, and actually moves non-Source related
to a non-Source directory.

* CMakeLists.txt: Copied from Source/CMakeLists.txt.

Source/JavaScriptCore:

* CMakeLists.txt: Point to the right Source/ directory.
* wtf/CMakeLists.txt: Ditto.

Source/WebCore:

No new tests, this is a buildsystem changes.

* CMakeLists.txt: Adjust the Source/ directory.
* PlatformBlackBerry.cmake: Ditto.

Source/WebKit:

* blackberry/CMakeListsBlackBerry.txt: Adjust the Source/ directory.

Source/WebKit2:

* CMakeLists.txt: Adjust Source/ directory.

Tools:

* CMakeLists.txt: Added.
* DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
* EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
* Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject):
* WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72768

.: 

Reviewed by Adam Barth and Antonio Gomes.

* Source/CMakeLists.txt: Add the BlackBerry port and support for building on QNX.
* Source/cmake/OptionsBlackBerry.cmake: Added.
* Source/cmake/OptionsCommon.cmake: Add QNX QCC-variant of CODE_GENERATOR_PREPROCESSOR.
  We may be able to fold this into the non-MSVC CODE_GENERATOR_PREPROCESSOR.

Source/JavaScriptCore: 

Reviewed by Antonio Gomes.

* PlatformBlackBerry.cmake: Added.
* shell/PlatformBlackBerry.cmake: Added.
* wtf/PlatformBlackBerry.cmake: Added.

Source/WebCore: 

Reviewed by Antonio Gomes.

* CMakeLists.txt: At this time the BlackBerry port doesn't support generating
  DOM bindings from the SVG IDLs. See WebKit bug #72773.
* PlatformBlackBerry.cmake: Added.

Source/WebKit: 

Reviewed by Antonio Gomes.

* blackberry: Added.
* blackberry/CMakeListsBlackBerry.txt: Added.

Tools: 

Reviewed by Antonio Gomes.

Add optional --blackberry command line argument to build-webkit to build the
BlackBerry port.

* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(determineBaseProductDir):
(argumentsForConfiguration):
(builtDylibPathForName):
(determineIsQt):
(isBlackBerry): Added.
(determineIsBlackBerry): Added.
(blackberryTargetArchitecture): Added.
(isAppleWebKit):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=72710

Reviewed by Brent Fulgham.

.:

* Source/CMakeLists.txt:

Source/WebKit:

* CMakeLists.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=71062

Reviewed by Antonio Gomes.

.: 

Adds a CMake option, called SHOULD_INSTALL_JS_SHELL, that when
defined will generate an installation rule to install the built
JavaScript shell into /bin (with respect to the prefix path).

By default, we don't define this option and hence don't generate
an installation rule for the JavaScript shell.

* Source/CMakeLists.txt:

Source/JavaScriptCore: 

Generate an installation rule for installing the JavaScript shell in
/bin (with respect to the prefix path) when SHOULD_INSTALL_JS_SHELL
is defined.

* shell/CMakeLists.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67482

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-26
Reviewed by Adam Barth.

So far the buildsystem only considered Windows, Linux and Mac OS X as
valid operating systems, but any Unix (or at least the BSDs) should also
work fine.

By using the OS values CMake itself defines we can check for Unix
systems in a more generic fashion.

* Source/CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95986 268f45cc-cd09-0410-ab3c-d52691b4dbfc