Commit acfd01cc authored by inferno@chromium.org's avatar inferno@chromium.org

2011-01-11 Abhishek Arya <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        RefPtr the FrameView to prevent scrollbar from getting deleted inside
        its scroll event.
        https://bugs.webkit.org/show_bug.cgi?id=52238

        Test: scrollbars/scrollable-iframe-remove-crash.html

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::scrollTo):
2011-01-11  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Tests that we do not crash when we remove scrollable iframe when executing
        inside its scroll event.
        https://bugs.webkit.org/show_bug.cgi?id=52238

        * scrollbars/scrollable-iframe-remove-crash-expected.txt: Added.
        * scrollbars/scrollable-iframe-remove-crash.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 3d7b4cc5
2011-01-11 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Tests that we do not crash when we remove scrollable iframe when executing
inside its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238
* scrollbars/scrollable-iframe-remove-crash-expected.txt: Added.
* scrollbars/scrollable-iframe-remove-crash.html: Added.
2011-01-11 Martin Robinson <mrobinson@igalia.com>
Remove some GTK+-specific baselines. GTK+ now enough feature parity with the Mac
......
<html>
<script>
if (window.layoutTestController)
{
layoutTestController.dumpAsText();
layoutTestController.waitUntilDone();
}
function scrollEventFired()
{
document.getElementById('console').innerHTML = "Scrolled by JavaScript scrollTo(): PASS";
if (window.layoutTestController)
layoutTestController.notifyDone();
}
function runTest()
{
window.frames[0].onscroll = scrollEventFired;
window.frames[0].scrollTo(0, 50);
}
</script>
<junk id="console">
<iframe onload="runTest();" src="resources/scrollable-iframe.html">
</junk>
</html>
2011-01-11 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
RefPtr the FrameView to prevent scrollbar from getting deleted inside
its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238
Test: scrollbars/scrollable-iframe-remove-crash.html
* page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollTo):
2011-01-08 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by David Hyatt.
......
......@@ -1339,7 +1339,7 @@ void DOMWindow::scrollTo(int x, int y) const
m_frame->document()->updateLayoutIgnorePendingStylesheets();
FrameView* view = m_frame->view();
RefPtr<FrameView> view = m_frame->view();
if (!view)
return;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment