Unreviewed, rolling out r116527.

http://trac.webkit.org/changeset/116527 https://bugs.webkit.org/show_bug.cgi?id=86199 Causing crashes on ClusterFuzz (Requested by inferno-sec on #webkit). Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11 Source/WebCore: * rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::updateScrollbarPart): * rendering/RenderScrollbarPart.h: LayoutTests: * scrollbars/scrollbar-percent-padding-crash-expected.txt: Removed. * scrollbars/scrollbar-percent-padding-crash.html: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed, rolling out r116527.
http://trac.webkit.org/changeset/116527 https://bugs.webkit.org/show_bug.cgi?id=86199 Causing crashes on ClusterFuzz (Requested by inferno-sec on #webkit). Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11 Source/WebCore: * rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::updateScrollbarPart): * rendering/RenderScrollbarPart.h: LayoutTests: * scrollbars/scrollbar-percent-padding-crash-expected.txt: Removed. * scrollbars/scrollbar-percent-padding-crash.html: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
6adf2ae7 · inferno@chromium.org · ea081727 · 6adf2ae7 · ea081727 · ea081727
Commit 6adf2ae7 authored May 11, 2012 by inferno@chromium.org
6 changed files
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
+2012-05-11  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r116527.
+        http://trac.webkit.org/changeset/116527
+        https://bugs.webkit.org/show_bug.cgi?id=86199
+
+        Causing crashes on ClusterFuzz (Requested by inferno-sec on
+        #webkit).
+
+        * scrollbars/scrollbar-percent-padding-crash-expected.txt: Removed.
+        * scrollbars/scrollbar-percent-padding-crash.html: Removed.
+
 2012-05-11  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update wrong expectations.

--- a/LayoutTests/scrollbars/scrollbar-percent-padding-crash-expected.txt
+++ b/LayoutTests/scrollbars/scrollbar-percent-padding-crash-expected.txt
-Test for bug 83889: This tests that there is no crash when using percentage value for scrollbar's padding property. On success you should see a frame with scrollbars and one PASS message in it.
-
-
--- a/LayoutTests/scrollbars/scrollbar-percent-padding-crash.html
+++ b/LayoutTests/scrollbars/scrollbar-percent-padding-crash.html
-<!DOCTYPE html>
-<html>
-<head>
-<style>
-::-webkit-scrollbar {
- -webkit-padding-start: 1%; background: #666 -webkit-gradient(linear, left top, right top, from(rgba(255,255,255,0.5)), color-stop(0.5, rgba(255,255,255,0.1)), color-stop(0.5, rgba(0,0,0,0)), to(rgba(0,0,0,0.01)));
-}
-</style>
-<script>
-function runTest() {
-    if (window.layoutTestController) {
-        layoutTestController.dumpAsText();
-        document.body.offsetTop;
-        layoutTestController.display();
-    }
-};
-</script>
-</head>
-<body onload="runTest()">
-<p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=83889">bug 83889</a>:
-This tests that there is no crash when using percentage value for scrollbar's padding property. On success you should see a frame with scrollbars and one PASS message in it.
-<div style="height: 1000px;"></div>
-</body>
-</html>
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
+2012-05-11  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r116527.
+        http://trac.webkit.org/changeset/116527
+        https://bugs.webkit.org/show_bug.cgi?id=86199
+
+        Causing crashes on ClusterFuzz (Requested by inferno-sec on
+        #webkit).
+
+        * rendering/RenderScrollbar.cpp:
+        (WebCore::RenderScrollbar::updateScrollbarPart):
+        * rendering/RenderScrollbarPart.h:
+
 2012-05-11  Yoshifumi Inoue  <yosin@chromium.org>

        [Forms] Move ValidityState methods implementation to another place
--- a/Source/WebCore/rendering/RenderScrollbar.cpp
+++ b/Source/WebCore/rendering/RenderScrollbar.cpp
@@ -270,11 +270,9 @@ void RenderScrollbar::updateScrollbarPart(ScrollbarPart partType, bool destroy)
    RenderScrollbarPart* partRenderer = m_parts.get(partType);
    if (!partRenderer && needRenderer) {
        partRenderer = new (owningRenderer()->renderArena()) RenderScrollbarPart(owningRenderer()->document(), this, partType);
-        partRenderer->setParent(owningRenderer());
        m_parts.set(partType, partRenderer);
    } else if (partRenderer && !needRenderer) {
        m_parts.remove(partType);
-        partRenderer->setParent(0);
        partRenderer->destroy();
        partRenderer = 0;
    }

--- a/Source/WebCore/rendering/RenderScrollbarPart.h
+++ b/Source/WebCore/rendering/RenderScrollbarPart.h
@@ -35,8 +35,6 @@ class RenderScrollbar;

 class RenderScrollbarPart : public RenderBlock {
 public:
-    friend class RenderScrollbar;
-
    RenderScrollbarPart(Node*, RenderScrollbar* = 0, ScrollbarPart = NoPart);
    virtual ~RenderScrollbarPart();