Skip to content

GitLab

W
webkit
Commit 4a6c624e authored by scheib@chromium.org's avatar scheib@chromium.org
Browse files
Options

[Chromium] Clear m_currentInputEvent after handled by pointerLockMouseEvent(). 

https://bugs.webkit.org/show_bug.cgi?id=90391

Source/WebKit/chromium:

WebViewImpl::handleInputEvent was keeping a pointer to an input event that would
later be accessed. When in pointer lock, that pointer was not being cleared.
Code modified to use TemporaryChange to automatically clear the pointer at all
method exit points.

Reviewed by Abhishek Arya.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):

LayoutTests:

Test that reproduces bug 90391:
Enable pointer lock, receive mouse move, call window.open, don't crash.

Reviewed by Abhishek Arya.

* pointer-lock/bug90391-move-then-window-open-crash-expected.txt: Added.
* pointer-lock/bug90391-move-then-window-open-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 833b1958
Hide whitespace changes
Inline Side-by-side
Showing with 109 additions and 3 deletions
LayoutTests/ChangeLog
View file @ 4a6c624e
2012-07-05 Vincent Scheib <scheib@chromium.org>
[Chromium] Clear m_currentInputEvent after handled by pointerLockMouseEvent().
https://bugs.webkit.org/show_bug.cgi?id=90391
Test that reproduces bug 90391:
Enable pointer lock, receive mouse move, call window.open, don't crash.
Reviewed by Abhishek Arya.
* pointer-lock/bug90391-move-then-window-open-crash-expected.txt: Added.
* pointer-lock/bug90391-move-then-window-open-crash.html: Added.
2012-07-05 John Mellor <johnme@chromium.org>
Text Autosizing: Add test framework and simple test.
LayoutTests/pointer-lock/bug90391-move-then-window-open-crash-expected.txt 0 → 100644
View file @ 4a6c624e
bug 90391: pointer lock mouse move events then window.open should not crash.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Locking targetdiv1.
PASS document.onwebkitpointerlockchange event received.
Sending mouse move events.
Calling window.open.
PASS Didn't crash
PASS successfullyParsed is true
TEST COMPLETE
doNextStep for manual testing
LayoutTests/pointer-lock/bug90391-move-then-window-open-crash.html 0 → 100644
View file @ 4a6c624e
<!DOCTYPE HTML>
<html>
<head>
<script src="../fast/js/resources/js-test-pre.js"></script>
</head>
<body>
<div>
<button onclick="doNextStep('manual');">doNextStep for manual testing</button>
<div id="target1"></div>
</div>
<script>
description("bug 90391: pointer lock mouse move events then window.open should not crash.")
window.jsTestIsAsync = true;
targetdiv1 = document.getElementById("target1");
currentStep = 0;
function doNextStep(manual)
{
if (!window.layoutTestController && !manual)
return;
if (currentStep < todo.length)
setTimeout(function () { todo[currentStep++](); }, 0);
else if (currentStep++ == todo.length)
setTimeout(function () { finishJSTest(); }, 0);
}
todo = [
function () {
debug(" Locking targetdiv1.")
targetdiv1.webkitRequestPointerLock();
document.onwebkitpointerlockchange = function () {
document.onwebkitpointerlockchange = null;
testPassed("document.onwebkitpointerlockchange event received.");
doNextStep('manual');
};
},
function () {
debug(" Sending mouse move events.")
var mouseMoveEvents = 0;
targetdiv1.onmousemove = function () {
if (++mouseMoveEvents == 2) {
targetdiv1.onmousemove = null;
doNextStep('manual');
}
}
if (window.eventSender) {
eventSender.mouseMoveTo(100, 100);
eventSender.mouseMoveTo(200, 200);
}
},
function () {
debug(" Calling window.open.")
gc();
window.open();
testPassed("Didn't crash");
document.webkitExitPointerLock();
doNextStep('manual');
},
];
doNextStep();
</script>
<script src="../fast/js/resources/js-test-post.js"></script>
</body>
</html>
Source/WebKit/chromium/ChangeLog
View file @ 4a6c624e
2012-07-05 Vincent Scheib <scheib@chromium.org>
[Chromium] Clear m_currentInputEvent after handled by pointerLockMouseEvent().
https://bugs.webkit.org/show_bug.cgi?id=90391
WebViewImpl::handleInputEvent was keeping a pointer to an input event that would
later be accessed. When in pointer lock, that pointer was not being cleared.
Code modified to use TemporaryChange to automatically clear the pointer at all
method exit points.
Reviewed by Abhishek Arya.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
2012-07-05 John Mellor <johnme@chromium.org>
Text Autosizing: Add test framework and simple test.
......
Source/WebKit/chromium/src/WebViewImpl.cpp
View file @ 4a6c624e
......@@ -164,6 +164,7 @@
#include <wtf/CurrentTime.h>
#include <wtf/MainThread.h>
#include <wtf/RefPtr.h>
#include <wtf/TemporaryChange.h>
#include <wtf/Uint8ClampedArray.h>
#if ENABLE(GESTURE_EVENTS)
......@@ -1760,7 +1761,7 @@ bool WebViewImpl::handleInputEvent(const WebInputEvent& inputEvent)
if (m_ignoreInputEvents)
return false;
m_currentInputEvent = &inputEvent;
TemporaryChange<const WebInputEvent*>(m_currentInputEvent, &inputEvent);
#if ENABLE(POINTER_LOCK)
if (isPointerLocked() && WebInputEvent::isMouseEventType(inputEvent.type)) {
......@@ -1798,12 +1799,10 @@ bool WebViewImpl::handleInputEvent(const WebInputEvent& inputEvent)
node->dispatchMouseEvent(
PlatformMouseEventBuilder(mainFrameImpl()->frameView(), *static_cast<const WebMouseEvent*>(&inputEvent)),
eventType, static_cast<const WebMouseEvent*>(&inputEvent)->clickCount);
m_currentInputEvent = 0;
return true;
}
bool handled = PageWidgetDelegate::handleInputEvent(m_page.get(), *this, inputEvent);
m_currentInputEvent = 0;
return handled;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment