Skip to content
  • graouts@apple.com's avatar
    Web Inspector: rows in the Layer sidebar panel may have the incorrect background color · c24920f7
    graouts@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=122108
    
    Reviewed by Darin Adler.
    
    The LayerTreeDataGrid is a custom DataGrid subclass which exposes a .setChildren() method
    used to sort chidren without DOM order manipulation, for performance reason. However, since
    the way the alternating background color is usually implemented is based on the built-in
    CSS pseudo-classes working with DOM order, the background colors of nodes in the LayerTreeDataGrid
    can be incorrect depending on the sort order and the number of nodes. To fix this, we now manually
    set "even" and "odd" CSS classes on those nodes when they're sorted such that we have a chance
    to style them as intended.
    
    * UserInterface/LayerTreeDataGrid.js:
    (WebInspector.LayerTreeDataGrid.prototype._updateChildren):
    Check if the data grid node index is even or odd and reflect this via an exclusive "even"
    or "odd" CSS class name.
    
    * UserInterface/LayerTreeSidebarPanel.css:
    (.layer-tree.panel .data-container tbody > tr.even):
    (.layer-tree.panel .data-container tbody > tr.odd):
    Apply alternating colors based on the exclusive "even" and "odd" CSS class names as applied in
    WebInspector.LayerTreeDataGrid.prototype._updateChildren().
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    c24920f7