Skip to content
  • commit-queue@webkit.org's avatar
    Dispatch a progress event before dispatching abort, error or timeout event · 84973bf0
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=126575
    
    Source/WebCore:
    
    Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-13
    Reviewed by Alexey Proskuryakov.
    
    Added sending of progress event after readystatechange event (switching to DONE state) in case of abort, error or timeout.
    Fixed assertions in XMLHttpRequestProgressEventThrottle and XMLHttpRequestUpload.
    
    * xml/XMLHttpRequest.cpp:
    (WebCore::XMLHttpRequest::dispatchErrorEvents): added sending of progress event before the specific error event
    * xml/XMLHttpRequestProgressEventThrottle.cpp:
    (WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): fixed assertion
    * xml/XMLHttpRequestUpload.cpp:
    (WebCore::XMLHttpRequestUpload::dispatchProgressEvent): fixed assertion
    
    LayoutTests:
    
    Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-13
    Reviewed by Alexey Proskuryakov.
    
    Updated onloadend-event-after-abort.html and onloadend-event-after-error.html to check for progress event.
    Fixed the other tests to cope with additional progress event.
    
    * http/tests/xmlhttprequest/onabort-progressevent-attributes.html:
    * http/tests/xmlhttprequest/onloadend-event-after-abort-expected.txt:
    * http/tests/xmlhttprequest/onloadend-event-after-abort.html:
    * http/tests/xmlhttprequest/onloadend-event-after-error-expected.txt:
    * http/tests/xmlhttprequest/onloadend-event-after-error.html:
    * http/tests/xmlhttprequest/simple-cross-origin-progress-events-expected.txt:
    * http/tests/xmlhttprequest/simple-cross-origin-progress-events.html:
    * http/tests/xmlhttprequest/upload-onloadend-event-after-abort.html:
    * http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events-expected.txt:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    84973bf0