• commit-queue@webkit.org's avatar
    CTTE: Use references in and around DragController · f293496b
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=122427
    
    Patch by Sam Weinig <sam@webkit.org> on 2013-10-07
    Reviewed by Andreas Kling.
    
    Source/WebCore:
    
    Use references to indicate non-nullness of DragController related
    objects.
    
    Source/WebKit/efl:
    
    * WebCoreSupport/DragClientEfl.cpp:
    (WebCore::DragClientEfl::willPerformDragDestinationAction):
    (WebCore::DragClientEfl::willPerformDragSourceAction):
    (WebCore::DragClientEfl::actionMaskForDrag):
    (WebCore::DragClientEfl::startDrag):
    * WebCoreSupport/DragClientEfl.h:
    
    Source/WebKit/gtk:
    
    * WebCoreSupport/DragClientGtk.cpp:
    (WebKit::DragClient::willPerformDragDestinationAction):
    (WebKit::DragClient::willPerformDragSourceAction):
    (WebKit::DragClient::actionMaskForDrag):
    (WebKit::DragClient::startDrag):
    * WebCoreSupport/DragClientGtk.h:
    * webkit/webkitwebview.cpp:
    (dragExitedCallback):
    (webkit_web_view_drag_motion):
    (webkit_web_view_drag_data_received):
    (webkit_web_view_drag_drop):
    
    Source/WebKit/mac:
    
    * WebCoreSupport/WebDragClient.h:
    * WebCoreSupport/WebDragClient.mm:
    (WebDragClient::actionMaskForDrag):
    (WebDragClient::willPerformDragDestinationAction):
    (WebDragClient::willPerformDragSourceAction):
    (WebDragClient::startDrag):
    (WebDragClient::declareAndWriteDragImage):
    * WebView/WebFrame.mm:
    (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
    * WebView/WebHTMLView.mm:
    (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
    * WebView/WebView.mm:
    (-[WebView draggingEntered:]):
    (-[WebView draggingUpdated:]):
    (-[WebView draggingExited:]):
    (-[WebView performDragOperation:]):
    
    Source/WebKit/win:
    
    * WebCoreSupport/WebDragClient.cpp:
    (WebDragClient::actionMaskForDrag):
    (WebDragClient::willPerformDragDestinationAction):
    (WebDragClient::willPerformDragSourceAction):
    (WebDragClient::startDrag):
    * WebCoreSupport/WebDragClient.h:
    
    Source/WebKit2:
    
    * UIProcess/API/gtk/WebKitWebViewBase.cpp:
    (webkitWebViewBaseDragDataReceived):
    (webkitWebViewBaseDragMotion):
    (dragExitedCallback):
    (webkitWebViewBaseDragDrop):
    * UIProcess/API/mac/WKView.mm:
    (-[WKView draggingEntered:]):
    (-[WKView draggingUpdated:]):
    (-[WKView draggingExited:]):
    (-[WKView performDragOperation:]):
    * UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::dragEntered):
    (WebKit::WebPageProxy::dragUpdated):
    (WebKit::WebPageProxy::dragExited):
    (WebKit::WebPageProxy::performDrag):
    (WebKit::WebPageProxy::performDragControllerAction):
    * UIProcess/WebPageProxy.h:
    * WebProcess/WebCoreSupport/WebDragClient.cpp:
    (WebKit::WebDragClient::willPerformDragDestinationAction):
    (WebKit::WebDragClient::willPerformDragSourceAction):
    (WebKit::WebDragClient::actionMaskForDrag):
    (WebKit::WebDragClient::dragSourceActionMaskForPoint):
    (WebKit::WebDragClient::startDrag):
    * WebProcess/WebCoreSupport/WebDragClient.h:
    * WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
    (WebKit::WebDragClient::startDrag):
    * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
    (WebKit::WebDragClient::startDrag):
    (WebKit::cachedImage):
    (WebKit::WebDragClient::declareAndWriteDragImage):
    * WebProcess/WebPage/WebPage.cpp:
    (WebKit::WebPage::performDragControllerAction):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    f293496b