Skip to content
  • jochen@chromium.org's avatar
    Source/WebCore: Make NavigationAction wrap a ResourceRequest instead of a KURL. · 056b7fa8
    jochen@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=68803
    
    With this, FrameLoaderClient::dispatchCreatePage knows about the
    request that will be used for the initial navigaion of the to be
    created page.
    
    Reviewed by Nate Chapin.
    
    Test: platform/chromium/fast/loader/create-view-target-blank.html
    
    * loader/FrameLoader.cpp:
    (WebCore::FrameLoader::loadURL):
    (WebCore::FrameLoader::load):
    (WebCore::FrameLoader::loadWithDocumentLoader):
    (WebCore::FrameLoader::reload):
    (WebCore::FrameLoader::loadPostRequest):
    (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
    (WebCore::FrameLoader::loadDifferentDocumentItem):
    (WebCore::createWindow):
    * loader/NavigationAction.cpp:
    (WebCore::NavigationAction::NavigationAction):
    * loader/NavigationAction.h:
    (WebCore::NavigationAction::isEmpty):
    (WebCore::NavigationAction::url):
    (WebCore::NavigationAction::resourceRequest):
    * loader/PolicyChecker.cpp:
    (WebCore::PolicyChecker::checkNavigationPolicy):
    * page/ContextMenuController.cpp:
    (WebCore::openNewWindow):
    * WebCore.exp: updated
    
    Source/WebKit/chromium: Make NavigationAction wrap a ResourceRequest instead of a KURL.
    https://bugs.webkit.org/show_bug.cgi?id=68803
    
    Use the request in the NavigationAction, if the FrameLoadRequest
    doesn't already contain a request.
    
    Reviewed by Nate Chapin.
    
    * src/ChromeClientImpl.cpp:
    (WebKit::ChromeClientImpl::createWindow):
    
    Tools: [chromium] add LayoutTestController.dumpCreateView() to monitor calls to WebViewClient::createView
    https://bugs.webkit.org/show_bug.cgi?id=68803
    
    Reviewed by Nate Chapin.
    
    * DumpRenderTree/chromium/LayoutTestController.cpp:
    (LayoutTestController::LayoutTestController):
    (LayoutTestController::dumpCreateView):
    * DumpRenderTree/chromium/LayoutTestController.h:
    (LayoutTestController::shouldDumpCreateView):
    * DumpRenderTree/chromium/WebViewHost.cpp:
    (WebViewHost::createView):
    
    LayoutTests: Verify that the URL to be opened in the new window is passed by dispatchCreateWindow down to createView.
    https://bugs.webkit.org/show_bug.cgi?id=68803
    
    Reviewed by Nate Chapin.
    
    * platform/chromium/fast/loader/create-view-target-blank-expected.txt: Added.
    * platform/chromium/fast/loader/create-view-target-blank.html: Added.
    * platform/chromium/fast/loader/resources/done.html: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@97716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    056b7fa8