Skip to content
  • carlosgc@webkit.org's avatar
    [GLIB] Use GUniquePtr instead of GOwnPtr · f2ece55f
    carlosgc@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=127431
    
    Reviewed by Martin Robinson.
    
    GUniquePtr is a template alias of std::unique_ptr with a custom
    deleter that replaces GOwnPtr. GOwnPtr is still used for the cases
    where the output pointer is needed, but it will also be replaced soon.
    
    Source/WebCore:
    
    * GNUmakefile.list.am:
    * PlatformGTK.cmake:
    * accessibility/atk/AXObjectCacheAtk.cpp:
    * accessibility/atk/WebKitAccessibleInterfaceText.cpp:
    (getAttributeSetForAccessibilityObject):
    (accessibilityObjectLength):
    (textExtents):
    (webkitAccessibleTextGetChar):
    (numberOfReplacedElementsBeforeOffset):
    * page/ContextMenuController.cpp:
    * platform/SharedBuffer.h:
    * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
    (webKitWebAudioSrcConstructed):
    (webKitWebAudioSrcLoop):
    * platform/audio/gtk/AudioBusGtk.cpp:
    (WebCore::AudioBus::loadPlatformResource):
    * platform/geoclue/GeolocationProviderGeoclue.cpp:
    * platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
    * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
    (WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
    (WebCore::MediaPlayerPrivateGStreamer::handleMessage):
    * platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:
    (webKitMediaSrcAddSrc):
    * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
    (webKitWebSrcStart):
    (ResourceHandleStreamingClient::wasBlocked):
    (ResourceHandleStreamingClient::cannotShowURL):
    * platform/graphics/gtk/ImageBufferGtk.cpp:
    (WebCore::encodeImage):
    (WebCore::ImageBuffer::toDataURL):
    * platform/graphics/gtk/ImageGtk.cpp:
    (WebCore::getThemeIconFileName):
    (WebCore::Image::loadPlatformResource):
    * platform/gtk/ContextMenuGtk.cpp:
    (WebCore::ContextMenu::itemCount):
    (WebCore::contextMenuItemVector):
    * platform/gtk/ContextMenuItemGtk.cpp:
    (WebCore::createPlatformMenuItemDescription):
    * platform/gtk/DataObjectGtk.cpp:
    (WebCore::DataObjectGtk::setURIList):
    (WebCore::DataObjectGtk::setURL):
    * platform/gtk/FileSystemGtk.cpp:
    (WebCore::filenameToString):
    (WebCore::fileSystemRepresentation):
    (WebCore::filenameForDisplay):
    (WebCore::pathGetFileName):
    (WebCore::applicationDirectoryPath):
    (WebCore::sharedResourcesPath):
    (WebCore::directoryName):
    (WebCore::listDirectory):
    (WebCore::openTemporaryFile):
    * platform/gtk/GOwnPtrGtk.cpp: Removed.
    * platform/gtk/GOwnPtrGtk.h: Removed.
    * platform/gtk/GUniquePtrGtk.h: Added.
    * platform/gtk/GamepadsGtk.cpp:
    (WebCore::GamepadsGtk::GamepadsGtk):
    * platform/gtk/GtkClickCounter.cpp:
    (WebCore::GtkClickCounter::shouldProcessButtonEvent):
    * platform/gtk/GtkInputMethodFilter.cpp:
    (WebCore::GtkInputMethodFilter::sendCompositionAndPreeditWithFakeKeyEvents):
    * platform/gtk/GtkPopupMenu.cpp:
    (WebCore::GtkPopupMenu::popUp):
    (WebCore::GtkPopupMenu::typeAheadFind):
    * platform/gtk/LanguageGtk.cpp:
    (WebCore::platformLanguage):
    * platform/gtk/LocalizedStringsGtk.cpp:
    (WebCore::imageTitle):
    (WebCore::localizedMediaTimeDescription):
    * platform/gtk/PasteboardHelper.cpp:
    (WebCore::selectionDataToUTF8String):
    (WebCore::PasteboardHelper::getClipboardContents):
    (WebCore::PasteboardHelper::fillSelectionData):
    * platform/gtk/PopupMenuGtk.cpp:
    (WebCore::PopupMenuGtk::createGtkActionForMenuItem):
    (WebCore::PopupMenuGtk::show):
    * platform/gtk/WebKitAuthenticationWidget.cpp:
    (webkitAuthenticationWidgetInitialize):
    * platform/network/ResourceHandleInternal.h:
    * platform/network/gtk/CredentialBackingStore.cpp:
    (WebCore::credentialForChallengeAsyncReadyCallback):
    * platform/network/soup/CookieJarSoup.cpp:
    (WebCore::setCookiesFromDOM):
    (WebCore::cookiesForSession):
    (WebCore::getRawCookies):
    (WebCore::deleteCookie):
    (WebCore::getHostnamesWithCookies):
    (WebCore::deleteCookiesForHostname):
    (WebCore::deleteAllCookies):
    * platform/network/soup/DNSSoup.cpp:
    * platform/network/soup/GUniquePtrSoup.h: Added.
    * platform/network/soup/ResourceErrorSoup.cpp:
    (WebCore::failingURI):
    * platform/network/soup/ResourceHandleSoup.cpp:
    (WebCore::ResourceHandle::ensureReadBuffer):
    (WebCore::cleanupSoupRequestOperation):
    (WebCore::createSoupRequestAndMessageForHandle):
    * platform/network/soup/ResourceRequestSoup.cpp:
    (WebCore::ResourceRequest::updateSoupMessageMembers):
    (WebCore::ResourceRequest::updateSoupMessage):
    * platform/network/soup/ResourceResponseSoup.cpp:
    * platform/network/soup/SoupURIUtils.cpp:
    (WebCore::soupURIToKURL):
    * platform/soup/SharedBufferSoup.cpp:
    (WebCore::SharedBuffer::SharedBuffer):
    (WebCore::SharedBuffer::clearPlatformData):
    (WebCore::SharedBuffer::maybeTransferPlatformData):
    (WebCore::SharedBuffer::hasPlatformData):
    * plugins/gtk/PluginPackageGtk.cpp:
    (WebCore::PluginPackage::fetchInfo):
    (WebCore::PluginPackage::load):
    
    Source/WebKit/gtk:
    
    * WebCoreSupport/ContextMenuClientGtk.cpp:
    (WebKit::getUnicodeMenuItemPosition):
    * WebCoreSupport/DragClientGtk.cpp:
    (WebKit::DragClient::startDrag):
    * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
    (DumpRenderTreeSupportGtk::setValueForUser):
    * WebCoreSupport/EditorClientGtk.h:
    * WebCoreSupport/FrameLoaderClientGtk.cpp:
    (WebKit::FrameLoaderClient::userAgent):
    (WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
    (WebKit::FrameLoaderClient::dispatchWillSendRequest):
    (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
    (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
    (WebKit::FrameLoaderClient::dispatchDidReceiveContentLength):
    (WebKit::FrameLoaderClient::dispatchDidFinishLoading):
    (WebKit::FrameLoaderClient::dispatchDidFailLoading):
    (WebKit::FrameLoaderClient::dispatchDidFailLoad):
    * WebCoreSupport/InspectorClientGtk.h:
    * webkit/webkitfavicondatabase.cpp:
    (webkit_favicon_database_set_path):
    * webkit/webkitfilechooserrequest.cpp:
    * webkit/webkitglobals.cpp:
    (webkitInit):
    * webkit/webkithittestresult.cpp:
    (WebKit::kit):
    * webkit/webkiticondatabase.cpp:
    (webkit_icon_database_set_path):
    * webkit/webkitspellcheckerenchant.cpp:
    * webkit/webkitwebplugin.cpp:
    (webkit_web_plugin_get_path):
    * webkit/webkitwebpluginprivate.h:
    * webkit/webkitwebsettings.cpp:
    (webkit_web_settings_class_init):
    (webkit_web_settings_copy):
    * webkit/webkitwebview.cpp:
    (webkit_web_view_forward_context_menu_event):
    (fileChooserDialogResponseCallback):
    (webkit_web_view_drag_end):
    * webkit/webkitwebviewprivate.h:
    
    Source/WebKit2:
    
    * Shared/Downloads/soup/DownloadSoup.cpp:
    (WebKit::DownloadClient::didReceiveResponse):
    * Shared/NativeWebKeyboardEvent.h:
    * Shared/NativeWebMouseEvent.h:
    * Shared/NativeWebWheelEvent.h:
    * Shared/gtk/ArgumentCodersGtk.cpp:
    (IPC::encodeGKeyFile):
    (IPC::decodeGKeyFile):
    (IPC::encode):
    (IPC::decode):
    * UIProcess/API/gtk/WebKitContextMenuItem.cpp:
    (webkitContextMenuItemSetSubMenuFromGtkMenu):
    * UIProcess/API/gtk/WebKitDownload.cpp:
    (webkitDownloadDecideDestination):
    (webkitDownloadNotifyProgress):
    (webkitDownloadFailed):
    * UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
    (webkit_file_chooser_request_select_files):
    * UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
    (didReceiveWebViewMessageFromInjectedBundle):
    (getInjectedBundleInitializationUserData):
    * UIProcess/API/gtk/WebKitLoaderClient.cpp:
    (didFailProvisionalLoadWithErrorForFrame):
    (didFailLoadWithErrorForFrame):
    * UIProcess/API/gtk/WebKitPrintOperation.cpp:
    (drawPagesForPrintingCompleted):
    * UIProcess/API/gtk/WebKitURIRequest.cpp:
    (webkit_uri_request_get_http_headers):
    * UIProcess/API/gtk/WebKitURISchemeRequest.cpp:
    (webkit_uri_scheme_request_get_scheme):
    (webkit_uri_scheme_request_get_path):
    * UIProcess/API/gtk/WebKitWebContext.cpp:
    (injectedBundleFilename):
    (webkit_web_context_set_favicon_database_directory):
    * UIProcess/API/gtk/WebKitWebView.cpp:
    (webkitWebViewLoadFail):
    (webkitWebViewCreateJavaScriptDialog):
    (fileChooserDialogResponseCallback):
    (webkitWebViewLoadChanged):
    (webkitWebViewLoadFailedWithTLSErrors):
    (webkitWebViewPopulateContextMenu):
    * UIProcess/API/gtk/WebKitWebViewBase.cpp:
    (webkitWebViewBaseButtonPressEvent):
    (webkitWebViewBaseStartDrag):
    * UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
    (WebKit::WebInspectorServer::platformResourceForPath):
    * UIProcess/InspectorServer/soup/WebSocketServerSoup.cpp:
    (WebKit::connectionCallback):
    * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
    (WebKit::ProcessLauncher::launchProcess):
    * UIProcess/gtk/WebContextGtk.cpp:
    (WebKit::WebContext::platformDefaultApplicationCacheDirectory):
    (WebKit::WebContext::platformDefaultDatabaseDirectory):
    (WebKit::WebContext::platformDefaultIconDatabasePath):
    (WebKit::WebContext::platformDefaultLocalStorageDirectory):
    (WebKit::WebContext::platformDefaultDiskCacheDirectory):
    * UIProcess/gtk/WebContextMenuProxyGtk.cpp:
    (WebKit::contextMenuItemVisibilityChanged):
    * UIProcess/gtk/WebInspectorProxyGtk.cpp:
    (WebKit::WebInspectorProxy::platformInspectedURLChanged):
    * UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
    (WebKit::WebPopupMenuProxyGtk::createGtkActionForMenuItem):
    * WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
    * WebProcess/WebPage/gtk/WebPageGtk.cpp:
    (WebKit::WebPage::platformInitialize):
    * WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
    * WebProcess/gtk/WebProcessMainGtk.cpp:
    * WebProcess/soup/WebSoupRequestManager.cpp:
    (WebKit::WebSoupRequestManager::send):
    
    Tools:
    
    * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
    (printAccessibilityEvent):
    (axObjectEventListener):
    * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
    (indexRangeInTable):
    (AccessibilityUIElement::role):
    (AccessibilityUIElement::title):
    (AccessibilityUIElement::description):
    (AccessibilityUIElement::stringValue):
    (AccessibilityUIElement::language):
    (AccessibilityUIElement::lineForIndex):
    (AccessibilityUIElement::selectedTextRange):
    (AccessibilityUIElement::url):
    * DumpRenderTree/efl/AccessibilityControllerEfl.cpp:
    (AccessibilityController::accessibleElementById):
    * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
    (AccessibilityController::accessibleElementById):
    * DumpRenderTree/gtk/DumpRenderTree.cpp:
    (getOutputDir):
    (getFontsPath):
    (initializeFonts):
    (dumpFramesAsText):
    (compareHistoryItems):
    (dumpHistoryItem):
    (soupURIToStringPreservingPassword):
    (resetDefaultsToConsistentValues):
    (temporaryDatabaseDirectory):
    (webViewTitleChanged):
    (webFrameLoadStatusNotified):
    (pathFromSoupURI):
    (convertWebResourceToURLPath):
    (urlSuitableForTestResult):
    (descriptionSuitableForTestResult):
    (willSendRequestCallback):
    (frameLoadEventCallback):
    * DumpRenderTree/gtk/EditingCallbacks.cpp:
    (dumpNodePath):
    (dumpRange):
    (shouldApplyStyle):
    * DumpRenderTree/gtk/EventSender.cpp:
    (contextClickCallback):
    (beginDragWithFilesCallback):
    * DumpRenderTree/gtk/TestRunnerGtk.cpp:
    (TestRunner::pathToLocalResource):
    (TestRunner::queueLoad):
    (TestRunner::removeOriginAccessWhitelistEntry):
    (TestRunner::setMockGeolocationPositionUnavailableError):
    (TestRunner::setIconDatabaseEnabled):
    (TestRunner::findString):
    (TestRunner::setDomainRelaxationForbiddenForURLScheme):
    (TestRunner::overridePreference):
    (TestRunner::addUserScript):
    (TestRunner::addUserStyleSheet):
    (TestRunner::setTextDirection):
    * DumpRenderTree/gtk/TextInputController.cpp:
    (setMarkedTextCallback):
    (insertTextCallback):
    (doCommandCallback):
    * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
    (LoadHTMLStringItem::invoke):
    * TestWebKitAPI/PlatformGTK.cmake:
    * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
    (WebKitDOMNodeTest::testTagNames):
    * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
    (testBackForwardListLimitAndCache):
    * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
    (testContextMenuSmartSeparators):
    * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
    * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
    (testDownloadLocalFile):
    (testDownloadLocalFileError):
    (addContentDispositionHTTPHeaderToResponse):
    (serverCallback):
    (testDownloadRemoteFileError):
    * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
    (startTestServer):
    (testInspectorServerPageList):
    (openRemoteDebuggingSession):
    * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
    (testPrintOperationPrint):
    * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
    (addCacheHTTPHeadersToResponse):
    (serverCallback):
    * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
    (httpsServerCallback):
    (httpServerCallback):
    * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
    (testWebViewJavaScriptDialogs):
    (testWebViewWindowProperties):
    (testWebViewFileChooserRequest):
    * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
    (testWebExtensionWindowObjectCleared):
    (testWebExtensionIsolatedWorld):
    * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
    (startTestServer):
    (checkAtspiAccessible):
    * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
    (serverCallback):
    (testClearDatabase):
    (testGetFaviconURI):
    (webkitFaviconDatabaseFinalizedCallback):
    * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
    (testWebContextGetPlugins):
    (testWebContextURIScheme):
    * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
    (testWebViewRunJavaScript):
    (testWebViewMode):
    (testWebViewPageVisibility):
    * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
    (isStyleSheetInjectedForURLAtPath):
    * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
    (testWebViewEditorCutCopyPasteNonEditable):
    (testWebViewEditorCutCopyPasteEditable):
    (testWebViewEditorSelectAllNonEditable):
    (testWebViewEditorSelectAllEditable):
    * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
    (sendRequestCallback):
    (methodCallCallback):
    * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
    (TestWebKitAPI::Util::createInjectedBundlePath):
    (TestWebKitAPI::Util::createURLForResource):
    * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
    (TestWebKitAPI::doKeyStroke):
    (TestWebKitAPI::doMouseButtonEvent):
    (TestWebKitAPI::PlatformWebView::simulateMouseMove):
    * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
    (loadFailedCallback):
    (LoadTrackingTest::loadURI):
    (LoadTrackingTest::loadHtml):
    (LoadTrackingTest::loadPlainText):
    (LoadTrackingTest::loadRequest):
    (LoadTrackingTest::reload):
    (LoadTrackingTest::goBack):
    (LoadTrackingTest::goForward):
    * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
    * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
    (registerGResource):
    (removeNonEmptyDirectory):
    (main):
    * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
    (Test::getWebKit1TestResoucesDir):
    (Test::getResourcesDir):
    * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
    (WebKitTestBus::run):
    * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
    (WebKitTestServer::WebKitTestServer):
    (WebKitTestServer::getURIForPath):
    * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
    (WebProcessTestRunner::runTest):
    * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
    (resourceGetDataCallback):
    (WebViewTest::mainResourceData):
    (WebViewTest::mouseMoveTo):
    (WebViewTest::keyStroke):
    (WebViewTest::doMouseButtonEvent):
    * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
    * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
    (WTR::AccessibilityController::accessibleElementById):
    * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
    * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
    (WTR::AccessibilityUIElement::role):
    (WTR::AccessibilityUIElement::title):
    (WTR::AccessibilityUIElement::description):
    (WTR::AccessibilityUIElement::stringValue):
    (WTR::AccessibilityUIElement::language):
    (WTR::AccessibilityUIElement::lineForIndex):
    (WTR::AccessibilityUIElement::selectedTextRange):
    (WTR::AccessibilityUIElement::url):
    * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
    (WTR::getOutputDir):
    (WTR::getFontsPath):
    (WTR::initializeFontConfigSetting):
    * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
    (WTR::topLevelPath):
    * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
    (WTR::TestRunner::pathToLocalResource):
    * WebKitTestRunner/gtk/TestControllerGtk.cpp:
    (WTR::TestController::initializeInjectedBundlePath):
    (WTR::TestController::initializeTestPluginDirectory):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    f2ece55f