Skip to content
  • commit-queue@webkit.org's avatar
    DelayNode has a fixed one second max delay time · ef2e4996
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=78758
    
    Source/WebCore:
    
    Change DelayNode to accept an optional parameter to specify the
    maximum delay allowed. If not specified, the default is 1 sec.
    
    Patch by Raymond Toy <rtoy@google.com> on 2012-03-03
    Reviewed by Chris Rogers.
    
    Test: webaudio/delaynode-maxdelay.html
          webaudio/delaynode-maxdelay-expected.txt
    
    * webaudio/AudioContext.cpp:
    (WebCore::AudioContext::createDelayNode): Allow maxDelayTime
    parameter to specify max delay.
    * webaudio/AudioContext.h: Allow maxDelayTime
    parameter to specify max delay but default to 1.
    (AudioContext):
    * webaudio/AudioContext.idl: createDelayNode takes optional max
    delay time parameter.
    * webaudio/DelayDSPKernel.cpp:
    (WebCore::DelayDSPKernel::DelayDSPKernel): Remove unused
    DefaultMaxDelayTime. Set m_maxDelayTime from processor
    maxDelayTime.
    * webaudio/DelayNode.cpp:
    (WebCore::DelayNode::DelayNode): Add maxDelayTime parameter.
    * webaudio/DelayNode.h:
    (WebCore::DelayNode::create): Add maxDelayTime parameter.
    (DelayNode): Add maxDelayTime parameter.
    * webaudio/DelayProcessor.cpp:
    (WebCore::DelayProcessor::DelayProcessor): Add maxDelayTime
    parameter.
    * webaudio/DelayProcessor.h:
    (DelayProcessor): Add maxDelayTime parameter.
    (WebCore::DelayProcessor::maxDelayTime): New slot to hold
    maxDelayTime.
    
    LayoutTests:
    
    Patch by Raymond Toy <rtoy@google.com> on 2012-03-03
    Reviewed by Chris Rogers.
    
    * webaudio/resources/delay-testing.js: Added more informative
    messages.
    * webaudio/delaynode-expected.txt: Updated result for more
    informative messages
    * webaudio/delaynode-scheduling-expected.txt: Updated result for
    more informative messages.
    * webaudio/delaynode-maxdelay-expected.txt: Added
    * webaudio/delaynode-maxdelay.html: Added
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@109666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    ef2e4996