Skip to content
  • crogers@google.com's avatar
    Implement WebIDL-style string constants in WebAudio (part 2) · 04304451
    crogers@google.com authored
    https://bugs.webkit.org/show_bug.cgi?id=105977
    
    Reviewed by Kentaro Hara.
    
    Source/WebCore:
    
    See Deprecation Notes for more detail:
    https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#DeprecationNotes
    
    PannerNode, BiquadFilterNode, OscillatorNode constants must support WebIDL-style string constants.
    Legacy support in the setters for the old integer values should be supported.
    This patch handles the changes for BiquadFilterNode and PannerNode.
    
    Test: webaudio/pannernode-basic.html
    
    * GNUmakefile.list.am:
    * Modules/webaudio/BiquadFilterNode.cpp:
    (WebCore::BiquadFilterNode::type):
    (WebCore):
    (WebCore::BiquadFilterNode::setType):
    * Modules/webaudio/BiquadFilterNode.h:
    (BiquadFilterNode):
    * Modules/webaudio/BiquadFilterNode.idl:
    * Modules/webaudio/PannerNode.cpp:
    (WebCore::PannerNode::panningModel):
    (WebCore):
    (WebCore::PannerNode::setPanningModel):
    (WebCore::PannerNode::distanceModel):
    (WebCore::PannerNode::setDistanceModel):
    * Modules/webaudio/PannerNode.h:
    (PannerNode):
    * Modules/webaudio/PannerNode.idl:
    * Target.pri:
    * UseJSC.cmake:
    * UseV8.cmake:
    * WebCore.gypi:
    * WebCore.xcodeproj/project.pbxproj:
    * bindings/js/JSBiquadFilterNodeCustom.cpp: Copied from Source/WebCore/Modules/webaudio/BiquadFilterNode.cpp.
    (WebCore):
    (WebCore::JSBiquadFilterNode::setType):
    * bindings/js/JSPannerNodeCustom.cpp: Copied from Source/WebCore/Modules/webaudio/BiquadFilterNode.cpp.
    (WebCore):
    (WebCore::JSPannerNode::setPanningModel):
    (WebCore::JSPannerNode::setDistanceModel):
    * bindings/v8/custom/V8BiquadFilterNodeCustom.cpp: Copied from Source/WebCore/Modules/webaudio/BiquadFilterNode.cpp.
    (WebCore):
    (WebCore::V8BiquadFilterNode::typeAccessorSetter):
    * bindings/v8/custom/V8PannerNodeCustom.cpp: Added.
    (WebCore):
    (WebCore::V8PannerNode::panningModelAccessorSetter):
    (WebCore::V8PannerNode::distanceModelAccessorSetter):
    
    LayoutTests:
    
    * webaudio/audiopannernode-basic-expected.txt: Removed.
    * webaudio/audiopannernode-basic.html: Removed.
    * webaudio/biquad-getFrequencyResponse-expected.txt:
    * webaudio/biquad-getFrequencyResponse.html:
    * webaudio/biquadfilternode-basic-expected.txt:
    * webaudio/biquadfilternode-basic.html:
    * webaudio/pannernode-basic-expected.txt: Added.
    * webaudio/pannernode-basic.html: Added.
    * webaudio/resources/biquad-testing.js:
    * webaudio/resources/distance-model-testing.js:
    (createGraph):
    (.return.renderedBuffer):
    (checkDistanceResult):
    * webaudio/resources/panner-model-testing.js:
    (createGraph):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    04304451