Skip to content
  • allan.jensen@nokia.com's avatar
    [TouchAdjustment] Adjust to word or selection · dbb31194
    allan.jensen@nokia.com authored
    https://bugs.webkit.org/show_bug.cgi?id=94449
    
    Reviewed by Antonio Gomes.
    
    Source/WebCore:
    
    Makes each separate word a separate subtarget when context menu triggers
    selections, and only the selected part of a partial selected node a
    target when selections are not overridden.
    
    Fix of reverted commit r126026, fix misplaced ASSERT.
    
    Test: touchadjustment/context-menu-text-subtargets.html
    
    * page/TouchAdjustment.cpp:
    (TouchAdjustment):
    (WebCore::TouchAdjustment::providesContextMenuItems):
    (WebCore::TouchAdjustment::appendQuadsToSubtargetList):
    (WebCore::TouchAdjustment::appendBasicSubtargetsForNode):
    (WebCore::TouchAdjustment::appendContextSubtargetsForNode):
    (WebCore::TouchAdjustment::compileSubtargetList):
    (WebCore::findBestClickableCandidate):
    (WebCore::findBestContextMenuCandidate):
    
    LayoutTests:
    
    Tests that touch-adjustment can adjust to the right subtargets within text-nodes.
    
    * touchadjustment/context-menu-select-text.html:
    * touchadjustment/context-menu-text-subtargets-expected.txt: Added.
    * touchadjustment/context-menu-text-subtargets.html: Added.
    * touchadjustment/resources/touchadjustment.js:
    (pointToString):
    (shouldBeWithin):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    dbb31194