Skip to content
  • commit-queue@webkit.org's avatar
    MediaControls::show() should make controls opaque · 4dfb6a7f
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=106034
    
    Patch by Min Qin <qinmin@chromium.org> on 2013-01-05
    Reviewed by Eric Carlson.
    
    Source/WebCore:
    
    When a video enters fullscreen, webkit starts a timer to make the control transparent when the timer expires.
    If the user exits fullscreen while the timer expires, webkit will call mediaControls::show().
    However, show() actually displays nothing as the control is transparent.
    The user had to move his mouse outside the video rect and move it back in order to show the controls.
    Simply clicking/moving the mouse inside the video rect will not make the control opaque.
    Test: media/video-controls-visible-exiting-fullscreen.html
    
    * html/shadow/MediaControls.cpp:
    (WebCore::MediaControls::show):
    
    LayoutTests:
    
    Add tests to check that video controls are shown when exiting from fullscreen.
    
    * media/video-controls-visible-exiting-fullscreen-expected.txt: Added.
    * media/video-controls-visible-exiting-fullscreen.html: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    4dfb6a7f